@reltio/components 1.4.2188 → 1.4.2190

package/features/workflow/WorkflowTaskCard/components/GenericWorkflowTaskCard/GenericWorkflowTaskCard.spec.js

@@ -57,7 +57,7 @@ var __spreadArray = (this && this.__spreadArray) || function (to, from, pack) {
 import React from 'react';
 import i18n from 'ui-i18n';
 import { identity } from 'ramda';
-import { render, screen } from '@testing-library/react';
+import { render, screen, within } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 import { createTheme } from '@mui/material/styles';
 import { ThemeProvider } from '@mui/styles';
@@ -451,4 +451,108 @@ describe('GenericWorkflowTaskCard tests', function () {
             }
         });
     }); });
+    describe('Required comments', function () {
+        it('should show comment dialog when user runs action and comment is required', function () { return __awaiter(void 0, void 0, void 0, function () {
+            var task, user, dialog, comment, commentInput;
+            return __generator(this, function (_a) {
+                switch (_a.label) {
+                    case 0:
+                        task = __assign(__assign({}, defaultTask), { possibleActions: [
+                                {
+                                    action: 'Delete',
+                                    label: 'Delete',
+                                    commentRequired: true
+                                },
+                                {
+                                    action: 'Cancel',
+                                    label: 'Cancel',
+                                    commentRequired: false
+                                }
+                            ] });
+                        user = setUp({ task: task }).user;
+                        return [4 /*yield*/, user.click(screen.getByTestId('task-actions'))];
+                    case 1:
+                        _a.sent();
+                        return [4 /*yield*/, user.click(screen.getByText(task.possibleActions[0].label))];
+                    case 2:
+                        _a.sent();
+                        expect(runTaskAction).not.toHaveBeenCalled();
+                        dialog = screen.getAllByRole('presentation')[1];
+                        expect(within(dialog).getByText('Please provide a comment for your action')).toBeInTheDocument();
+                        expect(within(dialog).getByText('Type a comment')).toBeInTheDocument();
+                        expect(within(dialog).getByText('Cancel')).toBeInTheDocument();
+                        expect(within(dialog).getByText('Done')).toBeInTheDocument();
+                        comment = 'comment';
+                        commentInput = screen.getAllByRole('textbox')[0];
+                        return [4 /*yield*/, user.click(commentInput)];
+                    case 3:
+                        _a.sent();
+                        return [4 /*yield*/, user.paste(comment)];
+                    case 4:
+                        _a.sent();
+                        return [4 /*yield*/, user.click(within(screen.getAllByRole('presentation')[1]).getByText('Done'))];
+                    case 5:
+                        _a.sent();
+                        expect(runTaskAction).toHaveBeenCalledWith({
+                            workflowPath: workflowPath,
+                            environment: workflowEnvironmentUrl,
+                            tenant: tenant.id,
+                            taskId: defaultTask.taskId,
+                            action: defaultTask.possibleActions[0].action,
+                            processInstanceComment: comment
+                        });
+                        return [2 /*return*/];
+                }
+            });
+        }); });
+        it('should not show comment dialog when user types comment and run action', function () { return __awaiter(void 0, void 0, void 0, function () {
+            var task, user, comment, commentInput;
+            var _a;
+            return __generator(this, function (_b) {
+                switch (_b.label) {
+                    case 0:
+                        task = __assign(__assign({}, defaultTask), { possibleActions: [
+                                {
+                                    action: 'Delete',
+                                    label: 'Delete',
+                                    commentRequired: true
+                                },
+                                {
+                                    action: 'Cancel',
+                                    label: 'Cancel',
+                                    commentRequired: false
+                                }
+                            ] });
+                        user = setUp({ task: task }).user;
+                        return [4 /*yield*/, user.click(screen.getByTestId('collapse-button'))];
+                    case 1:
+                        _b.sent();
+                        comment = 'comment';
+                        commentInput = screen.getByPlaceholderText('Write a comment');
+                        return [4 /*yield*/, user.click(commentInput)];
+                    case 2:
+                        _b.sent();
+                        return [4 /*yield*/, user.paste(comment)];
+                    case 3:
+                        _b.sent();
+                        return [4 /*yield*/, user.click(screen.getByRole('button', { name: (_a = task.preferredAction) === null || _a === void 0 ? void 0 : _a.label }))];
+                    case 4:
+                        _b.sent();
+                        return [4 /*yield*/, user.click(screen.getByTestId("reltio-profile-select-mode-".concat(task.possibleActions[0].label)))];
+                    case 5:
+                        _b.sent();
+                        expect(screen.queryByText('Please provide a comment for your action')).not.toBeInTheDocument();
+                        expect(runTaskAction).toHaveBeenCalledWith({
+                            workflowPath: workflowPath,
+                            environment: workflowEnvironmentUrl,
+                            tenant: tenant.id,
+                            taskId: defaultTask.taskId,
+                            action: defaultTask.possibleActions[0].action,
+                            processInstanceComment: comment
+                        });
+                        return [2 /*return*/];
+                }
+            });
+        }); });
+    });
 });

package/features/workflow/WorkflowTaskCard/components/PotentialMatchTaskCard/PotentialMatchTaskCard.spec.js

@@ -46,25 +46,32 @@ var __generator = (this && this.__generator) || function (thisArg, body) {
     }
 };
 import React from 'react';
-import { render, screen } from '@testing-library/react';
+import { render, screen, within } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
-import { ActivityFilter } from '@reltio/mdm-sdk';
+import { ActivityFilter, runTaskAction } from '@reltio/mdm-sdk';
 import { LocalizationProvider } from '@mui/x-date-pickers/LocalizationProvider';
 import { AdapterMoment } from '@mui/x-date-pickers/AdapterMoment';
 import { MdmModuleProvider } from '../../../../../contexts/MdmModuleContext';
 import { CommentDialogProvider } from '../../../../../contexts/CommentDialogContext';
 import { PotentialMatchTaskCard } from './PotentialMatchTaskCard';
+jest.mock('@reltio/mdm-sdk', function () { return (__assign(__assign({}, jest.requireActual('@reltio/mdm-sdk')), { runTaskAction: jest.fn() })); });
 describe('PotentialMatchTaskCard tests', function () {
+    var tenant = { id: 't1', name: 't1' };
+    var workflowPath = 'workflowPath';
+    var workflowEnvironmentUrl = 'workflowEnvironmentUrl';
     var mdmValues = {
         metadata: { entityTypes: [], relationTypes: [] },
         entity: { uri: 'entities/uri1', type: 'configuration/entityTypes/HCO' },
-        tenant: { id: 't1', name: 't1' },
+        tenant: tenant,
+        workflowPath: workflowPath,
+        workflowEnvironmentUrl: workflowEnvironmentUrl,
+        user: { username: 'egorshkov' },
         dtssPath: 'path',
         dataTenants: [],
         activityFilter: ActivityFilter.ACTIVE_ONLY
     };
     var relatedEntityUri = 'entities/6hj8baQ';
-    var task = {
+    var defaultTask = {
         assignee: 'egorshkov',
         objectURIs: [relatedEntityUri, 'entities/1RdgehCi'],
         createdBy: 'egorshkov',
@@ -98,7 +105,7 @@ describe('PotentialMatchTaskCard tests', function () {
             uri: 'entities/6hj8baQ'
         }
     };
-    var defaultProps = { task: task, match: match, entitiesMap: entitiesMap };
+    var defaultProps = { task: defaultTask, match: match, entitiesMap: entitiesMap };
     var setUp = function (props) {
         if (props === void 0) { props = {}; }
         var user = userEvent.setup();
@@ -110,6 +117,9 @@ describe('PotentialMatchTaskCard tests', function () {
         };
         return __assign({ user: user }, render(React.createElement(PotentialMatchTaskCard, __assign({}, defaultProps, props)), { wrapper: Providers }));
     };
+    beforeAll(function () {
+        runTaskAction.mockResolvedValue(null);
+    });
     afterEach(function () {
         jest.clearAllMocks();
     });
@@ -158,4 +168,60 @@ describe('PotentialMatchTaskCard tests', function () {
             }
         });
     }); });
+    describe('Required comments', function () {
+        it('should show comment dialog when user runs action and comment is required', function () { return __awaiter(void 0, void 0, void 0, function () {
+            var task, user, dialog, comment, commentInput;
+            return __generator(this, function (_a) {
+                switch (_a.label) {
+                    case 0:
+                        task = __assign(__assign({}, defaultTask), { isOpen: true, possibleActions: [
+                                {
+                                    action: 'Approve',
+                                    label: 'Approve',
+                                    commentRequired: true
+                                },
+                                {
+                                    action: 'Reject',
+                                    label: 'Reject',
+                                    commentRequired: false
+                                }
+                            ] });
+                        user = setUp({ task: task }).user;
+                        return [4 /*yield*/, user.click(screen.getByTestId('task-actions'))];
+                    case 1:
+                        _a.sent();
+                        return [4 /*yield*/, user.click(screen.getByText(task.possibleActions[0].label))];
+                    case 2:
+                        _a.sent();
+                        expect(runTaskAction).not.toHaveBeenCalled();
+                        dialog = screen.getAllByRole('presentation')[1];
+                        expect(within(dialog).getByText('Please provide a comment for your action')).toBeInTheDocument();
+                        expect(within(dialog).getByText('Type a comment')).toBeInTheDocument();
+                        expect(within(dialog).getByText('Cancel')).toBeInTheDocument();
+                        expect(within(dialog).getByText('Done')).toBeInTheDocument();
+                        comment = 'Some comment';
+                        commentInput = screen.getAllByRole('textbox')[0];
+                        return [4 /*yield*/, user.click(commentInput)];
+                    case 3:
+                        _a.sent();
+                        return [4 /*yield*/, user.paste(comment)];
+                    case 4:
+                        _a.sent();
+                        return [4 /*yield*/, user.click(within(dialog).getByText('Done'))];
+                    case 5:
+                        _a.sent();
+                        expect(screen.queryByText('Please provide a comment for your action')).not.toBeInTheDocument();
+                        expect(runTaskAction).toHaveBeenCalledWith({
+                            workflowPath: workflowPath,
+                            environment: workflowEnvironmentUrl,
+                            tenant: tenant.id,
+                            taskId: task.taskId,
+                            action: task.possibleActions[0].action,
+                            processInstanceComment: comment
+                        });
+                        return [2 /*return*/];
+                }
+            });
+        }); });
+    });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reltio/components",
-  "version": "1.4.2188",
+  "version": "1.4.2190",
   "license": "SEE LICENSE IN LICENSE FILE",
   "main": "./cjs/index.js",
   "module": "./index.js",