@reltio/components 1.4.2181 → 1.4.2182

package/features/workflow/AddWorkflowDialog/AddWorkflowDialog.spec.js

@@ -56,7 +56,7 @@ import { theme } from '../../../constants';
 import { MdmModuleProvider } from '../../../contexts/MdmModuleContext';
 import { WorkflowTasksContext } from '../../../contexts/WorkflowTasksContext';
 import { AddWorkflowDialog } from './AddWorkflowDialog';
-jest.mock('@reltio/mdm-sdk', function () { return (__assign(__assign({}, jest.requireActual('@reltio/mdm-sdk')), { processDefinitions: jest.fn(), startProcessInstance: jest.fn() })); });
+jest.mock('@reltio/mdm-sdk', function () { return (__assign(__assign({}, jest.requireActual('@reltio/mdm-sdk')), { processDefinitions: jest.fn(), startProcessInstance: jest.fn(), memoizeWith: jest.fn(function (keyFn, fn) { return fn; }) })); });
 var tenant = { id: 'alenat', name: 'alenat' };
 var workflowEnvironmentUrl = 'https://tst-01.reltio.com';
 var workflowPath = 'https://tst-01-workflow.reltio.com/workflow-adapter';
@@ -131,7 +131,7 @@ describe('AddWorkflowDialog tests', function () {
         });
     }); });
     it('should render Popover and selector correctly if anchorEl exists', function () { return __awaiter(void 0, void 0, void 0, function () {
-        var mockAnchorEl, props, user;
+        var mockAnchorEl, props, user, dropdown;
         return __generator(this, function (_a) {
             switch (_a.label) {
                 case 0:
@@ -142,10 +142,10 @@ describe('AddWorkflowDialog tests', function () {
                     };
                     user = setUp(props).user;
                     expect(screen.getByText('Add new workflow')).toBeInTheDocument();
-                    return [4 /*yield*/, user.click(screen.getByText('Select task type'))];
+                    dropdown = screen.getByRole('combobox');
+                    return [4 /*yield*/, user.click(dropdown)];
                 case 1:
                     _a.sent();
-                    expect(screen.getByText('RDM Data Change Request Review')).toBeInTheDocument();
                     expect(screen.getByText('Data Verification With Loop')).toBeInTheDocument();
                     expect(screen.getByText('Account onboarding')).toBeInTheDocument();
                     return [2 /*return*/];
@@ -165,13 +165,14 @@ describe('AddWorkflowDialog tests', function () {
                     };
                     user = setUp(props).user;
                     expect(screen.getByText('Add new workflow')).toBeInTheDocument();
-                    return [4 /*yield*/, user.click(screen.getByText('Select task type'))];
+                    return [4 /*yield*/, user.click(screen.getByRole('combobox'))];
                 case 1:
                     _a.sent();
+                    expect(screen.getByText('RDM Data Change Request Review')).toBeInTheDocument();
                     return [4 /*yield*/, user.click(screen.getByText('RDM Data Change Request Review'))];
                 case 2:
                     _a.sent();
-                    comment = screen.getByPlaceholderText('Type a comment');
+                    comment = screen.getByLabelText('Type a comment');
                     return [4 /*yield*/, user.type(comment, 'comment')];
                 case 3:
                     _a.sent();
@@ -210,13 +211,13 @@ describe('AddWorkflowDialog tests', function () {
                     };
                     user = setUp(props).user;
                     expect(screen.getByText('Add new workflow')).toBeInTheDocument();
-                    return [4 /*yield*/, user.click(screen.getByText('Select task type'))];
+                    return [4 /*yield*/, user.click(screen.getByRole('combobox'))];
                 case 1:
                     _a.sent();
                     return [4 /*yield*/, user.click(screen.getByText('RDM Data Change Request Review'))];
                 case 2:
                     _a.sent();
-                    comment = screen.getByPlaceholderText('Type a comment');
+                    comment = screen.getByLabelText('Type a comment');
                     return [4 /*yield*/, user.type(comment, 'comment')];
                 case 3:
                     _a.sent();
@@ -251,7 +252,7 @@ describe('AddWorkflowDialog tests', function () {
                         anchorEl: mockAnchorEl
                     };
                     user = setUp(props).user;
-                    return [4 /*yield*/, user.click(screen.getByText('Select task type'))];
+                    return [4 /*yield*/, user.click(screen.getByRole('combobox'))];
                 case 1:
                     _a.sent();
                     expect(consoleSpy).toHaveBeenCalledWith('Workflow error', 'Some error');

package/features/workflow/AddWorkflowDialog/styles.d.ts

@@ -1 +1 @@
-export declare const useStyles: (props?: any) => import("@mui/styles").ClassNameMap<"content" | "title" | "footer" | "input" | "select" | "inputRoot" | "cancelButton" | "popoverPaper" | "simpleDropDownSelector">;
+export declare const useStyles: (props?: any) => import("@mui/styles").ClassNameMap<"content" | "title" | "footer" | "input" | "select" | "inputRoot" | "asterisk" | "cancelButton" | "inputLabelRoot" | "popoverPaper" | "simpleDropDownSelector">;

package/features/workflow/AddWorkflowDialog/styles.js

@@ -9,20 +9,26 @@ export var useStyles = makeStyles(function (theme) { return ({
         letterSpacing: '0.25px',
         lineHeight: '24px',
         color: theme.palette.text.primary,
-        marginBottom: '17px'
+        marginBottom: '20px'
     },
     content: {
         display: 'flex',
         flexDirection: 'column',
-        padding: '23px 24px 14px 24px'
+        padding: '18px 16px 20px 16px'
     },
     simpleDropDownSelector: {
         marginBottom: '20px'
     },
     inputRoot: {
-        paddingTop: '0 !important',
+        paddingTop: '12px !important',
         paddingBottom: '0 !important'
     },
+    inputLabelRoot: {
+        fontSize: '14px'
+    },
+    asterisk: {
+        color: 'red'
+    },
     select: {
         fontSize: '14px'
     },
@@ -36,6 +42,7 @@ export var useStyles = makeStyles(function (theme) { return ({
         marginRight: '8px'
     },
     input: {
-        fontSize: '14px'
+        fontSize: '14px',
+        paddingBottom: '5px'
     }
 }); });

package/features/workflow/ReassignButton/components/ReassignDialog/styles.d.ts

@@ -1 +1 @@
-export declare const useStyles: (props?: any) => import("@mui/styles").ClassNameMap<"caption" | "disabled" | "title" | "currentAssignee" | "dialogText" | "dialogContent">;
+export declare const useStyles: (props?: any) => import("@mui/styles").ClassNameMap<"caption" | "disabled" | "title" | "currentAssignee" | "dialogContent" | "dialogText">;

package/features/workflow/TaskActionButtons/TaskActionButtons.spec.js

@@ -47,11 +47,12 @@ var __generator = (this && this.__generator) || function (thisArg, body) {
 };
 import React from 'react';
 import { runTaskAction } from '@reltio/mdm-sdk';
-import { render, screen } from '@testing-library/react';
+import { render, screen, within } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 import { TaskActionButtons } from '../TaskActionButtons';
 import { WorkflowTasksContext } from '../../../contexts/WorkflowTasksContext';
 import { MdmModuleProvider } from '../../../contexts/MdmModuleContext';
+import { CommentDialogProvider } from '../../../contexts/CommentDialogContext';
 jest.mock('@reltio/mdm-sdk', function () { return (__assign(__assign({}, jest.requireActual('@reltio/mdm-sdk')), { runTaskAction: jest.fn() })); });
 var task = {
     assignee: 'somebody',
@@ -92,7 +93,8 @@ var setUp = function (props) {
     var Providers = function (_a) {
         var children = _a.children;
         return (React.createElement(WorkflowTasksContext.Provider, { value: workflowTaskContextValue },
-            React.createElement(MdmModuleProvider, { values: mdmValues }, children)));
+            React.createElement(CommentDialogProvider, null,
+                React.createElement(MdmModuleProvider, { values: mdmValues }, children))));
     };
     return __assign(__assign({}, render(React.createElement(TaskActionButtons, __assign({}, props)), { wrapper: Providers })), { user: user });
 };
@@ -132,4 +134,55 @@ describe('TaskActionButtons tests', function () {
             }
         });
     }); });
+    describe('required comments', function () {
+        it('should show comment dialog if commentRequired is true', function () { return __awaiter(void 0, void 0, void 0, function () {
+            var task, user, dialog, textfield;
+            return __generator(this, function (_a) {
+                switch (_a.label) {
+                    case 0:
+                        task = __assign(__assign({}, defaultProps.task), { possibleActions: [
+                                { action: 'Approve', label: 'Approve', commentRequired: false },
+                                { action: 'Reject', label: 'Reject', commentRequired: true }
+                            ] });
+                        user = setUp({ task: task }).user;
+                        return [4 /*yield*/, user.click(screen.getByText('Reject'))];
+                    case 1:
+                        _a.sent();
+                        expect(onActionSuccess).not.toHaveBeenCalledWith('Reject');
+                        dialog = screen.getAllByRole('presentation')[1];
+                        expect(within(dialog).getByText('Please provide a comment for your action')).toBeInTheDocument();
+                        expect(within(dialog).getByText('Type a comment')).toBeInTheDocument();
+                        expect(within(dialog).getByText('Cancel')).toBeInTheDocument();
+                        expect(within(dialog).getByText('Done')).toBeInTheDocument();
+                        return [4 /*yield*/, user.click(within(dialog).getByText('Cancel'))];
+                    case 2:
+                        _a.sent();
+                        expect(onActionSuccess).not.toHaveBeenCalled();
+                        return [4 /*yield*/, user.click(screen.getByText('Reject'))];
+                    case 3:
+                        _a.sent();
+                        textfield = screen.getAllByRole('textbox')[0];
+                        return [4 /*yield*/, user.click(textfield)];
+                    case 4:
+                        _a.sent();
+                        return [4 /*yield*/, user.paste('test comment')];
+                    case 5:
+                        _a.sent();
+                        return [4 /*yield*/, user.click(within(screen.getAllByRole('presentation')[1]).getByText('Done'))];
+                    case 6:
+                        _a.sent();
+                        expect(onActionSuccess).toHaveBeenCalledWith('Reject');
+                        expect(runTaskAction).toHaveBeenCalledWith({
+                            taskId: '38453993',
+                            workflowPath: 'workflowPath',
+                            environment: 'workflowEnvironmentURL',
+                            tenant: 't1',
+                            action: 'Reject',
+                            processInstanceComment: 'test comment'
+                        });
+                        return [2 /*return*/];
+                }
+            });
+        }); });
+    });
 });

package/features/workflow/WorkflowTaskCard/WorkflowTaskCard.test.js

@@ -62,6 +62,7 @@ import { WorkflowTaskCard } from './WorkflowTaskCard';
 import { LocalizationProvider } from '@mui/x-date-pickers/LocalizationProvider';
 import { AdapterMoment } from '@mui/x-date-pickers/AdapterMoment';
 import { MdmModuleProvider } from '../../../contexts/MdmModuleContext';
+import { CommentDialogProvider } from '../../../contexts/CommentDialogContext';
 jest.mock('@reltio/mdm-sdk', function () { return (__assign(__assign({}, jest.requireActual('@reltio/mdm-sdk')), { getDataChangeRequest: jest.fn(), getEntitiesByUris: jest.fn() })); });
 jest.mock('../../../icons/DefaultTaskIcon', function () {
     var MockDefaultTaskIcon = function () { return React.createElement("div", { "data-reltio-id": "default-task-icon" }); };
@@ -97,7 +98,8 @@ describe('WorkflowTaskCard tests', function () {
         var Providers = function (_a) {
             var children = _a.children;
             return (React.createElement(LocalizationProvider, { dateAdapter: AdapterMoment },
-                React.createElement(MdmModuleProvider, { values: mdmValues }, children)));
+                React.createElement(CommentDialogProvider, null,
+                    React.createElement(MdmModuleProvider, { values: mdmValues }, children))));
         };
         return __assign({ user: user }, render(React.createElement(WorkflowTaskCard, { task: __assign(__assign({}, defaultTask), task) }), { wrapper: Providers }));
     };

package/features/workflow/WorkflowTaskCard/components/DataChangeRequestTaskCard/DataChangeRequestTaskCard.spec.js

@@ -62,6 +62,7 @@ import { LocalizationProvider } from '@mui/x-date-pickers/LocalizationProvider';
 import { AdapterMoment } from '@mui/x-date-pickers/AdapterMoment';
 import { DCROperationTypes, DCRTypes, getDataChangeRequest, getEntitiesByUris } from '@reltio/mdm-sdk';
 import { useMdmMetadata } from '../../../../../contexts/MdmModuleContext';
+import { CommentDialogProvider } from '../../../../../contexts/CommentDialogContext';
 import { DataChangeRequestTaskCard } from './DataChangeRequestTaskCard';
 jest.mock('@reltio/mdm-sdk', function () { return (__assign(__assign({}, jest.requireActual('@reltio/mdm-sdk')), { getDataChangeRequest: jest.fn(), getEntitiesByUris: jest.fn() })); });
 jest.mock('../../../../../contexts/MdmModuleContext', function () { return (__assign(__assign({}, jest.requireActual('../../../../../contexts/MdmModuleContext')), { useMdmMetadata: jest.fn() })); });
@@ -258,7 +259,8 @@ describe('DataChangeRequestTaskCard tests', function () {
         var user = userEvent.setup();
         var Providers = function (_a) {
             var children = _a.children;
-            return (React.createElement(LocalizationProvider, { dateAdapter: AdapterMoment }, children));
+            return (React.createElement(LocalizationProvider, { dateAdapter: AdapterMoment },
+                React.createElement(CommentDialogProvider, null, children)));
         };
         return __assign(__assign({}, render(React.createElement(DataChangeRequestTaskCard, { task: task }), { wrapper: Providers })), { user: user });
     };

package/features/workflow/WorkflowTaskCard/components/GenericWorkflowTaskCard/GenericWorkflowTaskCard.spec.js

@@ -67,6 +67,7 @@ import { runTaskAction, getTaskById, addCommentForTask } from '@reltio/mdm-sdk';
 import { theme } from '../../../../../constants';
 import { MdmModuleProvider } from '../../../../../contexts/MdmModuleContext';
 import { WorkflowTasksContext } from '../../../../../contexts/WorkflowTasksContext';
+import { CommentDialogProvider } from '../../../../../contexts/CommentDialogContext';
 import { ErrorPopup } from '../../../../../ErrorPopup';
 import { getDefaultTask } from './task.test-data';
 import { GenericWorkflowTaskCard } from './GenericWorkflowTaskCard';
@@ -106,10 +107,11 @@ var setUp = function (_a) {
     return __assign(__assign({}, render(React.createElement(MdmModuleProvider, { values: mdmValues, actions: { errorSet: errorSet } },
         React.createElement(ThemeProvider, { theme: createTheme(theme) },
             React.createElement(LocalizationProvider, { dateAdapter: AdapterMoment },
-                React.createElement(WorkflowTasksContext.Provider, { value: workflowTaskContextValue },
-                    React.createElement(GenericWorkflowTaskCard, { task: task },
-                        React.createElement("div", { className: "someChildren" }, "some children")),
-                    React.createElement(ErrorPopup, { showErrorFromStore: true }))))))), { user: user });
+                React.createElement(CommentDialogProvider, null,
+                    React.createElement(WorkflowTasksContext.Provider, { value: workflowTaskContextValue },
+                        React.createElement(GenericWorkflowTaskCard, { task: task },
+                            React.createElement("div", { className: "someChildren" }, "some children")),
+                        React.createElement(ErrorPopup, { showErrorFromStore: true })))))))), { user: user });
 };
 var checkAlwaysVisibleElements = function (task) {
     var processDefinitionDisplayName = task.processDefinitionDisplayName, createdBy = task.createdBy, createTime = task.createTime, dueDate = task.dueDate, displayName = task.displayName;
@@ -300,7 +302,7 @@ describe('GenericWorkflowTaskCard tests', function () {
                         tenant: tenant.id,
                         taskId: defaultTask.taskId,
                         action: defaultTask.possibleActions[1].action,
-                        processInstanceComment: undefined
+                        processInstanceComment: null
                     });
                     expect(onActionSuccess).toHaveBeenCalledWith(defaultTask.possibleActions[1].action);
                     return [2 /*return*/];
@@ -325,7 +327,7 @@ describe('GenericWorkflowTaskCard tests', function () {
                         tenant: tenant.id,
                         taskId: defaultTask.taskId,
                         action: defaultTask.possibleActions[1].action,
-                        processInstanceComment: undefined
+                        processInstanceComment: null
                     });
                     expect(onActionSuccess).toHaveBeenCalledWith(defaultTask.possibleActions[1].action);
                     return [2 /*return*/];
@@ -370,7 +372,7 @@ describe('GenericWorkflowTaskCard tests', function () {
                         tenant: tenant.id,
                         taskId: defaultTask.taskId,
                         action: defaultTask.possibleActions[1].action,
-                        processInstanceComment: undefined
+                        processInstanceComment: null
                     });
                     expect(onActionSuccess).not.toHaveBeenCalled();
                     expect(screen.getByText('Error')).toBeInTheDocument();

package/features/workflow/WorkflowTaskCard/components/PotentialMatchTaskCard/PotentialMatchTaskCard.spec.js

@@ -52,6 +52,7 @@ import { ActivityFilter } from '@reltio/mdm-sdk';
 import { LocalizationProvider } from '@mui/x-date-pickers/LocalizationProvider';
 import { AdapterMoment } from '@mui/x-date-pickers/AdapterMoment';
 import { MdmModuleProvider } from '../../../../../contexts/MdmModuleContext';
+import { CommentDialogProvider } from '../../../../../contexts/CommentDialogContext';
 import { PotentialMatchTaskCard } from './PotentialMatchTaskCard';
 describe('PotentialMatchTaskCard tests', function () {
     var mdmValues = {
@@ -104,7 +105,8 @@ describe('PotentialMatchTaskCard tests', function () {
         var Providers = function (_a) {
             var children = _a.children;
             return (React.createElement(LocalizationProvider, { dateAdapter: AdapterMoment },
-                React.createElement(MdmModuleProvider, { values: mdmValues }, children)));
+                React.createElement(CommentDialogProvider, null,
+                    React.createElement(MdmModuleProvider, { values: mdmValues }, children))));
         };
         return __assign({ user: user }, render(React.createElement(PotentialMatchTaskCard, __assign({}, defaultProps, props)), { wrapper: Providers }));
     };

package/features/workflow/helpers/common.d.ts

@@ -1,4 +1,4 @@
-import { AttributeType, DCRAttributeValue, DCRObjectsInfo, DCROperationTypes, DCRValue, WorkflowTaskData } from '@reltio/mdm-sdk';
+import { AttributeType, DCRAttributeValue, DCRObjectsInfo, DCROperationTypes, DCRValue, WorkflowTaskData, WorkflowDefinition } from '@reltio/mdm-sdk';
 export declare const getOperationType: (type: string, oldValue?: DCRAttributeValue) => DCROperationTypes;
 export declare const getOperationLabel: (operation: DCROperationTypes) => string;
 export declare const getAttributeDescription: (attrType: AttributeType, value: DCRAttributeValue, currentEntityUri: string, objectsInfo?: DCRObjectsInfo) => {
@@ -11,3 +11,4 @@ export declare const getDCRUri: (objectUris?: string[]) => string;
 export declare const getDCRId: (objectUris?: string[]) => string;
 export declare const isOpenTask: (isOpen: WorkflowTaskData["isOpen"]) => boolean;
 export declare const isRequestedTask: (processTypes: string[], assignee: string) => (task: WorkflowTaskData) => boolean;
+export declare const findWorkflowDefinitionByType: (definitions: WorkflowDefinition[], type: string) => WorkflowDefinition | undefined;

package/features/workflow/helpers/common.js

@@ -1,4 +1,4 @@
-import { pipe, startsWith, isNil, unless, split, nth, allPass, always, equals, evolve, prop, when, filter, has, length } from 'ramda';
+import { pipe, startsWith, isNil, unless, split, nth, allPass, always, equals, evolve, prop, when, filter, has, length, propEq } from 'ramda';
 import i18n from 'ui-i18n';
 import { DataTypes, DCRTypes, getAttrDataTypeDefinition, isUrl, DCROperationTypes } from '@reltio/mdm-sdk';
 export var getOperationType = function (type, oldValue) {
@@ -66,3 +66,4 @@ export var isOpenTask = function (isOpen) { return isOpen === undefined || isOpe
 export var isRequestedTask = function (processTypes, assignee) { return function (task) {
     return (!processTypes || processTypes.includes(task.processType)) && (!assignee || assignee === task.assignee);
 }; };
+export var findWorkflowDefinitionByType = function (definitions, type) { return definitions.find(propEq('type', type)); };

package/features/workflow/hooks/useWorkflowActions.js

@@ -1,9 +1,46 @@
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+var __generator = (this && this.__generator) || function (thisArg, body) {
+    var _ = { label: 0, sent: function() { if (t[0] & 1) throw t[1]; return t[1]; }, trys: [], ops: [] }, f, y, t, g = Object.create((typeof Iterator === "function" ? Iterator : Object).prototype);
+    return g.next = verb(0), g["throw"] = verb(1), g["return"] = verb(2), typeof Symbol === "function" && (g[Symbol.iterator] = function() { return this; }), g;
+    function verb(n) { return function (v) { return step([n, v]); }; }
+    function step(op) {
+        if (f) throw new TypeError("Generator is already executing.");
+        while (g && (g = 0, op[0] && (_ = 0)), _) try {
+            if (f = 1, y && (t = op[0] & 2 ? y["return"] : op[0] ? y["throw"] || ((t = y["return"]) && t.call(y), 0) : y.next) && !(t = t.call(y, op[1])).done) return t;
+            if (y = 0, t) op = [op[0] & 2, t.value];
+            switch (op[0]) {
+                case 0: case 1: t = op; break;
+                case 4: _.label++; return { value: op[1], done: false };
+                case 5: _.label++; y = op[1]; op = [0]; continue;
+                case 7: op = _.ops.pop(); _.trys.pop(); continue;
+                default:
+                    if (!(t = _.trys, t = t.length > 0 && t[t.length - 1]) && (op[0] === 6 || op[0] === 2)) { _ = 0; continue; }
+                    if (op[0] === 3 && (!t || (op[1] > t[0] && op[1] < t[3]))) { _.label = op[1]; break; }
+                    if (op[0] === 6 && _.label < t[1]) { _.label = t[1]; t = op; break; }
+                    if (t && _.label < t[2]) { _.label = t[2]; _.ops.push(op); break; }
+                    if (t[2]) _.ops.pop();
+                    _.trys.pop(); continue;
+            }
+            op = body.call(thisArg, _);
+        } catch (e) { op = [6, e]; y = 0; } finally { f = t = 0; }
+        if (op[0] & 5) throw op[1]; return { value: op[0] ? op[1] : void 0, done: true };
+    }
+};
 import { useCallback, useContext, useMemo, useState } from 'react';
 import { runTaskAction } from '@reltio/mdm-sdk';
 import { showWorkflowError } from '../helpers/errors';
 import { isOpenTask } from '../helpers/common';
 import { WorkflowTasksContext } from '../../../contexts/WorkflowTasksContext';
 import { useMdmTenant, useMdmUsername, useMdmWorkflowEnvironmentUrl, useMdmWorkflowPath } from '../../../contexts/MdmModuleContext';
+import { useCommentDialog } from '../../../contexts/CommentDialogContext';
 export var useWorkflowActions = function (task, onActionSuccess) {
     var _a = task !== null && task !== void 0 ? task : {}, possibleActions = _a.possibleActions, assignee = _a.assignee, taskId = _a.taskId, isOpen = _a.isOpen;
     var workflowTasks = useContext(WorkflowTasksContext);
@@ -11,34 +48,57 @@ export var useWorkflowActions = function (task, onActionSuccess) {
     var environment = useMdmWorkflowEnvironmentUrl();
     var tenant = useMdmTenant();
     var username = useMdmUsername();
+    var showCommentDialog = useCommentDialog();
     var _b = useState(false), actionRequestIsInProgress = _b[0], setActionRequestIsInProgress = _b[1];
     var handleActionSuccess = onActionSuccess !== null && onActionSuccess !== void 0 ? onActionSuccess : workflowTasks === null || workflowTasks === void 0 ? void 0 : workflowTasks.onActionSuccess;
-    var performTaskAction = useCallback(function (action) { return function (comment) {
-        if (workflowPath && taskId) {
-            setActionRequestIsInProgress(true);
-            var processInstanceComment = typeof comment === 'string' && comment.length ? comment : undefined;
-            runTaskAction({
-                taskId: taskId,
-                workflowPath: workflowPath,
-                environment: environment,
-                tenant: tenant,
-                action: action,
-                processInstanceComment: processInstanceComment
-            })
-                .then(function () {
-                handleActionSuccess === null || handleActionSuccess === void 0 ? void 0 : handleActionSuccess(action);
-            })
-                .catch(showWorkflowError)
-                .finally(function () {
-                setActionRequestIsInProgress(false);
+    var performTaskAction = useCallback(function (action, commentRequired) {
+        return function (comment) { return __awaiter(void 0, void 0, void 0, function () {
+            var processInstanceComment;
+            return __generator(this, function (_a) {
+                switch (_a.label) {
+                    case 0:
+                        if (!(workflowPath && taskId)) return [3 /*break*/, 3];
+                        setActionRequestIsInProgress(true);
+                        processInstanceComment = typeof comment === 'string' && comment.length ? comment : null;
+                        if (!(commentRequired && !processInstanceComment)) return [3 /*break*/, 2];
+                        return [4 /*yield*/, showCommentDialog()];
+                    case 1:
+                        processInstanceComment = _a.sent();
+                        if (processInstanceComment === null) {
+                            setActionRequestIsInProgress(false);
+                            return [2 /*return*/];
+                        }
+                        _a.label = 2;
+                    case 2:
+                        runTaskAction({
+                            taskId: taskId,
+                            workflowPath: workflowPath,
+                            environment: environment,
+                            tenant: tenant,
+                            action: action,
+                            processInstanceComment: processInstanceComment
+                        })
+                            .then(function () {
+                            handleActionSuccess === null || handleActionSuccess === void 0 ? void 0 : handleActionSuccess(action);
+                        })
+                            .catch(showWorkflowError)
+                            .finally(function () {
+                            setActionRequestIsInProgress(false);
+                        });
+                        _a.label = 3;
+                    case 3: return [2 /*return*/];
+                }
             });
-        }
-    }; }, [workflowPath, taskId, environment, tenant, handleActionSuccess]);
+        }); };
+    }, [workflowPath, taskId, environment, tenant, handleActionSuccess, showCommentDialog]);
     var actions = useMemo(function () {
         return username === assignee && isOpenTask(isOpen)
             ? (possibleActions || []).map(function (_a) {
-                var action = _a.action, label = _a.label;
-                return ({ text: label, onClick: performTaskAction(action) });
+                var action = _a.action, label = _a.label, commentRequired = _a.commentRequired;
+                return ({
+                    text: label,
+                    onClick: performTaskAction(action, commentRequired)
+                });
             })
             : [];
     }, [possibleActions, performTaskAction, username, assignee, isOpen]);

package/features/workflow/hooks/useWorkflowDefinitions.d.ts

@@ -1,3 +1,8 @@
-export declare const useWorkflowDefinitions: () => {
-    definitions: any[];
+import { WorkflowDefinition } from '@reltio/mdm-sdk';
+export declare const useWorkflowDefinitions: ({ all, canViewDefinitions }?: {
+    all?: boolean;
+    canViewDefinitions?: boolean;
+}) => {
+    definitions: WorkflowDefinition[];
+    loading: boolean;
 };

package/features/workflow/hooks/useWorkflowDefinitions.js

@@ -1,5 +1,5 @@
-import { useEffect, useState } from 'react';
-import { processDefinitions } from '@reltio/mdm-sdk';
+import { useEffect, useMemo, useState } from 'react';
+import { memoizeWith, processDefinitions } from '@reltio/mdm-sdk';
 import { useSafePromise } from '../../../hooks/useSafePromise';
 import { useMdmEntity, useMdmTenant, useMdmWorkflowEnvironmentUrl, useMdmWorkflowPath } from '../../../contexts/MdmModuleContext';
 var filterDefinitions = function (definitions, entityTypeUri) {
@@ -8,26 +8,39 @@ var filterDefinitions = function (definitions, entityTypeUri) {
         return manualStart && (!objectTypes || (objectTypes === null || objectTypes === void 0 ? void 0 : objectTypes.some(function (uri) { return uri === entityTypeUri; })));
     });
 };
-export var useWorkflowDefinitions = function () {
-    var _a = useState([]), definitions = _a[0], setDefinitions = _a[1];
+var memoizedProcessDefinitions = memoizeWith(function (_a) {
+    var workflowPath = _a.workflowPath, environment = _a.environment, tenant = _a.tenant;
+    return "".concat(workflowPath, "-").concat(environment, "-").concat(tenant);
+}, processDefinitions);
+export var useWorkflowDefinitions = function (_a) {
+    var _b = _a === void 0 ? {} : _a, _c = _b.all, all = _c === void 0 ? false : _c, _d = _b.canViewDefinitions, canViewDefinitions = _d === void 0 ? true : _d;
+    var _e = useState([]), definitions = _e[0], setDefinitions = _e[1];
+    var _f = useState(false), loading = _f[0], setLoading = _f[1];
     var workflowPath = useMdmWorkflowPath();
     var environment = useMdmWorkflowEnvironmentUrl();
     var tenant = useMdmTenant();
     var entity = useMdmEntity();
-    var entityType = entity.type;
+    var entityType = entity === null || entity === void 0 ? void 0 : entity.type;
     var safePromise = useSafePromise();
     useEffect(function () {
-        safePromise(processDefinitions({ workflowPath: workflowPath, environment: environment, tenant: tenant }))
+        if (!canViewDefinitions) {
+            return;
+        }
+        setLoading(true);
+        safePromise(memoizedProcessDefinitions({ workflowPath: workflowPath, environment: environment, tenant: tenant }))
             .then(function (_a) {
             var data = _a.data;
             if (!data) {
                 return;
             }
-            setDefinitions(filterDefinitions(data, entityType));
+            setDefinitions(all ? data : filterDefinitions(data, entityType));
         })
             .catch(function (error) {
             console.warn('Workflow error', error);
+        })
+            .finally(function () {
+            setLoading(false);
         });
-    }, [entityType, workflowPath, environment, tenant]);
-    return { definitions: definitions };
+    }, [entityType, workflowPath, environment, tenant, all, canViewDefinitions]);
+    return useMemo(function () { return ({ definitions: definitions, loading: loading }); }, [definitions, loading]);
 };

package/features/workflow/index.d.ts

@@ -11,3 +11,4 @@ export { useWorkflowActions } from './hooks/useWorkflowActions';
 export { useWorkflowCheckPermission } from './hooks/useWorkflowCheckPermission';
 export { useWorkflowTasks } from './hooks/useWorkflowTasks';
 export { useWorkflowDefaultActionSuccessHandler } from './hooks/useWorkflowDefaultActionSuccessHandler';
+export { findWorkflowDefinitionByType } from './helpers/common';

package/features/workflow/index.js

@@ -13,3 +13,5 @@ export { useWorkflowActions } from './hooks/useWorkflowActions';
 export { useWorkflowCheckPermission } from './hooks/useWorkflowCheckPermission';
 export { useWorkflowTasks } from './hooks/useWorkflowTasks';
 export { useWorkflowDefaultActionSuccessHandler } from './hooks/useWorkflowDefaultActionSuccessHandler';
+// helpers
+export { findWorkflowDefinitionByType } from './helpers/common';