@reltio/components 1.4.1993 → 1.4.1994

package/cjs/EntityUriLink/EntityUriLink.js

@@ -53,9 +53,8 @@ var events_1 = require("../helpers/events");
 exports.EntityUriLink = (0, react_1.forwardRef)(function (_a, ref) {
     var value = _a.value, children = _a.children, screen = _a.screen, className = _a.className, _b = _a.shouldOpenInNewTab, shouldOpenInNewTab = _b === void 0 ? false : _b, otherProps = __rest(_a, ["value", "children", "screen", "className", "shouldOpenInNewTab"]);
     var generateEntityUrl = (0, react_1.useContext)(UrlGeneratorsContext_1.UrlGeneratorsContext).generateEntityUrl;
-    var openEntity = (0, MdmModuleContext_1.useMdmAction)('openEntity');
     var uiPath = (0, MdmModuleContext_1.useMdmUiPath)();
-    var generateEntityUrlByUri = function (uri) { return generateEntityUrl({ uiPath: uiPath, uri: uri, screen: screen }); };
+    var openEntity = (0, MdmModuleContext_1.useMdmAction)('openEntity');
     var handleClick = (0, react_1.useCallback)(function (e) {
         if (!(0, events_1.isControlOrCommandPressed)(e)) {
             openEntity({ uri: value, screen: screen });
@@ -63,6 +62,6 @@ exports.EntityUriLink = (0, react_1.forwardRef)(function (_a, ref) {
         }
         e.stopPropagation();
     }, [openEntity, screen, value]);
-    return (react_1.default.createElement("a", __assign({ ref: ref, href: generateEntityUrlByUri(value), onClick: shouldOpenInNewTab ? undefined : handleClick, target: shouldOpenInNewTab ? '_blank' : '_self', rel: "noreferrer", className: className }, otherProps), children));
+    return value ? (react_1.default.createElement("a", __assign({ ref: ref, href: generateEntityUrl({ uiPath: uiPath, uri: value, screen: screen }), onClick: shouldOpenInNewTab ? undefined : handleClick, target: shouldOpenInNewTab ? '_blank' : '_self', rel: "noreferrer", className: className }, otherProps), children)) : (react_1.default.createElement("span", __assign({ className: className }, otherProps), children));
 });
 exports.EntityUriLink.displayName = 'EntityUriLink';

package/cjs/EntityUriLink/EntityUriLink.test.js

@@ -170,4 +170,19 @@ describe('EntityUriLink', function () {
             }
         });
     }); });
+    it('should not open entity with broken uri', function () { return __awaiter(void 0, void 0, void 0, function () {
+        var props, user;
+        return __generator(this, function (_a) {
+            switch (_a.label) {
+                case 0:
+                    props = __assign(__assign({}, defaultProps), { value: undefined });
+                    user = setUp({ props: props }).user;
+                    return [4 /*yield*/, user.click(react_2.screen.getByText('label'))];
+                case 1:
+                    _a.sent();
+                    expect(openEntity).not.toHaveBeenCalled();
+                    return [2 /*return*/];
+            }
+        });
+    }); });
 });

package/esm/EntityUriLink/EntityUriLink.js

@@ -27,9 +27,8 @@ import { isControlOrCommandPressed } from '../helpers/events';
 export var EntityUriLink = forwardRef(function (_a, ref) {
     var value = _a.value, children = _a.children, screen = _a.screen, className = _a.className, _b = _a.shouldOpenInNewTab, shouldOpenInNewTab = _b === void 0 ? false : _b, otherProps = __rest(_a, ["value", "children", "screen", "className", "shouldOpenInNewTab"]);
     var generateEntityUrl = useContext(UrlGeneratorsContext).generateEntityUrl;
-    var openEntity = useMdmAction('openEntity');
     var uiPath = useMdmUiPath();
-    var generateEntityUrlByUri = function (uri) { return generateEntityUrl({ uiPath: uiPath, uri: uri, screen: screen }); };
+    var openEntity = useMdmAction('openEntity');
     var handleClick = useCallback(function (e) {
         if (!isControlOrCommandPressed(e)) {
             openEntity({ uri: value, screen: screen });
@@ -37,6 +36,6 @@ export var EntityUriLink = forwardRef(function (_a, ref) {
         }
         e.stopPropagation();
     }, [openEntity, screen, value]);
-    return (React.createElement("a", __assign({ ref: ref, href: generateEntityUrlByUri(value), onClick: shouldOpenInNewTab ? undefined : handleClick, target: shouldOpenInNewTab ? '_blank' : '_self', rel: "noreferrer", className: className }, otherProps), children));
+    return value ? (React.createElement("a", __assign({ ref: ref, href: generateEntityUrl({ uiPath: uiPath, uri: value, screen: screen }), onClick: shouldOpenInNewTab ? undefined : handleClick, target: shouldOpenInNewTab ? '_blank' : '_self', rel: "noreferrer", className: className }, otherProps), children)) : (React.createElement("span", __assign({ className: className }, otherProps), children));
 });
 EntityUriLink.displayName = 'EntityUriLink';

package/esm/EntityUriLink/EntityUriLink.test.js

@@ -165,4 +165,19 @@ describe('EntityUriLink', function () {
             }
         });
     }); });
+    it('should not open entity with broken uri', function () { return __awaiter(void 0, void 0, void 0, function () {
+        var props, user;
+        return __generator(this, function (_a) {
+            switch (_a.label) {
+                case 0:
+                    props = __assign(__assign({}, defaultProps), { value: undefined });
+                    user = setUp({ props: props }).user;
+                    return [4 /*yield*/, user.click(screen.getByText('label'))];
+                case 1:
+                    _a.sent();
+                    expect(openEntity).not.toHaveBeenCalled();
+                    return [2 /*return*/];
+            }
+        });
+    }); });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reltio/components",
-  "version": "1.4.1993",
+  "version": "1.4.1994",
   "license": "SEE LICENSE IN LICENSE FILE",
   "main": "./cjs/index.js",
   "module": "./esm/index.js",