@reltio/components 1.4.1966 → 1.4.1968

package/cjs/hooks/useHiddenAttributes/useHiddenAttributes.js

@@ -28,7 +28,7 @@ var useHiddenAttributes = function () {
     var updateHiddenAttributes = (0, MdmModuleContext_1.useMdmAction)('updateHiddenAttributes');
     var resetHiddenAttributes = (0, MdmModuleContext_1.useMdmAction)('resetHiddenAttributes');
     var hiddenAttributes = (0, MdmModuleContext_1.useMdmHiddenAttributes)();
-    var currentEntityHiddenAttributes = (0, react_1.useMemo)(function () { return hiddenAttributes[entityUri] || []; }, [hiddenAttributes, entityUri]);
+    var currentEntityHiddenAttributes = (0, react_1.useMemo)(function () { return hiddenAttributes[entityUri] || null; }, [hiddenAttributes, entityUri]);
     var updateControlAttributes = (0, MdmModuleContext_1.useMdmAction)('updateControlAttributes');
     var ruleBasedAttributes = (0, react_1.useMemo)(function () { return (0, mdm_sdk_1.getRuleBasedAttributes)(metadata, entity === null || entity === void 0 ? void 0 : entity.type); }, [metadata, entity === null || entity === void 0 ? void 0 : entity.type]);
     var parsedRuleBasedAttributes = (0, react_1.useMemo)(function () {
@@ -55,7 +55,10 @@ var useHiddenAttributes = function () {
     }, [rulesToCheck, entity, showAttributeURIs]);
     (0, react_1.useEffect)(function () {
         if (entityUri && (addedHiddenAttributes.length || showAttributeURIs.length)) {
-            updateHiddenAttributes(entityUri, (0, ramda_1.without)(showAttributeURIs, currentEntityHiddenAttributes).concat(addedHiddenAttributes));
+            var updatedHiddenAttributes = (0, ramda_1.without)(showAttributeURIs, currentEntityHiddenAttributes || []).concat(addedHiddenAttributes);
+            if (!(0, ramda_1.equals)(currentEntityHiddenAttributes, updatedHiddenAttributes)) {
+                updateHiddenAttributes(entityUri, updatedHiddenAttributes);
+            }
         }
     }, [addedHiddenAttributes, showAttributeURIs, entityUri]);
     (0, react_1.useEffect)(function () {

package/cjs/hooks/useHiddenAttributes/useHiddenAttributes.test.js

@@ -463,4 +463,38 @@ describe('useHiddenAttributes', function () {
         expect(resetHiddenAttributes).toHaveBeenCalled();
         expect(updateHiddenAttributes).toHaveBeenCalledWith('entities/uri_e_permanent', []);
     });
+    it('should not dispatch action if value is unchanged', function () {
+        var entity = {
+            type: 'configuration/entityTypes/HCP',
+            uri: 'entities/uri_e',
+            attributes: {
+                Category1: [
+                    {
+                        uri: 'entities/uri_e/attributes/uri1',
+                        value: 'category1_value1'
+                    }
+                ],
+                Category2: [
+                    {
+                        uri: 'entities/uri_e/attributes/uri2',
+                        value: 'category2_value1'
+                    }
+                ]
+            }
+        };
+        MdmModuleContext_1.useMdmEntity.mockReturnValue(entity);
+        MdmModuleContext_1.useMdmMode.mockReturnValue(mdm_sdk_1.Mode.Editing);
+        var rerender = setUp().rerender;
+        expect(updateHiddenAttributes).toHaveBeenCalledWith(entity.uri, []);
+        updateHiddenAttributes.mockClear();
+        var newEntity = (0, ramda_1.assocPath)(['attributes', 'Category3'], [
+            {
+                uri: 'entities/uri_e/attributes/uri3',
+                value: 'category3_value1'
+            }
+        ], entity);
+        MdmModuleContext_1.useMdmEntity.mockReturnValue(newEntity);
+        rerender();
+        expect(updateHiddenAttributes).not.toHaveBeenCalled();
+    });
 });

package/esm/hooks/useHiddenAttributes/useHiddenAttributes.js

@@ -10,7 +10,7 @@ var __assign = (this && this.__assign) || function () {
     return __assign.apply(this, arguments);
 };
 import { useEffect, useMemo } from 'react';
-import { flatten, pipe, pluck, uniq, without } from 'ramda';
+import { flatten, pipe, pluck, uniq, without, equals } from 'ramda';
 import { getRuleBasedAttributes, isEditableMode, parseRuleBasedAttribute } from '@reltio/mdm-sdk';
 import { useChangedAttributes } from '../useChangedAttributes';
 import { findRulesToCheck, findShowAttributeURIs } from './helpers';
@@ -25,7 +25,7 @@ export var useHiddenAttributes = function () {
     var updateHiddenAttributes = useMdmAction('updateHiddenAttributes');
     var resetHiddenAttributes = useMdmAction('resetHiddenAttributes');
     var hiddenAttributes = useMdmHiddenAttributes();
-    var currentEntityHiddenAttributes = useMemo(function () { return hiddenAttributes[entityUri] || []; }, [hiddenAttributes, entityUri]);
+    var currentEntityHiddenAttributes = useMemo(function () { return hiddenAttributes[entityUri] || null; }, [hiddenAttributes, entityUri]);
     var updateControlAttributes = useMdmAction('updateControlAttributes');
     var ruleBasedAttributes = useMemo(function () { return getRuleBasedAttributes(metadata, entity === null || entity === void 0 ? void 0 : entity.type); }, [metadata, entity === null || entity === void 0 ? void 0 : entity.type]);
     var parsedRuleBasedAttributes = useMemo(function () {
@@ -52,7 +52,10 @@ export var useHiddenAttributes = function () {
     }, [rulesToCheck, entity, showAttributeURIs]);
     useEffect(function () {
         if (entityUri && (addedHiddenAttributes.length || showAttributeURIs.length)) {
-            updateHiddenAttributes(entityUri, without(showAttributeURIs, currentEntityHiddenAttributes).concat(addedHiddenAttributes));
+            var updatedHiddenAttributes = without(showAttributeURIs, currentEntityHiddenAttributes || []).concat(addedHiddenAttributes);
+            if (!equals(currentEntityHiddenAttributes, updatedHiddenAttributes)) {
+                updateHiddenAttributes(entityUri, updatedHiddenAttributes);
+            }
         }
     }, [addedHiddenAttributes, showAttributeURIs, entityUri]);
     useEffect(function () {

package/esm/hooks/useHiddenAttributes/useHiddenAttributes.test.js

@@ -461,4 +461,38 @@ describe('useHiddenAttributes', function () {
         expect(resetHiddenAttributes).toHaveBeenCalled();
         expect(updateHiddenAttributes).toHaveBeenCalledWith('entities/uri_e_permanent', []);
     });
+    it('should not dispatch action if value is unchanged', function () {
+        var entity = {
+            type: 'configuration/entityTypes/HCP',
+            uri: 'entities/uri_e',
+            attributes: {
+                Category1: [
+                    {
+                        uri: 'entities/uri_e/attributes/uri1',
+                        value: 'category1_value1'
+                    }
+                ],
+                Category2: [
+                    {
+                        uri: 'entities/uri_e/attributes/uri2',
+                        value: 'category2_value1'
+                    }
+                ]
+            }
+        };
+        useMdmEntity.mockReturnValue(entity);
+        useMdmMode.mockReturnValue(Mode.Editing);
+        var rerender = setUp().rerender;
+        expect(updateHiddenAttributes).toHaveBeenCalledWith(entity.uri, []);
+        updateHiddenAttributes.mockClear();
+        var newEntity = assocPath(['attributes', 'Category3'], [
+            {
+                uri: 'entities/uri_e/attributes/uri3',
+                value: 'category3_value1'
+            }
+        ], entity);
+        useMdmEntity.mockReturnValue(newEntity);
+        rerender();
+        expect(updateHiddenAttributes).not.toHaveBeenCalled();
+    });
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reltio/components",
-  "version": "1.4.1966",
+  "version": "1.4.1968",
   "license": "SEE LICENSE IN LICENSE FILE",
   "main": "./cjs/index.js",
   "module": "./esm/index.js",
@@ -8,7 +8,7 @@
     "@fluentui/react-context-selector": "^9.1.26",
     "@react-google-maps/api": "2.7.0",
     "@react-sigma/core": "3.4.0",
-    "@reltio/mdm-sdk": "^1.4.1870",
+    "@reltio/mdm-sdk": "^1.4.1871",
     "d3-cloud": "^1.2.5",
     "d3-geo": "^2.0.1",
     "d3-hierarchy": "^2.0.0",