@relaybus/nestjs 0.2.0 → 0.3.0

package/README.md

@@ -1,6 +1,6 @@
 # @relaybus/nestjs
 
-@relaybus/nestjs is the NestJS module of relaybus, a reliable, storage-agnostic event bus for NestJS and Node.js: declare handlers with `@Subscribe` and publish inside your database transaction, and every committed event reaches every handler at least once.
+@relaybus/nestjs is the NestJS module of relaybus, a reliable, storage-agnostic event bus for NestJS and Node.js: declare handlers with `@RelayBusConsumer` and publish inside your database transaction, and every committed event reaches every handler at least once.
 
 NestJS integration for [relaybus](../core): one module, one decorator, correct lifecycle.
 
@@ -24,17 +24,26 @@ export class AppModule {}
 // shipping.handlers.ts - any provider of any module
 @Injectable()
 export class ShippingHandlers {
-  @Subscribe(OrderPlaced)
+  @RelayBusConsumer(OrderPlaced)
   async onOrderPlaced(event: EventEnvelope<{ orderId: string }>) {
     /* ... */
   }
 }
 
 // order.service.ts
-await this.bus.transaction(async (tx) => {
-  await tx.query('INSERT INTO orders ...');
-  await this.bus.publish(new OrderPlaced({ orderId }), { transaction: tx });
-});
+@Injectable()
+export class OrderService {
+  constructor(
+    private readonly bus: RelayBus,
+    private readonly transactions: RelayBusTransactionHost<PoolClient>,
+  ) {}
+
+  @RelayBusTransaction()
+  async place(orderId: string): Promise<void> {
+    await this.transactions.current().query('INSERT INTO orders (id) VALUES ($1)', [orderId]);
+    await this.bus.publish(new OrderPlaced({ orderId })); // joins the transaction
+  }
+}
 ```
 
 That is all: the module is global, the handler is discovered, the bus starts after bootstrap and
@@ -43,7 +52,21 @@ add the transaction type when you want it typed: `RelayBus<PoolClient>` (the gen
 runtime, so DI is unaffected).
 
 Call `app.enableShutdownHooks()` in `main.ts` so SIGTERM/SIGINT close the app and let the bus
-drain running handlers (`dispatcher.shutdownTimeout`, default 30s).
+drain running handlers. The whole `bus.stop()` is bounded by `dispatcher.shutdownTimeout`
+(default 30s): past it, running handlers are abandoned (their leases expire and another pod runs
+them again) and the connections relaybus opened itself are force-closed, so a hung query or broker
+cannot keep the pod alive until Kubernetes kills it. Keep the timeout below the pod's
+`terminationGracePeriodSeconds`, leaving room for the rest of `app.close()`:
+
+```ts
+// main.ts
+const app = await NestFactory.create(AppModule);
+app.enableShutdownHooks();
+await app.listen(3000);
+
+// app.module.ts, for a pod with terminationGracePeriodSeconds: 30
+RelayBusModule.forRoot({ store, dispatcher: { shutdownTimeout: '25s' } });
+```
 
 ## `RelayBusModule`
 
@@ -65,6 +88,7 @@ logs through a Nest `Logger` with context `RelayBus`, so `app.useLogger(...)` co
 | `source`                                      | `'relaybus'`              | Service name recorded on every event; set it to your app name                    |
 | `transactionMode`                             | `'required'`              | `'optional'` lets `publish` open its own transaction                             |
 | `transactionResolver`                         | none                      | Finds the caller's active transaction (see below)                                |
+| `transactionTimeout`                          | `'5s'`                    | Budget of every `bus.transaction` / `@RelayBusTransaction()` (see below)         |
 | `retry`                                       | core default              | Default retry policy of every handler and route                                  |
 | `handlerTimeout`                              | `false`                   | Default handler timeout                                                          |
 | `dispatcher.enabled`                          | `true`                    | `false` on publish-only processes (API pods, scripts)                            |
@@ -72,7 +96,7 @@ logs through a Nest `Logger` with context `RelayBus`, so `app.useLogger(...)` co
 | `dispatcher.batchSize`                        | concurrency               | Deliveries claimed per query                                                     |
 | `dispatcher.pollInterval`                     | `'1s'`                    | Wait between claims when idle                                                    |
 | `dispatcher.leaseDuration`                    | `'30s'`                   | Renewed every third of it                                                        |
-| `dispatcher.shutdownTimeout`                  | `'30s'`                   | How long shutdown waits for running handlers                                     |
+| `dispatcher.shutdownTimeout`                  | `'30s'`                   | Longest the whole shutdown takes; past it, handlers are abandoned                |
 | `retention.completed` / `.dead` / `.interval` | `'7d'` / `false` / `'1h'` | Cleanup of finished deliveries                                                   |
 | `transports`, `routes`, `subscriptions`       | none                      | Broker fan-out and fan-in (`@relaybus/kafka`, `@relaybus/rabbitmq`)              |
 | `setupStore`                                  | `true`                    | Create tables/indexes on start                                                   |
@@ -80,43 +104,99 @@ logs through a Nest `Logger` with context `RelayBus`, so `app.useLogger(...)` co
 | `clock`, `generateIdentifier`, `random`       | system                    | Mainly for tests                                                                 |
 | `isGlobal`                                    | `true`                    | Module-level, see above                                                          |
 
-## `@Subscribe(event, options?)`
+## `@RelayBusConsumer(event, options?)`
+
+The default way to handle events: put `@RelayBusConsumer` on any method of any provider.
 
 ```ts
-@Subscribe(OrderPlaced)                                   // class
-@Subscribe('order.placed.v1', { concurrency: 2 })         // type string
-@Subscribe(OrderPlaced, { id: 'billing.invoice', transactional: true, timeout: '10s' })
+@Injectable()
+export class ShippingHandlers {
+  @RelayBusConsumer(OrderPlaced)
+  async shipOrder(event: EventEnvelope<{ orderId: string }>) {}
+
+  @RelayBusConsumer(UserRegistered, { id: 'shipping.welcome-pack', retry: { attempts: 5 } })
+  async sendWelcomePack(event: EventOf<typeof UserRegistered>, context: HandlerContext) {}
+}
 ```
 
-Options are core's `SubscribeOptions` with `id` optional. Methods receive `(envelope, context)`;
-with a class argument the envelope payload is typed from the event.
+```ts
+@RelayBusConsumer(OrderPlaced)                                   // class
+@RelayBusConsumer('order.placed.v1', { concurrency: 2 })         // type string
+@RelayBusConsumer(OrderPlaced, { id: 'billing.invoice', transactional: true, timeout: '10s' })
+```
 
-**Why `@Subscribe`:** `@nestjs/event-emitter` already owns `@OnEvent`, and the two are commonly
-installed together. `@Subscribe` mirrors core's `bus.subscribe` and cannot collide.
+- **No class-level setup.** No catalog, interface or base class: method names are free, and one
+  class may handle events of different catalogs (or of none).
+- **Typed at compile time.** With a class argument the first parameter must be the envelope of
+  that event: `@RelayBusConsumer(OrderPlaced) ship(event: EventEnvelope<{ userId: number }>)` does
+  not compile.
+- Options are core's `SubscribeOptions` with `id` optional. Methods receive `(envelope, context)`.
+
+**Names.** The relaybus decorators share the `RelayBus` prefix (`@RelayBusConsumer`,
+`@RelayBusCatalogConsumer`, `@RelayBusTransaction`), so they never collide with `@nestjs/event-emitter`'s
+`@OnEvent` or `@nestjs/cqrs`. `@Subscribe` and `@EventConsumer` are the earlier names of
+`@RelayBusConsumer` and `@RelayBusCatalogConsumer`: they still work, are the same functions, are marked
+`@deprecated` (editors strike them through) and are removed in 1.0.0. `@RelayBusConsumer` only
+compiles on a method and takes an event; `@RelayBusCatalogConsumer` only compiles on a class and
+takes a catalog.
 
 Rules, all enforced at boot (the application fails to start, no silent skips):
 
 - **Stable ids.** The default id is `ClassName.methodName`. Deliveries are stored under the id, so
   renaming the class or method orphans pending deliveries; pin `{ id }` on handlers that matter.
-- **Duplicate ids** fail init with both locations named. A method with several `@Subscribe`
+- **Duplicate ids** fail init with both locations named. A method with several `@RelayBusConsumer`
   decorators must give each an explicit `id`.
 - **Singletons only.** Handlers on request-scoped or transient providers (or default-scoped
   providers that depend on one) are rejected: deliveries run outside any request, so there is no
   request instance to call. This covers class, `useClass` and `useFactory` providers (a factory is
   checked through its class token; a request-scoped factory under a string token cannot be
-  inspected). Providers without `@Subscribe` are never inspected for scope.
+  inspected). Providers without `@RelayBusConsumer` are never inspected for scope.
 - `this` is bound to the provider instance. Only providers are scanned, in every module. A handler
   reachable through several tokens (`useExisting`) is registered once. Declarations are stored per
   class and method, so decorators that wrap the method later do not drop them, and subclasses
   inherit the handlers of their base class.
 
-## `@EventConsumer(catalog, options?)`
+## Module contracts: `RelayBusModule.forFeature(...)`
+
+The recommended way to use catalogs in NestJS. A feature module states which events it consumes
+and produces; the method-level `@RelayBusConsumer` handlers of its providers fulfil the contract,
+spread over any classes and method names.
+
+```ts
+@Module({
+  imports: [
+    RelayBusModule.forFeature({
+      consumes: [OrderEvents], // or consume(OrderEvents, { events: ['OrderPlaced'] })
+      produces: [produce(BillingEvents, { events: ['InvoiceIssued'] })],
+    }),
+  ],
+  providers: [ChargeHandlers, RefundHandlers],
+})
+export class BillingModule {}
+```
+
+When the application initialises:
+
+- every consumed event needs a `@RelayBusConsumer` method (or a `@RelayBusCatalogConsumer` class)
+  among the providers **of that module**; consumers in other modules do not count;
+- every produced event needs a route to a transport (`routes` of `forRoot`).
+
+Otherwise the application fails to start with one line per gap, for example
+`[RelayBusHandlerExplorer](assertModuleContracts) BillingModule: OrderEvents.OrderCancelled (order.cancelled.v1) has no consumer`.
+`forRoot({ catalogs })` keeps working as the application-wide check (handlers anywhere).
+
+## Stricter checking (optional): catalogs and `@RelayBusCatalogConsumer(catalog, options?)`
+
+Method-level handlers are enough for most services. When a team wants the compiler and the boot
+to prove that _every_ event of a shared contract is handled, group the events in a catalog and
+let a class consume it. Everything here is optional and can be added later, next to
+`@RelayBusConsumer` methods.
 
 ```ts
 export const OrderEvents = defineCatalog({ OrderPlaced, OrderShipped }, { name: 'OrderEvents' });
 
 @Injectable()
-@EventConsumer(OrderEvents, { transactional: true })
+@RelayBusCatalogConsumer(OrderEvents, { transactional: true })
 export class ShippingHandlers implements HandlersOf<typeof OrderEvents> {
   onOrderPlaced(event: EventOf<typeof OrderPlaced>, context: HandlerContext) {}
   onOrderShipped(event: EventOf<typeof OrderShipped>) {}
@@ -132,13 +212,13 @@ documents a deliberate subset. Options are core's `SubscribeOptions` without `id
 handler of the class.
 
 - `catalogs: [OrderEvents]` in the module options is the boot check: if no provider (via
-  `@EventConsumer`, `@Subscribe` or a configured route) handles an event, the application fails to
+  `@RelayBusCatalogConsumer`, `@RelayBusConsumer` or a configured route) handles an event, the application fails to
   start with the list of missing events and the methods they expect.
-- It works next to `@Subscribe` in the same class. A `@Subscribe` that would take the same default
-  id (`@Subscribe(OrderPlaced) onOrderPlaced()`) fails init naming both; give it an explicit `id`.
-- Same rules as `@Subscribe`: singleton providers only, `useExisting` aliases register once,
+- It works next to `@RelayBusConsumer` in the same class. A `@RelayBusConsumer` that would take the same default
+  id (`@RelayBusConsumer(OrderPlaced) onOrderPlaced()`) fails init naming both; give it an explicit `id`.
+- Same rules as `@RelayBusConsumer`: singleton providers only, `useExisting` aliases register once,
   subclasses inherit the decoration and use their own class name in ids.
-- A class decorated with `@EventConsumer` that defines none of the catalog's methods fails init,
+- A class decorated with `@RelayBusCatalogConsumer` that defines none of the catalog's methods fails init,
   which catches misspelled method names.
 - Declarations are inherited from base classes; a subclass that declares the same catalog again
   replaces the inherited declaration, and one catalog declared twice on one class throws.
@@ -148,7 +228,7 @@ handler of the class.
 ```ts
 // shipping service
 @Injectable()
-@EventConsumer(OrderEvents, { events: ['OrderPlaced'] })
+@RelayBusCatalogConsumer(OrderEvents, { events: ['OrderPlaced'] })
 export class ShippingHandlers {
   onOrderPlaced(event: EventOf<typeof OrderPlaced>) {}
 }
@@ -177,8 +257,9 @@ RelayBusModule.forRoot({
 2. `onApplicationBootstrap`: `bus.start()` creates the schema (unless `setupStore: false`),
    connects transports and starts the dispatcher. If it rejects (database down, broker
    unreachable) the application does not boot.
-3. `beforeApplicationShutdown`: `bus.stop()` stops claiming, waits for running handlers up to
-   `shutdownTimeout`, then closes transports and the store. Needs `app.enableShutdownHooks()` for
+3. `beforeApplicationShutdown`: `bus.stop()` stops claiming, waits for running handlers, then
+   closes transports and the store, all within `shutdownTimeout` (it force-closes and resolves
+   when the deadline passes, see above). Needs `app.enableShutdownHooks()` for
    signals; `app.close()` runs it regardless. Nest runs `onApplicationShutdown` hooks (where
    TypeORM, Mongoose and most pools disconnect) after this, so handlers still have their
    connections while draining. If your own provider disconnects in `onModuleDestroy` (common with
@@ -186,14 +267,81 @@ RelayBusModule.forRoot({
 
 ## Transactions
 
-Inside `bus.transaction(fn)` every `publish` joins the transaction. Without it, publish needs a
-transaction: pass `{ transaction }`, configure `transactionResolver`, or set
-`transactionMode: 'optional'` (event stays durable but is no longer atomic with your writes).
+### `@RelayBusTransaction()`
+
+Runs an async method in a relaybus transaction. Every `bus.publish(...)` inside it, and inside
+everything it awaits, joins the transaction without `{ transaction }`; the transaction commits when
+the method resolves and rolls back when it throws.
+
+```ts
+// Before: the transaction is threaded through by hand
+async place(orderId: string): Promise<void> {
+  await this.bus.transaction(async (tx) => {
+    await tx.query('INSERT INTO orders (id) VALUES ($1)', [orderId]);
+    await this.bus.publish(new OrderPlaced({ orderId }), { transaction: tx });
+  });
+}
+
+// After
+@RelayBusTransaction()
+async place(orderId: string): Promise<void> {
+  await this.orders.insert(orderId); // the repository reads RelayBusTransactionHost.current()
+  await this.bus.publish(new OrderPlaced({ orderId }));
+}
+```
+
+- **Self-calls are transactional.** The decorator replaces the method itself (not an interceptor
+  or proxy), so `this.place()` from another method of the class opens the transaction too.
+- **Nested calls share one transaction.** A decorated method called inside another one, inside
+  `bus.transaction`, inside a transactional handler, or while `transactionResolver` finds a
+  transaction (for example `@nestjs-cls/transactional`) joins it instead of opening a second one.
+- **No injection needed.** The bus is the one of the application's `RelayBusModule`. Calling the
+  method before the application initialised, after it shut down, or with no `RelayBusModule`
+  throws a `ConfigurationError` that says so.
+- **Async methods only.** On a method that does not return a Promise it fails to compile:
+  `'@RelayBusTransaction() needs a method that returns a Promise: make the method async'`.
+
+### Time budget: `transactionTimeout`
+
+Every relaybus transaction (`bus.transaction` and `@RelayBusTransaction()`) is held to
+`transactionTimeout` (default `'5s'`). The database enforces it where it can, so a transaction
+waiting on something slow is ended by the server and its row locks are released:
+
+- **PostgreSQL:** `SET LOCAL statement_timeout`, and with the `pg` executor also
+  `idle_in_transaction_session_timeout` and, on PostgreSQL 17+, `transaction_timeout` (detected
+  per transaction). Adapters other than `pg` get `statement_timeout` only, because a server-ended
+  session would leave their checked-out connection without an `error` listener.
+- **MongoDB:** `maxCommitTimeMS` on the commit.
+
+A transaction that still runs past the budget is rolled back before it commits. Either way the
+caller gets a `TransactionTimeoutError` (`RELAYBUS_TRANSACTION_TIMEOUT`, with the database error as
+`cause`) whose message points at the usual cause: a slow call to another service inside the
+transaction. Move HTTP calls before the transaction or after it commits (the
+`@relaybus/eslint-plugin` rule `no-external-call-in-transaction` catches them) instead of raising
+the budget.
+
+### Repositories: `RelayBusTransactionHost<T>`
+
+Inject `RelayBusTransactionHost` typed with your store's transaction handle. `current()` returns
+the active transaction and throws `TransactionRequiredError` outside one; `find()` returns
+`undefined` instead. Outside Nest, `bus.currentTransaction()` does the same as `find()`.
+
+| Store / executor                    | `T` of `RelayBusTransactionHost<T>` | Write with                                   |
+| ----------------------------------- | ----------------------------------- | -------------------------------------------- |
+| `PostgresEventStore` with `pg`      | `PoolClient`                        | `tx.query(sql, values)`                      |
+| `createKyselyExecutor(db)`          | `Transaction<DB>`                   | `tx.insertInto('orders')...execute()`        |
+| `createTypeOrmExecutor(dataSource)` | `EntityManager`                     | `tx.getRepository(Order).save(order)`        |
+| `createPrismaExecutor(prisma)`      | `Prisma.TransactionClient`          | `tx.order.create({ data })`                  |
+| `MongoEventStore`                   | `ClientSession`                     | `collection.insertOne(doc, { session: tx })` |
+
+Without a decorator or `bus.transaction`, `publish` needs a transaction: pass `{ transaction }`,
+configure `transactionResolver`, or set `transactionMode: 'optional'` (event stays durable but is
+no longer atomic with your writes).
 
 ### Transactional handlers
 
 ```ts
-@Subscribe(PaymentCaptured, { id: 'ledger.record-capture', transactional: true })
+@RelayBusConsumer(PaymentCaptured, { id: 'ledger.record-capture', transactional: true })
 async record(event: EventEnvelope<{ paymentId: string }>, context: HandlerContext<PoolClient>) {
   // Writes through context.transaction commit atomically with the delivery completion:
   // effectively-once processing. Keep these handlers short.
@@ -293,7 +441,7 @@ await moduleRef.close();
   global (`isGlobal: false`) and not imported by the consuming module.
 - **Handler never runs:** the provider is not listed in any module `providers`, the process runs
   with `dispatcher.enabled: false`, or the event type differs (check `bus.handlers()`).
-- **`uses @Subscribe but its provider is request-scoped or transient`:** make the provider a
+- **`uses @RelayBusConsumer but its provider is request-scoped or transient`:** make the provider a
   singleton; inject request data through the event payload instead.
 - **Vitest/esbuild:** esbuild does not emit decorator metadata; use explicit `@Inject(Token)` in
   test classes.