@regulaforensics/react-native-document-reader-api 5.7.0 → 6.1.0

package/README.md

@@ -34,7 +34,7 @@ $ pod install
 5. iOS:
   * Copy the `regula.license` file to the `example/ios/DocumentReader` folder.
   * Change the Bundle Identifier to the one you have specified during the registration at [licensing.regulaforensics.com](https://licensing.regulaforensics.com).
-  * Run `react-native run-ios` inside `example` folder - this is just one way to run the app. You can also run it directly from within Xcode.
+  * Run `npx react-native run-ios` inside `example` folder - this is just one way to run the app. You can also run it directly from within Xcode.
 
 ### Troubleshooting license issues
 If you have issues with license verification when running the application, please verify that next is true:
@@ -46,7 +46,7 @@ If you have issues with license verification when running the application, pleas
 6. You placed the  `license` into the correct folder as described [here](#how-to-build-demo-application).
 
 ## Documentation
-You can find documentation on API [here](https://docs.regulaforensics.com/react-native).
+You can find documentation on API [here](https://docs.regulaforensics.com/develop/doc-reader-sdk/mobile/react-native).
 
 ## Additional information
 If you have any technical questions, feel free to [contact](mailto:react.support@regulaforensics.com) us or create issue [here](https://github.com/regulaforensics/react-native-document-reader/issues).

package/RNDocumentReaderApi.podspec

@@ -12,8 +12,8 @@ Pod::Spec.new do |s|
   s.homepage     = 'https://regulaforensics.com'
 
   s.source       = { :http => 'file:' + __dir__ }
-  s.ios.deployment_target = '9.0.0'
+  s.ios.deployment_target = '11.0'
   s.source_files  = "ios/*.{h,m}"
-  s.dependency 'DocumentReader', '5.7.2075'
+  s.dependency 'DocumentReader', '6.1.2358'
   s.dependency 'React'
 end

package/android/build.gradle

@@ -16,7 +16,7 @@ android {
     buildToolsVersion "30.0.0"
 
     defaultConfig {
-        minSdkVersion 19
+        minSdkVersion 21
         targetSdkVersion 30
         versionCode 1
         versionName "1.0"
@@ -37,12 +37,10 @@ repositories {
 rootProject.allprojects {
     repositories {
         maven {
-            url "http://maven.regulaforensics.com/RegulaDocumentReader"
-            allowInsecureProtocol true
+            url "https://maven.regulaforensics.com/RegulaDocumentReader"
         }
         maven {
-            url "http://maven.regulaforensics.com/RegulaDocumentReader/Beta"
-            allowInsecureProtocol true
+            url "https://maven.regulaforensics.com/RegulaDocumentReader/Beta"
         }
     }
 }
@@ -51,7 +49,7 @@ dependencies {
     //noinspection GradleDynamicVersion
     implementation 'com.facebook.react:react-native:+'
     //noinspection GradleDependency
-    implementation('com.regula.documentreader:api:5.7.4947') {
+    implementation('com.regula.documentreader:api:6.1.6564') {
         transitive = true
     }
 }

package/android/src/main/java/com/regula/documentreader/Helpers.java

@@ -24,9 +24,7 @@ import java.util.List;
 class Helpers {
     static Bitmap bitmapFromBase64(String base64) {
         byte[] decodedString = Base64.decode(base64, Base64.DEFAULT);
-        BitmapFactory.Options options = new BitmapFactory.Options();
-        options.inPreferredConfig = Bitmap.Config.RGB_565;
-        Bitmap result = BitmapFactory.decodeByteArray(decodedString, 0, decodedString.length, options);
+        Bitmap result = BitmapFactory.decodeByteArray(decodedString, 0, decodedString.length);
         int sizeMultiplier = result.getByteCount() / 5000000;
         if (result.getByteCount() > 5000000)
             result = Bitmap.createScaledBitmap(result, result.getWidth() / (int) Math.sqrt(sizeMultiplier), result.getHeight() / (int) Math.sqrt(sizeMultiplier), false);
@@ -136,4 +134,11 @@ class Helpers {
             result.add(jsonArray.optString(i));
         return result;
     }
+
+    static String[] stringArrayFromJson(JSONArray jsonArray) {
+        String[] result = new String[jsonArray.length()];
+        for (int i = 0; i < jsonArray.length(); i++)
+            result[i] = jsonArray.optString(i);
+        return result;
+    }
 }

package/android/src/main/java/com/regula/documentreader/JSONConstructor.java

@@ -1,9 +1,12 @@
 package com.regula.documentreader;
 
+import static com.regula.documentreader.api.completions.IRfidNotificationCompletion.RFID_EXTRA_ERROR_CODE;
+
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.graphics.BitmapFactory;
 import android.graphics.Rect;
+import android.os.Bundle;
 import android.util.Base64;
 
 import com.regula.documentreader.api.enums.DocReaderAction;
@@ -11,11 +14,13 @@ import com.regula.documentreader.api.enums.PDF417Info;
 import com.regula.documentreader.api.enums.eGraphicFieldType;
 import com.regula.documentreader.api.enums.eRPRM_Lights;
 import com.regula.documentreader.api.errors.DocumentReaderException;
+import com.regula.documentreader.api.internal.core.CoreDetailedScenario;
 import com.regula.documentreader.api.params.FaceMetaData;
 import com.regula.documentreader.api.params.rfid.authorization.PAAttribute;
 import com.regula.documentreader.api.params.rfid.authorization.PAResourcesIssuer;
 import com.regula.documentreader.api.params.rfid.authorization.TAChallenge;
 import com.regula.documentreader.api.results.Bounds;
+import com.regula.documentreader.api.results.BytesData;
 import com.regula.documentreader.api.results.Coordinate;
 import com.regula.documentreader.api.results.DocReaderFieldRect;
 import com.regula.documentreader.api.results.DocumentReaderBarcodeField;
@@ -25,14 +30,15 @@ import com.regula.documentreader.api.results.DocumentReaderGraphicField;
 import com.regula.documentreader.api.results.DocumentReaderGraphicResult;
 import com.regula.documentreader.api.results.DocumentReaderNotification;
 import com.regula.documentreader.api.results.DocumentReaderResults;
+import com.regula.documentreader.api.results.DocumentReaderResultsStatus;
 import com.regula.documentreader.api.results.DocumentReaderScenario;
-import com.regula.documentreader.api.results.DocumentReaderScenarioFull;
 import com.regula.documentreader.api.results.DocumentReaderTextField;
 import com.regula.documentreader.api.results.DocumentReaderTextResult;
 import com.regula.documentreader.api.results.DocumentReaderValue;
 import com.regula.documentreader.api.results.ElementPosition;
 import com.regula.documentreader.api.results.ImageQuality;
 import com.regula.documentreader.api.results.ImageQualityGroup;
+import com.regula.documentreader.api.results.VDSNCData;
 import com.regula.documentreader.api.results.authenticity.DocumentReaderAuthenticityCheck;
 import com.regula.documentreader.api.results.authenticity.DocumentReaderAuthenticityElement;
 import com.regula.documentreader.api.results.authenticity.DocumentReaderAuthenticityResult;
@@ -294,6 +300,18 @@ class JSONConstructor {
         return result;
     }
 
+    static JSONObject generateRfidNotificationCompletion(int notification, Bundle value) {
+        JSONObject result = new JSONObject();
+        try {
+            result.put("notification", notification);
+            if(value != null)
+            result.put("value", value.get(RFID_EXTRA_ERROR_CODE));
+        } catch (JSONException ignored) {
+        }
+
+        return result;
+    }
+
     static JSONObject generatePACertificateCompletion(byte[] serialNumber, PAResourcesIssuer issuer) {
         JSONObject result = new JSONObject();
         try {
@@ -335,8 +353,6 @@ class JSONConstructor {
         JSONObject result = new JSONObject();
         if (input == null) return result;
         try {
-            result.put("uvTorch", input.uvTorch);
-            result.put("seriesProcessMode", input.seriesProcessMode);
             result.put("name", input.name);
             result.put("caption", input.caption);
             result.put("description", input.description);
@@ -346,7 +362,7 @@ class JSONConstructor {
         return result;
     }
 
-    static JSONObject generateDocumentReaderScenarioFull(DocumentReaderScenarioFull input) {
+    static JSONObject generateCoreDetailedScenario(CoreDetailedScenario input) {
         JSONObject result = new JSONObject();
         if (input == null) return result;
         try {
@@ -1039,6 +1055,92 @@ class JSONConstructor {
         return result;
     }
 
+    static JSONObject generateDocumentReaderResultsStatus(DocumentReaderResultsStatus input) {
+        JSONObject result = new JSONObject();
+        if (input == null) return result;
+        try {
+            result.put("overallStatus", input.getOverallStatus());
+            result.put("optical", input.getOptical());
+            result.put("detailsOptical", generateDetailsOptical(input.getDetailsOptical()));
+            result.put("rfid", input.getRfid());
+            result.put("detailsRFID", generateDetailsRFID(input.getDetailsRFID()));
+            result.put("portrait", input.getPortrait());
+            result.put("stopList", input.getStopList());
+        } catch (JSONException e) {
+            e.printStackTrace();
+        }
+        return result;
+    }
+
+    static JSONObject generateDetailsOptical(DocumentReaderResultsStatus.DetailsOptical input) {
+        JSONObject result = new JSONObject();
+        if (input == null) return result;
+        try {
+            result.put("overallStatus", input.getOverallStatus());
+            result.put("mrz", input.getMrz());
+            result.put("text", input.getText());
+            result.put("docType", input.getDocType());
+            result.put("security", input.getSecurity());
+            result.put("imageQA", input.getImageQA());
+            result.put("expiry", input.getExpiry());
+            result.put("vds", input.getVds());
+            result.put("pagesCount", input.getPagesCount());
+        } catch (JSONException e) {
+            e.printStackTrace();
+        }
+        return result;
+    }
+
+    static JSONObject generateDetailsRFID(DocumentReaderResultsStatus.DetailsRFID input) {
+        JSONObject result = new JSONObject();
+        if (input == null) return result;
+        try {
+            result.put("pa", input.getPA());
+            result.put("ca", input.getCA());
+            result.put("aa", input.getAA());
+            result.put("ta", input.getTA());
+            result.put("bac", input.getBAC());
+            result.put("pace", input.getPACE());
+            result.put("overallStatus", input.getOverallStatus());
+        } catch (JSONException e) {
+            e.printStackTrace();
+        }
+        return result;
+    }
+
+    static JSONObject generateVDSNCData(VDSNCData input) {
+        JSONObject result = new JSONObject();
+        if (input == null) return result;
+        try {
+            result.put("type", input.getType());
+            result.put("version", input.getVersion());
+            result.put("issuingCountry", input.getIssuingCountry());
+            result.put("message", input.getMessage());
+            result.put("signatureAlgorithm", input.getSignatureAlg());
+            result.put("signature", generateBytesData(input.getSignature()));
+            result.put("certificate", generateBytesData(input.getCertificate()));
+            result.put("certificateChain", generateList(input.getCertificateChain(), JSONConstructor::generateCertificateChain));
+            result.put("notifications", generateLongArray(input.getNotifications()));
+        } catch (JSONException e) {
+            e.printStackTrace();
+        }
+        return result;
+    }
+
+    static JSONObject generateBytesData(BytesData input) {
+        JSONObject result = new JSONObject();
+        if (input == null) return result;
+        try {
+            result.put("data", input.getData());
+            result.put("length", input.getLength());
+            result.put("status", input.getStatus());
+            result.put("type", input.getType());
+        } catch (JSONException e) {
+            e.printStackTrace();
+        }
+        return result;
+    }
+
     static JSONObject generateDocumentReaderResults(DocumentReaderResults input, Context context) {
         JSONObject result = new JSONObject();
         if (input == null) return result;
@@ -1063,6 +1165,8 @@ class JSONConstructor {
             result.put("authenticityResult", generateDocumentReaderAuthenticityResult(input.authenticityResult, context));
             result.put("barcodeResult", generateDocumentReaderBarcodeResult(input.barcodeResult));
             result.put("documentType", generateList(input.documentType, JSONConstructor::generateDocumentReaderDocumentType));
+            result.put("status", generateDocumentReaderResultsStatus(input.status));
+            result.put("vdsncData", generateVDSNCData(input.vdsncData));
         } catch (JSONException e) {
             e.printStackTrace();
         }
@@ -1074,10 +1178,6 @@ class JSONConstructor {
     static DocumentReaderScenario DocumentReaderScenarioFromJSON(JSONObject input) {
         try {
             DocumentReaderScenario result = new DocumentReaderScenario();
-            if (input.has("uvTorch"))
-                result.uvTorch = input.getBoolean("uvTorch");
-            if (input.has("seriesProcessMode"))
-                result.seriesProcessMode = input.getBoolean("seriesProcessMode");
             if (input.has("name"))
                 result.name = input.getString("name");
             if (input.has("caption"))
@@ -1091,9 +1191,9 @@ class JSONConstructor {
         return null;
     }
 
-    static DocumentReaderScenarioFull DocumentReaderScenarioFullFromJSON(JSONObject input) {
+    static CoreDetailedScenario CoreDetailedScenarioFromJSON(JSONObject input) {
         try {
-            DocumentReaderScenarioFull result = new DocumentReaderScenarioFull();
+            CoreDetailedScenario result = new CoreDetailedScenario();
             if (input.has("uvTorch"))
                 result.uvTorch = input.getBoolean("uvTorch");
             if (input.has("frameOrientation"))

package/android/src/main/java/com/regula/documentreader/RNRegulaDocumentReaderModule.java

@@ -1,5 +1,6 @@
 package com.regula.documentreader;
 
+import android.annotation.SuppressLint;
 import android.app.Activity;
 import android.app.PendingIntent;
 import android.content.Context;
@@ -8,6 +9,7 @@ import android.content.IntentFilter;
 import android.graphics.Bitmap;
 import android.nfc.NfcAdapter;
 import android.nfc.tech.IsoDep;
+import android.os.Bundle;
 import android.util.Base64;
 
 import com.facebook.react.bridge.ActivityEventListener;
@@ -23,28 +25,34 @@ import com.facebook.react.modules.core.DeviceEventManagerModule;
 import com.regula.documentreader.api.completions.IDocumentReaderCompletion;
 import com.regula.documentreader.api.completions.IDocumentReaderInitCompletion;
 import com.regula.documentreader.api.completions.IDocumentReaderPrepareCompletion;
-import com.regula.documentreader.api.completions.IRfidNotificationCompletion;
 import com.regula.documentreader.api.completions.IRfidPKDCertificateCompletion;
 import com.regula.documentreader.api.completions.IRfidReaderRequest;
 import com.regula.documentreader.api.completions.IRfidTASignatureCompletion;
 import com.regula.documentreader.api.enums.DocReaderAction;
 import com.regula.documentreader.api.errors.DocumentReaderException;
+import com.regula.documentreader.api.internal.core.CoreScenarioUtil;
+import com.regula.documentreader.api.params.DocReaderConfig;
 import com.regula.documentreader.api.params.ImageInputParam;
 import com.regula.documentreader.api.params.rfid.PKDCertificate;
 import com.regula.documentreader.api.params.rfid.authorization.PAResourcesIssuer;
 import com.regula.documentreader.api.params.rfid.authorization.TAChallenge;
 import com.regula.documentreader.api.results.DocumentReaderResults;
+import com.regula.documentreader.api.parser.DocReaderResultsJsonParser;
 
 import org.json.JSONArray;
 import org.json.JSONException;
 import org.json.JSONObject;
 
 import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
 import java.util.ArrayList;
 import java.util.List;
 
 import static com.regula.documentreader.api.DocumentReader.Instance;
 
+import androidx.annotation.NonNull;
+
 @SuppressWarnings({"ConstantConditions", "RedundantSuppression"})
 public class RNRegulaDocumentReaderModule extends ReactContextBaseJavaModule implements ActivityEventListener, LifecycleEventListener {
     private final static String prepareDatabaseProgressChangeEvent = "prepareDatabaseProgressChangeEvent";
@@ -132,8 +140,8 @@ public class RNRegulaDocumentReaderModule extends ReactContextBaseJavaModule imp
         send(videoEncoderCompletionEvent, JSONConstructor.generateVideoEncoderCompletion(sessionId, file).toString());
     }
 
-    private void sendIRfidNotificationCompletion(int notification) {
-        send(rfidNotificationCompletionEvent, notification + "");
+    private void sendIRfidNotificationCompletion(int notification, Bundle value) {
+        send(rfidNotificationCompletionEvent, JSONConstructor.generateRfidNotificationCompletion(notification, value).toString());
     }
 
     private void sendPACertificateCompletion(byte[] serialNumber, PAResourcesIssuer issuer) {
@@ -181,6 +189,9 @@ public class RNRegulaDocumentReaderModule extends ReactContextBaseJavaModule imp
         };
         try {
             switch (action) {
+                case "initializeReaderAutomatically":
+                    initializeReaderAutomatically(callback);
+                    break;
                 case "getAPIVersion":
                     getAPIVersion(callback);
                     break;
@@ -337,6 +348,9 @@ public class RNRegulaDocumentReaderModule extends ReactContextBaseJavaModule imp
                 case "provideTASignature":
                     provideTASignature(callback, args(0));
                     break;
+                case "parseCoreResults":
+                    parseCoreResults(callback, args(0));
+                    break;
                 case "initializeReaderWithDatabasePath":
                     initializeReaderWithDatabasePath(callback, args(0), args(1));
                     break;
@@ -376,6 +390,7 @@ public class RNRegulaDocumentReaderModule extends ReactContextBaseJavaModule imp
         };
         Intent intent = new Intent(activity.getApplicationContext(), activity.getClass());
         intent.setFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP);
+        @SuppressLint("UnspecifiedImmutableFlag")
         PendingIntent pendingIntent = PendingIntent.getActivity(activity.getApplicationContext(), 0, intent, 0);
         NfcAdapter.getDefaultAdapter(getActivity()).enableForegroundDispatch(activity, pendingIntent, filters, techList);
     }
@@ -387,10 +402,32 @@ public class RNRegulaDocumentReaderModule extends ReactContextBaseJavaModule imp
         backgroundRFIDEnabled = false;
     }
 
+    private void initializeReaderAutomatically(Callback callback) {
+        if (!Instance().isReady())
+            try {
+                InputStream is = getContext().getAssets().open("regula.license");
+                byte[] license = new byte[is.available()];
+                //noinspection ResultOfMethodCallIgnored
+                is.read(license);
+                Instance().initializeReader(getContext(), new DocReaderConfig(license), getInitCompletion(callback));
+                is.close();
+            } catch (IOException e) {
+                e.printStackTrace();
+                callback.error("problem reading license(see logs)");
+            }
+        else
+            callback.success("already initialized");
+    }
+
     private void getAvailableScenarios(Callback callback) throws JSONException {
         callback.success(JSONConstructor.generateList(Instance().availableScenarios, JSONConstructor::generateDocumentReaderScenario).toString());
     }
 
+    private void parseCoreResults(Callback callback, String json) {
+        DocumentReaderResults results = (DocumentReaderResults) DocReaderResultsJsonParser.parseCoreResults(json).get("docReaderResults");
+        callback.success(JSONConstructor.generateDocumentReaderResults(results, getContext()).toString());
+    }
+
     private void getAPIVersion(Callback callback) {
         callback.success(Instance().version.api);
     }
@@ -445,11 +482,11 @@ public class RNRegulaDocumentReaderModule extends ReactContextBaseJavaModule imp
     }
 
     private void selectedScenario(Callback callback) {
-        callback.success(JSONConstructor.generateDocumentReaderScenarioFull(Instance().getScenario(Instance().processParams().getScenario())).toString());
+        callback.success(JSONConstructor.generateCoreDetailedScenario(CoreScenarioUtil.getScenario(Instance().processParams().getScenario())).toString());
     }
 
     private void getScenario(Callback callback, String scenario) {
-        callback.success(JSONConstructor.generateDocumentReaderScenarioFull(Instance().getScenario(scenario)).toString());
+        callback.success(JSONConstructor.generateCoreDetailedScenario(CoreScenarioUtil.getScenario(scenario)).toString());
     }
 
     private void getLicenseExpiryDate(Callback callback) {
@@ -471,11 +508,11 @@ public class RNRegulaDocumentReaderModule extends ReactContextBaseJavaModule imp
     }
 
     private void getDocumentReaderIsReady(Callback callback) {
-        callback.success(Instance().getDocumentReaderIsReady());
+        callback.success(Instance().isReady());
     }
 
     private void getDocumentReaderStatus(Callback callback) {
-        callback.success(Instance().getDocumentReaderStatus());
+        callback.success(Instance().isReady());
     }
 
     private void isRFIDAvailableForUse(Callback callback) {
@@ -483,15 +520,15 @@ public class RNRegulaDocumentReaderModule extends ReactContextBaseJavaModule imp
     }
 
     private void initializeReader(Callback callback, Object license) {
-        if (!Instance().getDocumentReaderIsReady())
-            Instance().initializeReader(getContext(), Base64.decode(license.toString(), Base64.DEFAULT), getInitCompletion(callback));
+        if (!Instance().isReady())
+            Instance().initializeReader(getContext(), new DocReaderConfig(Base64.decode(license.toString(), Base64.DEFAULT)), getInitCompletion(callback));
         else
             callback.success("already initialized");
     }
 
     private void initializeReaderWithDatabase(Callback callback, Object license, Object db) {
-        if (!Instance().getDocumentReaderIsReady())
-            Instance().initializeReader(getContext(), Base64.decode(license.toString(), Base64.DEFAULT), Base64.decode(db.toString(), Base64.DEFAULT), getInitCompletion(callback));
+        if (!Instance().isReady())
+            Instance().initializeReader(getContext(), new DocReaderConfig(Base64.decode(license.toString(), Base64.DEFAULT), Base64.decode(db.toString(), Base64.DEFAULT)), getInitCompletion(callback));
         else
             callback.success("already initialized");
     }
@@ -593,11 +630,11 @@ public class RNRegulaDocumentReaderModule extends ReactContextBaseJavaModule imp
     private void startRFIDReader(@SuppressWarnings("unused") Callback callback) {
         stopBackgroundRFID();
         IRfidReaderRequest delegate = null;
-        if(rfidDelegate == RFIDDelegate.NO_PA)
+        if (rfidDelegate == RFIDDelegate.NO_PA)
             delegate = getIRfidReaderRequestNoPA();
-        if(rfidDelegate == RFIDDelegate.FULL)
+        if (rfidDelegate == RFIDDelegate.FULL)
             delegate = getIRfidReaderRequest();
-        Instance().startRFIDReader(getContext(), getCompletion(), delegate, getIRfidNotificationCompletion());
+        Instance().startRFIDReader(getContext(), getCompletion(), delegate, this::sendIRfidNotificationCompletion);
     }
 
     private void stopRFIDReader(Callback callback) {
@@ -705,7 +742,7 @@ public class RNRegulaDocumentReaderModule extends ReactContextBaseJavaModule imp
     private IDocumentReaderCompletion getCompletion() {
         return (action, results, error) -> {
             sendCompletion(action, results, error);
-            if (action == DocReaderAction.ERROR || action == DocReaderAction.CANCEL || (action == DocReaderAction.COMPLETE && results.rfidResult == 1))
+            if (action == DocReaderAction.ERROR || action == DocReaderAction.CANCEL || (action == DocReaderAction.COMPLETE && results != null && results.rfidResult == 1))
                 stopBackgroundRFID();
         };
     }
@@ -743,20 +780,20 @@ public class RNRegulaDocumentReaderModule extends ReactContextBaseJavaModule imp
     private IRfidReaderRequest getIRfidReaderRequest() {
         return new IRfidReaderRequest() {
             @Override
-            public void onRequestPACertificates(byte[] serialNumber, PAResourcesIssuer issuer, IRfidPKDCertificateCompletion completion) {
+            public void onRequestPACertificates(byte[] serialNumber, PAResourcesIssuer issuer, @NonNull IRfidPKDCertificateCompletion completion) {
                 paCertificateCompletion = completion;
                 completion.onCertificatesReceived(new PKDCertificate[0]);
                 sendPACertificateCompletion(serialNumber, issuer);
             }
 
             @Override
-            public void onRequestTACertificates(String keyCAR, IRfidPKDCertificateCompletion completion) {
+            public void onRequestTACertificates(String keyCAR, @NonNull IRfidPKDCertificateCompletion completion) {
                 taCertificateCompletion = completion;
                 sendTACertificateCompletion(keyCAR);
             }
 
             @Override
-            public void onRequestTASignature(TAChallenge challenge, IRfidTASignatureCompletion completion) {
+            public void onRequestTASignature(TAChallenge challenge, @NonNull IRfidTASignatureCompletion completion) {
                 taSignatureCompletion = completion;
                 sendTASignatureCompletion(challenge);
             }
@@ -766,19 +803,19 @@ public class RNRegulaDocumentReaderModule extends ReactContextBaseJavaModule imp
     private IRfidReaderRequest getIRfidReaderRequestNoPA() {
         return new IRfidReaderRequest() {
             @Override
-            public void onRequestPACertificates(byte[] serialNumber, PAResourcesIssuer issuer, IRfidPKDCertificateCompletion completion) {
+            public void onRequestPACertificates(byte[] serialNumber, PAResourcesIssuer issuer, @NonNull IRfidPKDCertificateCompletion completion) {
                 paCertificateCompletion = null;
                 completion.onCertificatesReceived(new PKDCertificate[0]);
             }
 
             @Override
-            public void onRequestTACertificates(String keyCAR, IRfidPKDCertificateCompletion completion) {
+            public void onRequestTACertificates(String keyCAR, @NonNull IRfidPKDCertificateCompletion completion) {
                 taCertificateCompletion = completion;
                 sendTACertificateCompletion(keyCAR);
             }
 
             @Override
-            public void onRequestTASignature(TAChallenge challenge, IRfidTASignatureCompletion completion) {
+            public void onRequestTASignature(TAChallenge challenge, @NonNull IRfidTASignatureCompletion completion) {
                 taSignatureCompletion = completion;
                 sendTASignatureCompletion(challenge);
             }
@@ -792,9 +829,4 @@ public class RNRegulaDocumentReaderModule extends ReactContextBaseJavaModule imp
         public static final int NO_PA = 1;
         public static final int FULL = 2;
     }
-
-
-    private IRfidNotificationCompletion getIRfidNotificationCompletion() {
-        return (notificationType, value) -> sendIRfidNotificationCompletion(notificationType);
-    }
 }