@refinitiv-ui/elements 7.9.0 → 7.9.1

package/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [7.9.1](https://github.com/Refinitiv/refinitiv-ui/compare/@refinitiv-ui/elements@7.9.0...@refinitiv-ui/elements@7.9.1) (2023-11-13)
+
+### Bug Fixes
+
+- **time-picker:** remove pre-populate value ([#995](https://github.com/Refinitiv/refinitiv-ui/issues/995)) ([afe008c](https://github.com/Refinitiv/refinitiv-ui/commit/afe008c1059031d28f6a6c6cff79caf8f301acaa))
+
 # [7.9.0](https://github.com/Refinitiv/refinitiv-ui/compare/@refinitiv-ui/elements@7.8.0...@refinitiv-ui/elements@7.9.0) (2023-11-06)
 
 ### Features

package/lib/time-picker/index.d.ts

@@ -143,6 +143,10 @@ export declare class TimePicker extends ControlElement {
      * Seconds are automatically shown when `hh:mm:ss` time format is provided as a value.
      */
     private get isShowSeconds();
+    /**
+     * True if time value is complete, that is having all the required time segment
+     */
+    private get isCompleteValue();
     /**
      * Get hours taking into account AM/PM placeholder
      */
@@ -295,6 +299,7 @@ export declare class TimePicker extends ControlElement {
     /**
      * Changes a time segment value by a specified amount.
      * Also updates parent values when rolling through cycles.
+     * Incomplete value will update only segment without pre-populate value.
      * @param amount Amount to change by
      * @param segment Segment id
      * @returns {void}

package/lib/time-picker/index.js

@@ -8,7 +8,7 @@ import { state } from '@refinitiv-ui/core/decorators/state.js';
 import { guard } from '@refinitiv-ui/core/directives/guard.js';
 import '@refinitiv-ui/phrasebook/locale/en/time-picker.js';
 import { translate } from '@refinitiv-ui/translate';
-import { MILLISECONDS_IN_HOUR, MILLISECONDS_IN_MINUTE, MILLISECONDS_IN_SECOND, TimeFormat, addOffset, format, getFormat, isAM, isPM, isValidTime, padNumber, parse, toTimeSegment } from '@refinitiv-ui/utils/date.js';
+import { MILLISECONDS_IN_HOUR, MILLISECONDS_IN_MINUTE, MILLISECONDS_IN_SECOND, MINUTES_IN_HOUR, SECONDS_IN_MINUTE, TimeFormat, addOffset, format, getFormat, isAM, isPM, isValidTime, padNumber, parse, toTimeSegment } from '@refinitiv-ui/utils/date.js';
 import '../number-field/index.js';
 import { VERSION } from '../version.js';
 var Segment;
@@ -23,6 +23,20 @@ const MAX_MINUTES = 59;
 const MAX_SECONDS = 59;
 const HOURS_IN_DAY = 24;
 const HOURS_OF_NOON = 12;
+const SegmentMap = {
+    [Segment.HOURS]: {
+        milliseconds: MILLISECONDS_IN_HOUR,
+        cycle: HOURS_IN_DAY
+    },
+    [Segment.MINUTES]: {
+        milliseconds: MILLISECONDS_IN_MINUTE,
+        cycle: MINUTES_IN_HOUR
+    },
+    [Segment.SECONDS]: {
+        milliseconds: MILLISECONDS_IN_SECOND,
+        cycle: SECONDS_IN_MINUTE
+    }
+};
 const Placeholder = {
     HOURS: '--',
     MINUTES: '--',
@@ -194,7 +208,7 @@ let TimePicker = TimePicker_1 = class TimePicker extends ControlElement {
         }
     }
     get value() {
-        if (this.hours === null || this.minutes === null || (this.isShowSeconds && this.seconds === null)) {
+        if (!this.isCompleteValue) {
             return '';
         }
         return this.currentTimeString;
@@ -230,6 +244,12 @@ let TimePicker = TimePicker_1 = class TimePicker extends ControlElement {
     get isShowSeconds() {
         return this.showSeconds || this.valueWithSeconds;
     }
+    /**
+     * True if time value is complete, that is having all the required time segment
+     */
+    get isCompleteValue() {
+        return !(this.hours === null || this.minutes === null || (this.isShowSeconds && this.seconds === null));
+    }
     /**
      * Get hours taking into account AM/PM placeholder
      */
@@ -358,17 +378,6 @@ let TimePicker = TimePicker_1 = class TimePicker extends ControlElement {
                 break;
             // no default
         }
-        // Pre-populate empty segments
-        if (value !== null) {
-            if (segment === Segment.HOURS && this.minutes === null) {
-                this.minutes = 0;
-            }
-            if (this.isShowSeconds &&
-                this.seconds === null &&
-                (segment === Segment.HOURS || segment === Segment.MINUTES)) {
-                this.seconds = 0;
-            }
-        }
         // verify value again, as time segment validation
         // might fail in setter and previous value returned
         if (oldValue !== this.value) {
@@ -579,27 +588,24 @@ let TimePicker = TimePicker_1 = class TimePicker extends ControlElement {
     /**
      * Changes a time segment value by a specified amount.
      * Also updates parent values when rolling through cycles.
+     * Incomplete value will update only segment without pre-populate value.
      * @param amount Amount to change by
      * @param segment Segment id
      * @returns {void}
      */
     changeValueBy(amount, segment) {
-        let offset = 0;
-        switch (segment) {
-            case Segment.HOURS:
-                offset = this.hours === null ? 0 : amount * MILLISECONDS_IN_HOUR;
-                break;
-            case Segment.MINUTES:
-                offset = this.minutes === null ? 0 : amount * MILLISECONDS_IN_MINUTE;
-                break;
-            case Segment.SECONDS:
-                offset = this.seconds === null ? 0 : amount * MILLISECONDS_IN_SECOND;
-                break;
-            // no default
+        const segmentValue = this[segment];
+        const { milliseconds, cycle } = SegmentMap[segment];
+        if (this.isCompleteValue) {
+            const offset = segmentValue === null ? 0 : amount * milliseconds;
+            const value = addOffset(this.currentTimeString, offset);
+            this.setValueAndNotify(value);
+            this.selectedSegment = segment;
+        }
+        else {
+            // a segment cycle is added to support wrapping of amount with negative value
+            this[segment] = segmentValue === null ? 0 : (segmentValue + amount + cycle) % cycle;
         }
-        const value = addOffset(this.currentTimeString, offset);
-        this.setValueAndNotify(value);
-        this.selectedSegment = segment;
     }
     /**
      * Gets the hours segment of the provided value

package/lib/version.js

@@ -1 +1 @@
-export const VERSION = '7.9.0';
+export const VERSION = '7.9.1';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@refinitiv-ui/elements",
-  "version": "7.9.0",
+  "version": "7.9.1",
   "description": "Element Framework Elements",
   "author": "LSEG",
   "license": "Apache-2.0",
@@ -373,5 +373,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "fd69344454e78b14bb7ecd5ddb4d9286e60e4c95"
+  "gitHead": "78ca6b3e5c4b3347663dc2abc713fa150c9ee638"
 }