@refinitiv-ui/elements 7.13.2 → 7.13.4

package/CHANGELOG.md

@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [7.13.4](https://github.com/Refinitiv/refinitiv-ui/compare/@refinitiv-ui/elements@7.13.3...@refinitiv-ui/elements@7.13.4) (2024-08-26)
+
+### Bug Fixes
+
+- **tree-select:** fix item interface doesn't sync with values ([#1206](https://github.com/Refinitiv/refinitiv-ui/issues/1206)) ([9691ff6](https://github.com/Refinitiv/refinitiv-ui/commit/9691ff6608f99af7ea47121c3f9325ea35b05e12))
+
+## [7.13.3](https://github.com/Refinitiv/refinitiv-ui/compare/@refinitiv-ui/elements@7.13.2...@refinitiv-ui/elements@7.13.3) (2024-08-13)
+
+### Bug Fixes
+
+- **slider:** sync emitted value and input value ([#1198](https://github.com/Refinitiv/refinitiv-ui/issues/1198)) ([59099f6](https://github.com/Refinitiv/refinitiv-ui/commit/59099f619d95565f0aba2c2467056936c8b1e6bf))
+
 ## [7.13.2](https://github.com/Refinitiv/refinitiv-ui/compare/@refinitiv-ui/elements@7.13.1...@refinitiv-ui/elements@7.13.2) (2024-07-30)
 
 ### Bug Fixes

package/lib/slider/elements/slider.js

@@ -806,20 +806,27 @@ let Slider = class Slider extends FormFieldElement {
      */
     updateNotifyProperty(name, value) {
         let shouldUpdate = false;
-        if (name === SliderDataName.to) {
-            shouldUpdate = this.isValueInBoundary(Number(value), SliderDataName.to);
-        }
-        else {
-            shouldUpdate = this.isValueInBoundary(Number(value), '');
-        }
+        const valueNumber = Number(value);
+        shouldUpdate = this.isValueInBoundary(valueNumber, name);
+        // Adjust update-pending from/to value based on min range
+        const adjustValue = (value) => {
+            const _currentValue = Number(value);
+            if (name === SliderDataName.from && _currentValue === this.toNumber) {
+                return String(_currentValue - this.minRangeNumber);
+            }
+            if (name === SliderDataName.to && _currentValue === this.fromNumber) {
+                return String(_currentValue + this.minRangeNumber);
+            }
+            return value;
+        };
         if (shouldUpdate) {
-            this[name] = value;
-            this.notifyPropertyChange(name, value);
-        }
-        else {
-            const inputName = `${name}Input`;
-            this[inputName].value = this[name];
+            this[name] = adjustValue(this.format(valueNumber));
+            this.notifyPropertyChange(name, this[name]);
         }
+        // Sync number field value with its component property counterpart.
+        // It's crucial especially when the value has been adjusted above.
+        const inputName = `${name}Input`;
+        this[inputName].value = this[name];
     }
     /**
      * Dispatch data {value, from, to} changed event
@@ -1091,7 +1098,18 @@ let Slider = class Slider extends FormFieldElement {
      * @returns {void}
      */
     onFromValueChange() {
-        if (this.isValueInBoundary(this.fromNumber, SliderDataName.from)) {
+        /**
+         * This method handles "from" value change triggered by
+         * both user interaction and programmatic update.
+         *
+         * In case of user interaction update,
+         * the value would be adjusted by min range before entering this method.
+         * That adjustment needs to be reverted.
+         *
+         * In case of programmatic value update,
+         * This method could handle the revert although there is no prior adjustment.
+         */
+        if (this.isValueInBoundary(this.fromNumber + this.minRangeNumber, SliderDataName.from)) {
             this.from = this.format(this.fromNumber);
         }
         else {
@@ -1128,10 +1146,11 @@ let Slider = class Slider extends FormFieldElement {
             return false;
         }
         if (this.range) {
-            if (valueFor === SliderDataName.to && value < this.fromNumber + this.minRangeNumber) {
-                return false;
-            }
-            else if (valueFor === SliderDataName.from && value > this.toNumber - this.minRangeNumber) {
+            const isFromOutOfBound = valueFor === SliderDataName.from &&
+                (value > this.toNumber || (this.minRangeNumber > 0 && value >= this.toNumber));
+            const isToOutOfBound = valueFor === SliderDataName.to &&
+                (value < this.fromNumber || (this.minRangeNumber > 0 && value <= this.fromNumber));
+            if (isFromOutOfBound || isToOutOfBound) {
                 return false;
             }
         }
@@ -1142,7 +1161,18 @@ let Slider = class Slider extends FormFieldElement {
      * @returns {void}
      */
     onToValueChange() {
-        if (this.isValueInBoundary(this.toNumber, SliderDataName.to)) {
+        /**
+         * This method handles "to" value change triggered by
+         * both user interaction and programmatic update.
+         *
+         * In case of user interaction update,
+         * the value would be adjusted by min range before entering this method.
+         * That adjustment needs to be reverted.
+         *
+         * In case of programmatic value update,
+         * This method could handle the revert although there is no prior adjustment.
+         */
+        if (this.isValueInBoundary(this.toNumber - this.minRangeNumber, SliderDataName.to)) {
             this.to = this.format(this.toNumber);
         }
         else {

package/lib/tree-select/index.d.ts

@@ -116,6 +116,12 @@ export declare class TreeSelect extends ComboBox<TreeSelectDataItem> {
      */
     get values(): string[];
     set values(values: string[]);
+    /**
+     * Update composer values.
+     * @param newValues new values
+     * @returns {void}
+     */
+    protected updateComposerValues(newValues: string[]): void;
     /**
      * Renderer used to render tree item elements
      */

package/lib/tree-select/index.js

@@ -199,6 +199,28 @@ let TreeSelect = class TreeSelect extends ComboBox {
             this.requestUpdate('values', oldValues);
         }
     }
+    /**
+     * Update composer values.
+     * @param newValues new values
+     * @returns {void}
+     */
+    updateComposerValues(newValues) {
+        for (const item of this.treeManager.checkedItems) {
+            this.treeManager.uncheckItem(item);
+        }
+        const selectedItems = this.queryItems((item, composer) => {
+            return newValues.includes(composer.getItemPropertyValue(item, 'value') ?? '');
+        });
+        const sortedSelectedItem = [];
+        for (const item of selectedItems) {
+            const value = this.composer.getItemPropertyValue(item, 'value') ?? '';
+            const index = newValues.indexOf(value);
+            sortedSelectedItem[index] = item;
+        }
+        for (const item of sortedSelectedItem) {
+            this.treeManager.checkItem(item);
+        }
+    }
     /**
      * Set maximum number of selected items
      * @param value max value

package/lib/version.js

@@ -1 +1 @@
-export const VERSION = '7.13.2';
+export const VERSION = '7.13.4';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@refinitiv-ui/elements",
-  "version": "7.13.2",
+  "version": "7.13.4",
   "description": "Element Framework Elements",
   "author": "LSEG",
   "license": "Apache-2.0",
@@ -353,25 +353,25 @@
     "tslib": "^2.3.1"
   },
   "devDependencies": {
-    "@refinitiv-ui/core": "^7.5.0",
-    "@refinitiv-ui/demo-block": "^7.1.14",
-    "@refinitiv-ui/i18n": "^7.1.4",
+    "@refinitiv-ui/core": "^7.5.1",
+    "@refinitiv-ui/demo-block": "^7.1.15",
+    "@refinitiv-ui/i18n": "^7.1.5",
     "@refinitiv-ui/phrasebook": "^7.1.1",
-    "@refinitiv-ui/test-helpers": "^7.1.1",
-    "@refinitiv-ui/translate": "^7.1.8",
+    "@refinitiv-ui/test-helpers": "^7.1.2",
+    "@refinitiv-ui/translate": "^7.1.9",
     "@refinitiv-ui/utils": "^7.3.0",
     "@types/d3-interpolate": "^3.0.1"
   },
   "peerDependencies": {
     "@refinitiv-ui/browser-sparkline": "^1.0.0 || ^2.0.0",
-    "@refinitiv-ui/core": "^7.5.0",
-    "@refinitiv-ui/i18n": "^7.1.4",
+    "@refinitiv-ui/core": "^7.5.1",
+    "@refinitiv-ui/i18n": "^7.1.5",
     "@refinitiv-ui/phrasebook": "^7.1.1",
-    "@refinitiv-ui/translate": "^7.1.8",
+    "@refinitiv-ui/translate": "^7.1.9",
     "@refinitiv-ui/utils": "^7.3.0"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "73f95529865ca81cce75efbe496d7e4b37e5d67a"
+  "gitHead": "8055e563e6634f16068e6752a63cf6237e2e47e6"
 }