@refinitiv-ui/efx-grid 6.0.68 → 6.0.70

package/lib/tr-grid-row-filtering/es6/RowFiltering.js

@@ -61,7 +61,7 @@ The expression can take various forms:<br>
 */
 
 /** @typedef {Object} RowFilteringPlugin~FilterExpression
-* @description FilterExpression contains all data used for saving and restoring filter in a column
+* @description Deprecated. FilterExpression contains all data used for saving and restoring filter in a column
 * @property {string} field
 * @property {RowFilteringPlugin~Expression} expression Expression representing filter function
 * @property {*} context Context object contains context/states given by user
@@ -307,6 +307,8 @@ RowFilteringPlugin.prototype.unload = function (host) {
   host.unlisten("columnRemoved", this._onColumnRemoved);
 
   if (!this._hosts.length) {
+    this._hasPendingFilter = false;
+
     if (this._filterDialog) {
       this._filterDialog.hide(); // Remove the dialog from document
 
@@ -335,6 +337,34 @@ RowFilteringPlugin.prototype._afterInit = function () {
       setTimeout(this._onPreLoadedDialog, 10);
     }
   }
+
+  this._applyPendingFilter();
+};
+/** @private
+*/
+
+
+RowFilteringPlugin.prototype._applyPendingFilter = function () {
+  if (!this._initializedGrid) {
+    return;
+  }
+
+  if (!this._hasPendingFilter) {
+    return;
+  }
+
+  this._hasPendingFilter = false;
+  var colCount = this.getColumnCount();
+
+  for (var c = 0; c < colCount; ++c) {
+    var colSettings = this._getUserColumnSettings(c);
+
+    if (colSettings.expression) {
+      this.addColumnFilter(c, colSettings.expression, colSettings.filterState);
+    } else {
+      this._removeColumnFilters(c);
+    }
+  }
 };
 /** @private
 */
@@ -424,6 +454,8 @@ RowFilteringPlugin.prototype.config = function (options) {
 
     this._setColumnOptions(i, column);
   }
+
+  this._applyPendingFilter();
 };
 /** @public
 * @param {Object=} gridOptions
@@ -448,22 +480,20 @@ RowFilteringPlugin.prototype.getConfigObject = function (gridOptions) {
       column = columns[i] = {};
     }
 
-    var cfo = this._getColumnFilterOption(i);
+    var colSettings = this._getUserColumnSettings(i);
 
-    if (cfo) {
-      var exp = cfo._expressions[0];
+    var exp = colSettings.expression;
 
-      if (exp && typeof exp !== "function") {
-        // TODO: Accept function type
-        column.filter = exp; // This could be string, array, or object
-      }
+    if (exp && typeof exp !== "function") {
+      // TODO: Accept function type
+      column.filter = exp; // This could be string, array, or object
+    }
 
-      var ctx = cfo._context[0];
+    var ctx = colSettings.filterState;
 
-      if (ctx != null) {
-        if (_typeof(ctx) !== "object" || !ctx._autoGenerated) {
-          column.filterState = ctx;
-        }
+    if (ctx != null) {
+      if (_typeof(ctx) !== "object" || !ctx._autoGenerated) {
+        column.filterState = ctx;
       }
     }
   }
@@ -655,7 +685,10 @@ RowFilteringPlugin.prototype.addColumnFilter = function (colIndex, exp, ctx) {
     func =
     /** @type{Function} */
     exp;
-    exp = ctx && typeof ctx === "string" ? ctx : null; // for saving. TODO: Support saving for function type
+
+    if (ctx && typeof ctx === "string") {
+      exp = ctx;
+    }
   } else {
     func = this._parseFilter(exp, colIndex, ctx);
   }
@@ -664,6 +697,16 @@ RowFilteringPlugin.prototype.addColumnFilter = function (colIndex, exp, ctx) {
     return false;
   }
 
+  if (colIndex < 0 || colIndex >= this.getColumnCount()) {
+    return false;
+  }
+
+  var colSettings = this._getUserColumnSettings(colIndex);
+
+  colSettings.expression = exp; // WARNING: Only the last expression are saved (previous one is overwritten)
+
+  colSettings.filterState = ctx;
+
   if (ctx == null) {
     ctx = {
       "_autoGenerated": true
@@ -712,10 +755,28 @@ RowFilteringPlugin.prototype.addColumnFilter = function (colIndex, exp, ctx) {
 * @param {(Object|string)=} ctx Context object that will be passed as the third parameter for the filter logic
 * @return {boolean} True If there is any change
 * @fires RowFilteringPlugin#filterChanged
+* @example
+* extension.setColumnFilter(colIndex1,
+*  [["GT", 0]]
+* );
+* extension.setColumnFilter(colIndex2,
+*   "filter": "[PCTCHNG] > 0"
+* );
+* extension.setColumnFilter(colIndex3,
+*   function(rowData) {
+*     return rowData["PCTCHNG"] > 0;
+*   }
+* );
 */
 
 
 RowFilteringPlugin.prototype.setColumnFilter = function (colIndex, exp, ctx) {
+  var curExp = this._getColumnExpression(colIndex);
+
+  if (curExp === exp) {
+    return false;
+  }
+
   var removed = this._removeColumnFilters(colIndex);
 
   var added = this.addColumnFilter(colIndex, exp, ctx);
@@ -726,71 +787,88 @@ RowFilteringPlugin.prototype.setColumnFilter = function (colIndex, exp, ctx) {
 
   return removed || added;
 };
+/** @private
+ * @param {number} colIndex
+ * @return {RowFilteringPlugin~Expression}
+ */
+
+
+RowFilteringPlugin.prototype._getColumnExpression = function (colIndex) {
+  var colSettings = this._getUserColumnSettings(colIndex);
+
+  return colSettings.expression || null;
+};
 /** Set data to colData["rowFiltering"]
 * @private
 * @param {number} colIndex
-* @param {RowFilteringPlugin~ColumnOptions} columnOptions
+* @param {RowFilteringPlugin~ColumnOptions} userObj
 * @example
-* var colDef = {
-*   "filter": "gt♦0♣"
+* var colDef1 = {
+*   "field": "PCTCHNG",
+*   "filter": [["GT", 0]]
 * };
 * var colDef2 = {
 *   "filter": "[PCTCHNG] > 0"
 * };
 * var colDef3 = {
-*   "filter": function() { }
+*   "filter": function(rowData) {
+*     return rowData["PCTCHNG"] > 0;
+*   }
 * };
 */
 
 
-RowFilteringPlugin.prototype._setColumnOptions = function (colIndex, columnOptions) {
-  var colOptions = this._newExtColumnOptions(colIndex);
+RowFilteringPlugin.prototype._setColumnOptions = function (colIndex, userObj) {
+  var colSettings = this._getUserColumnSettings(colIndex);
 
-  var filterIcon = columnOptions["filterIcon"];
-  var fieldDataType = columnOptions["fieldDataType"] || columnOptions["dataType"]; // TODO: This should not be set here, should retreive data type from Composite/Realtime Grid
+  var filterIcon = userObj["filterIcon"]; // TODO: This should not be set here, should retreive data type from Composite/Realtime Grid
+
+  var fieldDataType = userObj["fieldDataType"] || userObj["dataType"];
 
   if (fieldDataType) {
-    colOptions.fieldDataType = fieldDataType; // TODO: This should not be set here, should retreive data type from Composite/Realtime Grid
+    colSettings.fieldDataType = fieldDataType; // TODO: This should not be set here, should retreive data type from Composite/Realtime Grid
   }
 
   if (filterIcon != null) {
-    colOptions.filterIcon = filterIcon;
+    colSettings.filterIcon = filterIcon;
   }
 
-  var iconActivation = filterIcon == false ? "none" : this._iconActivation;
-  var exp = columnOptions["filter"];
+  var exp = userObj["filter"];
 
-  if (exp) {
-    this.addColumnFilter(colIndex, exp, columnOptions["filterState"]);
-  } else if (iconActivation == "always" || iconActivation == "onHover") {
-    this._updateColumnIcon(colIndex);
+  if (exp != null) {
+    colSettings.expression = exp;
+    colSettings.filterState = null;
+    this._hasPendingFilter = true;
   }
-};
-/** @private
- * @param {number} colIndex
- * @return {Object} colData["rowFiltering"]
- */
 
+  var filterState = userObj["filterState"];
+
+  if (filterState != null) {
+    colSettings.filterState = filterState;
+  }
+
+  var iconActivation = filterIcon == false ? "none" : this._iconActivation;
 
-RowFilteringPlugin.prototype._getExtColumnOptions = function (colIndex) {
-  return this._getColumnOption(colIndex, "rowFiltering");
+  if (iconActivation == "always" || iconActivation == "onHover") {
+    this._updateColumnIcon(colIndex);
+  }
 };
 /** @private
  * @param {number} colIndex
- * @return {!Object} Newly created extension column option or the existing one
+ * @return {!Object} colData["rowFiltering"]
  */
 
 
-RowFilteringPlugin.prototype._newExtColumnOptions = function (colIndex) {
-  var colDef = this._newColumnData(colIndex);
+RowFilteringPlugin.prototype._getUserColumnSettings = function (colIndex) {
+  var colData = this._newColumnData(colIndex);
 
-  var colExtOptions = colDef["rowFiltering"];
+  var colSettings = colData["rowFiltering"];
 
-  if (!colExtOptions) {
-    colExtOptions = colDef["rowFiltering"] = {};
+  if (!colSettings) {
+    colSettings = colData["rowFiltering"] = {};
   }
 
-  return colExtOptions;
+  return colSettings;
 };
 /** @private
 * @param {number} colIndex
@@ -799,40 +877,37 @@ RowFilteringPlugin.prototype._newExtColumnOptions = function (colIndex) {
 
 
 RowFilteringPlugin.prototype._getColumnFilterOption = function (colIndex) {
-  var colOptions = this._getExtColumnOptions(colIndex);
+  var colSettings = this._getUserColumnSettings(colIndex);
 
-  if (colOptions) {
-    return colOptions["filterOption"] || null;
+  if (colSettings) {
+    return colSettings["filterOption"] || null;
   } else {
     return null;
   }
 };
-/** Set data to colData["rowFiltering"]["filterOption"]
+/** Remove colData["rowFiltering"]["filterOption"]
 * @private
 * @param {number} colIndex
-* @param {Object} filterOption
 */
 
 
-RowFilteringPlugin.prototype._setColumnFilterOption = function (colIndex, filterOption) {
-  var colOptions = this._newExtColumnOptions(colIndex);
-
-  if (filterOption) {
-    colOptions["filterOption"] = filterOption;
-  } else {
-    var cfo = colOptions["filterOption"];
+RowFilteringPlugin.prototype._removeActiveFilterStates = function (colIndex) {
+  var colSettings = this._getUserColumnSettings(colIndex);
 
-    if (cfo) {
-      colOptions["filterOption"] = null;
+  colSettings.expression = null;
+  colSettings.filterState = null;
+  var cfo = colSettings["filterOption"];
 
-      if (cfo._filters.length) {
-        this._dispatch("filterChanged", {
-          "filterType": "column",
-          "changeType": "remove",
-          "colIndex": colIndex,
-          "field": this._getField(colIndex)
-        });
-      }
+  if (cfo) {
+    colSettings["filterOption"] = null;
+
+    if (cfo._filters.length) {
+      this._dispatch("filterChanged", {
+        "filterType": "column",
+        "changeType": "remove",
+        "colIndex": colIndex,
+        "field": this._getField(colIndex)
+      });
     }
   }
 };
@@ -851,7 +926,9 @@ RowFilteringPlugin.prototype._initColumnFilterOption = function (colIndex) {
     cfo._expressions = [];
     cfo._context = [];
 
-    this._setColumnFilterOption(colIndex, cfo);
+    var colSettings = this._getUserColumnSettings(colIndex);
+
+    colSettings["filterOption"] = cfo;
   }
 
   return cfo;
@@ -907,6 +984,7 @@ RowFilteringPlugin.prototype.removeFilter = function (funcRef) {
 * @public
 * @param {number} colIndex
 * @return {boolean} True if there is any change
+* @fires RowFilteringPlugin#filterChanged
 */
 
 
@@ -927,6 +1005,7 @@ RowFilteringPlugin.prototype.removeColumnFilters = function (colIndex) {
 /** @private
 * @param {number} colIndex
 * @return {boolean} True if there is any change
+* @fires RowFilteringPlugin#filterChanged
 */
 
 
@@ -940,7 +1019,7 @@ RowFilteringPlugin.prototype._removeColumnFilters = function (colIndex) {
       this._columnFilters.splice(funcIndex, 1);
     }
 
-    this._setColumnFilterOption(colIndex, null); // filterChanged fired
+    this._removeActiveFilterStates(colIndex); // filterChanged fired
 
 
     var inputExt = this._getPlugin("FilterInputPlugin"); // TODO: Use the event instead
@@ -958,6 +1037,7 @@ RowFilteringPlugin.prototype._removeColumnFilters = function (colIndex) {
 * @function
 * @param {number} colIndex
 * @return {boolean} True if there is any change
+* @fires RowFilteringPlugin#filterChanged
 */
 
 
@@ -965,6 +1045,7 @@ RowFilteringPlugin.prototype.removeColumnFilter = RowFilteringPlugin.prototype.r
 /** Remove all column filters from all columns, excluding global filters
 * @public
 * @return {boolean} Return true if there is any change
+* @fires RowFilteringPlugin#filterChanged
 */
 
 RowFilteringPlugin.prototype.removeAllColumnFilters = function () {
@@ -976,7 +1057,7 @@ RowFilteringPlugin.prototype.removeAllColumnFilters = function () {
     var colCount = this._getColumnCount();
 
     for (var i = 0; i < colCount; ++i) {
-      this._setColumnFilterOption(i, null); // filterChanged fired
+      this._removeActiveFilterStates(i); // filterChanged fired
 
 
       inputExt && inputExt.updateUI(i, ""); // TODO: Use the event instead
@@ -1054,10 +1135,10 @@ RowFilteringPlugin.prototype.setRowTransform = function (func) {
 RowFilteringPlugin.prototype.getFilters = function () {
   return this._globalFilters;
 };
-/** Return filter functions. Use getFilterExpressions for saving and loading instead of this function
+/** Returns filter functions. Use getConfigObject for saving and loading instead of this function
 * @public
 * @return {!Array.<Function>} All column filters
-* @see {@link RowFilteringPlugin.getFilterExpressions}
+* @see {@link RowFilteringPlugin.getConfigObject}
 */
 
 
@@ -1076,21 +1157,22 @@ RowFilteringPlugin.prototype.getAllColumnFilters = function () {
 
   return filters;
 };
-/** Get existing filter expressions for saving and restoring.
+/** Deprecated in favor of getConfigObject(). Get existing filter expressions for saving and restoring.
 * @public
 * @return {Array.<RowFilteringPlugin~FilterExpression>} Return null if there is no column filter
-* @see {@link RowFilteringPlugin.setFilterExpressions}
+* @see {@link RowFilteringPlugin.getConfigObject}
 */
 
 
 RowFilteringPlugin.prototype.getFilterExpressions = function () {
   if (this._columnFilters.length) {
+    // TODO: Provide a way to save rawDataAccessor and formattedDataAccessor
     return this._columnFilters.map(toFilterExpression);
   }
 
   return null;
 };
-/** Clear all existing column filters and restore column filters from the given valid filter expressions. If the parameter is null, the result is equivalent to calling removeAllColumnFilters();
+/** Deprecated. Clear all existing column filters and restore column filters from the given valid filter expressions. If the parameter is null, the result is equivalent to calling removeAllColumnFilters();
 * @public
 * @param {Array.<RowFilteringPlugin~FilterExpression>} filterExps
 */
@@ -1110,7 +1192,7 @@ RowFilteringPlugin.prototype.setFilterExpressions = function (filterExps) {
       var colIndex = fields.indexOf(field);
 
       if (colIndex >= 0) {
-        this.addColumnFilter(colIndex, filterExp.expression, filterExp.context);
+        this.setColumnFilter(colIndex, filterExp.expression, filterExp.context);
       }
     }
   }
@@ -1349,11 +1431,13 @@ RowFilteringPlugin.prototype.refresh = function () {
 
 
 RowFilteringPlugin.prototype._updateColumnIcon = function (colIndex) {
-  var cfo = this._getColumnFilterOption(colIndex);
+  var cfo = this._getColumnFilterOption(colIndex); // colData["rowFiltering"]["filterOption"]
 
-  var co = this._getExtColumnOptions(colIndex);
 
-  var iconActivation = co.filterIcon == false ? "none" : this._iconActivation;
+  var colSettings = this._getUserColumnSettings(colIndex); // colData["rowFiltering"]
+
+
+  var iconActivation = colSettings.filterIcon == false ? "none" : this._iconActivation;
   var hasFilter = cfo ? cfo._filters.length : 0;
 
   for (var i = this._hosts.length; --i >= 0;) {
@@ -1492,10 +1576,10 @@ RowFilteringPlugin.prototype.getColumnFilterState = function (colIndex) {
 
   return null;
 };
-/** Get the stored user context from all columns. The column with no filter will return null value
+/** Deprecated in favor of getConfigObject(). Get the stored user context from all columns. The column with no filter will return null value
 * @public
 * @return {!Array} Array of context objects
-* @see {@link RowFilteringPlugin.getFilterExpressions}
+* @see {@link RowFilteringPlugin.getConfigObject}
 */
 
 
@@ -1554,11 +1638,13 @@ RowFilteringPlugin.prototype._getDataTable = function (dv) {
 * @param {string=} fmtField A field name to be used instead of formatter for getting formatted value
 * @param {Function=} rawDataAccessor Data getter to retrieve raw value
 * @param {Function=} formattedDataAccessor Data getter to retrieve formatted value. This paramter will override formatted and fmtField parameters
+* @param {Function=} filterFuncs
+* @param {Object=} selectedItems
 * @return {Object} Object that maps formatted value to array of raw values
 */
 
 
-RowFilteringPlugin.prototype.getUniqueValues = function (field, formatter, fmtField, rawDataAccessor, formattedDataAccessor) {
+RowFilteringPlugin.prototype.getUniqueValues = function (field, formatter, fmtField, rawDataAccessor, formattedDataAccessor, filterFuncs, selectedItems) {
   if (!field) {
     return null;
   }
@@ -1629,6 +1715,12 @@ RowFilteringPlugin.prototype.getUniqueValues = function (field, formatter, fmtFi
         continue;
       }
 
+      if (filterFuncs) {
+        if (!selectedItems[formattedVal]) {
+          selectedItems[formattedVal] = RowFilteringPlugin._getFilteredValue(row, filterFuncs);
+        }
+      }
+
       var rawValues = uniqueValues[formattedVal];
 
       if (rawValues) {
@@ -1668,6 +1760,23 @@ RowFilteringPlugin._createDialog = function () {
 
   return tag ? document.createElement(tag) : null;
 };
+/** @private
+* @function
+* @param {Object} rowData
+* @param {!Array.<Function>} filters
+* @returns {boolean}
+*/
+
+
+RowFilteringPlugin._getFilteredValue = function (rowData, filters) {
+  for (var i = filters.length; --i >= 0;) {
+    if (!filters[i](rowData)) {
+      return false;
+    }
+  }
+
+  return true;
+};
 /** @public
 * @param {number} colIndex
 * @param {RowFilteringPlugin~FilterDialogOptions=} runtimeDialogOptions
@@ -1767,13 +1876,6 @@ RowFilteringPlugin.prototype.openDialog = function (colIndex, runtimeDialogOptio
     this._filterDialog.setSortState(stp.getSortOrder(colIndex)); // This is for ELF v3
 
   } // Setting up dialog configuration
-  // cfo is required for storing unique entries in the dialog, even though no filter is active
-
-
-  var cfo = this._initColumnFilterOption(colIndex); // colData["rowFiltering"]["filterOption"]
-
-
-  var colOptions = this._getExtColumnOptions(colIndex); // colData["rowFiltering"]
 
 
   var colData = host.getColumnData(colIndex);
@@ -1802,36 +1904,53 @@ RowFilteringPlugin.prototype.openDialog = function (colIndex, runtimeDialogOptio
   };
   var columnDialogOptions = null;
 
-  if (colOptions) {
-    if (colOptions.fieldDataType) {
-      // TODO: Use data type from Composite Grid (getColumnDataType) or Realtime Grid (getDataType) instead
-      columnDialogOptions = {
-        fieldDataType: colOptions.fieldDataType
-      };
-    }
+  var colSettings = this._getUserColumnSettings(colIndex); // colData["rowFiltering"]
+
+
+  if (colSettings.fieldDataType) {
+    // TODO: Use data type from Composite Grid (getColumnDataType) or Realtime Grid (getDataType) instead
+    columnDialogOptions = {
+      fieldDataType: colSettings.fieldDataType
+    };
   }
 
   RowFilteringPlugin._overrideConfig(dialogConfig, this._dialogOptions);
 
   RowFilteringPlugin._overrideConfig(dialogConfig, columnDialogOptions);
 
-  RowFilteringPlugin._overrideConfig(dialogConfig, runtimeDialogOptions);
+  RowFilteringPlugin._overrideConfig(dialogConfig, runtimeDialogOptions); // cfo is required for storing unique entries in the dialog, even though no filter is active
+  // TODO: move rawDataAccessor and other settings to colSettings
+
+
+  var cfo = this._initColumnFilterOption(colIndex); // colData["rowFiltering"]["filterOption"]
+
 
   var rawDataAccessor = cfo._rawDataAccessor = dialogConfig.rawDataAccessor || null;
   var formattedDataAccessor = cfo._formattedDataAccessor = dialogConfig.formattedDataAccessor || null;
   var sortLogic = dialogConfig.sortLogic || null; // Populate data for filter dialog based on existing states
 
-  var customFilter = cfo._expressions[0] || "";
-  var ctx = cfo._context[0];
-  var selectedItems = ctx ? ctx.selectedItems : null;
+  var condition2D = null;
+  var filterMode = ""; // default
 
-  if (selectedItems) {
-    customFilter = "";
-  } else {
-    selectedItems = {};
+  var filterFuncs = null;
+  var exp = colSettings.expression;
+
+  if (exp) {
+    if (Array.isArray(exp)) {
+      if (exp.length) {
+        condition2D = Array.isArray(exp[0]) ? exp : [exp]; // Guaranteed condition2D to be a 2D array
+
+        filterMode = "advanced";
+      }
+    } else if (typeof exp === "function" || typeof exp === "string" || _typeof(exp) === "object") {
+      if (cfo._filters && cfo._filters.length) {
+        filterFuncs = cfo._filters;
+      }
+    }
   }
 
-  var uniqueValues = cfo.uniqueValues = this.getUniqueValues(field, this._getFormatter(colIndex), "", rawDataAccessor, formattedDataAccessor);
+  var selectedItems = {};
+  var uniqueValues = cfo.uniqueValues = this.getUniqueValues(field, this._getFormatter(colIndex), "", rawDataAccessor, formattedDataAccessor, filterFuncs, selectedItems);
   var keys = Object.keys(uniqueValues);
 
   if (sortLogic) {
@@ -1862,8 +1981,8 @@ RowFilteringPlugin.prototype.openDialog = function (colIndex, runtimeDialogOptio
   this._filterDialog._colIndex = colIndex;
   this._filterDialog.data = items; // TODO: Move all settings to configuration object
 
-  this._filterDialog.filterMode = customFilter ? "advanced" : "";
-  this._filterDialog.conditions = customFilter; // WARNING: This must be 2D Array
+  this._filterDialog.filterMode = filterMode;
+  this._filterDialog.conditions = condition2D;
 
   this._filterDialog.show();
 };
@@ -2059,14 +2178,6 @@ RowFilteringPlugin.prototype._onDialogFilterChanged = function (e) {
   }
 
   if (atLeastOne) {
-    if (!ctx) {
-      ctx = {};
-    }
-
-    if (ctx) {
-      ctx["selectedItems"] = selectedItems; // For restore item in the dialog
-    }
-
     this.addColumnFilter(colIndex, itemMap, ctx);
   }
 

package/lib/tr-grid-row-selection/es6/RowSelection.js

@@ -633,16 +633,21 @@ RowSelectionPlugin.prototype._onClick = function (e) {
 * @param {Object=} mouseEvt
 */
 RowSelectionPlugin.prototype.selectByMouse = function (rowIndex, mouseEvt) {
-	if(!mouseEvt) {
-		mouseEvt = {};
-	}
-	if(rowIndex >= 0) {
-		var grid = this._activeGrid || this._hosts[0];
-		var cell = grid ? grid.getCell("content", 0, rowIndex) : null;
-		mouseEvt.target = cell ? cell.getElement() : null;
-	}
-	this._onMouseDown(mouseEvt);
+	var eventObj = this._mockMouseEvent(0, rowIndex, mouseEvt);
+	this._onMouseDown(eventObj);
+};
+
+/** @public
+* @description Select a specified row as if it were modified by a keyboard input. This is for testing purpose.
+* @ignore
+* @param {number|string} keyCode Use key code number or "up", "down" string
+* @param {Object=} keyboardEvt
+*/
+RowSelectionPlugin.prototype.selectByKey = function (keyCode, keyboardEvt) {
+	var eventObj = this._mockKeyboardEvent(keyCode, keyboardEvt);
+	this._onKeyDown(eventObj);
 };
+
 /** @private
 * @description Left click will cause single row selection <br>
 * Shift + left click will cause range selection <br>
@@ -783,29 +788,6 @@ RowSelectionPlugin.prototype._clearPendingClickIndex = function (host) {
 	host && host.unlisten("mousemove", this._onMouseMove);
 };
 
-/** @public
-* @description Select a specified row as if it were modified by a keyboard input. This is for testing purpose.
-* @ignore
-* @param {number} keyCode Use -1 for arrow up. Use 1 for arrow down
-* @param {Object=} keyboardEvt
-*/
-RowSelectionPlugin.prototype.selectByKey = function (keyCode, keyboardEvt) {
-	if(!keyboardEvt) {
-		keyboardEvt = {};
-	}
-	if(keyCode) {
-		if(keyCode === 1) {
-			keyboardEvt.keyCode = 40;
-		} else if(keyCode === -1) {
-			keyboardEvt.keyCode = 38;
-		} else if(typeof keyCode === "number"){
-			keyboardEvt.keyCode = keyCode;
-		}
-	}
-	keyboardEvt.preventDefault = function(){};
-	keyboardEvt.stopPropagation = function(){};
-	this._onKeyDown(keyboardEvt);
-};
 /** @private
 * @param {KeyboardEvent} e
 */