@refinitiv-ui/efx-grid 6.0.140 → 6.0.142

package/lib/rt-grid/es6/Grid.js

@@ -617,6 +617,10 @@ Grid.prototype._topSection = true;
 * @private
 */
 Grid.prototype._focusingArgs = null;
+/** @type {boolean}
+* @private
+*/
+Grid.prototype._hasNewUpdates = false;
 
 /** @public
 */
@@ -2381,8 +2385,12 @@ Grid.prototype.insertRow = function(rowOption, rowRef) {
 		}
 	}
 	let rowDef = new RowDefinition(rowOption);
+
+	if(rowDef.setDataSource(this._dc, this._subs)) { // This could also subscribe chain index/ric to JET/RTK
+		this._hasNewUpdates = true; // Mark data table for cleaning it up later
+	}
 	rowDef.registerToView(this._dv, this._getRowId(rowRef));
-	rowDef.setDataSource(this._dc, this._subs); // This could also subscribe chain index/ric to JET/RTK
+
 	this._initDuplicateRicData(rowDef);
 
 	if(rowOption && rowOption["hidden"]) {
@@ -3763,11 +3771,21 @@ Grid.prototype._registerConstituents = function(rowDef) {
 * @param {Object} e
 */
 Grid.prototype._onDataChanged = function(e) {
-	if(this._dt && e && e["rid"] && e["changes"]) {
-		let rowDef = this._getRowDefinitionById(e["rid"]);
-		if(rowDef) {
-			if(rowDef.addUpdate(e["changes"])) { // This is the only place that update array can grow. It is used for blinking data.
-				this._dt._hasNewUpdates = true; // Mark data table for cleaning it up later
+	if(!this._dt) {
+		return;
+	}
+	if(e) {
+		if(e["initialChanges"] && !this._dt.hasSegmentClassification()) {
+			return;
+		}
+
+		// TODO: Insertion should also be addressed here.
+		if(e["rid"] && e["changes"]) {
+			let rowDef = this._getRowDefinitionById(e["rid"]);
+			if(rowDef) {
+				if(rowDef.addUpdate(e["changes"])) { // This is the only place that update array can grow. It is used for blinking data.
+					this._hasNewUpdates = true; // Mark data table for cleaning it up later
+				}
 			}
 		}
 	}
@@ -3776,10 +3794,8 @@ Grid.prototype._onDataChanged = function(e) {
 		return;
 	}
 
-	if(this._dt) {
-		this._dt.classifySegments();
-		this._dt.dispatchGlobalChange();
-	}
+	this._dt.classifySegments();
+	this._dt.dispatchGlobalChange();
 };
 
 /** @private
@@ -3841,9 +3857,10 @@ Grid.prototype._asyncClearDataUpdates = function() {
 /** @private
 */
 Grid.prototype._clearDataUpdates = function() {
-	if(!this._dt || !this._dt._hasNewUpdates) {
+	if(!this._dt || !this._hasNewUpdates) {
 		return;
 	}
+	this._hasNewUpdates = false;
 	let rowIds = this._dt.getAllRowIds(true); // Use shallow copy for speed
 	for(let i = rowIds.length; --i >= 0;) {
 		let rowData = this._dt.getRowData(rowIds[i]);
@@ -4001,7 +4018,11 @@ Grid.prototype._onFormulaDataRequired = function(e) {
 Grid.prototype._onDataComposed = function(e) {
 	let values = e["changes"];
 	if(!values) {
-		return; // Cannot do data composition if there is no change in data
+		if(e["initialChanges"]) {
+			values = e["changes"] = e["initialChanges"]; // Need to keep e["changes"] for backward compatibility.
+		} else {
+			return; // Cannot do data composition if there is no change in data
+		}
 	}
 
 	if(!e["rowData"]) {
@@ -4009,7 +4030,7 @@ Grid.prototype._onDataComposed = function(e) {
 	}
 
 	let rowId = e["rid"];
-	let rowDef = this._getRowDefinitionById(rowId);
+	let rowDef = e["rowDef"] || this._getRowDefinitionById(rowId);
 	if(!rowDef) {
 		rowDef = this._constituentMap ? this._constituentMap[rowId] : null; // Row def could be in pending for adding to view
 		if(!rowDef) {
@@ -4079,8 +4100,10 @@ Grid.prototype._onSubSegmentChanged = function(e) {
 		rowDef = new RowDefinition({
 			"segmentId": segmentId // WARNING: This could cause row id duplication
 		});
+		if(rowDef.setDataSource(this._dc)) { // auto generated row does not require a subscription
+			this._hasNewUpdates = true; // Mark data table for cleaning it up later
+		}
 		rowDef.registerToView(this._dv);
-		rowDef.setDataSource(this._dc); // auto generated row does not require a subscription
 	}
 };
 

package/lib/rt-grid/es6/RowDefinition.d.ts

@@ -48,7 +48,7 @@ declare class RowDefinition {
 
     public getType(): string;
 
-    public setDataSource(dataSource: DataCache|null, subs?: any): void;
+    public setDataSource(dataSource: DataCache|null, subs?: any): boolean;
 
     public getDataSource(): DataCache|null;
 

package/lib/rt-grid/es6/RowDefinition.js

@@ -603,20 +603,28 @@ RowDefinition.prototype.getType = function() {
 * @public
 * @param {DataCache} dataSource
 * @param {Object=} subs Quotes2 subscription object
+* @return {boolean} Returns true if there is an data update
 */
 RowDefinition.prototype.setDataSource = function(dataSource, subs) {
 	this._dc = dataSource || null;
-
+	let dataUpdated = false;
 	if(this._dc) {
-		this.setRowData({}); // Trigger data change
 		if(this._staticValues) {
-			this.setRowData(this._staticValues); // Trigger dataComposed and add updates
+			let rowData = _cloneObject(this._staticValues);
+			dataUpdated = this.addUpdate(rowData);
+			this._dc.setRowData(this._rowId, rowData, {
+				"rowDef": this, // The _onDataChanged and _onDataComposed handlers cannot get rowDef from DT because row does not register to view yet.
+				"initialChanges": this.getUpdates() // Used by _onDataComposed to keep backward compatibility.
+			}); // Trigger dataComposed and add updates
+		} else {
+			this._dc.setRowData(this._rowId, {});
 		}
 	}
 
 	this._subs = subs || null;
 	// This will work for runtime row insertion, but not for first initilization.
 	this.subscribeForUpdates();
+	return dataUpdated;
 };
 /** @public
 * @return {DataCache} dataSource

package/lib/tr-grid-conditional-coloring/es6/ConditionalColoring.d.ts

@@ -1,6 +1,6 @@
 import {Ext} from '../../tr-grid-util/es6/Ext.js';
 import {GridPlugin} from '../../tr-grid-util/es6/GridPlugin.js';
-import {extendObject, injectCss, prettifyCss, isEmptyObject} from '../../tr-grid-util/es6/Util.js';
+import {extendObject, injectCss, prettifyCss} from '../../tr-grid-util/es6/Util.js';
 import {CellPainter} from '../../tr-grid-util/es6/CellPainter.js';
 import {FilterBuilder} from '../../tr-grid-util/es6/FilterBuilder.js';
 import {ElfUtil} from '../../tr-grid-util/es6/ElfUtil.js';

package/lib/tr-grid-conditional-coloring/es6/ConditionalColoring.js

@@ -1,6 +1,6 @@
 import {Ext} from '../../tr-grid-util/es6/Ext.js';
 import {GridPlugin} from '../../tr-grid-util/es6/GridPlugin.js';
-import {extendObject, injectCss, prettifyCss, isEmptyObject} from '../../tr-grid-util/es6/Util.js';
+import {extendObject, injectCss, prettifyCss} from '../../tr-grid-util/es6/Util.js';
 import {CellPainter} from '../../tr-grid-util/es6/CellPainter.js';
 import {FilterBuilder} from '../../tr-grid-util/es6/FilterBuilder.js';
 import {ElfUtil} from '../../tr-grid-util/es6/ElfUtil.js';
@@ -1200,7 +1200,6 @@ ConditionalColoringPlugin.prototype._onSectionBinding = function (e) {
 	}
 
 	let prevDataRow, prevDataRows = host._prevDataRows;
-	let isPrevRowExisted = !isEmptyObject(prevDataRows);
 	let api = this.getGridApi();
 	for (r = fromR; r < toR; ++r) {
 		rid = dv.getRowId(r);
@@ -1260,7 +1259,7 @@ ConditionalColoringPlugin.prototype._onSectionBinding = function (e) {
 								}
 							}
 						} else {
-							if(isPrevRowExisted && insertedRow){
+							if(insertedRow){
 								blinking = true;
 								bgBlinking = painter.flash(cell, this._insertionBlinking, dataRow);
 							}

package/lib/tr-grid-row-filtering/es6/RowFiltering.d.ts

@@ -20,7 +20,8 @@ declare namespace RowFilteringPlugin {
     type ColumnOptions = {
         filter?: RowFilteringPlugin.Expression|null,
         filterState?: any,
-        filterIcon?: boolean|null
+        filterIcon?: boolean|null,
+        filterDialogOptions?: RowFilteringPlugin.FilterDialogOptions|null
     };
 
     type FilterDialogOptions = {

package/lib/tr-grid-row-filtering/es6/RowFiltering.js

@@ -74,6 +74,7 @@ The expression can take various forms:<br>
 * @property {RowFilteringPlugin~Expression=} filter An expression string or Function
 * @property {*=} filterState Context object that will be passed as the third parameter for the filter logic
 * @property {boolean=} filterIcon=true If disabled, filter icon will not be shown. This property only works with "always" mode
+* @property {RowFilteringPlugin~FilterDialogOptions=} filterDialogOptions=null Configuration for Filter Dialog, applying to column.
 */
 
 /** @typedef {Object} RowFilteringPlugin~FilterDialogOptions
@@ -614,6 +615,11 @@ RowFilteringPlugin.prototype.getConfigObject = function (gridOptions) {
 		if(!filterIcon) {
 			column.filterIcon = false;
 		}
+
+		let filterDialogOptions = colSettings.filterDialogOptions;
+		if(filterDialogOptions != null) {
+			column.filterDialogOptions = colSettings.filterDialogOptions;
+		}
 	}
 
 	let extOptions = obj.rowFiltering;
@@ -914,6 +920,11 @@ RowFilteringPlugin.prototype._setColumnOptions = function(colIndex, userObj) {
 		this._updateColumnIcon(colIndex);
 	}
 
+	let filterDialogOptions = userObj["filterDialogOptions"];
+	if(filterDialogOptions != null) {
+		colSettings.filterDialogOptions = filterDialogOptions;
+	}
+
 	return (exp != null);
 };
 /** @private
@@ -1925,11 +1936,15 @@ RowFilteringPlugin.prototype.openDialog = function(colIndex, runtimeDialogOption
 
 	let columnDialogOptions = null;
 	let colSettings = this._getUserColumnSettings(colIndex); // colData["rowFiltering"]
+	if(colSettings.filterDialogOptions) {
+		columnDialogOptions = colSettings.filterDialogOptions;
+	}
 	if(colSettings.fieldDataType){
 		// TODO: Use data type from Composite Grid (getColumnDataType) or Realtime Grid (getDataType) instead
-		columnDialogOptions = {
-			fieldDataType: colSettings.fieldDataType
-		};
+		if(!columnDialogOptions) {
+			columnDialogOptions = {};
+		}
+		columnDialogOptions.fieldDataType = colSettings.fieldDataType;
 	}
 
 	RowFilteringPlugin._overrideConfig(dialogConfig, this._dialogOptions);

package/lib/tr-grid-util/es6/CellPainter.d.ts

@@ -56,12 +56,8 @@ declare class CellPainter {
 
     public resetColoring(): void;
 
-    public resetBlinking(): void;
-
     public clearBlinking(): void;
 
-    public resetHeatMap(): void;
-
     public clearHeatMap(): boolean;
 
     public applyThemeColor(): void;
@@ -122,7 +118,7 @@ declare class CellPainter {
 
     public static getOppositeColor(hexCode: string|(number)[]|null): string;
 
-    public render(cell: any, rowData: any, min: number, max: number, changedCols?: any): void;
+    public render(cell: any, rowData: any, min: number, max: number): void;
 
     public renderHeatMap(cell: any, rowData: any, min: number, max: number): void;
 
@@ -132,8 +128,6 @@ declare class CellPainter {
 
     public flash(cell: any, blinkColor: string|null|null, rowData: any): boolean;
 
-    public _blink(scope: any, elem: Element|null, blinkColor: string, contrastColor: string): boolean;
-
     public blinkCell(cell: any, newValue: number, oldValue: number, rowData: any): boolean;
 
     public verifyBlinking(cell: any, rowData: any): void;

package/lib/tr-grid-util/es6/CellPainter.js

@@ -35,14 +35,25 @@ import { ExpressionParser } from "./ExpressionParser.js";
 * @property {string=} tickDown Color for negative tick icon
 */
 
-/** @constructor */
-
+/** @constructor
+*/
 let CellPainter = function() {
 	this._conditions = [];
 	this._scopes = [];
 
 	CellPainter._painters.push(this); // For later referencing
 };
+/** @private
+* @function
+* @param {Element} elem
+* @param {string=} targetClass
+*/
+let _removeCssClass = function(elem, targetClass) {
+	if (elem._coloringCssClass != null && elem._coloringCssClass !== targetClass) {
+		elem.classList.remove(elem._coloringCssClass);
+		elem._coloringCssClass = null;
+	}
+};
 
 /** Enum for coloring types.
 * @enum {number}
@@ -165,25 +176,7 @@ CellPainter.prototype.dispose = function() {
 /** @public */
 CellPainter.prototype.reset = function() {
 	this._setColoringType(0);
-
-	let len = this._scopes.length;
-	if(len) {
-		for(let i = 0; i < len; ++i) {
-			let scope = this._scopes[i];
-			if(CellPainter._clearBlinkTimer(scope)) {
-				scope._restorer();
-			}
-			let cell = scope["cell"];
-			if(cell) {
-				delete cell["blinking"]; // Delete cell blinking scope
-			}
-
-			scope["cell"] = null;
-		}
-		this._scopes.length = 0;
-	}
-
-	this._blinkCondition = null;
+	this.clearBlinking();
 };
 
 /** @public */
@@ -194,12 +187,6 @@ CellPainter.prototype.resetColoring = function() {
 	this._conditions.length = 0;
 };
 
-/** @public */
-CellPainter.prototype.resetBlinking = function() {
-	this._blinkCondition = null;
-	this._scopes.length = 0;
-};
-
 /** @public */
 CellPainter.prototype.clearBlinking = function() {
 	this._blinkCondition = null;
@@ -220,12 +207,11 @@ CellPainter.prototype.clearBlinking = function() {
 		this._scopes.length = 0;
 	}
 };
-
-/** @public */
-CellPainter.prototype.resetHeatMap = function() {
-	this._conditions.length = 0;
-	this._columnStats = null;
-};
+/** @public
+* @ignore
+* @function
+*/
+CellPainter.prototype.resetBlinking = CellPainter.prototype.clearBlinking;
 
 /** Return true if no one is using this painter
  * @public
@@ -241,6 +227,14 @@ CellPainter.prototype.clearHeatMap = function() {
 		return true;
 	}
 };
+/** @public
+* @ignore
+* @function
+*/
+CellPainter.prototype.resetHeatMap = function() {
+	this._conditions.length = 0;
+	this._columnStats = null;
+};
 
 /** @public */
 CellPainter.prototype.applyThemeColor = function() {
@@ -308,7 +302,7 @@ CellPainter.prototype.setConditions = function(conditions) {
 	this._conditions.length = 0; // TODO: Clear existing cell styles first
 	this._setColoringType(CellPainter.ColoringTypes.CONDITIONAL);
 
-	let len = conditions.length;
+	let len = conditions ? conditions.length : 0;
 	for (let i = 0; i < len; i++) {
 		this._addCondition(conditions[i]);
 	}
@@ -400,6 +394,7 @@ CellPainter.prototype._addColorText = function(expression, field, upClass, downC
 	condition["upClass"] = upClass;
 	condition["downClass"] = downClass;
 	condition["levelClass"] = levelClass;
+	 // TODO: Make this consistent with other type (e.g., heat map and blinking)
 
 	this._addCondition(condition);
 	return condition;
@@ -526,20 +521,14 @@ CellPainter.prototype.renderForPrinting = function(cell, rowData, min, max) {
 	}
 	let styles = this._getStyles(rowData, min, max);
 	let cssClass = styles["cssClass"]; // Can be an empty string
+
+	_removeCssClass(cell, cssClass);
 	if (cssClass != null) { // Predefined colors mode
-		if (elem._coloringCssClass && elem._coloringCssClass !== cssClass) {
-			elem.classList.remove(elem._coloringCssClass);
-			elem._coloringCssClass = null;
-		}
 		if (cssClass) {
-			elem.classList.add(cssClass);
-			elem._coloringCssClass = cssClass;
+			cell.classList.add(cssClass);
+			cell._coloringCssClass = cssClass;
 		}
 	} else {
-		if (cell._coloringCssClass) {
-			cell.classList.remove(cell._coloringCssClass);
-			cell._coloringCssClass = null;
-		}
 		cell.style.backgroundColor = styles["backgroundColor"] || "";
 		cell.style.color = styles["color"] || "";
 	}
@@ -660,11 +649,8 @@ CellPainter._cellRestorer = function(scope) {
 
 		let styles = this._getStyles(rowData, min, max);
 		let cssClass = styles["cssClass"]; // Can be an empty string
+		_removeCssClass(elem, cssClass);
 		if (cssClass != null) { // Predefined colors mode
-			if (elem._coloringCssClass && elem._coloringCssClass !== cssClass) {
-				elem.classList.remove(elem._coloringCssClass);
-				elem._coloringCssClass = null;
-			}
 			if (cssClass) {
 				elem.classList.add(cssClass);
 				elem._coloringCssClass = cssClass;
@@ -673,10 +659,6 @@ CellPainter._cellRestorer = function(scope) {
 			elem.style.backgroundColor = "";
 			elem.style.color = "";
 		} else {
-			if (elem._coloringCssClass) {
-				elem.classList.remove(elem._coloringCssClass);
-				elem._coloringCssClass = null;
-			}
 			elem.style.backgroundColor = styles["backgroundColor"] || "";
 			elem.style.color = styles["color"] || "";
 		}
@@ -728,10 +710,12 @@ CellPainter.prototype._getStyles = function(rowData, min, max) {
 					curCond["cssClass"] = curCond["upClass"];
 				} else if(ret < 0) {
 					curCond["cssClass"] = curCond["downClass"];
-				} else {
+				} else if(ret === 0) {
 					curCond["cssClass"] = curCond["levelClass"];
+				} // else case is no change in cssClass
+				if(!curCond["cssClass"]) {
+					curCond["cssClass"] = ""; // If no cssClass, remove existing one
 				}
-				curCond["cssClass"] = curCond["cssClass"] || "";
 				return curCond;
 			}
 
@@ -864,9 +848,7 @@ CellPainter.clearCellStyle = function(cell, styles) {
 		// WARNING: Scope is not removed from the this._scopes collection to speed things up
 	}
 
-	if(elem._coloringCssClass) {
-		elem.classList.remove(elem._coloringCssClass);
-	}
+	_removeCssClass(elem);
 
 	if(!styles){
 		styles = CellPainter.supportedStyles;
@@ -949,9 +931,8 @@ CellPainter.getOppositeColor = function (hexCode) {
 * @param {Object} rowData e.g. { PCTCHNG: 0.53, CF_NETCHNG: 0.75 }
 * @param {number} min
 * @param {number} max
-* @param {Object=} changedCols
 */
-CellPainter.prototype.render = function (cell, rowData, min, max, changedCols) {
+CellPainter.prototype.render = function (cell, rowData, min, max) {
 	if (min != null && min === min) { // Render heatmap
 		this._paintCell(cell, rowData, min, max);
 	} else if (this._conditions.length && this._coloringType === CellPainter.ColoringTypes.CONDITIONAL) { // Render conditional-coloring
@@ -1005,10 +986,7 @@ CellPainter.prototype._paintCell = function(cell, rowData, min, max) {
 	let elStyle = elem.style;
 
 	let cssClass = styles["cssClass"]; // Can be an empty string
-	if (elem._coloringCssClass && elem._coloringCssClass !== cssClass) {
-		elem.classList.remove(elem._coloringCssClass);
-		elem._coloringCssClass = null;
-	}
+	_removeCssClass(elem, cssClass);
 	if (cssClass != null) { // Predefined colors mode
 		if (cssClass) {
 			elem.classList.add(cssClass);
@@ -1086,7 +1064,8 @@ CellPainter.prototype.blink = function (cell, blinkSignal, rowData) {
 		contrastColor = bc["contrastLevelColor"];
 	}
 
-	return this._blink(scope, elem, blinkColor, contrastColor);
+	this._blink(scope, elem, blinkColor, contrastColor);
+	return true;
 };
 
 /** Blink cell with specific color or theme's neutral movement color.
@@ -1112,32 +1091,30 @@ CellPainter.prototype.flash = function(cell, blinkColor, rowData) {
 		blinkColor = ElfUtil.themeColors["level"];
 	}
 
-	return this._blink(scope, elem, blinkColor, CellPainter.getOppositeColor(blinkColor));
+	this._blink(scope, elem, blinkColor, CellPainter.getOppositeColor(blinkColor));
+	return true;
 };
 
-/**
-* @public
+/** @private
 * @param {Object} scope
 * @param {Element} elem
 * @param {string} blinkColor
 * @param {string} contrastColor
-* @return {boolean}
+* @return {boolean} Returns true if it is a background blinking, otherwise returns false
 */
 CellPainter.prototype._blink = function (scope, elem, blinkColor, contrastColor) {
-	let bgBlinking = true;
+	CellPainter._clearBlinkTimer(scope);
+	scope["blinkTimer"] = setTimeout(scope._restorer, this._blinkingDuration);
 
 	if (this._blinkCondition["border"]) {
 		elem.style.border = "1px solid " + blinkColor;
-		bgBlinking = false;
+		return false;
 	} else {
 		elem.style.backgroundColor = blinkColor;
 		elem.style.color = contrastColor;
 	}
 
-	CellPainter._clearBlinkTimer(scope);
-	scope["blinkTimer"] = setTimeout(scope._restorer, this._blinkingDuration);
-
-	return bgBlinking;
+	return true;
 };
 
 /**

package/lib/tr-grid-util/es6/ElfUtil.d.ts

@@ -8,6 +8,8 @@ declare namespace ElfUtil {
 
     const themeColors: { [key: string]:  string }|null;
 
+    function setElfVersion(ver: number): void;
+
     function getElfVersion(): number;
 
     function hasComponent(compName: string): number;

package/lib/tr-grid-util/es6/ElfUtil.js

@@ -116,6 +116,15 @@ ElfUtil._icons = {
 ElfUtil._icons["halo-theme"] = ElfUtil._icons["elf-theme-halo"];
 ElfUtil._icons["solar-theme"] = ElfUtil._icons["elf-theme-solar"];
 
+
+/** Set ELF version for testing purpose
+* @public
+* @function
+* @param {number} ver
+*/
+ElfUtil.setElfVersion = function (ver) {
+	ElfUtil._elfVersion = ver;
+};
 /** Check ELF version
 * @public
 * @function
@@ -533,7 +542,8 @@ ElfUtil._profileNameRetrieved = function() {
 };
 
 /** Get theme colors from document
-* @private
+* @public
+* @ignore
 * @param {string} profileName Movement color profile name
 */
 ElfUtil._retrieveThemeColors = function(profileName) {

package/lib/tr-grid-util/es6/jet/MockQuotes2.d.ts

@@ -29,6 +29,8 @@ declare class MockSubscriptions {
 
     public setPercentageDataUpdate(percent?: number|null): void;
 
+    public setPercentageOrderChanged(percent?: number|null): void;
+
     public setSeed(seed: number): void;
 
     public addRic(ric: string, subId?: string|null): string|null|null;