@refinitiv-ui/efx-grid 6.0.131 → 6.0.133

package/lib/tr-grid-row-selection/es6/RowSelection.js

@@ -437,16 +437,15 @@ RowSelectionPlugin.prototype.getSelectedRows = function (sectRef) {
 * @private
 * @param {Object} dv
 * @param {Array<string>} rids
-* @param {boolean=} select
+* @param {boolean=} selected
 */
-RowSelectionPlugin.prototype._setHeaderSelections = function(dv, rids, select) {
-	if(select == null) {
-		select = true;
+RowSelectionPlugin.prototype._setHeaderSelections = function(dv, rids, selected) {
+	if(selected == null) {
+		selected = true;
 	}
 	let len = rids.length;
 	for (let i = 0; i < len; i++) {
-		let rid = rids[i];
-		this._setHeaderSelection(dv, rid, select);
+		this._setHeaderSelection(dv, rids[i], selected);
 	}
 };
 
@@ -454,14 +453,13 @@ RowSelectionPlugin.prototype._setHeaderSelections = function(dv, rids, select) {
 * @private
 * @param {Object} dv
 * @param {sting|number} rowRef
-* @param {boolean=} select
+* @param {boolean=} selected
 */
-RowSelectionPlugin.prototype._setHeaderSelection = function(dv, rowRef, select) {
-	if(select == null) {
-		select = true;
-	}
+RowSelectionPlugin.prototype._setHeaderSelection = function(dv, rowRef, selected) {
 	let rowId = this._getRowId(dv, rowRef);
-	this._headerSelection[rowId] = select;
+	if(rowId) {
+		this._headerSelection[rowId] = (selected == null) ? true : selected;
+	}
 };
 
 /**
@@ -471,8 +469,7 @@ RowSelectionPlugin.prototype._setHeaderSelection = function(dv, rowRef, select)
 * @return {boolean}
 */
 RowSelectionPlugin.prototype._isHeaderSelection = function(dv, rowRef) {
-	let rowId = this._getRowId(dv, rowRef);
-	return this._headerSelection[rowId];
+	return this._headerSelection[this._getRowId(dv, rowRef)] ? true : false;
 };
 
 /**
@@ -592,27 +589,25 @@ RowSelectionPlugin.prototype.setSelectedRow = function (rowIndex, opt_select, se
 RowSelectionPlugin.prototype.selectSingleRow = function (rowIndex, sectRef, activeGrid) {
 	if(!(rowIndex >= 0)) { return false; }
 
-	// 1. first of all let's clear selectedRows of prevGrid
-	let prevGrid = activeGrid ? this._activeGrid : null;
-	if(prevGrid) {
-		this._clearSelectedRows();
-
-		// 2. after clear selection let switch active grid
-		this._activeGrid = activeGrid; // HACK
+	let prevGrid = null;
+	if(activeGrid) {
+		prevGrid = this._activeGrid;
+		if(prevGrid) { // In case of multi-table, clear selection on the previous active grid
+			this._clearSelectedRows();
+		}
+		this._activeGrid = activeGrid;
 	}
 
-	// 3. now active grid is switch let's normally select row
-	let section = this._getSection(sectRef); // TODO: Check if the given section is in the active grid
-	if(this._selectSingleRow(section, rowIndex)) {
+	// WANRING: this._getSection will modify activeGrid, if it does not exist
+	let section = this._getSection(sectRef);
+	if(this._selectSingleRow(section, rowIndex)) { // This will also clear existing selection in the active grid
 		this._scrollToRow(rowIndex);
 		return true;
 	}
-	// 4. in case fail to perform _selectSingleRow
-	// we will turn back _activeGrid to prevGrid
-	else if(prevGrid) {
-		this._activeGrid = prevGrid;
-	}
 
+	if(prevGrid) {
+		this._activeGrid = prevGrid; // If the selection is unsuccessful, restore previous active grid
+	}
 	return false;
 };
 /** @public
@@ -896,9 +891,7 @@ RowSelectionPlugin.prototype._onReselection = function (e) {
 * @param {Object} e postSectionDataBinding event context
 */
 RowSelectionPlugin.prototype._onPostSectionDataBinding = function (e) {
-	if(!this._basedOnContent
-		|| "content" !== e.sectionType
-		|| !this._activeGrid) {
+	if(!this._basedOnContent || e.sectionType !== "content") {
 		return;
 	}
 	let section = e.section;
@@ -1436,6 +1429,18 @@ RowSelectionPlugin.prototype._dispatchSelectionChanged = function (e, rowIndex,
 	}
 };
 
+/** @public
+* @ignore
+* @return {!Object}
+*/
+RowSelectionPlugin.prototype._getEventHandlers = function() {
+	return {
+		"mousedown": this._onMouseDown,
+		"click": this._onClick,
+		"keydown": this._onKeyDown
+	};
+};
+
 
 
 export default RowSelectionPlugin;

package/lib/tr-grid-textformatting/es6/TextFormatting.d.ts

@@ -8,7 +8,6 @@ declare namespace TextFormattingPlugin {
 
     type FormatOptions = {
         formatType?: string|null,
-        type?: string|null,
         field?: string|null,
         decimalPlaces?: (number|boolean)|null,
         precisionEnabled?: boolean|null,
@@ -17,7 +16,6 @@ declare namespace TextFormattingPlugin {
         percentSign?: boolean|null,
         scalingUnit?: string|null,
         multiplyBy100?: boolean|null,
-        mutiplyBy100?: boolean|null,
         dateTimeFormat?: string|null,
         useUTCTime?: boolean|null,
         autoTextFormatting?: boolean|null,