@reefclaw/connect 0.1.10 → 0.1.12

package/assets/shared/signals/strategy-adapter.js

@@ -165,15 +165,25 @@ export function adaptStrategy(config, gateNamespace) {
             const { conditions: pass1, condCtx } = evaluateConditions(config.conditions, ectx, null);
             // Determine direction
             const direction = resolveDirection(config.directionRule, ectx, condCtx);
-            // Pass 2: re-evaluate direction-sensitive conditions now that we know direction
-            // (orderbook_imbalance and funding_contrarian behave differently per direction)
-            const directionSensitive = new Set(['orderbook_imbalance', 'funding_contrarian', 'funding_extreme_skip', 'funding_position_ok', 'return_momentum']);
-            const hasDirSensitive = config.conditions.some(c => directionSensitive.has(c.type));
+            // Pass 2: once the direction is known, re-evaluate the FULL condition
+            // array with it. Many registry conditions branch on `direction`
+            // (orderbook_imbalance, funding_contrarian, macd_crossover,
+            // bollinger_breakout, vwap_position, stoch_rsi_extreme, ichimoku_cloud,
+            // supertrend_direction, …) and their pass-1 result was computed against
+            // direction=null — typically the permissive either-side branch. A
+            // hand-curated allowlist here (the pre-fix 5-type set) silently drifted
+            // out of sync with the registry, so non-listed direction-dependent
+            // conditions kept their permissive pass-1 result forever (e.g. a
+            // fixed_long strategy's macd_crossover accepted a BEARISH crossover).
+            // Pass 2 always evaluated the whole array anyway — use it wholesale.
+            // Direction-insensitive conditions are pure functions of (ctx, params)
+            // and return identical results in both passes; entry/stop computation
+            // below deliberately keeps pass 1's condCtx (setter values don't depend
+            // on direction).
             let finalConditions = pass1;
-            if (direction && hasDirSensitive) {
+            if (direction) {
                 const { conditions: pass2 } = evaluateConditions(config.conditions, ectx, direction);
-                // Merge: use pass2 results for direction-sensitive, pass1 for others
-                finalConditions = pass1.map((c, i) => directionSensitive.has(config.conditions[i].type) ? pass2[i] : c);
+                finalConditions = pass2;
             }
             const allMet = finalConditions.every(c => c.met);
             let trade;

package/assets/skill/SKILL.md

@@ -80,6 +80,8 @@ OpenClaw can install the ReefClaw plugin through its own owner chat command —
 2. Tell the user to type `/restart` in this chat.
 3. Then the user types: `/plugins install clawhub:@reefclaw/openclaw-plugin` — the install restarts OpenClaw automatically; the bundled connector starts by itself and the dashboard flips to Connected.
 
+If that install is **cancelled asking for a ClawHub risk acknowledgement** (OpenClaw 2026.7+ does this; older versions never ask and reject the flag), rerun the identical command with the acknowledgement appended: `/plugins install clawhub:@reefclaw/openclaw-plugin --acknowledge-clawhub-risk`. If it is still refused, use the `npx @reefclaw/connect` fallback — it does not go through ClawHub.
+
 Only fall back to `npx @reefclaw/connect` (below) when the chat install is unavailable.
 
 ## If you cannot run the installer (elevated exec disabled)

package/dist/deps.js

@@ -5,10 +5,10 @@
 import { writeFileSync, cpSync, mkdirSync, existsSync } from 'node:fs';
 import { join } from 'node:path';
 import { run } from './exec.js';
-export function writePackageJson(dir, name, deps, extra = {}) {
+export function writePackageJson(dir, name, deps, extra = {}, version = '0.1.0') {
     const pkg = {
         name,
-        version: '0.1.0',
+        version,
         private: true,
         type: 'module',
         main: 'index.js',

package/dist/plugin.js

@@ -1,6 +1,7 @@
 // Install + register the ReefClaw trading plugin (reefclaw-paper-trading) into
 // the user's OpenClaw. Mirrors deploy-full.py: place dist, install deps, vendor
 // shared, then `openclaw plugins install --link`.
+import { readFileSync } from 'node:fs';
 import { join } from 'node:path';
 import { PLUGIN_DIR, assetsDir, ASSET_PLUGIN, ASSET_SHARED } from './paths.js';
 import { copyAsset, writePackageJson, npmInstall, vendorShared } from './deps.js';
@@ -8,6 +9,21 @@ import { run, which } from './exec.js';
 import { step, ok, info, warn, fail } from './ui.js';
 // Plugin runtime deps (mirror plugin/package.json). ws + ccxt; ccxt is large.
 const PLUGIN_DEPS = { ccxt: '^4.4.0', ws: '^8.18.0' };
+/** Version for the placed package.json — read from the bundled manifest (which
+ *  bundle-assets stamps from the published plugin version). Falls back to the
+ *  historical 0.1.0 placeholder so a missing/old manifest can't break installs. */
+function readBundledManifestVersion(pluginDir) {
+    try {
+        const manifest = JSON.parse(readFileSync(join(pluginDir, 'openclaw.plugin.json'), 'utf-8'));
+        if (typeof manifest.version === 'string' && manifest.version.length > 0) {
+            return manifest.version;
+        }
+    }
+    catch {
+        /* fall through to placeholder */
+    }
+    return '0.1.0';
+}
 export function installPlugin() {
     step('Installing the ReefClaw trading plugin');
     const assets = assetsDir();
@@ -17,9 +33,10 @@ export function installPlugin() {
     // (2026.6+ hard-fails without it). The placed dir holds the built dist at top
     // level, so the entry is ./index.js — NOT ./src/index.ts like the repo's
     // plugin/package.json (see CLAUDE.md "dist/package.json's openclaw entry").
-    writePackageJson(PLUGIN_DIR, 'reefclaw-paper-trading', PLUGIN_DEPS, {
-        openclaw: { extensions: ['./index.js'] },
-    });
+    // Version comes from the bundled manifest (stamped at bundle time from the
+    // published plugin version) so package.json and openclaw.plugin.json agree —
+    // the same package/manifest coherence ClawHub validates on the npm channel.
+    writePackageJson(PLUGIN_DIR, 'reefclaw-paper-trading', PLUGIN_DEPS, { openclaw: { extensions: ['./index.js'] } }, readBundledManifestVersion(PLUGIN_DIR));
     info('installing plugin dependencies (this can take a minute — ccxt is large)…');
     if (!npmInstall(PLUGIN_DIR)) {
         warn('npm install reported a problem; the plugin may still work if deps resolved.');
@@ -31,16 +48,27 @@ export function installPlugin() {
     const cli = which('openclaw');
     if (!cli) {
         fail('the `openclaw` CLI is not on your PATH — cannot register the plugin.');
-        info(`Once OpenClaw is on PATH, run:  openclaw plugins install --link ${PLUGIN_DIR}`);
+        info(`Once OpenClaw is on PATH, run:  openclaw plugins install --force --link ${PLUGIN_DIR}`);
         return { registered: false };
     }
+    // --force is REQUIRED on openclaw >= 2026.7.2 (issue #216): non-ClawHub
+    // sources (incl. local paths) need an acknowledgement, and in a non-TTY
+    // context the install is cancelled with "rerun with --force" instead of
+    // prompting. Acknowledging is correct here — the "source" is our own bundled
+    // plugin the user explicitly chose to install by running this installer.
+    // On <= 2026.7.1, --force only means overwrite-an-existing-install, which
+    // also makes installer re-runs idempotent instead of failing on the exists
+    // check. Verified against both dists' plugins-install command + the beta's
+    // confirmNonClawHubInstall (install cancelled when !TTY && !force).
     info('registering the plugin with OpenClaw…');
-    const r = run('openclaw', ['plugins', 'install', '--link', PLUGIN_DIR], { timeoutMs: 300_000 });
+    const r = run('openclaw', ['plugins', 'install', '--force', '--link', PLUGIN_DIR], {
+        timeoutMs: 300_000,
+    });
     if (!r.ok) {
-        warn('`openclaw plugins install --link` returned non-zero:');
+        warn('`openclaw plugins install --force --link` returned non-zero:');
         if (r.stderr.trim())
             info(r.stderr.trim().split('\n').slice(-3).join('\n'));
-        info(`Retry manually:  openclaw plugins install --link ${PLUGIN_DIR}`);
+        info(`Retry manually:  openclaw plugins install --force --link ${PLUGIN_DIR}`);
         return { registered: false };
     }
     ok('plugin registered with OpenClaw');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reefclaw/connect",
-  "version": "0.1.10",
+  "version": "0.1.12",
   "description": "One-command installer that connects your OpenClaw agent to ReefClaw (paper trading, no exchange keys).",
   "type": "module",
   "bin": {

package/assets/plugin/audit/mode-transition-audit.d.ts

@@ -1,11 +0,0 @@
-import type { TradingMode } from '../types.js';
-export interface ModeTransitionAuditEntry {
-    ts: string;
-    previousMode: TradingMode;
-    targetMode: TradingMode;
-    acknowledged: boolean;
-    ok: boolean;
-    reason?: string;
-    testnet?: boolean;
-}
-export declare function recordModeTransition(entry: Omit<ModeTransitionAuditEntry, 'ts'>, pluginId?: string): void;

package/assets/plugin/audit/mode-transition-audit.js

@@ -1,29 +0,0 @@
-// Mode-transition audit — append-only JSONL record of every set_trading_mode call.
-//
-// Written BEFORE the adapter swap (so even a crashed transition leaves a trail)
-// and updated with the outcome. Intended for post-incident review and regulatory
-// defence ("the operator acknowledged the LIVE transition at 2026-04-20T14:32:11Z").
-//
-// Path: ~/.openclaw/plugins/<pluginId>/mode-transitions.jsonl
-// Append-only; never truncated. One JSON object per line.
-import { appendFileSync, existsSync, mkdirSync } from 'node:fs';
-import { join } from 'node:path';
-import { logger, formatError } from '../logger.js';
-import { resolvePluginsBaseDir } from '../util/plugin-paths.js';
-const TAG = 'mode-audit';
-function resolvePath(pluginId) {
-    const dir = join(resolvePluginsBaseDir(), pluginId ?? 'reefclaw-paper-trading');
-    if (!existsSync(dir))
-        mkdirSync(dir, { recursive: true });
-    return join(dir, 'mode-transitions.jsonl');
-}
-export function recordModeTransition(entry, pluginId) {
-    const full = { ts: new Date().toISOString(), ...entry };
-    try {
-        appendFileSync(resolvePath(pluginId), JSON.stringify(full) + '\n', 'utf8');
-        logger.info(TAG, `${full.previousMode} → ${full.targetMode} ok=${full.ok} ack=${full.acknowledged}`);
-    }
-    catch (err) {
-        logger.error(TAG, `Failed to write audit entry: ${formatError(err)}`);
-    }
-}

package/assets/plugin/balance-utils.d.ts

@@ -1,36 +0,0 @@
-import type { CcxtBalance } from './types.js';
-/**
- * Read the total quote-currency balance from a CCXT balance map.
- *
- * Uses the PRIMARY funded currency only — whichever of USDT/USDC has
- * the larger balance. Summing both was incorrect because Binance
- * cross-margin accounting reports position margin/value as a phantom
- * balance in the settlement currency (e.g., opening an ATOM/USDT
- * position with a USDC-funded account creates a USDT "balance" entry
- * equal to the position's notional, inflating getQuoteBalance by the
- * position value and causing the KPI to double-count).
- *
- * For wallet/equity/NAV reads on Binance Futures, prefer
- * `getQuoteWalletBalance(balance)` — it handles BNFCR.
- */
-export declare function getQuoteBalance(balanceMap: Record<string, number> | undefined): number;
-/**
- * Read the effective wallet-equivalent quote balance from a Binance Futures
- * fetchBalance response, including the BNFCR realized-PnL accumulator.
- *
- * Why this exists: Binance multi-asset accounts settle realized PnL into
- * BNFCR (negative when net-loss, positive when net-gain). CCXT's `total`
- * map carries `marginBalance` (= walletBalance + uPnl), so the BNFCR line
- * mixes uPnl into the total, which double-counts when the caller adds
- * position uPnl on top. This helper reads `info.assets[i].walletBalance`
- * directly, which excludes uPnl by construction.
- *
- * Returns max(USDT_wallet, USDC_wallet) + BNFCR_wallet. BNFCR is added
- * (not max'd) because it is independent of the funded stablecoin — a
- * USDC-funded account with cumulative losses shows USDC unchanged plus
- * BNFCR negative; the user's true wallet is the sum.
- *
- * Falls back to `getQuoteBalance(balance.total)` when `info.assets` is
- * absent (mock balances in unit tests, non-Binance exchanges).
- */
-export declare function getQuoteWalletBalance(balance: CcxtBalance | null | undefined): number;

package/assets/plugin/balance-utils.js

@@ -1,98 +0,0 @@
-// Utility for reading quote-currency balance from CCXT balance objects.
-// Binance USDⓈ-M Futures settles in USDT or USDC — accounts may hold either or both.
-// On multi-asset accounts a third asset, BNFCR, accumulates realized PnL as a
-// signed wallet line (negative = cumulative loss, positive = cumulative gain).
-/**
- * Read the total quote-currency balance from a CCXT balance map.
- *
- * Uses the PRIMARY funded currency only — whichever of USDT/USDC has
- * the larger balance. Summing both was incorrect because Binance
- * cross-margin accounting reports position margin/value as a phantom
- * balance in the settlement currency (e.g., opening an ATOM/USDT
- * position with a USDC-funded account creates a USDT "balance" entry
- * equal to the position's notional, inflating getQuoteBalance by the
- * position value and causing the KPI to double-count).
- *
- * For wallet/equity/NAV reads on Binance Futures, prefer
- * `getQuoteWalletBalance(balance)` — it handles BNFCR.
- */
-export function getQuoteBalance(balanceMap) {
-    if (!balanceMap)
-        return 0;
-    const usdt = balanceMap.USDT ?? 0;
-    const usdc = balanceMap.USDC ?? 0;
-    // Use whichever currency has the larger wallet balance (the funded one).
-    // If both are zero, return 0. If both are funded, use the larger.
-    return Math.max(usdt, usdc);
-}
-/**
- * Read the effective wallet-equivalent quote balance from a Binance Futures
- * fetchBalance response, including the BNFCR realized-PnL accumulator.
- *
- * Why this exists: Binance multi-asset accounts settle realized PnL into
- * BNFCR (negative when net-loss, positive when net-gain). CCXT's `total`
- * map carries `marginBalance` (= walletBalance + uPnl), so the BNFCR line
- * mixes uPnl into the total, which double-counts when the caller adds
- * position uPnl on top. This helper reads `info.assets[i].walletBalance`
- * directly, which excludes uPnl by construction.
- *
- * Returns max(USDT_wallet, USDC_wallet) + BNFCR_wallet. BNFCR is added
- * (not max'd) because it is independent of the funded stablecoin — a
- * USDC-funded account with cumulative losses shows USDC unchanged plus
- * BNFCR negative; the user's true wallet is the sum.
- *
- * Falls back to `getQuoteBalance(balance.total)` when `info.assets` is
- * absent (mock balances in unit tests, non-Binance exchanges).
- */
-export function getQuoteWalletBalance(balance) {
-    if (!balance)
-        return 0;
-    // Prefer Binance's own account-level wallet aggregate when present.
-    // `/fapi/v3/account` (CCXT passes it through verbatim at `info`) returns
-    // `totalWalletBalance` — in Multi-Assets Mode this is the USD-denominated
-    // sum across all margin assets, with each non-USD collateral valued at
-    // Binance's live index price (verified against developers.binance.com →
-    // Account Information V3, 2026-05-16). It also excludes uPnL by
-    // construction (marginBalance = walletBalance + uPnL), matching this
-    // function's "wallet, uPnL added by caller" contract.
-    //
-    // Why this beats the per-asset reconstruction below: summing
-    // `max(USDT,USDC) + BNFCR` values USDC at FACE 1.0000, but Binance values
-    // USDC collateral at the live USDC/USD index (~0.9998). That made the
-    // dashboard wallet permanently ~$0.2 high vs the Binance app on this
-    // account (always-on, same-sign, slowly varying with the USDC peg —
-    // 2026-05-16 "figures slightly off always"). totalWalletBalance is the
-    // exact number the app's Futures "Wallet Balance" shows. The read path is
-    // already REST (`LiveAdapter.getBalance` → `fetchBalance()` every poll),
-    // so this is zero freshness regression — same cadence, correct value.
-    const info = balance?.info;
-    if (info && info.totalWalletBalance != null) {
-        const twb = parseFloat(String(info.totalWalletBalance));
-        if (Number.isFinite(twb))
-            return twb;
-    }
-    // Fallback (no Binance aggregate — non-Binance exchange, mock balances in
-    // unit tests, or a WS-store-derived balance object): the legacy
-    // face-value per-asset reconstruction. Carries the documented ~USDC-index
-    // drift but is the best available when the aggregate is absent.
-    const assets = balance?.info?.assets;
-    if (!Array.isArray(assets))
-        return getQuoteBalance(balance.total);
-    let usdt = 0;
-    let usdc = 0;
-    let bnfcr = 0;
-    for (const a of assets) {
-        if (!a || typeof a.asset !== 'string')
-            continue;
-        const wb = parseFloat(String(a.walletBalance ?? 0));
-        if (!Number.isFinite(wb))
-            continue;
-        if (a.asset === 'USDT')
-            usdt = wb;
-        else if (a.asset === 'USDC')
-            usdc = wb;
-        else if (a.asset === 'BNFCR')
-            bnfcr = wb;
-    }
-    return Math.max(usdt, usdc) + bnfcr;
-}

package/assets/plugin/ccxt/binance-ban-gate.d.ts

@@ -1,47 +0,0 @@
-/** Thrown by `assertNotBanned` while the gate is closed. Carries the
- *  remaining cooldown so callers/telemetry can reason about it. Methods
- *  catch this in their existing catch block — it is NOT meant to escape
- *  the API layer with special handling; it degrades to the method's normal
- *  failure contract. */
-export declare class BinanceBannedError extends Error {
-    readonly retryAfterMs: number;
-    constructor(retryAfterMs: number, context: string);
-}
-/** Thrown by the proactive weight pacer. Subclass of BinanceBannedError so
- *  every `instanceof BinanceBannedError` check and every method's existing
- *  catch keep working unchanged — it degrades to the same null/[]/throw
- *  contract (treated exactly like a transient fetch failure). The distinct
- *  name lets journal/telemetry tell prevention apart from a real IP ban. */
-export declare class BinanceWeightPacedError extends BinanceBannedError {
-    constructor(retryAfterMs: number, context: string);
-}
-/** Fast pre-flight check. Call as the first line inside a Binance call's
- *  try-block. Throws `BinanceBannedError` (no network) while the gate is
- *  open. */
-export declare function assertNotBanned(context: string): void;
-/** Inspect a failed call's error and arm/extend the gate on a Binance
- *  rate-limit signal. Non-rate-limit errors are ignored (normal transient
- *  handling stays in the caller). Safe to call with any error shape. */
-export declare function noteBinanceError(err: unknown): void;
-/** Relax the soft-429 ladder after a clean call. (A hard 418 window is NOT
- *  shortened by this — only Binance's stated expiry clears it.) */
-export declare function noteSuccess(): void;
-/** Reconcile the local weight estimate against Binance truth from a response
- *  header (`x-mbx-used-weight-1m`). Best-effort: callers pass whatever header
- *  bag they have; absent/garbage values are ignored. The local estimate
- *  leads (counts in-flight calls Binance hasn't tallied yet), so we take the
- *  MAX within the window — never let a lagging header lower our guard. A
- *  header far BELOW the estimate means Binance's minute rolled; re-anchor the
- *  window to Binance's clock so we don't shed for a stale local total. */
-export declare function noteResponseWeight(headers: Record<string, string> | undefined | null): void;
-/** Test/diagnostic helper — current gate state. */
-export declare function getBanGateState(): {
-    banUntilMs: number;
-    remainingMs: number;
-    rateLimitStep: number;
-    weightUsed: number;
-    weightCeiling: number;
-    cosmeticCeiling: number;
-};
-/** Test-only reset. Not used in production code paths. */
-export declare function __resetBanGateForTests(): void;