@redpanda-data/docs-extensions-and-macros 5.13.2 → 5.13.3

package/extensions/version-fetcher/get-latest-console-version.js

@@ -13,8 +13,13 @@ module.exports = async (github, owner, repo, logger = null) => {
         per_page: 50
       });
 
-      // Filter valid semver tags and sort them to find the highest version
+      // Filter valid semver tags and sort them to find the highest version.
+      // Drafts are dropped first, before the map discards the flag: a draft has
+      // no published Docker image, so returning its tag hands the caller a
+      // CONSOLE_VERSION that cannot be pulled. Drafts are only visible to
+      // callers whose token has push access to the repository.
       const sortedReleases = releases.data
+        .filter(release => !release.draft)
         .map(release => release.tag_name)
         .filter(tag => semver.valid(tag.replace(/^v/, '')))
         .sort((a, b) => semver.rcompare(a.replace(/^v/, ''), b.replace(/^v/, '')));

package/extensions/version-fetcher/get-latest-redpanda-version.js

@@ -26,9 +26,14 @@ module.exports = async (github, owner, repo, logger = null) => {
         release => !release.tag_name.includes('-rc') && !release.draft
       );
 
-      // Find latest RC release (can be draft or not, adjust if needed)
+      // Find latest RC release that is NOT a draft. The primary risk is a draft
+      // outranking the real latest RC (a token with push access sees drafts;
+      // unauthenticated CI does not, which is why this stays invisible there).
+      // A draft's git tag usually already exists, but isn't guaranteed to --
+      // when it's missing, the getRef below 404s, which the caller now handles
+      // per-RC instead of letting it take down the whole lookup.
       const latestRcRelease = sortedReleases.find(
-        release => release.tag_name.includes('-rc')
+        release => release.tag_name.includes('-rc') && !release.draft
       );
 
       let latestRedpandaReleaseCommitHash = null;
@@ -41,14 +46,30 @@ module.exports = async (github, owner, repo, logger = null) => {
         latestRedpandaReleaseCommitHash = commitData.data.object.sha;
       }
 
+      // Resolved separately from the stable release: an RC whose tag cannot be
+      // resolved should cost us the RC, not the stable version the caller
+      // probably asked for. Only a missing tag is tolerated; transient errors
+      // still propagate so retryWithBackoff can retry them.
       let latestRcReleaseCommitHash = null;
+      let resolvedRcRelease = latestRcRelease;
       if (latestRcRelease) {
-        const rcCommitData = await github.rest.git.getRef({
-          owner,
-          repo,
-          ref: `tags/${latestRcRelease.tag_name}`
-        });
-        latestRcReleaseCommitHash = rcCommitData.data.object.sha;
+        try {
+          const rcCommitData = await github.rest.git.getRef({
+            owner,
+            repo,
+            ref: `tags/${latestRcRelease.tag_name}`
+          });
+          latestRcReleaseCommitHash = rcCommitData.data.object.sha;
+        } catch (error) {
+          if (error.status !== 404) throw error;
+          const message = `No git tag for RC release ${latestRcRelease.tag_name}; ignoring it.`;
+          if (logger) {
+            logger.warn(message);
+          } else {
+            console.error(`⚠️  ${message}`);
+          }
+          resolvedRcRelease = null;
+        }
       }
 
       return {
@@ -56,8 +77,8 @@ module.exports = async (github, owner, repo, logger = null) => {
           version: latestRedpandaRelease.tag_name,
           commitHash: latestRedpandaReleaseCommitHash.substring(0, 7)
         } : null,
-        latestRcRelease: latestRcRelease ? {
-          version: latestRcRelease.tag_name,
+        latestRcRelease: resolvedRcRelease ? {
+          version: resolvedRcRelease.tag_name,
           commitHash: latestRcReleaseCommitHash.substring(0, 7)
         } : null
       };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@redpanda-data/docs-extensions-and-macros",
-  "version": "5.13.2",
+  "version": "5.13.3",
   "description": "Antora extensions and macros developed for Redpanda documentation.",
   "keywords": [
     "antora",