@redocly/openapi-core 1.0.0-beta.129 → 1.0.0-beta.130

package/lib/config/all.js

@@ -49,6 +49,7 @@ exports.default = {
         'no-invalid-parameter-examples': 'error',
         'scalar-property-missing-example': 'error',
         'spec-strict-refs': 'error',
+        'component-name-unique': 'error',
     },
     oas3_0Rules: {
         'no-invalid-media-type-examples': 'error',

package/lib/config/minimal.js

@@ -32,6 +32,7 @@ exports.default = {
         'paths-kebab-case': 'off',
         spec: 'error',
         'spec-strict-refs': 'off',
+        'component-name-unique': 'off',
     },
     oas3_0Rules: {
         'no-invalid-media-type-examples': {

package/lib/config/recommended.js

@@ -32,6 +32,7 @@ exports.default = {
         'paths-kebab-case': 'off',
         spec: 'error',
         'spec-strict-refs': 'off',
+        'component-name-unique': 'off',
     },
     oas3_0Rules: {
         'no-invalid-media-type-examples': {

package/lib/rules/oas3/component-name-unique.d.ts

@@ -0,0 +1,2 @@
+import { Oas2Rule, Oas3Rule } from '../../visitors';
+export declare const ComponentNameUnique: Oas3Rule | Oas2Rule;

package/lib/rules/oas3/component-name-unique.js

@@ -0,0 +1,124 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ComponentNameUnique = void 0;
+const TYPE_NAME_SCHEMA = 'Schema';
+const TYPE_NAME_PARAMETER = 'Parameter';
+const TYPE_NAME_RESPONSE = 'Response';
+const TYPE_NAME_REQUEST_BODY = 'RequestBody';
+const TYPE_NAME_TO_OPTION_COMPONENT_NAME = {
+    [TYPE_NAME_SCHEMA]: 'schemas',
+    [TYPE_NAME_PARAMETER]: 'parameters',
+    [TYPE_NAME_RESPONSE]: 'responses',
+    [TYPE_NAME_REQUEST_BODY]: 'requestBodies',
+};
+const ComponentNameUnique = (options) => {
+    const components = new Map();
+    const typeNames = [];
+    if (options.schemas !== 'off') {
+        typeNames.push(TYPE_NAME_SCHEMA);
+    }
+    if (options.parameters !== 'off') {
+        typeNames.push(TYPE_NAME_PARAMETER);
+    }
+    if (options.responses !== 'off') {
+        typeNames.push(TYPE_NAME_RESPONSE);
+    }
+    if (options.requestBodies !== 'off') {
+        typeNames.push(TYPE_NAME_REQUEST_BODY);
+    }
+    const rule = {
+        ref: {
+            leave(ref, { type, resolve }) {
+                const typeName = type.name;
+                if (typeNames.includes(typeName)) {
+                    const resolvedRef = resolve(ref);
+                    if (!resolvedRef.location)
+                        return;
+                    addComponentFromAbsoluteLocation(typeName, resolvedRef.location.absolutePointer.toString());
+                }
+            },
+        },
+        Root: {
+            leave(root, ctx) {
+                components.forEach((value, key, _) => {
+                    if (value.size > 1) {
+                        const component = getComponentFromKey(key);
+                        const optionComponentName = getOptionComponentNameForTypeName(component.typeName);
+                        const definitions = Array.from(value)
+                            .map((v) => `- ${v}`)
+                            .join('\n');
+                        const problem = {
+                            message: `Component '${optionComponentName}/${component.componentName}' is not unique. It is defined at:\n${definitions}`,
+                        };
+                        const componentSeverity = optionComponentName ? options[optionComponentName] : null;
+                        if (componentSeverity) {
+                            problem.forceSeverity = componentSeverity;
+                        }
+                        ctx.report(problem);
+                    }
+                });
+            },
+        },
+    };
+    if (options.schemas != 'off') {
+        rule.NamedSchemas = {
+            Schema(_, { location }) {
+                addComponentFromAbsoluteLocation(TYPE_NAME_SCHEMA, location.absolutePointer.toString());
+            },
+        };
+    }
+    if (options.responses != 'off') {
+        rule.NamedResponses = {
+            Response(_, { location }) {
+                addComponentFromAbsoluteLocation(TYPE_NAME_RESPONSE, location.absolutePointer.toString());
+            },
+        };
+    }
+    if (options.parameters != 'off') {
+        rule.NamedParameters = {
+            Parameter(_, { location }) {
+                addComponentFromAbsoluteLocation(TYPE_NAME_PARAMETER, location.absolutePointer.toString());
+            },
+        };
+    }
+    if (options.requestBodies != 'off') {
+        rule.NamedRequestBodies = {
+            RequestBody(_, { location }) {
+                addComponentFromAbsoluteLocation(TYPE_NAME_REQUEST_BODY, location.absolutePointer.toString());
+            },
+        };
+    }
+    return rule;
+    function getComponentNameFromAbsoluteLocation(absoluteLocation) {
+        const componentName = absoluteLocation.split('/').slice(-1)[0];
+        if (componentName.endsWith('.yml') ||
+            componentName.endsWith('.yaml') ||
+            componentName.endsWith('.json')) {
+            return componentName.slice(0, componentName.lastIndexOf('.'));
+        }
+        return componentName;
+    }
+    function addFoundComponent(typeName, componentName, absoluteLocation) {
+        var _a;
+        const key = getKeyForComponent(typeName, componentName);
+        const locations = (_a = components.get(key)) !== null && _a !== void 0 ? _a : new Set();
+        locations.add(absoluteLocation);
+        components.set(key, locations);
+    }
+    function addComponentFromAbsoluteLocation(typeName, absoluteLocation) {
+        const componentName = getComponentNameFromAbsoluteLocation(absoluteLocation);
+        addFoundComponent(typeName, componentName, absoluteLocation);
+    }
+};
+exports.ComponentNameUnique = ComponentNameUnique;
+function getOptionComponentNameForTypeName(typeName) {
+    var _a;
+    return (_a = TYPE_NAME_TO_OPTION_COMPONENT_NAME[typeName]) !== null && _a !== void 0 ? _a : null;
+}
+function getKeyForComponent(typeName, componentName) {
+    return `${typeName}/${componentName}`;
+}
+function getComponentFromKey(key) {
+    const [typeName, componentName] = key.split('/');
+    return { typeName, componentName };
+}

package/lib/rules/oas3/index.js

@@ -53,6 +53,7 @@ const spec_components_invalid_map_name_1 = require("./spec-components-invalid-ma
 const operation_4xx_problem_details_rfc7807_1 = require("./operation-4xx-problem-details-rfc7807");
 const required_string_property_missing_min_length_1 = require("../common/required-string-property-missing-min-length");
 const spec_strict_refs_1 = require("../common/spec-strict-refs");
+const component_name_unique_1 = require("./component-name-unique");
 exports.rules = {
     spec: spec_1.OasSpec,
     'info-contact': info_contact_1.InfoContact,
@@ -107,5 +108,6 @@ exports.rules = {
     'spec-components-invalid-map-name': spec_components_invalid_map_name_1.SpecComponentsInvalidMapName,
     'required-string-property-missing-min-length': required_string_property_missing_min_length_1.RequiredStringPropertyMissingMinLength,
     'spec-strict-refs': spec_strict_refs_1.SpecStrictRefs,
+    'component-name-unique': component_name_unique_1.ComponentNameUnique,
 };
 exports.preprocessors = {};

package/lib/rules/utils.js

@@ -72,6 +72,8 @@ function validateDefinedAndNonEmpty(fieldName, value, ctx) {
 }
 exports.validateDefinedAndNonEmpty = validateDefinedAndNonEmpty;
 function getSuggest(given, variants) {
+    if (given === null)
+        return variants;
     if (typeof given !== 'string' || !variants.length)
         return [];
     const distances = [];
@@ -127,7 +129,7 @@ function validateSchemaEnumType(schemaEnum, propertyValue, propName, refLocation
     if (!schemaEnum) {
         return;
     }
-    if (!schemaEnum.includes(propertyValue === null ? 'null' : propertyValue)) {
+    if (!schemaEnum.includes(propertyValue)) {
         report({
             location,
             message: `\`${propName}\` can be one of the following only: ${schemaEnum

package/lib/types/redocly-yaml.js

@@ -58,6 +58,7 @@ const builtInRulesList = [
     'spec-components-invalid-map-name',
     'required-string-property-missing-min-length',
     'spec-strict-refs',
+    'component-name-unique',
 ];
 const nodeTypesList = [
     'any',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@redocly/openapi-core",
-  "version": "1.0.0-beta.129",
+  "version": "1.0.0-beta.130",
   "description": "",
   "main": "lib/index.js",
   "engines": {