@redhat-developer/page-objects 1.21.0 → 1.22.0

package/out/index.js

@@ -64,6 +64,7 @@ __exportStar(require("./locators/locators"), exports);
 __exportStar(require("./errors/NullAttributeError"), exports);
 __exportStar(require("./errors/ExTesterError"), exports);
 __exportStar(require("./utils/WaitHelper"), exports);
+__exportStar(require("./utils/TimeoutConstants"), exports);
 __exportStar(require("./components/menu/Menu"), exports);
 __exportStar(require("./components/menu/MenuItem"), exports);
 __exportStar(require("./components/menu/TitleBar"), exports);

package/out/locators/locators.js

@@ -66,14 +66,37 @@ function fromText(locator) {
     };
 }
 async function findBestContainingElement(container, testElements) {
-    const areas = await Promise.all(testElements.map(async (value) => {
-        const rect = await value.getRect();
+    if (testElements.length === 0) {
+        return undefined;
+    }
+    // Short-circuit: single candidate needs no geometry.
+    if (testElements.length === 1) {
+        return testElements[0];
+    }
+    const rects = await Promise.all(testElements.map((el) => el.getRect()));
+    // When the container has not been laid out yet its rect is {0,0,0,0}.
+    // In that case overlap with any non-zero-position iframe would be negative
+    // for all candidates, causing the function to incorrectly return undefined.
+    // Fall back to picking the element with the largest own area so that the
+    // poll loop in switchToFrame can still make progress.
+    const containerArea = container.width * container.height;
+    if (containerArea === 0) {
+        let bestIdx = 0;
+        for (let i = 1; i < rects.length; i++) {
+            if (rects[i].width * rects[i].height > rects[bestIdx].width * rects[bestIdx].height) {
+                bestIdx = i;
+            }
+        }
+        return testElements[bestIdx];
+    }
+    // Normal case: pick the iframe whose intersection with the container is largest.
+    const areas = rects.map((rect) => {
         const ax = Math.max(container.x, rect.x);
         const ay = Math.max(container.y, rect.y);
         const bx = Math.min(container.x + container.width, rect.x + rect.width);
         const by = Math.min(container.y + container.height, rect.y + rect.height);
         return (bx - ax) * (by - ay);
-    }));
+    });
     let bestIdx = -1;
     for (let i = 0; i < testElements.length; i++) {
         if (areas[i] < 0) {

package/out/utils/TimeoutConstants.d.ts

@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License", destination); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/**
+ * Centralized timeout constants for page-object operations.
+ * Components should reference these instead of hardcoding values.
+ * Consumers can override by assigning to the mutable fields.
+ */
+export declare const TimeoutConstants: {
+    /** Default wait for an element to become visible (ms) */
+    ELEMENT_VISIBLE: number;
+    /** Default wait for an element to become stable (ms) */
+    ELEMENT_STABLE: number;
+    /** Wait for a menu to appear after context-click (ms) */
+    MENU_APPEAR: number;
+    /** Wait for a menu item count to stabilize (ms) */
+    MENU_STABLE: number;
+    /** Wait for an input box to appear (ms) */
+    INPUT_APPEAR: number;
+    /** Wait for quick open / command palette (ms) */
+    QUICK_OPEN: number;
+    /** Wait for editor to load (ms) */
+    EDITOR_LOAD: number;
+    /** Wait for content assist to populate (ms) */
+    CONTENT_ASSIST: number;
+    /** Wait for a tree section row container (ms) */
+    TREE_SECTION: number;
+    /** Wait for extension install from marketplace (ms) */
+    EXTENSION_INSTALL: number;
+    /** Wait for notifications to appear/dismiss (ms) */
+    NOTIFICATION: number;
+    /** Close all editors timeout (ms) */
+    CLOSE_ALL_EDITORS: number;
+    /** Wait for dialog / workbench elements (ms) */
+    DIALOG: number;
+    /** Debug toolbar / breakpoint wait (ms) */
+    DEBUG: number;
+    /** Webview frame switching (ms) */
+    WEBVIEW: number;
+    /** Wait for clipboard operations (ms) */
+    CLIPBOARD: number;
+    /** Default poll interval for condition waits (ms) */
+    POLL_INTERVAL: number;
+    /** Default number of stability checks */
+    STABILITY_CHECKS: number;
+};

package/out/utils/TimeoutConstants.js

@@ -0,0 +1,63 @@
+"use strict";
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License", destination); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.TimeoutConstants = void 0;
+/**
+ * Centralized timeout constants for page-object operations.
+ * Components should reference these instead of hardcoding values.
+ * Consumers can override by assigning to the mutable fields.
+ */
+exports.TimeoutConstants = {
+    /** Default wait for an element to become visible (ms) */
+    ELEMENT_VISIBLE: 5_000,
+    /** Default wait for an element to become stable (ms) */
+    ELEMENT_STABLE: 2_000,
+    /** Wait for a menu to appear after context-click (ms) */
+    MENU_APPEAR: 2_000,
+    /** Wait for a menu item count to stabilize (ms) */
+    MENU_STABLE: 1_000,
+    /** Wait for an input box to appear (ms) */
+    INPUT_APPEAR: 5_000,
+    /** Wait for quick open / command palette (ms) */
+    QUICK_OPEN: 10_000,
+    /** Wait for editor to load (ms) */
+    EDITOR_LOAD: 5_000,
+    /** Wait for content assist to populate (ms) */
+    CONTENT_ASSIST: 10_000,
+    /** Wait for a tree section row container (ms) */
+    TREE_SECTION: 5_000,
+    /** Wait for extension install from marketplace (ms) */
+    EXTENSION_INSTALL: 300_000,
+    /** Wait for notifications to appear/dismiss (ms) */
+    NOTIFICATION: 2_000,
+    /** Close all editors timeout (ms) */
+    CLOSE_ALL_EDITORS: 60_000,
+    /** Wait for dialog / workbench elements (ms) */
+    DIALOG: 5_000,
+    /** Debug toolbar / breakpoint wait (ms) */
+    DEBUG: 10_000,
+    /** Webview frame switching (ms) */
+    WEBVIEW: 5_000,
+    /** Wait for clipboard operations (ms) */
+    CLIPBOARD: 2_000,
+    /** Default poll interval for condition waits (ms) */
+    POLL_INTERVAL: 100,
+    /** Default number of stability checks */
+    STABILITY_CHECKS: 3,
+};
+//# sourceMappingURL=TimeoutConstants.js.map

package/out/utils/WaitHelper.js

@@ -54,8 +54,14 @@ class WaitHelper {
                 }
             }
             catch (e) {
-                // Store error but continue retrying for transient errors
-                if (e instanceof selenium_webdriver_1.error.StaleElementReferenceError || e instanceof selenium_webdriver_1.error.NoSuchElementError) {
+                // Store error but continue retrying for transient failures.
+                // TimeoutError from driver.wait(until.elementIsVisible) means the element
+                // exists but is not yet visible — the condition should be retried rather
+                // than aborting the outer poll loop.
+                if (e instanceof selenium_webdriver_1.error.StaleElementReferenceError ||
+                    e instanceof selenium_webdriver_1.error.NoSuchElementError ||
+                    e instanceof selenium_webdriver_1.error.TimeoutError ||
+                    e?.name === 'TimeoutError') {
                     lastError = e;
                 }
                 else {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@redhat-developer/page-objects",
-  "version": "1.21.0",
+  "version": "1.22.0",
   "description": "Page Object API implementation for a VS Code editor used by ExTester framework.",
   "main": "out/index.js",
   "types": "out/index.d.ts",
@@ -17,6 +17,9 @@
   },
   "author": "Red Hat",
   "license": "Apache-2.0",
+  "engines": {
+    "node": ">=22"
+  },
   "publishConfig": {
     "access": "public"
   },
@@ -43,8 +46,8 @@
     "fs-extra": "^11.4.0"
   },
   "peerDependencies": {
-    "selenium-webdriver": ">=4.6.1",
+    "selenium-webdriver": "^4.48.0",
     "typescript": ">=4.6.2"
   },
-  "gitHead": "d3ed855411fdff9575ce7d7e8a65faa70a08349f"
+  "gitHead": "46f92f28229b4fd407b7fbb54488abb1bfc2b4a8"
 }