@redhat-cloud-services/frontend-components-config 4.6.7 → 4.6.8

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@redhat-cloud-services/frontend-components-config",
-    "version": "4.6.7",
+    "version": "4.6.8",
     "description": "Config plugins and settings for RedHat Cloud Services project.",
     "main": "index.js",
     "bin": {
@@ -53,7 +53,7 @@
         "util": "^0.12.4",
         "webpack": "^5.55.1",
         "webpack-cli": "^4.8.0",
-        "webpack-dev-server": "4.3.1",
+        "webpack-dev-server": "4.8.1",
         "write-file-webpack-plugin": "^4.5.1",
         "yargs": "^17.2.1"
     }

package/src/plugins.js

@@ -1,5 +1,5 @@
 const { SourceMapDevToolPlugin } = require('webpack');
-const { ProvidePlugin } = require('webpack');
+const { ProvidePlugin, DefinePlugin } = require('webpack');
 const MiniCssExtractPlugin = require('mini-css-extract-plugin');
 const { CleanWebpackPlugin } = require('clean-webpack-plugin');
 const HtmlWebpackPlugin = require('html-webpack-plugin');
@@ -17,6 +17,7 @@ module.exports = ({
   generateSourceMaps,
   plugins,
   useChromeTemplate = false,
+  definePlugin = {},
 } = {}) => [
   ...(generateSourceMaps
     ? [
@@ -53,6 +54,11 @@ module.exports = ({
           },
           ...(replacePlugin || []),
         ]),
+        new DefinePlugin({
+          // we have to wrap the appname string in another string because of how define plugin explodes strings
+          CRC_APP_NAME: JSON.stringify(insights?.appname),
+          ...(definePlugin || {}),
+        }),
       ]),
   new ProvidePlugin({
     process: 'process/browser.js',

package/src/plugins.test.js

@@ -2,17 +2,18 @@ import plugins from './plugins';
 
 const HTML_WEBPACK = 2;
 const REPLACE = 3;
+const DEFINE_PLUGIN = 4;
 
 describe('plugins generations, no option', () => {
   const enabledPlugins = plugins();
 
   it('should generate plugins', () => {
-    expect(enabledPlugins.length).toBe(6);
+    expect(enabledPlugins.length).toBe(7);
   });
 
   it('should generate plugins with sourceMaps', () => {
     const enabledPlugins = plugins({ generateSourceMaps: true });
-    expect(enabledPlugins.length).toBe(7);
+    expect(enabledPlugins.length).toBe(8);
   });
 
   it('should generate correct template path for HtmlWebpackPlugin', () => {
@@ -52,3 +53,19 @@ it('replacePlugin should update', () => {
   });
   enabledPlugins[REPLACE].replace({ html: '@@another string @@env' }, (_, { html }) => expect(html).toBe('test-string string '));
 });
+
+it('definePlugin should have default replace of CRC_APP_NAME', () => {
+  const enabledPlugins = plugins({
+    insights: { appname: 'test_app' },
+  });
+  expect(enabledPlugins[DEFINE_PLUGIN].definitions.CRC_APP_NAME).toBe('"test_app"');
+});
+
+it('definePlugin should update', () => {
+  const enabledPlugins = plugins({
+    definePlugin: {
+      SOME_VAR: JSON.stringify('test_val'),
+    },
+  });
+  expect(enabledPlugins[DEFINE_PLUGIN].definitions.SOME_VAR).toBe('"test_val"');
+});