@reddoorla/maintenance 0.67.0 → 0.69.0

package/dist/index.js

@@ -1,7 +1,10 @@
-import "./chunk-JDGIO54P.js";
+import "./chunk-AESJBEM7.js";
+import {
+  approveBlockers
+} from "./chunk-E2GKKUEX.js";
 import {
   findDueReports
-} from "./chunk-VKAYZVMI.js";
+} from "./chunk-45AUGDFR.js";
 import {
   upgradeSvelte4to5
 } from "./chunk-ZO7WNY57.js";
@@ -9,7 +12,7 @@ import {
   DEFAULT_INIT_STEPS,
   a11yFixturesPage,
   init
-} from "./chunk-LCKKIJ22.js";
+} from "./chunk-42KKVLYN.js";
 import {
   convertToPnpm
 } from "./chunk-2X322ZES.js";
@@ -24,34 +27,35 @@ import {
 } from "./chunk-ZYBOT5PM.js";
 import {
   draftReportForSite
-} from "./chunk-ULL4AD3Y.js";
-import "./chunk-6LIWDIXU.js";
+} from "./chunk-O6G4HHMF.js";
+import "./chunk-RINXPU3H.js";
 import {
-  sendApprovedReports
-} from "./chunk-YKOOAWVL.js";
-import "./chunk-OGGRFBL4.js";
+  parseAddresses,
+  sendApprovedReports,
+  withGlobalCc
+} from "./chunk-2DCA7FHZ.js";
 import "./chunk-GECESMVS.js";
 import {
   BLURRED_CID,
   CHECK_CID,
-  loadBundledImages,
-  renderReportHtml
-} from "./chunk-SYTPVYIK.js";
-import {
   checklistFor,
   escapeHtml,
   isChecklistComplete,
   isPendingApproval,
+  loadBundledImages,
+  renderReportHtml,
   safeUrl
-} from "./chunk-OCS7SZUZ.js";
+} from "./chunk-6JFOAPW4.js";
+import "./chunk-WEKL2HYJ.js";
 import {
   bumpDeps
 } from "./chunk-D3DQFC32.js";
+import "./chunk-QTHKOIFJ.js";
 import {
   syncConfigs
-} from "./chunk-XVR7UM6Z.js";
-import "./chunk-XKOZUVK2.js";
+} from "./chunk-JNXCDUYB.js";
 import "./chunk-CASCWQQX.js";
+import "./chunk-XKOZUVK2.js";
 import "./chunk-OTGB6YQO.js";
 import {
   ALL_AUDIT_NAMES,
@@ -62,13 +66,13 @@ import {
   runAudits,
   runAuditsAcross,
   securityAudit
-} from "./chunk-WCN54744.js";
+} from "./chunk-6G7BC5SN.js";
+import "./chunk-GASBX52O.js";
+import "./chunk-YEGHUODU.js";
 import "./chunk-LKGVSM2O.js";
 import "./chunk-OTBA7DON.js";
 import "./chunk-PH3AGF4Z.js";
 import "./chunk-HIN3P4ZN.js";
-import "./chunk-GASBX52O.js";
-import "./chunk-YEGHUODU.js";
 import {
   fromJsonFile,
   localPath
@@ -78,18 +82,16 @@ import "./chunk-XXTZBPUY.js";
 import "./chunk-XTK5VIQB.js";
 import {
   fromAirtableBase
-} from "./chunk-Y4O44LZB.js";
+} from "./chunk-6MT5W6UF.js";
 import "./chunk-U5SZ4FOP.js";
 import {
   SEVERITY_RANK,
   siteSlug
-} from "./chunk-CL5DYUWQ.js";
+} from "./chunk-C3PDS623.js";
 import "./chunk-HN6I2XWI.js";
-import "./chunk-WEKL2HYJ.js";
 import "./chunk-6VAL7XJT.js";
 import "./chunk-EYODPUHV.js";
 import "./chunk-LYCKN7ZR.js";
-import "./chunk-QTHKOIFJ.js";
 
 // src/recipes/index.ts
 var ALL_RECIPE_NAMES = [
@@ -327,21 +329,66 @@ function checklistBlock(r) {
   }).join("");
   return `<div class="checklist" data-checklist-for="${rid}">${boxes}</div>`;
 }
-function approveButton(r) {
-  const disabled = isChecklistComplete(r) ? "" : " disabled";
-  return `<button class="approve" data-report-id="${escapeHtml(r.id)}" data-approve-url="${escapeHtml(`/api/reports/${encodeURIComponent(r.id)}/approve`)}"${disabled}>Approve</button>`;
+function approveButton(r, blocked) {
+  const disabled = isChecklistComplete(r) && !blocked ? "" : " disabled";
+  const blockedAttr = blocked ? ` data-send-blocked="1"` : "";
+  return `<button class="approve" data-report-id="${escapeHtml(r.id)}" data-approve-url="${escapeHtml(`/api/reports/${encodeURIComponent(r.id)}/approve`)}"${blockedAttr}${disabled}>Approve</button>`;
+}
+function preflightChip(findings) {
+  const fails = findings.filter((f) => f.level === "fail");
+  const warns = findings.filter((f) => f.level === "warn");
+  if (fails.length > 0) {
+    const title = escapeHtml(fails.map((f) => `${f.check}: ${f.message}`).join("\n"));
+    return `<span class="preflight preflight-fail" title="${title}">preflight \u2717 ${fails.length}</span>`;
+  }
+  if (warns.length > 0) {
+    const title = escapeHtml(warns.map((f) => `${f.check}: ${f.message}`).join("\n"));
+    return `<span class="preflight preflight-warn" title="${title}">preflight \u26A0 ${warns.length}</span>`;
+  }
+  return `<span class="preflight preflight-ok" title="recipients, header image and report scores all present">preflight \u2713</span>`;
+}
+function nextDailyRun(now) {
+  const run = new Date(now);
+  run.setUTCHours(9, 23, 0, 0);
+  if (run.getTime() <= now.getTime()) run.setUTCDate(run.getUTCDate() + 1);
+  return run;
 }
-function pendingRow(r) {
+function sendTimingLine(now) {
+  const minuteOfDay = now.getUTCHours() * 60 + now.getUTCMinutes();
+  const RUN_START = 9 * 60 + 23;
+  const GRACE_END = 10 * 60 + 30;
+  if (minuteOfDay >= RUN_START && minuteOfDay < GRACE_END) {
+    return `<span class="muted">today's 09:23 UTC run may still be in flight \u2014 approving now can send within minutes</span>`;
+  }
+  const run = nextDailyRun(now);
+  const leadMin = Math.floor((run.getTime() - now.getTime()) / 6e4);
+  const lead = leadMin >= 60 ? `~${Math.floor(leadMin / 60)}h` : leadMin >= 1 ? `~${leadMin} min` : "under 1 min";
+  return `<span class="muted">approve \u2260 send: goes out at the next daily run, 09:23 UTC (${lead})</span>`;
+}
+function recipientsLine(site) {
+  const to = parseAddresses(site.reportRecipientsTo) ?? parseAddresses(site.pointOfContact) ?? [];
+  if (to.length === 0) {
+    return `<span class="recipients recipients-missing">recipients: none resolve \u2014 set point of contact in Airtable</span>`;
+  }
+  const cc = withGlobalCc(parseAddresses(site.reportRecipientsCc), to);
+  const ccPart = cc.length > 0 ? ` \xB7 CC ${cc.map(escapeHtml).join(", ")}` : "";
+  return `<span class="recipients">To ${to.map(escapeHtml).join(", ")}${ccPart}</span>`;
+}
+function pendingRow(r, site, now) {
   const type = escapeHtml(r.reportType);
   const period = r.period ? escapeHtml(r.period) : "\u2014";
-  return `<li><div class="pending-head"><strong>${type}</strong> <span class="muted">${period}</span> ${approveButton(r)}</div>${checklistBlock(r)}</li>`;
+  const findings = approveBlockers(site, r);
+  const blocked = findings.some((f) => f.level === "fail");
+  const preview = r.renderedHtmlAttachment ? `<a href="${escapeHtml(safeUrl(r.renderedHtmlAttachment.url))}" rel="noopener noreferrer" title="rendered at draft time \u2014 Commentary/subject edits after drafting are not reflected">draft preview \u25B8</a>` : `<span class="muted">no preview yet</span>`;
+  const sendLine = sendTimingLine(now);
+  return `<li><div class="pending-head"><strong>${type}</strong> <span class="muted">${period}</span> ${preflightChip(findings)} ${preview} ${approveButton(r, blocked)}</div><div class="pending-info">${recipientsLine(site)} ${sendLine}</div>${checklistBlock(r)}</li>`;
 }
-function pendingSection(reports) {
+function pendingSection(reports, site, now) {
   const pending = reports.filter(isPendingApproval);
   if (pending.length === 0) return "";
   return `<div class="section pending">
     <h2>Pending your yes (${pending.length})</h2>
-    <ul class="pending-list">${pending.map(pendingRow).join("")}</ul>
+    <ul class="pending-list">${pending.map((r) => pendingRow(r, site, now)).join("")}</ul>
   </div>`;
 }
 function gaUsersCell(r) {
@@ -358,14 +405,17 @@ function searchCell(r) {
   }
   return DASH;
 }
-function reportRow(r) {
+function reportRow(r, site) {
   const date = r.completedOn ? escapeHtml(r.completedOn) : DASH;
   const type = escapeHtml(r.reportType);
   const id = escapeHtml(r.reportId);
   const ga = gaUsersCell(r);
   const search = searchCell(r);
   const link = r.renderedHtmlAttachment ? `<a href="${escapeHtml(safeUrl(r.renderedHtmlAttachment.url))}">view</a>` : `<span class="muted">no attachment</span>`;
-  const action = isPendingApproval(r) ? approveButton(r) : "";
+  const action = isPendingApproval(r) ? approveButton(
+    r,
+    approveBlockers(site, r).some((f) => f.level === "fail")
+  ) : "";
   return `<tr><td>${date}</td><td>${type}</td><td><code>${id}</code></td><td>${ga}</td><td>${search}</td><td>${link}</td><td>${action}</td></tr>`;
 }
 var SUBMISSIONS_PER_SITE_CAP = 25;
@@ -471,10 +521,16 @@ th, td { text-align: left; padding: 0.5rem; border-bottom: 1px solid #eee; }
 .empty { color: #999; padding: 1rem; border: 1px dashed #ccc; border-radius: 6px; text-align: center; }
 button.approve { font: inherit; padding: 0.35rem 0.85rem; border: 1px solid #2c7; border-radius: 6px; background: #2c7; color: #fff; cursor: pointer; }
 button.approve:disabled { opacity: 0.6; cursor: default; }
+.pending-info { display: flex; flex-wrap: wrap; gap: 0.35rem 1rem; font-size: 0.82rem; margin: 0.3rem 0 0.15rem; }
+.recipients-missing { color: #e57373; }
+.preflight { font-size: 0.78rem; padding: 0.1rem 0.45rem; border-radius: 999px; white-space: nowrap; }
+.preflight-ok { background: #1b5e2033; color: #7bc67e; }
+.preflight-warn { background: #f9a82533; color: #d79921; }
+.preflight-fail { background: #b71c1c33; color: #e57373; }
 .pending-list { list-style: none; padding: 0; margin: 0; }
 .pending-list li { padding: 0.5rem; border-bottom: 1px solid #eee; }
 @media (prefers-color-scheme: dark) { .pending-list li { border-color: #2a2a2a; } }
-.pending-head { display: flex; align-items: center; gap: 0.5rem; }
+.pending-head { display: flex; align-items: center; gap: 0.5rem; flex-wrap: wrap; row-gap: 0.25rem; }
 .checklist { display: flex; flex-wrap: wrap; gap: 0.25rem 1.25rem; margin: 0.5rem 0 0.25rem 0.25rem; }
 .check-item { display: flex; align-items: center; gap: 0.4rem; font-size: 0.9rem; }
 .check-item input { margin: 0; }
@@ -524,7 +580,7 @@ function renderSiteDashboardHtml(site, reports, submissions = [], spamTotals = n
   const recentReports = [...reports].sort((a, b) => (b.completedOn ?? "").localeCompare(a.completedOn ?? "")).slice(0, 6);
   const reportsSection = recentReports.length === 0 ? `<div class="empty">No reports yet.</div>` : `<table>
           <thead><tr><th>Completed</th><th>Type</th><th>ID</th><th>GA users</th><th>Search</th><th>Report</th><th></th></tr></thead>
-          <tbody>${recentReports.map(reportRow).join("")}</tbody>
+          <tbody>${recentReports.map((r) => reportRow(r, site)).join("")}</tbody>
         </table>`;
   return `<!doctype html>
 <html lang="en">
@@ -541,7 +597,7 @@ function renderSiteDashboardHtml(site, reports, submissions = [], spamTotals = n
   <div class="meta"><a href="${escapeHtml(urlSafe)}">${escapeHtml(site.url)}</a></div>
   ${auditedLine}
   ${setupSection(site)}
-  ${pendingSection(reports)}
+  ${pendingSection(reports, site, now)}
 
   <div class="section">
     <h2>Lighthouse</h2>
@@ -569,8 +625,18 @@ function renderSiteDashboardHtml(site, reports, submissions = [], spamTotals = n
         b.disabled = true;
         try {
           const res = await fetch(b.dataset.approveUrl, { method: "POST" });
-          b.textContent = res.ok ? "Approved" : "Failed";
-          if (!res.ok) b.disabled = false;
+          if (res.ok) {
+            b.textContent = "Approved";
+          } else {
+            // A 409 carries { reason, blockers } \u2014 surface WHY instead of a bare
+            // "Failed" next to a possibly-stale green chip. textContent/title
+            // assignment only (no innerHTML), so server strings stay inert.
+            const data = await res.json().catch(() => null);
+            b.textContent = data && data.reason === "send-blocked" ? "Blocked" : "Failed";
+            if (data && Array.isArray(data.blockers)) b.title = data.blockers.join("
+");
+            b.disabled = false;
+          }
         } catch {
           // Network rejection (offline, DNS, abort): mirror the !res.ok path so
           // the button doesn't sit permanently disabled reading "Approve".
@@ -638,7 +704,7 @@ function renderSiteDashboardHtml(site, reports, submissions = [], spamTotals = n
           });
           if (!res.ok) throw new Error("bad status");
           const data = await res.json();
-          if (approveBtn) approveBtn.disabled = !data.complete;
+          if (approveBtn) approveBtn.disabled = !data.complete || approveBtn.dataset.sendBlocked === "1";
         } catch {
           // Revert the optimistic flip so the box reflects the (unchanged) server state.
           cb.checked = !cb.checked;