@reddoorla/maintenance 0.6.4 → 0.6.6

package/dist/cli/bin.js

@@ -1040,6 +1040,17 @@ async function commit(cwd, message) {
 
 // src/recipes/sync-configs.ts
 var GITIGNORE_CONFIG = "gitignore";
+var ALL_CONFIG_NAMES = [
+  "lighthouse",
+  "eslint",
+  "prettier",
+  "playwright-a11y",
+  "svelte",
+  "gitignore"
+];
+function isConfigName(value) {
+  return ALL_CONFIG_NAMES.includes(value);
+}
 function siteLabel6(site) {
   return site.name ?? site.path;
 }
@@ -1119,12 +1130,34 @@ async function syncConfigs(site, opts = {}) {
 
 // src/cli/commands/sync-configs.ts
 function parseOnly2(value) {
-  return value ? value.split(",").map((s) => s.trim()) : void 0;
+  if (!value) return void 0;
+  const names = value.split(",").map((s) => s.trim());
+  for (const n of names) {
+    if (!isConfigName(n)) {
+      throw Object.assign(
+        new Error(`unknown config in --only: "${n}". Valid: ${ALL_CONFIG_NAMES.join(", ")}`),
+        { exitCode: 2 }
+      );
+    }
+  }
+  return names;
+}
+async function dryPlanGitignore(cwd) {
+  let existing;
+  try {
+    existing = await readFile7(join7(cwd, ".gitignore"), "utf-8");
+  } catch {
+    return "would create .gitignore";
+  }
+  const merge = mergeGitignore(existing, CANONICAL_GITIGNORE_ENTRIES);
+  if (merge.added.length === 0) return null;
+  return `would update .gitignore (${merge.added.length} canonical entries to add)`;
 }
 async function dryPlan(cwd, which) {
-  const targets = which ? templatesByName(which) : ALL_TEMPLATES;
+  const includeGitignore = which ? which.includes("gitignore") : true;
+  const templateTargets = which ? templatesByName(which.filter((c) => c !== "gitignore")) : ALL_TEMPLATES;
   const lines = [];
-  for (const t of targets) {
+  for (const t of templateTargets) {
     let existing = "";
     try {
       existing = await readFile7(join7(cwd, t.path), "utf-8");
@@ -1132,6 +1165,10 @@ async function dryPlan(cwd, which) {
     }
     if (existing !== t.contents) lines.push(`would update ${t.path} (config: ${t.config})`);
   }
+  if (includeGitignore) {
+    const gi = await dryPlanGitignore(cwd);
+    if (gi) lines.push(gi);
+  }
   return lines.length === 0 ? "no changes needed" : lines.join("\n");
 }
 function formatResult(r) {
@@ -1170,9 +1207,19 @@ async function runSyncConfigsCommand(site, opts) {
 import { resolve as resolve4 } from "path";
 
 // src/recipes/bump-deps.ts
+import { stat as stat2 } from "fs/promises";
+import { join as join8 } from "path";
 function siteLabel7(site) {
   return site.name ?? site.path;
 }
+async function exists(path) {
+  try {
+    await stat2(path);
+    return true;
+  } catch {
+    return false;
+  }
+}
 function outdatedFlagsForGroup(group) {
   if (group === "major") return ["--latest"];
   if (group === "minor") return [];
@@ -1186,6 +1233,24 @@ async function bumpDeps(site, opts = {}) {
   const label = siteLabel7(site);
   const group = opts.group ?? "minor";
   const spawn2 = opts.spawn ?? defaultSpawn;
+  const hasPnpmLock = await exists(join8(site.path, "pnpm-lock.yaml"));
+  if (!hasPnpmLock) {
+    const hasNpmLock = await exists(join8(site.path, "package-lock.json"));
+    const hasYarnLock = await exists(join8(site.path, "yarn.lock"));
+    if (hasNpmLock || hasYarnLock) {
+      const competing = hasNpmLock ? "package-lock.json" : "yarn.lock";
+      return {
+        recipe: "bump-deps",
+        site: label,
+        status: "failed",
+        commits: [],
+        notes: `site has ${competing} but no pnpm-lock.yaml \u2014 run convert-to-pnpm first`
+      };
+    }
+  }
+  if (!await isWorkingTreeClean(site.path)) {
+    throw new Error(`refusing to run: working tree is not clean at ${site.path}`);
+  }
   await spawn2("pnpm", ["install"], { cwd: site.path, streaming: true });
   const outdated = await spawn2("pnpm", ["outdated", "--json", ...outdatedFlagsForGroup(group)], {
     cwd: site.path
@@ -1206,9 +1271,6 @@ async function bumpDeps(site, opts = {}) {
       notes: `pnpm outdated reported nothing for group=${group}`
     };
   }
-  if (!await isWorkingTreeClean(site.path)) {
-    throw new Error(`refusing to run: working tree is not clean at ${site.path}`);
-  }
   const branch = branchName("bump-deps");
   await createBranch(site.path, branch);
   await spawn2("pnpm", ["up", ...upFlagsForGroup(group)], {
@@ -1262,7 +1324,7 @@ async function runBumpDepsCommand(site, opts) {
 import { resolve as resolve5 } from "path";
 
 // src/recipes/svelte-5/index.ts
-import { join as join13 } from "path";
+import { join as join14 } from "path";
 
 // src/util/pkg.ts
 import { readFile as readFile8, writeFile as writeFile4 } from "fs/promises";
@@ -1270,8 +1332,18 @@ async function readPackageJson(path) {
   const raw = await readFile8(path, "utf-8");
   return JSON.parse(raw);
 }
+function detectIndentFromContent(raw) {
+  const match = raw.match(/\n([ \t]+)"/);
+  return match ? match[1] ?? "  " : "  ";
+}
 async function writePackageJson(path, pkg) {
-  const content = JSON.stringify(pkg, null, 2) + "\n";
+  let indent = "  ";
+  try {
+    const existing = await readFile8(path, "utf-8");
+    indent = detectIndentFromContent(existing);
+  } catch {
+  }
+  const content = JSON.stringify(pkg, null, indent) + "\n";
   await writeFile4(path, content, "utf-8");
 }
 function bumpDep(pkg, name, version2, opts = {}) {
@@ -1301,7 +1373,7 @@ function bumpDep(pkg, name, version2, opts = {}) {
 }
 
 // src/recipes/svelte-5/step-bump-versions.ts
-import { join as join8 } from "path";
+import { join as join9 } from "path";
 var SVELTE_5_VERSIONS = {
   svelte: "^5.55.5",
   "@sveltejs/kit": "^2.59.0",
@@ -1314,7 +1386,7 @@ var SVELTE_5_VERSIONS = {
   "typescript-svelte-plugin": "^0.3.52"
 };
 async function bumpToSvelte5Versions(cwd) {
-  const pkgPath = join8(cwd, "package.json");
+  const pkgPath = join9(cwd, "package.json");
   const pkg = await readPackageJson(pkgPath);
   let next = pkg;
   for (const [name, version2] of Object.entries(SVELTE_5_VERSIONS)) {
@@ -1327,7 +1399,7 @@ async function bumpToSvelte5Versions(cwd) {
 
 // src/recipes/svelte-5/step-svelte-config.ts
 import { readFile as readFile9, writeFile as writeFile5 } from "fs/promises";
-import { join as join9 } from "path";
+import { join as join10 } from "path";
 var VITE_PLUGIN_PKG = "@sveltejs/vite-plugin-svelte";
 var IMPORT_FROM_VITE_PLUGIN = new RegExp(
   String.raw`^import\s+\{\s*([^}]+?)\s*\}\s+from\s+["']` + VITE_PLUGIN_PKG.replace(/[/]/g, "\\/") + String.raw`["'];?[ \t]*\n`,
@@ -1368,7 +1440,7 @@ function dropPreprocessKey(source) {
   return source.slice(0, m.index) + source.slice(tailIdx).replace(new RegExp(`^${indent}\\n`), "");
 }
 async function migrateSvelteConfig(cwd) {
-  const path = join9(cwd, "svelte.config.js");
+  const path = join10(cwd, "svelte.config.js");
   let src;
   try {
     src = await readFile9(path, "utf-8");
@@ -1405,9 +1477,9 @@ async function runSvelteMigrate(cwd, spawn2 = defaultSpawn) {
 }
 
 // src/recipes/svelte-5/step-tailwind-upgrade.ts
-import { join as join10 } from "path";
+import { join as join11 } from "path";
 async function upgradeTailwind(cwd, spawn2 = defaultSpawn) {
-  const pkg = await readPackageJson(join10(cwd, "package.json"));
+  const pkg = await readPackageJson(join11(cwd, "package.json"));
   const tailwindVersion = pkg.devDependencies?.tailwindcss ?? pkg.dependencies?.tailwindcss;
   if (!tailwindVersion) return { ran: false, reason: "tailwindcss not installed" };
   if (/^\^?4\./.test(tailwindVersion)) return { ran: false, reason: "already on tailwind 4.x" };
@@ -1429,7 +1501,7 @@ async function upgradeTailwind(cwd, spawn2 = defaultSpawn) {
 
 // src/recipes/svelte-5/step-gotchas.ts
 import { readFile as readFile10, writeFile as writeFile6 } from "fs/promises";
-import { join as join11 } from "path";
+import { join as join12 } from "path";
 import { glob as glob2 } from "tinyglobby";
 
 // src/recipes/svelte-5/codemods/on-event-to-handler.ts
@@ -1690,6 +1762,7 @@ function findStringClose(source, openIdx) {
   }
   return -1;
 }
+var MIGRATION_MARKER = "// @migration-task: $effect won't trigger UI updates on plain `let` bindings \u2014 refine mutated locals to $state or split into per-variable $derived.";
 function transformBlocks(body) {
   const out = [];
   let last = 0;
@@ -1705,6 +1778,8 @@ function transformBlocks(body) {
     out.push(body.slice(last, m.index));
     out.push(leadingNewline);
     const blockBody = body.slice(openBraceIdx + 1, closeBraceIdx);
+    out.push(`${indent}${MIGRATION_MARKER}
+`);
     out.push(`${indent}$effect(() => {${blockBody}});`);
     last = closeBraceIdx + 1;
     BLOCK_REACTIVE_HEAD.lastIndex = last;
@@ -1741,7 +1816,7 @@ async function planGotchaCodemods(cwd) {
   const changes = [];
   const relPaths = await glob2(SVELTE_GLOBS, { cwd, ignore: IGNORE2, absolute: false });
   for (const rel of relPaths) {
-    const path = join11(cwd, rel);
+    const path = join12(cwd, rel);
     const before = await readFile10(path, "utf-8");
     const after = CODEMODS.reduce((s, fn) => fn(s), before);
     if (after !== before) changes.push({ rel, after });
@@ -1751,7 +1826,7 @@ async function planGotchaCodemods(cwd) {
 async function applyGotchaCodemods(cwd) {
   const changes = await planGotchaCodemods(cwd);
   for (const c of changes) {
-    await writeFile6(join11(cwd, c.rel), c.after, "utf-8");
+    await writeFile6(join12(cwd, c.rel), c.after, "utf-8");
   }
   return { filesChanged: changes.length };
 }
@@ -1775,7 +1850,7 @@ async function verifyMigration(cwd, spawn2 = defaultSpawn) {
 
 // src/recipes/svelte-5/step-summary.ts
 import { writeFile as writeFile7 } from "fs/promises";
-import { join as join12 } from "path";
+import { join as join13 } from "path";
 async function writeMigrationSummary(input) {
   const lines = [
     `# Svelte 4 \u2192 5 migration summary`,
@@ -1792,7 +1867,7 @@ async function writeMigrationSummary(input) {
     `- Verify Playwright a11y tests still pass.`
   ];
   const content = lines.join("\n") + "\n";
-  const path = join12(input.cwd, "MIGRATION_SVELTE_5.md");
+  const path = join13(input.cwd, "MIGRATION_SVELTE_5.md");
   await writeFile7(path, content, "utf-8");
   return path;
 }
@@ -1803,7 +1878,7 @@ function siteLabel8(site) {
 }
 async function alreadyOnSvelte5(cwd) {
   try {
-    const pkg = await readPackageJson(join13(cwd, "package.json"));
+    const pkg = await readPackageJson(join14(cwd, "package.json"));
     const v = pkg.devDependencies?.svelte ?? pkg.dependencies?.svelte;
     return !!v && /^\^?5\./.test(v);
   } catch {
@@ -1920,8 +1995,8 @@ async function runUpgradeCommand(upgradeName, site, opts = {}) {
 import { resolve as resolve6 } from "path";
 
 // src/recipes/convert-to-pnpm.ts
-import { rm as rm3, stat as stat2 } from "fs/promises";
-import { join as join14 } from "path";
+import { rm as rm3, stat as stat3 } from "fs/promises";
+import { join as join15 } from "path";
 
 // src/recipes/convert-to-pnpm/script-rewrites.ts
 function rewriteScriptForPnpm(script) {
@@ -1943,9 +2018,9 @@ function rewriteScriptsForPnpm(scripts) {
 
 // src/recipes/convert-to-pnpm.ts
 var DEFAULT_PNPM_VERSION = "10.33.1";
-async function exists(path) {
+async function exists2(path) {
   try {
-    await stat2(path);
+    await stat3(path);
     return true;
   } catch {
     return false;
@@ -1958,10 +2033,10 @@ async function convertToPnpm(site, opts = {}) {
   const label = siteLabel9(site);
   const spawn2 = opts.spawn ?? defaultSpawn;
   const pnpmVersion = opts.pnpmVersion ?? DEFAULT_PNPM_VERSION;
-  const pnpmLockPath = join14(site.path, "pnpm-lock.yaml");
-  const npmLockPath = join14(site.path, "package-lock.json");
-  const yarnLockPath = join14(site.path, "yarn.lock");
-  if (await exists(pnpmLockPath)) {
+  const pnpmLockPath = join15(site.path, "pnpm-lock.yaml");
+  const npmLockPath = join15(site.path, "package-lock.json");
+  const yarnLockPath = join15(site.path, "yarn.lock");
+  if (await exists2(pnpmLockPath)) {
     return {
       recipe: "convert-to-pnpm",
       site: label,
@@ -1970,8 +2045,8 @@ async function convertToPnpm(site, opts = {}) {
       notes: "site already has pnpm-lock.yaml"
     };
   }
-  const hasNpmLock = await exists(npmLockPath);
-  const hasYarnLock = await exists(yarnLockPath);
+  const hasNpmLock = await exists2(npmLockPath);
+  const hasYarnLock = await exists2(yarnLockPath);
   if (!hasNpmLock && !hasYarnLock) {
     return {
       recipe: "convert-to-pnpm",
@@ -1992,7 +2067,7 @@ async function convertToPnpm(site, opts = {}) {
   const sourceLock = hasNpmLock ? "package-lock.json" : "yarn.lock";
   const lockSha = await commit(site.path, `chore(pnpm): remove ${sourceLock}`);
   if (lockSha) shas.push(lockSha);
-  const pkgPath = join14(site.path, "package.json");
+  const pkgPath = join15(site.path, "package.json");
   const pkg = await readPackageJson(pkgPath);
   const next = { ...pkg, packageManager: `pnpm@${pnpmVersion}` };
   if (pkg.scripts && typeof pkg.scripts === "object") {
@@ -2006,6 +2081,7 @@ async function convertToPnpm(site, opts = {}) {
   await writePackageJson(pkgPath, next);
   const pkgSha = await commit(site.path, "chore(pnpm): pin packageManager + rewrite npm scripts");
   if (pkgSha) shas.push(pkgSha);
+  await rm3(join15(site.path, "node_modules"), { recursive: true, force: true });
   const installResult = await spawn2("pnpm", ["install"], {
     cwd: site.path,
     streaming: true
@@ -2059,17 +2135,17 @@ async function runConvertToPnpmCommand(site, opts) {
 import { resolve as resolve7 } from "path";
 
 // src/recipes/onboard.ts
-import { stat as stat3 } from "fs/promises";
-import { join as join16 } from "path";
+import { stat as stat4 } from "fs/promises";
+import { join as join17 } from "path";
 
 // src/util/self-version.ts
 import { readFileSync } from "fs";
 import { fileURLToPath } from "url";
-import { dirname, join as join15 } from "path";
+import { dirname, join as join16 } from "path";
 function selfPackageVersion(callerImportMetaUrl) {
   try {
     const here2 = dirname(fileURLToPath(callerImportMetaUrl));
-    const raw = readFileSync(join15(here2, "..", "..", "package.json"), "utf-8");
+    const raw = readFileSync(join16(here2, "..", "..", "package.json"), "utf-8");
     const pkg = JSON.parse(raw);
     return pkg.version ?? "0.0.0";
   } catch {
@@ -2082,16 +2158,27 @@ function selfCaretRange(callerImportMetaUrl) {
 
 // src/recipes/onboard.ts
 var PACKAGE_NAME = "@reddoorla/maintenance";
-var AUDIT_DEPS = {
-  lighthouse: [{ name: "@lhci/cli", version: "^0.15.1" }],
-  a11y: [
-    { name: "@playwright/test", version: "^1.59.1" },
-    { name: "@axe-core/playwright", version: "^4.11.3" }
-  ]
+var AUDIT_DEP_NAMES = {
+  lighthouse: ["@lhci/cli"],
+  a11y: ["@playwright/test", "@axe-core/playwright"]
 };
-async function exists2(path) {
+var AUDIT_DEPS = Object.fromEntries(
+  Object.entries(AUDIT_DEP_NAMES).map(([audit, names]) => [
+    audit,
+    names.map((name) => {
+      const version2 = baselineVersions[name];
+      if (!version2) {
+        throw new Error(
+          `baseline-versions is missing audit dep "${name}" \u2014 add it to src/configs/baseline-versions.ts`
+        );
+      }
+      return { name, version: version2 };
+    })
+  ])
+);
+async function exists3(path) {
   try {
-    await stat3(path);
+    await stat4(path);
     return true;
   } catch {
     return false;
@@ -2108,7 +2195,7 @@ async function onboard(site, opts = {}) {
   const spawn2 = opts.spawn ?? defaultSpawn;
   const audits = opts.audits ?? ["lighthouse", "a11y"];
   const packageVersion = opts.packageVersion ?? selfCaretRange(import.meta.url);
-  if (!await exists2(join16(site.path, "pnpm-lock.yaml"))) {
+  if (!await exists3(join17(site.path, "pnpm-lock.yaml"))) {
     return {
       recipe: "onboard",
       site: label,
@@ -2117,7 +2204,7 @@ async function onboard(site, opts = {}) {
       notes: "no pnpm-lock.yaml at site root \u2014 run convert-to-pnpm first"
     };
   }
-  const pkgPath = join16(site.path, "package.json");
+  const pkgPath = join17(site.path, "package.json");
   const pkg = await readPackageJson(pkgPath);
   const toAdd = [];
   if (!isDeclared(pkg, PACKAGE_NAME)) {
@@ -2221,7 +2308,7 @@ import { resolve as resolve8 } from "path";
 
 // src/recipes/svelte-codemods.ts
 import { writeFile as writeFile8 } from "fs/promises";
-import { join as join17 } from "path";
+import { join as join18 } from "path";
 function siteLabel11(site) {
   return site.name ?? site.path;
 }
@@ -2243,7 +2330,7 @@ async function svelteCodemods(site) {
   const branch = branchName("svelte-codemods");
   await createBranch(site.path, branch);
   for (const c of changes) {
-    await writeFile8(join17(site.path, c.rel), c.after, "utf-8");
+    await writeFile8(join18(site.path, c.rel), c.after, "utf-8");
   }
   const sha = await commit(
     site.path,
@@ -2285,10 +2372,10 @@ async function runSvelteCodemodsCommand(site, opts) {
 
 // src/cli/version.ts
 import { readFileSync as readFileSync2 } from "fs";
-import { join as join18 } from "path";
+import { join as join19 } from "path";
 function resolvePackageVersion(fromDir) {
   try {
-    const raw = readFileSync2(join18(fromDir, "..", "..", "package.json"), "utf-8");
+    const raw = readFileSync2(join19(fromDir, "..", "..", "package.json"), "utf-8");
     const pkg = JSON.parse(raw);
     return pkg.version ?? "unknown";
   } catch {