@reddb-io/sdk 1.10.0 → 1.11.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reddb-io/sdk",
-  "version": "1.10.0",
+  "version": "1.11.0",
   "description": "Official embedded RedDB SDK — launches a local red binary over stdio JSON-RPC. Use @reddb-io/client for remote HTTP, gRPC, and RedWire.",
   "type": "module",
   "main": "src/index.js",
@@ -45,6 +45,6 @@
   },
   "scripts": {
     "postinstall": "node postinstall.js",
-    "test": "node --test test/ask.test.mjs test/cache.test.mjs test/db-helpers.test.mjs test/embedded-only.test.mjs test/helpers.test.mjs test/insert-ids.test.mjs test/kv.test.mjs test/params.test.mjs test/postinstall.test.mjs test/queue.test.mjs test/redwire.params.test.mjs test/transaction.test.mjs && node test/smoke.test.mjs && node test/conformance.test.mjs && node test/readme-examples.test.mjs"
+    "test": "node --test test/ask.test.mjs test/cache.test.mjs test/db-helpers.test.mjs test/embedded-only.test.mjs test/helpers.test.mjs test/insert-ids.test.mjs test/kv.test.mjs test/params.test.mjs test/postinstall.test.mjs test/queue.test.mjs test/redwire.params.test.mjs test/transaction.test.mjs test/url.test.mjs && node test/smoke.test.mjs && node test/conformance.test.mjs && node test/readme-examples.test.mjs"
   }
 }

package/src/url.js

@@ -153,17 +153,31 @@ export function parseLegacyUrl(uri) {
     || uri.startsWith('reds://')
   ) {
     const scheme = uri.split('://', 1)[0]
-    const stripped = uri.slice(`${scheme}://`.length)
-    const [hostPort] = stripped.split(/[/?]/, 1)
-    const [host, portStr] = hostPort.split(':')
-    if (!host) {
+    let parsed
+    try {
+      // Borrow the URL parser via an `https://` authority so userinfo /
+      // host / port / query all decode with the standard rules — a naive
+      // `hostPort.split(':')` breaks on `reds://user:pass@host:5050`
+      // (host becomes `user`, port NaN).
+      parsed = new URL('https://' + uri.slice(`${scheme}://`.length))
+    } catch (err) {
+      throw new RedDBError('UNPARSEABLE_URI', `failed to parse '${uri}': ${err.message}`)
+    }
+    if (!parsed.hostname) {
       throw new TypeError(`invalid ${scheme}:// URI: missing host in '${uri}'`)
     }
-    const legacyKind = scheme === 'reds' ? 'reds' : scheme === 'grpcs' ? 'grpcs' : scheme === 'grpc' ? 'grpc' : 'red'
+    const legacyKind = scheme === 'reds' ? 'reds' : scheme === 'grpcs' ? 'grpcs' : 'grpc'
+    const params = parsed.searchParams
     return {
       kind: legacyKind,
-      host,
-      port: portStr ? Number(portStr) : defaultPortFor(legacyKind),
+      host: parsed.hostname,
+      port: parsed.port ? Number(parsed.port) : defaultPortFor(legacyKind),
+      username: parsed.username ? decodeURIComponent(parsed.username) : undefined,
+      password: parsed.password ? decodeURIComponent(parsed.password) : undefined,
+      token: params.get('token') ?? undefined,
+      apiKey: params.get('apiKey') ?? params.get('api_key') ?? undefined,
+      loginUrl: params.get('loginUrl') ?? params.get('login_url') ?? undefined,
+      params,
       originalUri: uri,
     }
   }