@recordtimelabel/core 0.6.8 → 0.6.9

package/README.md

@@ -17,10 +17,10 @@ During local development an app can consume a sibling checkout with:
 "@recordtimelabel/core": "file:../recordtimelabel-core"
 ```
 
-For release builds, consume a fixed npm package, git tag, or private registry version so builds do not depend on a sibling folder path. The release target is `0.6.8`; verify that its registry tarball and lockfile integrity are available before updating consumers:
+For release builds, consume a fixed npm package, git tag, or private registry version so builds do not depend on a sibling folder path. The release target is `0.6.9`; verify that its registry tarball and lockfile integrity are available before updating consumers:
 
 ```json
-"@recordtimelabel/core": "0.6.8"
+"@recordtimelabel/core": "0.6.9"
 ```
 
 If this checkout's `package.json` is ahead of the published version, publish the new package before updating consumers to that version.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@recordtimelabel/core",
-  "version": "0.6.8",
+  "version": "0.6.9",
   "type": "module",
   "description": "Shared RecordTimeLabel data model, merge logic, operations, and sync engine.",
   "main": "./src/index.js",

package/src/changefeed.js

@@ -145,6 +145,33 @@ export const applyFirestoreV2ResolvedChangeBatch = ({
   };
   let rootChanged = false;
 
+  // Resolved documents represent the final target revision, not every
+  // intermediate receipt. If an entity is changed and then deleted within
+  // this contiguous batch, its final document correctly does not exist.
+  // Record the final mutation so that specific case can be reduced without
+  // weakening the fail-closed rule for genuinely missing changed documents.
+  const finalMutations = {
+    records: new Map(),
+    folders: new Map(),
+    trash: new Map()
+  };
+  batch.forEach((change, index) => {
+    [
+      ['records', change?.changedRecordIds, 'changed'],
+      ['records', change?.deletedRecordIds, 'deleted'],
+      ['folders', change?.changedFolderIds, 'changed'],
+      ['folders', change?.deletedFolderIds, 'deleted'],
+      ['trash', change?.changedTrashEntryIds, 'changed'],
+      ['trash', change?.deletedTrashEntryIds, 'deleted']
+    ].forEach(([kind, ids, mutation]) => {
+      toIdList(ids).forEach((id) => finalMutations[kind].set(id, {index, mutation}));
+    });
+  });
+  const isShadowedByLaterDelete = (kind, id, index) => {
+    const finalMutation = finalMutations[kind].get(id);
+    return finalMutation?.mutation === 'deleted' && finalMutation.index > index;
+  };
+
   for (let index = 0; index < batch.length; index += 1) {
     const change = batch[index] || {};
     const revision = Number(change.revision || 0);
@@ -193,7 +220,7 @@ export const applyFirestoreV2ResolvedChangeBatch = ({
       ...changedTrash.map((id) => ['trash', id])
     ].some(([kind, id]) => {
       const document = resolvedDocument(resolvedDocuments, kind, id);
-      return document == null;
+      return document == null && !isShadowedByLaterDelete(kind, id, index);
     });
     if (missingChanged) {
       return fail(FIRESTORE_V2_BOOTSTRAP_REASONS.CHANGED_DOCUMENT_MISSING, inputCache);
@@ -211,14 +238,17 @@ export const applyFirestoreV2ResolvedChangeBatch = ({
 
     changedRecords.forEach((id) => {
       const document = resolvedDocument(resolvedDocuments, 'records', id);
+      if (document == null && isShadowedByLaterDelete('records', id, index)) return;
       candidate.documents.records[id] = {id, ...document};
     });
     changedFolders.forEach((id) => {
       const document = resolvedDocument(resolvedDocuments, 'folders', id);
+      if (document == null && isShadowedByLaterDelete('folders', id, index)) return;
       candidate.documents.folders[id] = {id, ...document};
     });
     changedTrash.forEach((id) => {
       const document = resolvedDocument(resolvedDocuments, 'trash', id);
+      if (document == null && isShadowedByLaterDelete('trash', id, index)) return;
       candidate.documents.trash[id] = {id, ...document};
     });
     deletedRecords.forEach((id) => delete candidate.documents.records[id]);

package/src/index.js

@@ -145,7 +145,7 @@ export {
   selectBestMatchingTwitchVod
 };
 
-export const RECORD_TIMELABEL_CORE_VERSION = '0.6.8';
+export const RECORD_TIMELABEL_CORE_VERSION = '0.6.9';
 export const RTL_SYNC_PROTOCOL_VERSION = 2;
 export const RECORD_TIMELABEL_DURABLE_ENGINE_CAPABILITIES = Object.freeze([
   'fifo-retry-fence',