@reconcrap/boss-recommend-mcp 2.0.45 → 2.0.47

package/src/domains/recommend/roots.js

@@ -1,80 +1,80 @@
-import {
-  findIframeDocument,
-  getDocumentRoot,
-  querySelector,
-  sleep
-} from "../../core/browser/index.js";
-import { RECOMMEND_IFRAME_SELECTORS } from "./constants.js";
-
-export async function getRecommendRoots(client, {
-  iframeSelectors = RECOMMEND_IFRAME_SELECTORS,
-  requireFrame = true
-} = {}) {
-  const topRoot = await getDocumentRoot(client);
-  const iframe = await findIframeDocument(client, topRoot.nodeId, iframeSelectors);
-  if (!iframe && requireFrame) {
-    throw new Error("recommendFrame iframe was not found");
-  }
-
-  return {
-    topRoot,
-    iframe,
-    roots: [
-      { name: "top", nodeId: topRoot.nodeId },
-      iframe ? { name: "recommend-frame", nodeId: iframe.documentNodeId } : null
-    ].filter(Boolean),
-    rootNodes: {
-      top: topRoot.nodeId,
-      frame: iframe?.documentNodeId || 0,
-      frameOwner: iframe?.nodeId || 0
-    }
-  };
-}
-
-export async function waitForRecommendRoots(client, {
-  timeoutMs = 10000,
-  intervalMs = 250,
-  iframeSelectors = RECOMMEND_IFRAME_SELECTORS
-} = {}) {
-  const started = Date.now();
-  let lastState = null;
-  while (Date.now() - started <= timeoutMs) {
-    try {
-      lastState = await getRecommendRoots(client, {
-        iframeSelectors,
-        requireFrame: false
-      });
-    } catch (error) {
-      lastState = {
-        error: error?.message || String(error),
-        roots: [],
-        rootNodes: {
-          top: 0,
-          frame: 0,
-          frameOwner: 0
-        }
-      };
-    }
-    if (lastState.iframe?.documentNodeId) return lastState;
-    await sleep(intervalMs);
-  }
-  return lastState;
-}
-
-export async function queryFirstAcrossRoots(client, roots, selectors) {
-  for (const root of roots) {
-    if (!root?.nodeId) continue;
-    for (const selector of selectors) {
-      const nodeId = await querySelector(client, root.nodeId, selector);
-      if (nodeId) {
-        return {
-          root: root.name,
-          root_node_id: root.nodeId,
-          selector,
-          node_id: nodeId
-        };
-      }
-    }
-  }
-  return null;
-}
+import {
+  findIframeDocument,
+  getDocumentRoot,
+  querySelector,
+  sleep
+} from "../../core/browser/index.js";
+import { RECOMMEND_IFRAME_SELECTORS } from "./constants.js";
+
+export async function getRecommendRoots(client, {
+  iframeSelectors = RECOMMEND_IFRAME_SELECTORS,
+  requireFrame = true
+} = {}) {
+  const topRoot = await getDocumentRoot(client);
+  const iframe = await findIframeDocument(client, topRoot.nodeId, iframeSelectors);
+  if (!iframe && requireFrame) {
+    throw new Error("recommendFrame iframe was not found");
+  }
+
+  return {
+    topRoot,
+    iframe,
+    roots: [
+      { name: "top", nodeId: topRoot.nodeId },
+      iframe ? { name: "recommend-frame", nodeId: iframe.documentNodeId } : null
+    ].filter(Boolean),
+    rootNodes: {
+      top: topRoot.nodeId,
+      frame: iframe?.documentNodeId || 0,
+      frameOwner: iframe?.nodeId || 0
+    }
+  };
+}
+
+export async function waitForRecommendRoots(client, {
+  timeoutMs = 10000,
+  intervalMs = 250,
+  iframeSelectors = RECOMMEND_IFRAME_SELECTORS
+} = {}) {
+  const started = Date.now();
+  let lastState = null;
+  while (Date.now() - started <= timeoutMs) {
+    try {
+      lastState = await getRecommendRoots(client, {
+        iframeSelectors,
+        requireFrame: false
+      });
+    } catch (error) {
+      lastState = {
+        error: error?.message || String(error),
+        roots: [],
+        rootNodes: {
+          top: 0,
+          frame: 0,
+          frameOwner: 0
+        }
+      };
+    }
+    if (lastState.iframe?.documentNodeId) return lastState;
+    await sleep(intervalMs);
+  }
+  return lastState;
+}
+
+export async function queryFirstAcrossRoots(client, roots, selectors) {
+  for (const root of roots) {
+    if (!root?.nodeId) continue;
+    for (const selector of selectors) {
+      const nodeId = await querySelector(client, root.nodeId, selector);
+      if (nodeId) {
+        return {
+          root: root.name,
+          root_node_id: root.nodeId,
+          selector,
+          node_id: nodeId
+        };
+      }
+    }
+  }
+  return null;
+}

package/src/domains/recommend/run-service.js

@@ -46,13 +46,14 @@ import {
   screenCandidate
 } from "../../core/screening/index.js";
 import {
-  closeRecommendDetail,
-  createRecommendDetailNetworkRecorder,
-  extractRecommendDetailCandidate,
-  isStaleRecommendNodeError,
-  openRecommendCardDetailWithFreshRetry,
-  waitForRecommendDetailNetworkEvents
-} from "./detail.js";
+  closeRecommendDetail,
+  createRecommendDetailNetworkRecorder,
+  extractRecommendDetailCandidate,
+  isRecommendDetailOpenMissError,
+  isStaleRecommendNodeError,
+  openRecommendCardDetailWithFreshRetry,
+  waitForRecommendDetailNetworkEvents
+} from "./detail.js";
 import {
   readRecommendCardCandidate,
   waitForRecommendCardNodeIds
@@ -416,12 +417,13 @@ export function countRecommendResultStatuses(results = [], {
     detail_open_failed: results.filter((item) => (
       item.error?.code === "DETAIL_STALE_NODE"
       || item.error?.code === "DETAIL_OPEN_FAILED"
-    )).length,
-    transient_recovered: results.filter((item) => (
-      item.error?.code === "DETAIL_STALE_NODE"
-      || item.error?.code === "IMAGE_CAPTURE_STALE_NODE"
-      || item.error?.code === "IMAGE_CAPTURE_TIMEOUT"
-      || item.error?.code === "IMAGE_CAPTURE_TOTAL_TIMEOUT"
+    )).length,
+    transient_recovered: results.filter((item) => (
+      item.error?.code === "DETAIL_STALE_NODE"
+      || item.error?.code === "DETAIL_OPEN_FAILED"
+      || item.error?.code === "IMAGE_CAPTURE_STALE_NODE"
+      || item.error?.code === "IMAGE_CAPTURE_TIMEOUT"
+      || item.error?.code === "IMAGE_CAPTURE_TOTAL_TIMEOUT"
     )).length
   };
 }
@@ -449,15 +451,46 @@ function compactError(error, fallbackCode = "RECOMMEND_RUN_ERROR") {
   if (error.close_result) {
     result.close_result = compactCloseResult(error.close_result);
   }
+  if (error.refresh_attempt) {
+    result.refresh_attempt = error.refresh_attempt;
+  }
+  if (error.list_end_reason) {
+    result.list_end_reason = error.list_end_reason;
+  }
+  if (error.target_count != null) {
+    result.target_count = error.target_count;
+  }
+  if (error.passed_count != null) {
+    result.passed_count = error.passed_count;
+  }
+  if (Array.isArray(error.recommend_detail_open_attempts)) {
+    result.recommend_detail_open_attempts = error.recommend_detail_open_attempts;
+  }
   return result;
 }
 
-function createRecommendCloseFailureError(closeResult) {
-  const error = new Error(closeResult?.reason || "Recommend detail did not close before recovery");
-  error.code = "DETAIL_CLOSE_FAILED";
-  error.close_result = closeResult || null;
-  return error;
-}
+function createRecommendCloseFailureError(closeResult) {
+  const error = new Error(closeResult?.reason || "Recommend detail did not close before recovery");
+  error.code = "DETAIL_CLOSE_FAILED";
+  error.close_result = closeResult || null;
+  return error;
+}
+
+function createRecommendRefreshFailureError(refreshAttempt, {
+  listEndReason = "",
+  targetCount = 0,
+  passedCount = 0
+} = {}) {
+  const reason = refreshAttempt?.reason || "refresh_failed";
+  const detail = refreshAttempt?.error ? `: ${refreshAttempt.error}` : "";
+  const error = new Error(`Recommend refresh failed before target was reached (${reason}${detail})`);
+  error.code = "RECOMMEND_END_REFRESH_FAILED";
+  error.refresh_attempt = refreshAttempt || null;
+  error.list_end_reason = listEndReason || null;
+  error.target_count = targetCount;
+  error.passed_count = passedCount;
+  return error;
+}
 
 export function isRecoverableImageCaptureError(error) {
   const code = String(error?.code || "");
@@ -520,9 +553,9 @@ function createImageCaptureFailureScreening(candidate, error) {
   };
 }
 
-export function isRecoverableRecommendDetailError(error) {
-  return isStaleRecommendNodeError(error);
-}
+export function isRecoverableRecommendDetailError(error) {
+  return isStaleRecommendNodeError(error) || isRecommendDetailOpenMissError(error);
+}
 
 function compactRecoverableDetailError(error) {
   return compactError(error, isStaleRecommendNodeError(error) ? "DETAIL_STALE_NODE" : "DETAIL_OPEN_FAILED");
@@ -532,10 +565,12 @@ function createRecoverableDetailFailureScreening(candidate, error) {
   return {
     status: "fail",
     passed: false,
-    score: 0,
-    reasons: isStaleRecommendNodeError(error)
-      ? ["detail_open_failed", "stale_node"]
-      : ["detail_open_failed"],
+    score: 0,
+    reasons: isStaleRecommendNodeError(error)
+      ? ["detail_open_failed", "stale_node"]
+      : isRecommendDetailOpenMissError(error)
+      ? ["detail_open_failed", "detail_open_miss"]
+      : ["detail_open_failed"],
     error: compactRecoverableDetailError(error),
     candidate
   };
@@ -960,9 +995,9 @@ export async function runRecommendWorkflow({
           refresh_forced_recent_not_view: true,
           list_end_reason: listEndReason
         });
-        if (refreshResult.ok) {
-          rootState = refreshResult.root_state || await getRecommendRoots(client);
-          rootState = await ensureRecommendViewport(rootState, "refresh_after");
+        if (refreshResult.ok) {
+          rootState = refreshResult.root_state || await getRecommendRoots(client);
+          rootState = await ensureRecommendViewport(rootState, "refresh_after");
           cardNodeIds = await waitForRecommendCardNodeIds(client, rootState.iframe.documentNodeId, {
             timeoutMs: cardTimeoutMs,
             intervalMs: 300
@@ -976,12 +1011,17 @@ export async function runRecommendWorkflow({
               forced_recent_not_view: true
             }
           });
-          listEndReason = "";
-          continue;
-        }
-      }
-      break;
-    }
+          listEndReason = "";
+          continue;
+        }
+        throw createRecommendRefreshFailureError(compactRefresh, {
+          listEndReason,
+          targetCount: targetPassCount,
+          passedCount: countPassedResults(results)
+        });
+      }
+      break;
+    }
 
     const index = results.length;
     let cardNodeId = nextCandidateResult.item.node_id;