@reboot-dev/reboot 0.43.0 → 0.44.0

package/package.json

@@ -2,7 +2,7 @@
   "dependencies": {
     "@bufbuild/protoplugin": "1.10.1",
     "@bufbuild/protoc-gen-es": "1.10.1",
-    "@reboot-dev/reboot-api": "0.43.0",
+    "@reboot-dev/reboot-api": "0.44.0",
     "chalk": "^4.1.2",
     "node-addon-api": "^7.0.0",
     "node-gyp": ">=10.2.0",
@@ -22,7 +22,7 @@
   },
   "type": "module",
   "name": "@reboot-dev/reboot",
-  "version": "0.43.0",
+  "version": "0.44.0",
   "description": "npm package for Reboot",
   "scripts": {
     "preinstall": "node preinstall.cjs",

package/reboot_native.cc

@@ -1646,7 +1646,7 @@ Napi::Value Reboot_up(const Napi::CallbackInfo& info) {
 
   py::object* py_application = js_external_application.Value(info.Env()).Data();
 
-  bool local_envoy = false;
+  std::optional<bool> local_envoy;
   if (!info[2].IsUndefined()) {
     local_envoy = info[2].As<Napi::Boolean>();
   }
@@ -1666,6 +1666,10 @@ Napi::Value Reboot_up(const Napi::CallbackInfo& info) {
        py_application,
        local_envoy,
        local_envoy_port]() {
+        py::object py_local_envoy = py::none();
+        if (local_envoy.has_value()) {
+          py_local_envoy = py::bool_(*local_envoy);
+        }
         return py_reboot->attr("up")(
             py_application,
             // NOTE: while we support subprocess servers
@@ -1674,7 +1678,7 @@ Napi::Value Reboot_up(const Napi::CallbackInfo& info) {
             // clone a process like we do with multiprocessing
             // in Python.
             "in_process"_a = true,
-            "local_envoy"_a = local_envoy,
+            "local_envoy"_a = py_local_envoy,
             "local_envoy_port"_a = local_envoy_port);
       },
       [](py::object py_revision) {

package/version.d.ts

@@ -1 +1 @@
-export declare const REBOOT_VERSION = "0.43.0";
+export declare const REBOOT_VERSION = "0.44.0";

package/version.js

@@ -1 +1 @@
-export const REBOOT_VERSION = "0.43.0";
+export const REBOOT_VERSION = "0.44.0";

package/zod-to-proto.js

@@ -114,7 +114,18 @@ const generate = (proto, { schema, path, name, state = false, }) => {
                         console.error(chalk.stderr.bold.red(`Unexpected literal '${literal}' for property '${key}'; only 'string' literals are currently supported`));
                         process.exit(-1);
                     }
-                    proto.write(`${literal} = ${i++};`);
+                    // According to Protobuf `enum` rules:
+                    // `enum` values use C++ scoping rules, meaning that
+                    // `enum` values are siblings of their type, not
+                    // children of it.
+                    // That means we need to prefix the `enum` values
+                    // with the `enum` type name to avoid name conflicts.
+                    // It is safe here, since we preserve the original
+                    // order of the literals and during the conversion
+                    // from Pydantic model to Protobuf and back we
+                    // operate with the indexes of the literals, not
+                    // their names.
+                    proto.write(`${typeName}_${literal} = ${i++};`);
                 }
                 proto.write(`}`);
                 proto.write(`optional ${typeName} ${field} = ${tag};`);