@rebasepro/server-postgres 0.9.1-canary.ad25bc0 → 0.9.1-canary.b10dcdf

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -251,17 +251,32 @@ export async function ensureAuthTablesExist(db: NodePgDatabase, collection?: Col
251
251
  // Seed default roles if none exist
252
252
  // (no-op: roles are now stored inline on the users table)
253
253
 
254
- // ── Migration: Add is_anonymous column (safe for existing tables) ────
255
- await db.execute(sql`
256
- ALTER TABLE ${sql.raw(usersTableName)}
257
- ADD COLUMN IF NOT EXISTS is_anonymous BOOLEAN DEFAULT FALSE
258
- `);
259
-
260
- // ── Migration: Add inline roles column (safe for existing tables) ────
261
- await db.execute(sql`
262
- ALTER TABLE ${sql.raw(usersTableName)}
263
- ADD COLUMN IF NOT EXISTS roles TEXT[] DEFAULT '{}' NOT NULL
264
- `);
254
+ // ── Migration: reconcile the full users column set (safe for existing tables) ──
255
+ // CREATE TABLE IF NOT EXISTS never revisits an existing table, so a
256
+ // database provisioned by an older framework era is missing every
257
+ // column added since. Each column the auth services read or write must
258
+ // be back-filled here, or upgraded deployments break on the first
259
+ // statement that references it. `email` is deliberately absent: it has
260
+ // existed since the first era and cannot be added NOT NULL safely.
261
+ const userColumnBackfills = [
262
+ "display_name VARCHAR(255)",
263
+ "photo_url VARCHAR(500)",
264
+ "roles TEXT[] DEFAULT '{}' NOT NULL",
265
+ "password_hash VARCHAR(255)",
266
+ "email_verified BOOLEAN DEFAULT FALSE NOT NULL",
267
+ "email_verification_token VARCHAR(255)",
268
+ "email_verification_sent_at TIMESTAMP WITH TIME ZONE",
269
+ "is_anonymous BOOLEAN DEFAULT FALSE NOT NULL",
270
+ "metadata JSONB DEFAULT '{}' NOT NULL",
271
+ "created_at TIMESTAMP WITH TIME ZONE DEFAULT NOW() NOT NULL",
272
+ "updated_at TIMESTAMP WITH TIME ZONE DEFAULT NOW() NOT NULL"
273
+ ];
274
+ for (const columnDef of userColumnBackfills) {
275
+ await db.execute(sql`
276
+ ALTER TABLE ${sql.raw(usersTableName)}
277
+ ADD COLUMN IF NOT EXISTS ${sql.raw(columnDef)}
278
+ `);
279
+ }
265
280
 
266
281
  // ── Migration: Copy roles from legacy junction table to inline column ──
267
282
  // If the old rebase.user_roles and rebase.roles tables exist, migrate
@@ -358,6 +373,53 @@ export async function ensureAuthTablesExist(db: NodePgDatabase, collection?: Col
358
373
  ON ${sql.raw(recoveryCodesTableName)}(user_id)
359
374
  `);
360
375
 
376
+ // ── Migration: clear stale FORCE ROW LEVEL SECURITY (older RLS model) ──
377
+ // The current model never emits FORCE: privileged auth writes run as
378
+ // the table owner and rely on the owner bypassing plain ENABLE RLS
379
+ // (see generate-postgres-ddl-logic). A table still carrying FORCE from
380
+ // an older framework era binds the owner too, so the first user
381
+ // registration after an upgrade fails with SQLSTATE 42501. Reconcile
382
+ // on boot; only tables actually flagged get the ALTER (and its lock).
383
+ try {
384
+ const authTablePairs: [string, string][] = [
385
+ [usersSchema, resolvedTable],
386
+ [authSchema, "user_identities"],
387
+ [authSchema, "refresh_tokens"],
388
+ [authSchema, "password_reset_tokens"],
389
+ [authSchema, "app_config"],
390
+ [authSchema, "mfa_factors"],
391
+ [authSchema, "mfa_challenges"],
392
+ [authSchema, "recovery_codes"]
393
+ ];
394
+ for (const [schemaName, tableName] of authTablePairs) {
395
+ const forced = await db.execute(sql`
396
+ SELECT 1
397
+ FROM pg_class c
398
+ JOIN pg_namespace n ON n.oid = c.relnamespace
399
+ WHERE n.nspname = ${schemaName}
400
+ AND c.relname = ${tableName}
401
+ AND c.relforcerowsecurity
402
+ `);
403
+ if (forced.rows.length > 0) {
404
+ await db.execute(sql`
405
+ ALTER TABLE ${sql.raw(`"${schemaName}"."${tableName}"`)}
406
+ NO FORCE ROW LEVEL SECURITY
407
+ `);
408
+ logger.warn(
409
+ `🔧 Cleared stale FORCE ROW LEVEL SECURITY on "${schemaName}"."${tableName}" ` +
410
+ "(legacy RLS model — it binds the owner connection and breaks privileged auth writes)"
411
+ );
412
+ }
413
+ }
414
+ } catch (rlsReconcileError: unknown) {
415
+ // Non-fatal: the connection may lack ownership on a pre-provisioned
416
+ // table; registration will still fail loudly (42501) if FORCE remains.
417
+ logger.warn(
418
+ `⚠️ Could not reconcile FORCE ROW LEVEL SECURITY on auth tables: ` +
419
+ `${rlsReconcileError instanceof Error ? rlsReconcileError.message : String(rlsReconcileError)}`
420
+ );
421
+ }
422
+
361
423
  logger.info("✅ Auth tables ready");
362
424
  } catch (error) {
363
425
  logger.error("❌ Failed to create auth tables", { error });
@@ -82,6 +82,32 @@ export class UserService implements UserRepository {
82
82
  return `"${schema}"."${name}"`;
83
83
  }
84
84
 
85
+ /**
86
+ * Run a privileged auth write with an explicitly cleared RLS context.
87
+ *
88
+ * The auth services run on the base/owner connection, which by design
89
+ * carries a NULL `app.user_id` so the `auth.uid() IS NULL` server-escape
90
+ * in the default policies applies. That NULL is normally guaranteed by
91
+ * `set_config(..., is_local = true)` resetting at transaction end — but a
92
+ * GUC that survives on a pooled connection (or a connection role that
93
+ * doesn't bypass RLS: FORCE ROW LEVEL SECURITY, or a non-owner role)
94
+ * turns the trusted write into an RLS-scoped one and denies it with
95
+ * SQLSTATE 42501. Clearing the GUCs here, transaction-locally at the
96
+ * single chokepoint, makes the server context deterministic instead of
97
+ * trusting whatever state the pool hands us. `auth.uid()` reads '' as
98
+ * NULL via NULLIF, so '' is the server context.
99
+ */
100
+ private async withServerContext<T>(fn: (db: NodePgDatabase) => Promise<T>): Promise<T> {
101
+ return await this.db.transaction(async (tx) => {
102
+ await tx.execute(sql`
103
+ SELECT set_config('app.user_id', '', true),
104
+ set_config('app.user_roles', '', true),
105
+ set_config('app.jwt', '', true)
106
+ `);
107
+ return await fn(tx as unknown as NodePgDatabase);
108
+ });
109
+ }
110
+
85
111
  private mapRowToUser(row: Record<string, unknown>): UserData {
86
112
  if (!row) return row as UserData;
87
113
 
@@ -200,7 +226,9 @@ export class UserService implements UserRepository {
200
226
 
201
227
  async createUser(data: CreateUserData): Promise<UserData> {
202
228
  const payload = this.mapPayload(data);
203
- const [row] = (await this.db.insert(this.usersTable).values(payload).returning()) as Record<string, unknown>[];
229
+ const [row] = await this.withServerContext(async (db) =>
230
+ (await db.insert(this.usersTable).values(payload).returning()) as Record<string, unknown>[]
231
+ );
204
232
  return this.mapRowToUser(row);
205
233
  }
206
234
 
@@ -255,12 +283,12 @@ export class UserService implements UserRepository {
255
283
  }
256
284
 
257
285
  async linkUserIdentity(userId: string, provider: string, providerId: string, profileData?: Record<string, unknown>): Promise<void> {
258
- await this.db.insert(this.userIdentitiesTable).values({
286
+ await this.withServerContext(async (db) => db.insert(this.userIdentitiesTable).values({
259
287
  userId,
260
288
  provider,
261
289
  providerId,
262
290
  profileData: profileData || null
263
- }).onConflictDoNothing({ target: [this.userIdentitiesTable.provider, this.userIdentitiesTable.providerId] });
291
+ }).onConflictDoNothing({ target: [this.userIdentitiesTable.provider, this.userIdentitiesTable.providerId] }));
264
292
  }
265
293
 
266
294
  async updateUser(id: string, data: Partial<Omit<CreateUserData, "id">>): Promise<UserData | null> {
@@ -270,18 +298,20 @@ export class UserService implements UserRepository {
270
298
  const updatedAtKey = getColumnKey(this.usersTable, "updatedAt", "updated_at") || "updatedAt";
271
299
  payload[updatedAtKey] = new Date();
272
300
 
273
- const [row] = (await this.db
274
- .update(this.usersTable)
275
- .set(payload)
276
- .where(eq(idCol, id))
277
- .returning()) as Record<string, unknown>[];
301
+ const [row] = await this.withServerContext(async (db) =>
302
+ (await db
303
+ .update(this.usersTable)
304
+ .set(payload)
305
+ .where(eq(idCol, id))
306
+ .returning()) as Record<string, unknown>[]
307
+ );
278
308
  return row ? this.mapRowToUser(row) : null;
279
309
  }
280
310
 
281
311
  async deleteUser(id: string): Promise<void> {
282
312
  const idCol = getColumn(this.usersTable, "id");
283
313
  if (!idCol) return;
284
- await this.db.delete(this.usersTable).where(eq(idCol, id));
314
+ await this.withServerContext(async (db) => db.delete(this.usersTable).where(eq(idCol, id)));
285
315
  }
286
316
 
287
317
  async listUsers(): Promise<UserData[]> {
@@ -357,13 +387,13 @@ export class UserService implements UserRepository {
357
387
  const passwordHashColKey = getColumnKey(this.usersTable, "passwordHash", "password_hash") || "passwordHash";
358
388
  const updatedAtColKey = getColumnKey(this.usersTable, "updatedAt", "updated_at") || "updatedAt";
359
389
 
360
- await this.db
390
+ await this.withServerContext(async (db) => db
361
391
  .update(this.usersTable)
362
392
  .set({
363
393
  [passwordHashColKey]: passwordHash,
364
394
  [updatedAtColKey]: new Date()
365
395
  })
366
- .where(eq(idCol, id));
396
+ .where(eq(idCol, id)));
367
397
  }
368
398
 
369
399
  /**
@@ -376,14 +406,14 @@ export class UserService implements UserRepository {
376
406
  const emailVerificationTokenColKey = getColumnKey(this.usersTable, "emailVerificationToken", "email_verification_token") || "emailVerificationToken";
377
407
  const updatedAtColKey = getColumnKey(this.usersTable, "updatedAt", "updated_at") || "updatedAt";
378
408
 
379
- await this.db
409
+ await this.withServerContext(async (db) => db
380
410
  .update(this.usersTable)
381
411
  .set({
382
412
  [emailVerifiedColKey]: verified,
383
413
  [emailVerificationTokenColKey]: null,
384
414
  [updatedAtColKey]: new Date()
385
415
  })
386
- .where(eq(idCol, id));
416
+ .where(eq(idCol, id)));
387
417
  }
388
418
 
389
419
  /**
@@ -396,14 +426,14 @@ export class UserService implements UserRepository {
396
426
  const emailVerificationSentAtColKey = getColumnKey(this.usersTable, "emailVerificationSentAt", "email_verification_sent_at") || "emailVerificationSentAt";
397
427
  const updatedAtColKey = getColumnKey(this.usersTable, "updatedAt", "updated_at") || "updatedAt";
398
428
 
399
- await this.db
429
+ await this.withServerContext(async (db) => db
400
430
  .update(this.usersTable)
401
431
  .set({
402
432
  [emailVerificationTokenColKey]: token,
403
433
  [emailVerificationSentAtColKey]: token ? new Date() : null,
404
434
  [updatedAtColKey]: new Date()
405
435
  })
406
- .where(eq(idCol, id));
436
+ .where(eq(idCol, id)));
407
437
  }
408
438
 
409
439
  /**
@@ -463,11 +493,11 @@ export class UserService implements UserRepository {
463
493
  async setUserRoles(userId: string, roleIds: string[]): Promise<void> {
464
494
  const usersTableName = this.getQualifiedUsersTableName();
465
495
  const rolesArray = `{${roleIds.join(",")}}`;
466
- await this.db.execute(sql`
496
+ await this.withServerContext(async (db) => db.execute(sql`
467
497
  UPDATE ${sql.raw(usersTableName)}
468
498
  SET roles = ${rolesArray}::text[], updated_at = NOW()
469
499
  WHERE id = ${userId}
470
- `);
500
+ `));
471
501
  }
472
502
 
473
503
  /**
@@ -475,11 +505,11 @@ export class UserService implements UserRepository {
475
505
  */
476
506
  async assignDefaultRole(userId: string, roleId: string): Promise<void> {
477
507
  const usersTableName = this.getQualifiedUsersTableName();
478
- await this.db.execute(sql`
508
+ await this.withServerContext(async (db) => db.execute(sql`
479
509
  UPDATE ${sql.raw(usersTableName)}
480
510
  SET roles = array_append(roles, ${roleId}), updated_at = NOW()
481
511
  WHERE id = ${userId} AND NOT (${roleId} = ANY(roles))
482
- `);
512
+ `));
483
513
  }
484
514
 
485
515
  /**
@@ -0,0 +1,59 @@
1
+ import { isTable, getTableName, Relations } from "drizzle-orm";
2
+ import { PgEnum, PgTable } from "drizzle-orm/pg-core";
3
+ import { CollectionConfig } from "@rebasepro/types";
4
+ import { logger } from "@rebasepro/server";
5
+ import { PostgresCollectionRegistry } from "./PostgresCollectionRegistry";
6
+ import { warnOnKeysTheAdminCannotResolve } from "../services/collection-helpers";
7
+
8
+ /**
9
+ * Everything a registry is built from: the collections, and the drizzle schema
10
+ * they are backed by. In BaaS mode all of it is introspected from the live
11
+ * database; in CMS mode it comes from the config and the generated schema.
12
+ */
13
+ export interface RegistrySchema {
14
+ collections?: CollectionConfig[];
15
+ tables?: Record<string, unknown>;
16
+ enums?: Record<string, PgEnum<[string, ...string[]]>>;
17
+ relations?: Record<string, Relations>;
18
+ }
19
+
20
+ /**
21
+ * Build the collection registry for a driver.
22
+ *
23
+ * The order matters and is the reason this is one function rather than a run of
24
+ * statements in the bootstrapper. Keys are resolved from the drizzle schema, so
25
+ * anything that inspects them has to run *after* the tables are registered —
26
+ * and `warnOnKeysTheAdminCannotResolve` fails open if it does not, because a
27
+ * collection whose table it cannot look up is one it has nothing to say about.
28
+ * Warned too early, it would skip every collection and report nothing, which
29
+ * reads exactly like having nothing to report.
30
+ */
31
+ export function buildCollectionRegistry(schema: RegistrySchema): PostgresCollectionRegistry {
32
+ const registry = new PostgresCollectionRegistry();
33
+
34
+ if (schema.collections) {
35
+ registry.registerMultiple(schema.collections);
36
+ logger.info(
37
+ `📋 [PostgresRegistry] Registered ${registry.getCollections().length} collections: ` +
38
+ `[${registry.getCollections().map(c => c.slug).join(", ")}]`
39
+ );
40
+ }
41
+
42
+ if (schema.tables) {
43
+ Object.values(schema.tables).forEach((table) => {
44
+ if (isTable(table)) {
45
+ registry.registerTable(table as PgTable, getTableName(table));
46
+ }
47
+ });
48
+ }
49
+
50
+ if (schema.enums) registry.registerEnums(schema.enums);
51
+ if (schema.relations) registry.registerRelations(schema.relations);
52
+
53
+ // Now that the keys resolve: say which of them the admin cannot see. It
54
+ // compiles the same collection files into its bundle but never the drizzle
55
+ // schema, and nothing serves it one, so only an edit to the config fixes it.
56
+ warnOnKeysTheAdminCannotResolve(registry.getCollections(), registry);
57
+
58
+ return registry;
59
+ }
package/src/connection.ts CHANGED
@@ -27,11 +27,68 @@ const DEFAULT_POOL: Required<PostgresPoolConfig> = {
27
27
  max: 20,
28
28
  idleTimeoutMillis: 30_000,
29
29
  connectionTimeoutMillis: 10_000,
30
- queryTimeout: 30_000,
30
+ // The client-side read timeout MUST be comfortably above the server-side
31
+ // statement_timeout. When the client timer fires first, node-postgres
32
+ // abandons the in-flight statement but keeps the connection — inside a
33
+ // transaction that leaves the tx open (and any pending ROLLBACK is
34
+ // spliced out of the client queue before it ever reaches the wire), so
35
+ // the pooled connection is returned still in-transaction with its RLS
36
+ // GUCs set. The server abort (SQLSTATE 57014) is the clean path; the
37
+ // client timeout is only a backstop for a dead network.
38
+ queryTimeout: 60_000,
31
39
  statementTimeout: 30_000,
32
40
  keepAlive: true
33
41
  };
34
42
 
43
+ /** ReadyForQuery status byte: `I` idle, `T` in transaction, `E` failed transaction. */
44
+ const TX_IDLE = "I";
45
+
46
+ /**
47
+ * Destroy pool clients that are released while still inside a transaction.
48
+ *
49
+ * pg-pool returns a client to the idle list whenever `release()` is called
50
+ * without an error — even if the connection is still mid-transaction (status
51
+ * `T`/`E`). That happens in practice: drizzle's pool transaction releases in
52
+ * a `finally` after attempting ROLLBACK, and if the ROLLBACK itself fails
53
+ * (e.g. it was queued behind a statement that hit the client-side
54
+ * query_timeout), the client goes back dirty. The next checkout then runs
55
+ * its statements inside the zombie transaction — with the previous request's
56
+ * `app.*` RLS GUCs still applied, which turns unrelated queries into
57
+ * RLS-scoped ones (observed in production as registration failing with
58
+ * SQLSTATE 42501 under a leaked anonymous context).
59
+ *
60
+ * pg-pool emits `release` before it consults its private `_expired` set, so
61
+ * marking the client expired here makes `_release()` destroy it instead of
62
+ * pooling it. Both `client._txStatus` (pg ≥ 8.16) and `pool._expired` are
63
+ * private APIs — feature-detect and fall back to loud logging so an upstream
64
+ * change degrades to observability, never to silent corruption.
65
+ */
66
+ export function guardPoolAgainstDirtyRelease(pool: Pool, label: string): void {
67
+ pool.on("release", (err: Error | undefined, client: unknown) => {
68
+ if (err) return; // errored clients are already destroyed by pg-pool
69
+ const txStatus = (client as { _txStatus?: string | null })?._txStatus;
70
+ if (typeof txStatus !== "string" || txStatus === TX_IDLE) return;
71
+
72
+ // pg-pool keeps expired clients in a WeakSet (a plain object works too
73
+ // if upstream ever changes it — duck-type on add/has).
74
+ const expired = (pool as unknown as { _expired?: { add(c: object): unknown; has(c: object): boolean } })._expired;
75
+ if (expired && typeof expired.add === "function" && typeof expired.has === "function" && client && typeof client === "object") {
76
+ expired.add(client);
77
+ logger.error(
78
+ `[${label}] Client released back to the pool while still in a transaction ` +
79
+ `(status '${txStatus}') — destroying it so the open transaction and its ` +
80
+ `session state (RLS GUCs) cannot leak into the next request.`
81
+ );
82
+ } else {
83
+ logger.error(
84
+ `[${label}] Client released mid-transaction (status '${txStatus}') but the ` +
85
+ `pool's internal expiry set is unavailable (pg-pool internals changed?). ` +
86
+ `The connection may leak its open transaction into subsequent requests.`
87
+ );
88
+ }
89
+ });
90
+ }
91
+
35
92
  /**
36
93
  * Create a Drizzle-backed Postgres connection with a production-grade
37
94
  * connection pool.
@@ -75,6 +132,7 @@ export function createPostgresDatabaseConnection(
75
132
  logger.warn("[pg-pool] Connection timeout detected — pool will auto-retry");
76
133
  }
77
134
  });
135
+ guardPoolAgainstDirtyRelease(pool, "pg-pool");
78
136
 
79
137
  // Create drizzle instance — pass schema when available to enable db.query relational API
80
138
  const db = schema ? drizzle(pool, { schema }) : drizzle(pool);
@@ -118,6 +176,7 @@ export function createDirectDatabaseConnection(
118
176
  pool.on("error", (err) => {
119
177
  logger.error("[pg-direct-pool] Unexpected pool error", { detail: err.message });
120
178
  });
179
+ guardPoolAgainstDirtyRelease(pool, "pg-direct-pool");
121
180
 
122
181
  const db = schema ? drizzle(pool, { schema }) : drizzle(pool);
123
182
 
@@ -157,6 +216,7 @@ export function createReadReplicaConnection(
157
216
  pool.on("error", (err) => {
158
217
  logger.error("[pg-replica-pool] Unexpected pool error", { detail: err.message });
159
218
  });
219
+ guardPoolAgainstDirtyRelease(pool, "pg-replica-pool");
160
220
 
161
221
  const db = schema ? drizzle(pool, { schema }) : drizzle(pool);
162
222
 
@@ -20,12 +20,19 @@ import { logger } from "@rebasepro/server";
20
20
  export interface SerializedEntityData {
21
21
  /** Scalar column values ready for INSERT/UPDATE. */
22
22
  scalarData: Record<string, unknown>;
23
- /** Inverse relation updates that must be applied to target tables. */
23
+ /**
24
+ * Inverse relation updates that must be applied to target tables.
25
+ *
26
+ * No address here: the row being written does not know its own. These are
27
+ * applied by `PersistService`, which addresses them with the id it holds —
28
+ * the one it was given for an update, or the one the INSERT returned — and
29
+ * that is the authority. This item used to carry a `currentId` derived from
30
+ * the *input* values, which nothing ever read.
31
+ */
24
32
  inverseRelationUpdates: Array<{
25
33
  relationKey: string;
26
34
  relation: Relation;
27
35
  newValue: unknown;
28
- currentId?: string | number;
29
36
  }>;
30
37
  /** JoinPath relation updates that require multi-hop writes. */
31
38
  joinPathRelationUpdates: Array<{
@@ -105,7 +112,6 @@ joinPathRelationUpdates: [] };
105
112
  relationKey: string;
106
113
  relation: Relation;
107
114
  newValue: unknown;
108
- currentId?: string | number;
109
115
  }> = [];
110
116
  const joinPathRelationUpdates: Array<{
111
117
  relationKey: string;
@@ -146,12 +152,10 @@ joinPathRelationUpdates: [] };
146
152
  } else if (relation.direction === "inverse" && relation.foreignKeyOnTarget) {
147
153
  // Inverse relation: Need to update the target table's FK
148
154
  const serializedValue = serializePropertyToServer(effectiveValue, property);
149
- const pks = getPrimaryKeys(collection, registry!);
150
155
  inverseRelationUpdates.push({
151
156
  relationKey: key,
152
157
  relation,
153
- newValue: serializedValue,
154
- currentId: (row.id as string | number | undefined) || buildCompositeId(row, pks)
158
+ newValue: serializedValue
155
159
  });
156
160
  // Don't add the original relation property to the result
157
161
  continue;
@@ -170,12 +174,10 @@ joinPathRelationUpdates: [] };
170
174
  });
171
175
  } else {
172
176
  // Many inverse joinPath: capture as inverse relation update
173
- const pks = getPrimaryKeys(collection, registry!);
174
177
  inverseRelationUpdates.push({
175
178
  relationKey: key,
176
179
  relation,
177
- newValue: serializedValue,
178
- currentId: (row.id as string | number | undefined) || buildCompositeId(row, pks)
180
+ newValue: serializedValue
179
181
  });
180
182
  }
181
183
  // Don't add the original relation property to the result
@@ -2,6 +2,7 @@ import { Pool } from "pg";
2
2
  import { drizzle } from "drizzle-orm/node-postgres";
3
3
  import { NodePgDatabase } from "drizzle-orm/node-postgres";
4
4
  import { logger } from "@rebasepro/server";
5
+ import { guardPoolAgainstDirtyRelease } from "./connection";
5
6
 
6
7
  export class DatabasePoolManager {
7
8
  private pools: Map<string, Pool> = new Map();
@@ -50,6 +51,7 @@ export class DatabasePoolManager {
50
51
  pool.on("error", (err) => {
51
52
  logger.error(`[DatabasePoolManager] Unexpected error on idle client for db ${databaseName}`, { error: err });
52
53
  });
54
+ guardPoolAgainstDirtyRelease(pool, `pg-pool:${databaseName}`);
53
55
 
54
56
  this.pools.set(databaseName, pool);
55
57
  return pool;
@@ -1,6 +1,6 @@
1
1
  import { CollectionConfig, NumberProperty, Property, Relation, RelationProperty, SecurityOperation, SecurityRule, StringProperty, isPostgresCollectionConfig, DateProperty, ArrayProperty, MapProperty, ReferenceProperty, VectorProperty, BinaryProperty } from "@rebasepro/types";
2
2
  import { getPrimaryKeys } from "../services/collection-helpers";
3
- import { getEnumVarName, getTableName, getTableVarName, resolveCollectionRelations, findRelation, securityRuleToConditions, policyToPostgres, getEffectiveSecurityRules } from "@rebasepro/common";
3
+ import { getEnumVarName, getTableName, getTableVarName, resolveCollectionRelations, findRelation, securityRuleToConditions, policyToPostgres, getEffectiveSecurityRules, resolveJunctionSpecs, getJunctionSecurityRules, getJunctionCollectionConfig } from "@rebasepro/common";
4
4
  import { toSnakeCase, getPolicyNamesForRule } from "@rebasepro/utils";
5
5
  import { logger } from "@rebasepro/server";
6
6
  // --- Helper Functions ---
@@ -545,6 +545,10 @@ export const generateSchema = async (collections: CollectionConfig[], stripPolic
545
545
  });
546
546
  schemaContent += "\n";
547
547
 
548
+ // Junction policy derivation needs every declaring side of each junction,
549
+ // not just the first relation that reached it in the walk below.
550
+ const junctionSpecs = resolveJunctionSpecs(collections);
551
+
548
552
  // 2. Identify all tables (collections and junction tables only)
549
553
  for (const collection of collections) {
550
554
  const tableName = getTableName(collection);
@@ -601,9 +605,22 @@ export const generateSchema = async (collections: CollectionConfig[], stripPolic
601
605
  schemaContent += `export const ${tableVarName} = ${tableCreator}(\"${baseTableName}\", {\n`;
602
606
  schemaContent += ` ${sourceColumn}: ${sourceColType}(\"${sourceColumn}\").notNull().references(() => ${getTableVarName(getTableName(sourceCollection))}.${sourceId}, ${refOptions}),\n`;
603
607
  schemaContent += ` ${targetColumn}: ${targetColType}(\"${targetColumn}\").notNull().references(() => ${getTableVarName(getTableName(targetCollection))}.${targetId}, ${refOptions}),\n`;
604
- schemaContent += "}, (table) => ({\n";
605
- schemaContent += ` pk: primaryKey({ columns: [table.${sourceColumn}, table.${targetColumn}] })\n`;
606
- schemaContent += "}));\n\n";
608
+ schemaContent += "}, (table) => ([\n";
609
+ schemaContent += ` primaryKey({ columns: [table.${sourceColumn}, table.${targetColumn}] }),\n`;
610
+
611
+ // Junctions are generated tables like any other: locked by default,
612
+ // with derived policies (reads follow the endpoints, writes follow
613
+ // the declaring side's update rules). RLS is enabled regardless of
614
+ // policy stripping — a bare junction must default-deny, not fail open.
615
+ const junctionSpec = junctionSpecs.get(baseTableName);
616
+ if (!stripPolicies && junctionSpec) {
617
+ const junctionCollection = getJunctionCollectionConfig(junctionSpec);
618
+ const resolveCollection: ResolveCollection = (slug) => collections.find(c => c.slug === slug || getTableName(c) === slug);
619
+ getJunctionSecurityRules(junctionSpec).forEach((rule: SecurityRule, idx: number) => {
620
+ schemaContent += generatePolicyCode(junctionCollection, rule, idx, resolveCollection);
621
+ });
622
+ }
623
+ schemaContent += "])).enableRLS();\n\n";
607
624
  } else if (!isJunction) {
608
625
  const schema = isPostgresCollectionConfig(collection) ? collection.schema : undefined;
609
626
  const tableCreator = schema ? `${schema}Schema.table` : "pgTable";
@@ -1,5 +1,5 @@
1
1
  import { CollectionConfig, NumberProperty, Property, Relation, RelationProperty, SecurityOperation, SecurityRule, StringProperty, isPostgresCollectionConfig, DateProperty, ArrayProperty, MapProperty, ReferenceProperty, VectorProperty, BinaryProperty } from "@rebasepro/types";
2
- import { getEnumVarName, getTableName, resolveCollectionRelations, findRelation, securityRuleToConditions, policyToPostgres, getEffectiveSecurityRules, getInjectedSecurityRules } from "@rebasepro/common";
2
+ import { getEnumVarName, getTableName, resolveCollectionRelations, findRelation, securityRuleToConditions, policyToPostgres, getEffectiveSecurityRules, getInjectedSecurityRules, resolveJunctionSpecs, getJunctionSecurityRules, getJunctionCollectionConfig } from "@rebasepro/common";
3
3
  import { toSnakeCase, getPolicyNamesForRule } from "@rebasepro/utils";
4
4
 
5
5
  // --- Helper Functions ---
@@ -226,6 +226,10 @@ export const generatePostgresDdl = async (
226
226
  });
227
227
  if (ddl.endsWith(";\n")) ddl += "\n";
228
228
 
229
+ // Junction policy derivation needs every declaring side of each junction,
230
+ // not just the first relation that reached it in the walk below.
231
+ const junctionSpecs = resolveJunctionSpecs(collections);
232
+
229
233
  const allTablesToGenerate = new Map<string, {
230
234
  collection: CollectionConfig,
231
235
  isJunction?: boolean,
@@ -261,6 +265,11 @@ export const generatePostgresDdl = async (
261
265
 
262
266
  // 3. Generate tables
263
267
  const fkStatements: string[] = [];
268
+ // Policies are emitted after every CREATE TABLE, like the FK constraints:
269
+ // a policy may reference other tables (a junction's derived policies always
270
+ // reference both endpoints; `policy.existsIn` references a join table), and
271
+ // CREATE POLICY validates those relations at creation time.
272
+ const policyStatements: string[] = [];
264
273
  for (const [tableName, {
265
274
  collection,
266
275
  isJunction,
@@ -293,6 +302,25 @@ export const generatePostgresDdl = async (
293
302
 
294
303
  fkStatements.push(`ALTER TABLE "${schema}"."${baseTableName}" ADD CONSTRAINT "${baseTableName}_${sourceColumn}_fkey" FOREIGN KEY ("${sourceColumn}") REFERENCES "${sourceSchema}"."${sourceTable}" ("${sourceId}") ON DELETE ${onDelete.toUpperCase()};`);
295
304
  fkStatements.push(`ALTER TABLE "${schema}"."${baseTableName}" ADD CONSTRAINT "${baseTableName}_${targetColumn}_fkey" FOREIGN KEY ("${targetColumn}") REFERENCES "${targetSchema}"."${targetTable}" ("${targetId}") ON DELETE ${onDelete.toUpperCase()};`);
305
+
306
+ if (options.includePolicies) {
307
+ // Junction tables are generated tables like any other: locked by
308
+ // default, with derived policies — reads follow the endpoints'
309
+ // visibility, writes follow the declaring side's update rules.
310
+ // Without this they were the one kind of generated table with no
311
+ // RLS at all, readable and writable by every signed-in user.
312
+ ddl += `ALTER TABLE "${schema}"."${baseTableName}" ENABLE ROW LEVEL SECURITY;\n`;
313
+ ddl += `\n`;
314
+
315
+ const spec = junctionSpecs.get(baseTableName);
316
+ if (spec) {
317
+ const junctionCollection = getJunctionCollectionConfig(spec);
318
+ const resolveCollection: ResolveCollection = (slug) => collections.find(c => c.slug === slug || getTableName(c) === slug);
319
+ getJunctionSecurityRules(spec).forEach((rule: SecurityRule) => {
320
+ policyStatements.push(generatePolicyDdl(junctionCollection, rule, resolveCollection));
321
+ });
322
+ }
323
+ }
296
324
  } else if (!isJunction) {
297
325
  ddl += `CREATE TABLE "${schema}"."${baseTableName}" (\n`;
298
326
  const columns: string[] = [];
@@ -414,9 +442,8 @@ export const generatePostgresDdl = async (
414
442
  if (securityRules.length > 0) {
415
443
  const resolveCollection: ResolveCollection = (slug) => collections.find(c => c.slug === slug || getTableName(c) === slug);
416
444
  securityRules.forEach((rule: SecurityRule) => {
417
- ddl += generatePolicyDdl(collection, rule, resolveCollection);
445
+ policyStatements.push(generatePolicyDdl(collection, rule, resolveCollection));
418
446
  });
419
- ddl += "\n";
420
447
  }
421
448
  }
422
449
  }
@@ -427,6 +454,12 @@ export const generatePostgresDdl = async (
427
454
  ddl += fkStatements.join("\n") + "\n\n";
428
455
  }
429
456
 
457
+ if (policyStatements.length > 0) {
458
+ ddl += "-- Row Level Security Policies\n";
459
+ ddl += policyStatements.join("");
460
+ ddl += "\n";
461
+ }
462
+
430
463
  return ddl;
431
464
  };
432
465
 
@@ -473,6 +506,33 @@ export const generatePostgresPoliciesDdl = (collections: CollectionConfig[]): st
473
506
  }
474
507
  }
475
508
 
509
+ // Junction tables are generated from `through` relations, not declared as
510
+ // collections, so the walk above never sees them. They get the same
511
+ // treatment as any generated table: locked by default, with derived
512
+ // policies — reads follow the endpoints, writes follow the declaring
513
+ // side's update rules.
514
+ const junctionSpecs = resolveJunctionSpecs(collections);
515
+ for (const spec of junctionSpecs.values()) {
516
+ ddl += `ALTER TABLE "${spec.schema}"."${spec.table}" ENABLE ROW LEVEL SECURITY;\n`;
517
+ ddl += `\n`;
518
+
519
+ const junctionRules = getJunctionSecurityRules(spec);
520
+ if (junctionRules.length === 0) continue;
521
+
522
+ const junctionCollection = getJunctionCollectionConfig(spec);
523
+ const resolveCollection: ResolveCollection = (slug) => collections.find(c => c.slug === slug || getTableName(c) === slug);
524
+ const declaringSlugs = spec.declaringSides.map(s => s.collection.slug).join('", "');
525
+
526
+ ddl += `-- Derived by Rebase for the junction "${spec.table}" (no collection declares it).\n`;
527
+ ddl += `-- Reads require both endpoint rows to be visible; writes follow the update\n`;
528
+ ddl += `-- rules of "${declaringSlugs}". Set \`disableDefaultPolicies: true\` on the\n`;
529
+ ddl += `-- declaring collection(s) to drop these and police the junction yourself.\n`;
530
+ junctionRules.forEach((rule: SecurityRule) => {
531
+ ddl += generatePolicyDdl(junctionCollection, rule, resolveCollection);
532
+ });
533
+ ddl += "\n";
534
+ }
535
+
476
536
  return ddl;
477
537
  };
478
538