@rebasepro/server-postgres 0.9.1-canary.a57c262 → 0.9.1-canary.a639738

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -2,7 +2,7 @@ import { CollectionConfig, Property } from "@rebasepro/types";
2
2
  export type IssueSeverity = "error" | "warning" | "info";
3
3
  export interface DoctorIssue {
4
4
  severity: IssueSeverity;
5
- category: "missing_table" | "missing_column" | "type_mismatch" | "missing_constraint" | "schema_stale" | "missing_enum" | "enum_value_mismatch" | "missing_foreign_key" | "sdk_stale";
5
+ category: "missing_table" | "missing_column" | "type_mismatch" | "missing_constraint" | "schema_stale" | "missing_enum" | "enum_value_mismatch" | "missing_foreign_key" | "sdk_stale" | "sdk_not_generated";
6
6
  table?: string;
7
7
  column?: string;
8
8
  expected?: string;
@@ -63,6 +63,36 @@ export declare function parseExpectedPolicies(ddl: string): PolicyRef[];
63
63
  * of reads. The same blindness would hide a policy that fails open.
64
64
  */
65
65
  export declare function checkPolicyDrift(client: Queryable, collections: CollectionConfig[]): Promise<PolicyDrift>;
66
+ /**
67
+ * Does this name look like one the generator produced for this table?
68
+ *
69
+ * Unnamed rules compile to `<table>_<op>_<sha1[0:7]>` (plus `_<idx>` when one
70
+ * rule spans several operations), and the hash covers the rule's semantics — so
71
+ * *editing* a rule renames its policy. The policy under the old name is left
72
+ * behind by `db push`, which only DROPs the names it is about to CREATE, and
73
+ * Postgres ORs PERMISSIVE policies together: a superseded `USING (true)` keeps
74
+ * granting everything no matter how tight its replacement is.
75
+ *
76
+ * Matching the shape is what makes dropping them safe. A hand-written policy
77
+ * would have to collide with a 7-hex digest to be mistaken for generated one;
78
+ * a policy named anything else is left alone and merely reported, because a
79
+ * custom name is indistinguishable from one someone wrote in SQL on purpose.
80
+ */
81
+ export declare function isGeneratedPolicyName(name: string, table: string): boolean;
82
+ export interface OrphanCleanup {
83
+ /** Superseded generated policies that were dropped. */
84
+ dropped: PolicyRef[];
85
+ /** Orphans left in place because their names are not generator-shaped. */
86
+ kept: PolicyRef[];
87
+ }
88
+ /**
89
+ * Drop the policies an earlier push superseded but never removed.
90
+ *
91
+ * Only touches tables the collections describe — a table with no expected
92
+ * policy is not ours to reconcile, and scanning by schema alone would sweep up
93
+ * policies belonging to something else sharing the database.
94
+ */
95
+ export declare function dropOrphanedPolicies(client: Queryable, drift: PolicyDrift, collections: CollectionConfig[]): Promise<OrphanCleanup>;
66
96
  export declare const hasDrift: (d: PolicyDrift) => boolean;
67
97
  /** Human-readable report; empty string when the database matches the config. */
68
98
  export declare function formatPolicyDrift(drift: PolicyDrift): string;
@@ -50,8 +50,11 @@ export declare function toCmsRow(row: Record<string, unknown>, collection: Colle
50
50
  * The row REST serves: every column under its own name, with the value Postgres
51
51
  * returned, and relations inlined as the target's columns.
52
52
  *
53
- * Deliberately not normalized: REST serves what the database holds, and JSON
54
- * has its own opinions about dates that the admin's view-model does not share.
53
+ * Values are the ones the database returned, except where that contradicts the
54
+ * declared type: a `number` property is served as a number (see
55
+ * {@link coerceDeclaredNumber}). Dates stay as the database returned them —
56
+ * JSON has its own opinions about dates that the admin's view-model does not
57
+ * share.
55
58
  *
56
59
  * Keyed by the row rather than by the relation list — a REST fetch only loads
57
60
  * the relations `include` asked for, so the row is the authority on which are
package/package.json CHANGED
@@ -1,7 +1,7 @@
1
1
  {
2
2
  "name": "@rebasepro/server-postgres",
3
3
  "type": "module",
4
- "version": "0.9.1-canary.a57c262",
4
+ "version": "0.9.1-canary.a639738",
5
5
  "description": "PostgreSQL data source backend implementation for Rebase with Drizzle ORM",
6
6
  "funding": {
7
7
  "url": "https://github.com/sponsors/rebaseco"
@@ -71,14 +71,15 @@
71
71
  "execa": "^9.6.1",
72
72
  "pg": "^8.21.0",
73
73
  "ws": "^8.21.0",
74
- "@rebasepro/codegen": "0.9.1-canary.a57c262",
75
- "@rebasepro/common": "0.9.1-canary.a57c262",
76
- "@rebasepro/utils": "0.9.1-canary.a57c262",
77
- "@rebasepro/server": "0.9.1-canary.a57c262",
78
- "@rebasepro/types": "0.9.1-canary.a57c262"
74
+ "@rebasepro/codegen": "0.9.1-canary.a639738",
75
+ "@rebasepro/common": "0.9.1-canary.a639738",
76
+ "@rebasepro/types": "0.9.1-canary.a639738",
77
+ "@rebasepro/utils": "0.9.1-canary.a639738",
78
+ "@rebasepro/server": "0.9.1-canary.a639738"
79
79
  },
80
80
  "devDependencies": {
81
81
  "@hono/node-server": "^2.0.9",
82
+ "@jest/globals": "^30.4.1",
82
83
  "@types/jest": "^30.0.0",
83
84
  "@types/node": "^25.9.3",
84
85
  "@types/pg": "^8.20.0",
@@ -548,13 +548,26 @@ export class PostgresBackendDriver implements DataDriver {
548
548
  let updatedValues = values;
549
549
  const contextForCallback = this.buildCallContext();
550
550
 
551
- // Fetch previous values for callbacks AND history recording
551
+ // Fetch previous values for callbacks AND history recording. Same walk
552
+ // as the saved row the callbacks receive (`fetchOneForRest`), so
553
+ // `values` and `previousValues` compare like with like — a Date on one
554
+ // side and its ISO string on the other reads as a change that never
555
+ // happened.
552
556
  let previousValuesForHistory: Partial<M> | undefined;
553
557
  if (status === "existing" && id) {
554
- const existing = await this.dataService.fetchOne<M>(path, id, resolvedCollection?.databaseId);
555
- if (existing) {
556
- const { id: _existingId, ...existingValues } = existing;
557
- previousValuesForHistory = existingValues as Partial<M>;
558
+ try {
559
+ const existing = await this.dataService.getFetchService()
560
+ .fetchOneForRest(path, id, undefined, resolvedCollection?.databaseId);
561
+ if (existing) {
562
+ const { id: _existingId, ...existingValues } = existing;
563
+ previousValuesForHistory = existingValues as Partial<M>;
564
+ }
565
+ } catch (err) {
566
+ // Best-effort enrichment: callbacks and history run without
567
+ // previous values rather than the save failing on a read the
568
+ // write itself does not need (e.g. a collection whose key the
569
+ // registry cannot resolve).
570
+ logger.debug(`[save] Could not fetch previous values for "${path}"`, { detail: err instanceof Error ? err.message : String(err) });
558
571
  }
559
572
  }
560
573
 
@@ -65,6 +65,15 @@ export interface PostgresDriverInternals {
65
65
  realtimeService: RealtimeService;
66
66
  driver: PostgresBackendDriver;
67
67
  poolManager?: DatabasePoolManager;
68
+ /**
69
+ * Attach CDC triggers to tables that did not exist when the driver
70
+ * bootstrapped. Only set when database-level capture is actually active.
71
+ *
72
+ * Auth owns its own tables and creates them later in boot, so at driver
73
+ * bootstrap they are legitimately missing and get skipped; without this
74
+ * they would stay uninstrumented until the next restart.
75
+ */
76
+ provisionCdcForTables?: (tables: CdcTableRef[]) => Promise<void>;
68
77
  }
69
78
 
70
79
  // Re-export from shared CLI error utilities
@@ -334,6 +343,7 @@ export function createPostgresBootstrapper(pgConfig: PostgresDriverConfig): Back
334
343
  const wantsCdc = cdcMode !== "off";
335
344
  const explicitCdc = cdcMode === "trigger" || cdcMode === "wal";
336
345
  let cdcEnabled = false;
346
+ let provisionCdcForTables: PostgresDriverInternals["provisionCdcForTables"];
337
347
 
338
348
  if (wantsCdc && !directUrl) {
339
349
  const reason = "no direct database connection is available for the realtime LISTEN client (set DATABASE_DIRECT_URL)";
@@ -367,6 +377,11 @@ export function createPostgresBootstrapper(pgConfig: PostgresDriverConfig): Back
367
377
  await provisionTriggerCdc(cdcRunSql, cdcTables);
368
378
  await realtimeService.enableCdc(directUrl);
369
379
  cdcEnabled = true;
380
+ // Boot steps that create their own tables (auth) run after
381
+ // this one and use it to instrument what they just created.
382
+ provisionCdcForTables = async (tables) => {
383
+ await provisionTriggerCdc(cdcRunSql, tables);
384
+ };
370
385
  logger.info(
371
386
  `📡 [CDC] Realtime source = database-level change capture (mode: ${cdcMode === "wal" ? "wal→trigger" : "trigger"}). ` +
372
387
  `All writes now emit realtime events regardless of origin.`
@@ -417,6 +432,14 @@ export function createPostgresBootstrapper(pgConfig: PostgresDriverConfig): Back
417
432
  );
418
433
  const missing: Array<{ slug: string; table: string }> = [];
419
434
  for (const col of registeredCollections) {
435
+ // Auth owns its table and creates it later in this same
436
+ // boot (initializeAuth → ensureAuthTablesExist), so it is
437
+ // legitimately absent right now. Reporting it as drift
438
+ // tells the user to `db:push` a table that is about to
439
+ // exist — and on an introspected database, one that the
440
+ // database was never supposed to hold.
441
+ if ((col as { auth?: { enabled?: boolean } }).auth?.enabled) continue;
442
+
420
443
  const schemaName = "schema" in col && col.schema ? col.schema : "public";
421
444
  const tableName = registry.hasTableForCollection(
422
445
  col.table ?? col.slug
@@ -431,8 +454,10 @@ export function createPostgresBootstrapper(pgConfig: PostgresDriverConfig): Back
431
454
  const checkName = resolvedTable ?? tableName;
432
455
  const fullCheckName = schemaName === "public" ? checkName : `${schemaName}.${checkName}`;
433
456
  if (!dbTables.has(fullCheckName)) {
457
+ // Report what was actually looked up: an unqualified
458
+ // "users" sends people hunting for public.users.
434
459
  missing.push({ slug: col.slug,
435
- table: checkName });
460
+ table: fullCheckName });
436
461
  }
437
462
  }
438
463
  if (missing.length > 0) {
@@ -466,7 +491,8 @@ table: checkName });
466
491
  registry,
467
492
  realtimeService,
468
493
  driver,
469
- poolManager
494
+ poolManager,
495
+ provisionCdcForTables
470
496
  };
471
497
 
472
498
  return {
@@ -495,6 +521,29 @@ table: checkName });
495
521
  // ensureAuthTablesExist works with the collection abstraction — no Drizzle leakage.
496
522
  await ensureAuthTablesExist(db, authCollection);
497
523
 
524
+ // The driver bootstrapped before these tables existed, so CDC skipped
525
+ // them. Instrument them now, or writes to the user table emit no
526
+ // realtime events until the next restart.
527
+ if (authCollection && internals.provisionCdcForTables) {
528
+ const authSchema = "schema" in authCollection && typeof authCollection.schema === "string"
529
+ ? authCollection.schema
530
+ : "rebase";
531
+ const authTable = "table" in authCollection && typeof authCollection.table === "string"
532
+ ? authCollection.table
533
+ : authCollection.slug;
534
+ if (authTable) {
535
+ try {
536
+ await internals.provisionCdcForTables([{ schema: authSchema, table: authTable }]);
537
+ } catch (err) {
538
+ logger.warn(
539
+ `⚠️ [CDC] Could not attach change-capture to the auth table "${authSchema}.${authTable}" — ` +
540
+ "writes to it won't emit database-level events.",
541
+ { detail: err instanceof Error ? err.message : String(err) }
542
+ );
543
+ }
544
+ }
545
+ }
546
+
498
547
  let emailService: EmailService | undefined;
499
548
  if (authConfig.email) {
500
549
  emailService = createEmailService(authConfig.email as EmailConfig);
@@ -251,17 +251,32 @@ export async function ensureAuthTablesExist(db: NodePgDatabase, collection?: Col
251
251
  // Seed default roles if none exist
252
252
  // (no-op: roles are now stored inline on the users table)
253
253
 
254
- // ── Migration: Add is_anonymous column (safe for existing tables) ────
255
- await db.execute(sql`
256
- ALTER TABLE ${sql.raw(usersTableName)}
257
- ADD COLUMN IF NOT EXISTS is_anonymous BOOLEAN DEFAULT FALSE
258
- `);
259
-
260
- // ── Migration: Add inline roles column (safe for existing tables) ────
261
- await db.execute(sql`
262
- ALTER TABLE ${sql.raw(usersTableName)}
263
- ADD COLUMN IF NOT EXISTS roles TEXT[] DEFAULT '{}' NOT NULL
264
- `);
254
+ // ── Migration: reconcile the full users column set (safe for existing tables) ──
255
+ // CREATE TABLE IF NOT EXISTS never revisits an existing table, so a
256
+ // database provisioned by an older framework era is missing every
257
+ // column added since. Each column the auth services read or write must
258
+ // be back-filled here, or upgraded deployments break on the first
259
+ // statement that references it. `email` is deliberately absent: it has
260
+ // existed since the first era and cannot be added NOT NULL safely.
261
+ const userColumnBackfills = [
262
+ "display_name VARCHAR(255)",
263
+ "photo_url VARCHAR(500)",
264
+ "roles TEXT[] DEFAULT '{}' NOT NULL",
265
+ "password_hash VARCHAR(255)",
266
+ "email_verified BOOLEAN DEFAULT FALSE NOT NULL",
267
+ "email_verification_token VARCHAR(255)",
268
+ "email_verification_sent_at TIMESTAMP WITH TIME ZONE",
269
+ "is_anonymous BOOLEAN DEFAULT FALSE NOT NULL",
270
+ "metadata JSONB DEFAULT '{}' NOT NULL",
271
+ "created_at TIMESTAMP WITH TIME ZONE DEFAULT NOW() NOT NULL",
272
+ "updated_at TIMESTAMP WITH TIME ZONE DEFAULT NOW() NOT NULL"
273
+ ];
274
+ for (const columnDef of userColumnBackfills) {
275
+ await db.execute(sql`
276
+ ALTER TABLE ${sql.raw(usersTableName)}
277
+ ADD COLUMN IF NOT EXISTS ${sql.raw(columnDef)}
278
+ `);
279
+ }
265
280
 
266
281
  // ── Migration: Copy roles from legacy junction table to inline column ──
267
282
  // If the old rebase.user_roles and rebase.roles tables exist, migrate
@@ -358,6 +373,53 @@ export async function ensureAuthTablesExist(db: NodePgDatabase, collection?: Col
358
373
  ON ${sql.raw(recoveryCodesTableName)}(user_id)
359
374
  `);
360
375
 
376
+ // ── Migration: clear stale FORCE ROW LEVEL SECURITY (older RLS model) ──
377
+ // The current model never emits FORCE: privileged auth writes run as
378
+ // the table owner and rely on the owner bypassing plain ENABLE RLS
379
+ // (see generate-postgres-ddl-logic). A table still carrying FORCE from
380
+ // an older framework era binds the owner too, so the first user
381
+ // registration after an upgrade fails with SQLSTATE 42501. Reconcile
382
+ // on boot; only tables actually flagged get the ALTER (and its lock).
383
+ try {
384
+ const authTablePairs: [string, string][] = [
385
+ [usersSchema, resolvedTable],
386
+ [authSchema, "user_identities"],
387
+ [authSchema, "refresh_tokens"],
388
+ [authSchema, "password_reset_tokens"],
389
+ [authSchema, "app_config"],
390
+ [authSchema, "mfa_factors"],
391
+ [authSchema, "mfa_challenges"],
392
+ [authSchema, "recovery_codes"]
393
+ ];
394
+ for (const [schemaName, tableName] of authTablePairs) {
395
+ const forced = await db.execute(sql`
396
+ SELECT 1
397
+ FROM pg_class c
398
+ JOIN pg_namespace n ON n.oid = c.relnamespace
399
+ WHERE n.nspname = ${schemaName}
400
+ AND c.relname = ${tableName}
401
+ AND c.relforcerowsecurity
402
+ `);
403
+ if (forced.rows.length > 0) {
404
+ await db.execute(sql`
405
+ ALTER TABLE ${sql.raw(`"${schemaName}"."${tableName}"`)}
406
+ NO FORCE ROW LEVEL SECURITY
407
+ `);
408
+ logger.warn(
409
+ `🔧 Cleared stale FORCE ROW LEVEL SECURITY on "${schemaName}"."${tableName}" ` +
410
+ "(legacy RLS model — it binds the owner connection and breaks privileged auth writes)"
411
+ );
412
+ }
413
+ }
414
+ } catch (rlsReconcileError: unknown) {
415
+ // Non-fatal: the connection may lack ownership on a pre-provisioned
416
+ // table; registration will still fail loudly (42501) if FORCE remains.
417
+ logger.warn(
418
+ `⚠️ Could not reconcile FORCE ROW LEVEL SECURITY on auth tables: ` +
419
+ `${rlsReconcileError instanceof Error ? rlsReconcileError.message : String(rlsReconcileError)}`
420
+ );
421
+ }
422
+
361
423
  logger.info("✅ Auth tables ready");
362
424
  } catch (error) {
363
425
  logger.error("❌ Failed to create auth tables", { error });
@@ -82,6 +82,32 @@ export class UserService implements UserRepository {
82
82
  return `"${schema}"."${name}"`;
83
83
  }
84
84
 
85
+ /**
86
+ * Run a privileged auth write with an explicitly cleared RLS context.
87
+ *
88
+ * The auth services run on the base/owner connection, which by design
89
+ * carries a NULL `app.user_id` so the `auth.uid() IS NULL` server-escape
90
+ * in the default policies applies. That NULL is normally guaranteed by
91
+ * `set_config(..., is_local = true)` resetting at transaction end — but a
92
+ * GUC that survives on a pooled connection (or a connection role that
93
+ * doesn't bypass RLS: FORCE ROW LEVEL SECURITY, or a non-owner role)
94
+ * turns the trusted write into an RLS-scoped one and denies it with
95
+ * SQLSTATE 42501. Clearing the GUCs here, transaction-locally at the
96
+ * single chokepoint, makes the server context deterministic instead of
97
+ * trusting whatever state the pool hands us. `auth.uid()` reads '' as
98
+ * NULL via NULLIF, so '' is the server context.
99
+ */
100
+ private async withServerContext<T>(fn: (db: NodePgDatabase) => Promise<T>): Promise<T> {
101
+ return await this.db.transaction(async (tx) => {
102
+ await tx.execute(sql`
103
+ SELECT set_config('app.user_id', '', true),
104
+ set_config('app.user_roles', '', true),
105
+ set_config('app.jwt', '', true)
106
+ `);
107
+ return await fn(tx as unknown as NodePgDatabase);
108
+ });
109
+ }
110
+
85
111
  private mapRowToUser(row: Record<string, unknown>): UserData {
86
112
  if (!row) return row as UserData;
87
113
 
@@ -200,7 +226,9 @@ export class UserService implements UserRepository {
200
226
 
201
227
  async createUser(data: CreateUserData): Promise<UserData> {
202
228
  const payload = this.mapPayload(data);
203
- const [row] = (await this.db.insert(this.usersTable).values(payload).returning()) as Record<string, unknown>[];
229
+ const [row] = await this.withServerContext(async (db) =>
230
+ (await db.insert(this.usersTable).values(payload).returning()) as Record<string, unknown>[]
231
+ );
204
232
  return this.mapRowToUser(row);
205
233
  }
206
234
 
@@ -255,12 +283,12 @@ export class UserService implements UserRepository {
255
283
  }
256
284
 
257
285
  async linkUserIdentity(userId: string, provider: string, providerId: string, profileData?: Record<string, unknown>): Promise<void> {
258
- await this.db.insert(this.userIdentitiesTable).values({
286
+ await this.withServerContext(async (db) => db.insert(this.userIdentitiesTable).values({
259
287
  userId,
260
288
  provider,
261
289
  providerId,
262
290
  profileData: profileData || null
263
- }).onConflictDoNothing({ target: [this.userIdentitiesTable.provider, this.userIdentitiesTable.providerId] });
291
+ }).onConflictDoNothing({ target: [this.userIdentitiesTable.provider, this.userIdentitiesTable.providerId] }));
264
292
  }
265
293
 
266
294
  async updateUser(id: string, data: Partial<Omit<CreateUserData, "id">>): Promise<UserData | null> {
@@ -270,18 +298,20 @@ export class UserService implements UserRepository {
270
298
  const updatedAtKey = getColumnKey(this.usersTable, "updatedAt", "updated_at") || "updatedAt";
271
299
  payload[updatedAtKey] = new Date();
272
300
 
273
- const [row] = (await this.db
274
- .update(this.usersTable)
275
- .set(payload)
276
- .where(eq(idCol, id))
277
- .returning()) as Record<string, unknown>[];
301
+ const [row] = await this.withServerContext(async (db) =>
302
+ (await db
303
+ .update(this.usersTable)
304
+ .set(payload)
305
+ .where(eq(idCol, id))
306
+ .returning()) as Record<string, unknown>[]
307
+ );
278
308
  return row ? this.mapRowToUser(row) : null;
279
309
  }
280
310
 
281
311
  async deleteUser(id: string): Promise<void> {
282
312
  const idCol = getColumn(this.usersTable, "id");
283
313
  if (!idCol) return;
284
- await this.db.delete(this.usersTable).where(eq(idCol, id));
314
+ await this.withServerContext(async (db) => db.delete(this.usersTable).where(eq(idCol, id)));
285
315
  }
286
316
 
287
317
  async listUsers(): Promise<UserData[]> {
@@ -357,13 +387,13 @@ export class UserService implements UserRepository {
357
387
  const passwordHashColKey = getColumnKey(this.usersTable, "passwordHash", "password_hash") || "passwordHash";
358
388
  const updatedAtColKey = getColumnKey(this.usersTable, "updatedAt", "updated_at") || "updatedAt";
359
389
 
360
- await this.db
390
+ await this.withServerContext(async (db) => db
361
391
  .update(this.usersTable)
362
392
  .set({
363
393
  [passwordHashColKey]: passwordHash,
364
394
  [updatedAtColKey]: new Date()
365
395
  })
366
- .where(eq(idCol, id));
396
+ .where(eq(idCol, id)));
367
397
  }
368
398
 
369
399
  /**
@@ -376,14 +406,14 @@ export class UserService implements UserRepository {
376
406
  const emailVerificationTokenColKey = getColumnKey(this.usersTable, "emailVerificationToken", "email_verification_token") || "emailVerificationToken";
377
407
  const updatedAtColKey = getColumnKey(this.usersTable, "updatedAt", "updated_at") || "updatedAt";
378
408
 
379
- await this.db
409
+ await this.withServerContext(async (db) => db
380
410
  .update(this.usersTable)
381
411
  .set({
382
412
  [emailVerifiedColKey]: verified,
383
413
  [emailVerificationTokenColKey]: null,
384
414
  [updatedAtColKey]: new Date()
385
415
  })
386
- .where(eq(idCol, id));
416
+ .where(eq(idCol, id)));
387
417
  }
388
418
 
389
419
  /**
@@ -396,14 +426,14 @@ export class UserService implements UserRepository {
396
426
  const emailVerificationSentAtColKey = getColumnKey(this.usersTable, "emailVerificationSentAt", "email_verification_sent_at") || "emailVerificationSentAt";
397
427
  const updatedAtColKey = getColumnKey(this.usersTable, "updatedAt", "updated_at") || "updatedAt";
398
428
 
399
- await this.db
429
+ await this.withServerContext(async (db) => db
400
430
  .update(this.usersTable)
401
431
  .set({
402
432
  [emailVerificationTokenColKey]: token,
403
433
  [emailVerificationSentAtColKey]: token ? new Date() : null,
404
434
  [updatedAtColKey]: new Date()
405
435
  })
406
- .where(eq(idCol, id));
436
+ .where(eq(idCol, id)));
407
437
  }
408
438
 
409
439
  /**
@@ -463,11 +493,11 @@ export class UserService implements UserRepository {
463
493
  async setUserRoles(userId: string, roleIds: string[]): Promise<void> {
464
494
  const usersTableName = this.getQualifiedUsersTableName();
465
495
  const rolesArray = `{${roleIds.join(",")}}`;
466
- await this.db.execute(sql`
496
+ await this.withServerContext(async (db) => db.execute(sql`
467
497
  UPDATE ${sql.raw(usersTableName)}
468
498
  SET roles = ${rolesArray}::text[], updated_at = NOW()
469
499
  WHERE id = ${userId}
470
- `);
500
+ `));
471
501
  }
472
502
 
473
503
  /**
@@ -475,11 +505,11 @@ export class UserService implements UserRepository {
475
505
  */
476
506
  async assignDefaultRole(userId: string, roleId: string): Promise<void> {
477
507
  const usersTableName = this.getQualifiedUsersTableName();
478
- await this.db.execute(sql`
508
+ await this.withServerContext(async (db) => db.execute(sql`
479
509
  UPDATE ${sql.raw(usersTableName)}
480
510
  SET roles = array_append(roles, ${roleId}), updated_at = NOW()
481
511
  WHERE id = ${userId} AND NOT (${roleId} = ANY(roles))
482
- `);
512
+ `));
483
513
  }
484
514
 
485
515
  /**
package/src/cli.ts CHANGED
@@ -176,6 +176,7 @@ async function dbCommand(subcommand: string, rawArgs: string[]): Promise<void> {
176
176
 
177
177
  if (databaseUrl) {
178
178
  await applyPolicies(databaseUrl);
179
+ await reconcilePolicies(databaseUrl, collectionsPath);
179
180
  await ensureRlsUserRole(databaseUrl);
180
181
  } else {
181
182
  logger.warn(chalk.yellow(" ⚠️ DATABASE_URL not found in environment, skipping RLS policies application."));
@@ -269,6 +270,65 @@ async function applyPolicies(databaseUrl: string): Promise<void> {
269
270
  }
270
271
  }
271
272
 
273
+ /**
274
+ * Remove the policies an earlier push superseded but never dropped.
275
+ *
276
+ * `policies.sql` only DROPs the names it is about to CREATE, and a rule's
277
+ * generated name contains a hash of its own semantics — so editing a rule
278
+ * writes a *new* policy and abandons the old one. Postgres ORs PERMISSIVE
279
+ * policies together, which makes an abandoned grant outrank every tightening
280
+ * that replaced it, and push reported success the whole time.
281
+ *
282
+ * Runs after `applyPolicies` so the current policies are already in place: the
283
+ * drift check then sees exactly the set that should survive, and anything else
284
+ * on a managed table is by definition left over.
285
+ */
286
+ async function reconcilePolicies(databaseUrl: string, collectionsPath: string): Promise<void> {
287
+ try {
288
+ const { checkPolicyDrift, dropOrphanedPolicies, formatPolicyDrift, hasDrift } =
289
+ await import("./security/policy-drift");
290
+ const { loadCollections } = await import("./schema/doctor");
291
+
292
+ const collections = await loadCollections(path.resolve(process.cwd(), collectionsPath));
293
+ const { Client } = await import("pg");
294
+ const client = new Client({ connectionString: databaseUrl });
295
+ await client.connect();
296
+ try {
297
+ const drift = await checkPolicyDrift(client as never, collections);
298
+ const { dropped, kept } = await dropOrphanedPolicies(client as never, drift, collections);
299
+
300
+ for (const p of dropped) {
301
+ logger.info(chalk.gray(` ✓ Dropped superseded policy "${p.name}" on ${p.schema}.${p.table}`));
302
+ }
303
+ if (dropped.length > 0) {
304
+ logger.info(chalk.green(` ✓ Removed ${dropped.length} superseded RLS ${dropped.length === 1 ? "policy" : "policies"}.`));
305
+ }
306
+
307
+ // Custom-named orphans are indistinguishable from policies someone
308
+ // wrote in SQL deliberately, so they are reported, never dropped.
309
+ if (kept.length > 0) {
310
+ logger.warn(chalk.yellow(" ⚠️ Policies in the database that no collection describes:"));
311
+ for (const p of kept) {
312
+ logger.warn(chalk.yellow(` • ${p.schema}.${p.table} → "${p.name}" (${p.command} TO ${p.roles.join(", ")})`));
313
+ }
314
+ logger.warn(chalk.yellow(" These still grant access. Drop them by hand if they are stale."));
315
+ }
316
+
317
+ // Missing/diverged are not push's to fix, but staying silent about
318
+ // them is how a database ends up not matching its config.
319
+ const remaining = { ...drift, orphaned: kept };
320
+ if (hasDrift(remaining) && (remaining.missing.length > 0 || remaining.diverged.length > 0)) {
321
+ logger.warn(chalk.yellow(" ⚠️ RLS policies do not match your collections:"));
322
+ logger.warn(formatPolicyDrift({ ...remaining, orphaned: [] }));
323
+ }
324
+ } finally {
325
+ await client.end();
326
+ }
327
+ } catch (err) {
328
+ logger.warn(chalk.yellow(` ⚠️ Could not reconcile RLS policies: ${err instanceof Error ? err.message : String(err)}`));
329
+ }
330
+ }
331
+
272
332
  async function branchCommand(rawArgs: string[]): Promise<void> {
273
333
  const branchAction = rawArgs[2]; // create, list, delete, info
274
334
 
package/src/connection.ts CHANGED
@@ -27,11 +27,68 @@ const DEFAULT_POOL: Required<PostgresPoolConfig> = {
27
27
  max: 20,
28
28
  idleTimeoutMillis: 30_000,
29
29
  connectionTimeoutMillis: 10_000,
30
- queryTimeout: 30_000,
30
+ // The client-side read timeout MUST be comfortably above the server-side
31
+ // statement_timeout. When the client timer fires first, node-postgres
32
+ // abandons the in-flight statement but keeps the connection — inside a
33
+ // transaction that leaves the tx open (and any pending ROLLBACK is
34
+ // spliced out of the client queue before it ever reaches the wire), so
35
+ // the pooled connection is returned still in-transaction with its RLS
36
+ // GUCs set. The server abort (SQLSTATE 57014) is the clean path; the
37
+ // client timeout is only a backstop for a dead network.
38
+ queryTimeout: 60_000,
31
39
  statementTimeout: 30_000,
32
40
  keepAlive: true
33
41
  };
34
42
 
43
+ /** ReadyForQuery status byte: `I` idle, `T` in transaction, `E` failed transaction. */
44
+ const TX_IDLE = "I";
45
+
46
+ /**
47
+ * Destroy pool clients that are released while still inside a transaction.
48
+ *
49
+ * pg-pool returns a client to the idle list whenever `release()` is called
50
+ * without an error — even if the connection is still mid-transaction (status
51
+ * `T`/`E`). That happens in practice: drizzle's pool transaction releases in
52
+ * a `finally` after attempting ROLLBACK, and if the ROLLBACK itself fails
53
+ * (e.g. it was queued behind a statement that hit the client-side
54
+ * query_timeout), the client goes back dirty. The next checkout then runs
55
+ * its statements inside the zombie transaction — with the previous request's
56
+ * `app.*` RLS GUCs still applied, which turns unrelated queries into
57
+ * RLS-scoped ones (observed in production as registration failing with
58
+ * SQLSTATE 42501 under a leaked anonymous context).
59
+ *
60
+ * pg-pool emits `release` before it consults its private `_expired` set, so
61
+ * marking the client expired here makes `_release()` destroy it instead of
62
+ * pooling it. Both `client._txStatus` (pg ≥ 8.16) and `pool._expired` are
63
+ * private APIs — feature-detect and fall back to loud logging so an upstream
64
+ * change degrades to observability, never to silent corruption.
65
+ */
66
+ export function guardPoolAgainstDirtyRelease(pool: Pool, label: string): void {
67
+ pool.on("release", (err: Error | undefined, client: unknown) => {
68
+ if (err) return; // errored clients are already destroyed by pg-pool
69
+ const txStatus = (client as { _txStatus?: string | null })?._txStatus;
70
+ if (typeof txStatus !== "string" || txStatus === TX_IDLE) return;
71
+
72
+ // pg-pool keeps expired clients in a WeakSet (a plain object works too
73
+ // if upstream ever changes it — duck-type on add/has).
74
+ const expired = (pool as unknown as { _expired?: { add(c: object): unknown; has(c: object): boolean } })._expired;
75
+ if (expired && typeof expired.add === "function" && typeof expired.has === "function" && client && typeof client === "object") {
76
+ expired.add(client);
77
+ logger.error(
78
+ `[${label}] Client released back to the pool while still in a transaction ` +
79
+ `(status '${txStatus}') — destroying it so the open transaction and its ` +
80
+ `session state (RLS GUCs) cannot leak into the next request.`
81
+ );
82
+ } else {
83
+ logger.error(
84
+ `[${label}] Client released mid-transaction (status '${txStatus}') but the ` +
85
+ `pool's internal expiry set is unavailable (pg-pool internals changed?). ` +
86
+ `The connection may leak its open transaction into subsequent requests.`
87
+ );
88
+ }
89
+ });
90
+ }
91
+
35
92
  /**
36
93
  * Create a Drizzle-backed Postgres connection with a production-grade
37
94
  * connection pool.
@@ -75,6 +132,7 @@ export function createPostgresDatabaseConnection(
75
132
  logger.warn("[pg-pool] Connection timeout detected — pool will auto-retry");
76
133
  }
77
134
  });
135
+ guardPoolAgainstDirtyRelease(pool, "pg-pool");
78
136
 
79
137
  // Create drizzle instance — pass schema when available to enable db.query relational API
80
138
  const db = schema ? drizzle(pool, { schema }) : drizzle(pool);
@@ -118,6 +176,7 @@ export function createDirectDatabaseConnection(
118
176
  pool.on("error", (err) => {
119
177
  logger.error("[pg-direct-pool] Unexpected pool error", { detail: err.message });
120
178
  });
179
+ guardPoolAgainstDirtyRelease(pool, "pg-direct-pool");
121
180
 
122
181
  const db = schema ? drizzle(pool, { schema }) : drizzle(pool);
123
182
 
@@ -157,6 +216,7 @@ export function createReadReplicaConnection(
157
216
  pool.on("error", (err) => {
158
217
  logger.error("[pg-replica-pool] Unexpected pool error", { detail: err.message });
159
218
  });
219
+ guardPoolAgainstDirtyRelease(pool, "pg-replica-pool");
160
220
 
161
221
  const db = schema ? drizzle(pool, { schema }) : drizzle(pool);
162
222