@rebasepro/server-postgres 0.19.2-canary.g2cd43e9 → 0.19.2-canary.g7199920

package/dist/index.es.js

@@ -3552,6 +3552,28 @@ function compareForSort(a, b, nullsLast) {
 * Service for handling all row read operations.
 * Handles fetching, searching, counting, and filtering rows.
 */
+/**
+* Which aggregate aliases hold a number that Postgres handed back as a string.
+*
+* `count`, `sum` and `avg` always do: bigint and numeric are returned as text
+* because they do not fit a JS number in general. `min` and `max` are uncast,
+* so they do it too — but only over a numeric column, and those are the two
+* functions that also apply to text and dates.
+*
+* Decided by the column's DECLARED type, not by trying `Number()` on the value.
+* `?select=avg(price),max(price)` used to answer `{avg_price: 5,
+* max_price: "8.5"}` — one column, two functions, two JSON types, and
+* arithmetic on the second one silently concatenates. Parsing whatever looks
+* numeric would fix that and break something worse: a `min(sku)` of `"00123"`
+* would come back as `123`, a different value, and no NaN check would catch it.
+*
+* Exported to be tested: the parsing itself needs a database, this decision
+* does not.
+*/
+function numericAggregateAliases(aggregates, properties) {
+	const isNumberField = (field) => Boolean(field) && properties[field]?.type === "number";
+	return new Set(aggregates.filter((a) => a.fn === "count" || a.fn === "sum" || a.fn === "avg" || (a.fn === "min" || a.fn === "max") && isNumberField(a.field)).map((a) => a.alias));
+}
 var FetchService = class FetchService {
 	db;
 	registry;
@@ -4392,7 +4414,7 @@ var FetchService = class FetchService {
 			if (options.limit) query = query.limit(options.limit);
 		}
 		const rows = await query;
-		const numericAliases = new Set(options.aggregates.filter((a) => a.fn === "count" || a.fn === "sum" || a.fn === "avg").map((a) => a.alias));
+		const numericAliases = numericAggregateAliases(options.aggregates, collection?.properties ?? {});
 		return rows.map((row) => {
 			const out = { ...row };
 			for (const alias of numericAliases) {
@@ -5157,7 +5179,7 @@ var PersistService = class {
 		} catch (error) {
 			throw this.toUserFriendlyError(error, collection.slug, collection);
 		}
-		const finalEntity = await this.fetchService.fetchOneForRest(collection.slug, savedId, void 0, databaseId);
+		const finalEntity = await this.fetchService.fetchOneForRest(collection.slug, savedId, void 0, databaseId, { withDeleted: true });
 		if (!finalEntity) throw new Error("Could not fetch row after save.");
 		return finalEntity;
 	}