@rebasepro/server-postgres 0.13.0 → 0.13.1-canary.g06dbe5b

package/src/services/realtimeService.ts

@@ -4,7 +4,7 @@ import { Client as PgClient } from "pg";
 import { randomUUID } from "crypto";
 import { DataService } from "./dataService";
 
-import { ANONYMOUS_USER_ID, FetchCollectionProps, ListenCollectionProps, ListenOneProps, DataDriver, CollectionUpdateMessage, SingleUpdateMessage, CollectionPatchMessage, WebSocketMessage, FilterValues, CollectionConfig, RebaseCallContext, resolveClientListLimit } from "@rebasepro/types";
+import { ANONYMOUS_USER_ID, FetchCollectionProps, ListenCollectionProps, ListenOneProps, DataDriver, CollectionUpdateMessage, SingleUpdateMessage, CollectionPatchMessage, WebSocketMessage, FilterValues, LogicalCondition, CollectionConfig, RebaseCallContext, resolveClientListLimit, ListLimitError } from "@rebasepro/types";
 import { NodePgDatabase } from "drizzle-orm/node-postgres";
 import { sql as drizzleSql } from "drizzle-orm";
 import { RealtimeProvider, CollectionSubscriptionConfig, SingleSubscriptionConfig } from "../interfaces";
@@ -33,6 +33,37 @@ export interface SubscriptionAuthContext {
     roles: string[];
 }
 
+/** What a channel frame is asking to do. */
+export type ChannelAction = "join" | "broadcast" | "presence" | "history";
+
+/** Everything an authorizer is told about the frame it is asked to allow. */
+export interface ChannelAuthorizationRequest {
+    /** The channel the frame names, exactly as the client wrote it. */
+    channel: string;
+    action: ChannelAction;
+    /** The socket, not the principal — one user may hold several. */
+    clientId: string;
+    /** The socket's authenticated principal, or the anonymous one. */
+    user?: SubscriptionAuthContext;
+}
+
+/**
+ * The extension point for channel access rules.
+ *
+ * **This is deliberately not a product API yet.** The rule *language* — a
+ * config key, a per-pattern DSL, how it composes with `securityRules` — is an
+ * open design question (see `docs/channel-authorization.md`), and
+ * inventing one here would be inventing the answer. What exists is the single
+ * place every channel frame passes through, so that whatever shape the rules
+ * eventually take has exactly one seam to plug into and no arm of the switch
+ * can be forgotten.
+ *
+ * Returning `false` — or throwing — refuses the frame. It is consulted *after*
+ * the membership floor below, so an authorizer can only ever narrow access,
+ * never widen it.
+ */
+export type ChannelAuthorizer = (request: ChannelAuthorizationRequest) => boolean | Promise<boolean>;
+
 interface DataDriverWithData extends DataDriver {
     data: unknown;
 }
@@ -41,6 +72,30 @@ type RealTimeListenCollectionProps = ListenCollectionProps & {
     subscriptionId: string
 };
 
+/**
+ * The narrowing a collection subscription was created with, kept so that every
+ * refetch answers the same query the initial fetch did.
+ *
+ * Named once because it used to be written out inline in five places, and a
+ * field missing from one of them is accepted over the wire and then silently
+ * ignored: `offset` was declared on the incoming props and never stored, so a
+ * live list on page three served page one, and `logical` was never stored
+ * either, so an `or(...)` subscription was pushed every row in the table.
+ */
+type StoredCollectionRequest = {
+    filter?: Record<string, unknown>;
+    logical?: LogicalCondition;
+    orderBy?: string;
+    order?: "desc" | "asc";
+    limit?: number;
+    offset?: number;
+    startAfter?: Record<string, unknown>;
+    databaseId?: string;
+    searchString?: string;
+    /** Ask each row which declared search field matched — populates `_matches`. */
+    searchExplain?: boolean;
+};
+
 type RealTimeListenEntityProps = ListenOneProps & { subscriptionId: string };
 
 /**
@@ -50,6 +105,13 @@ type RealTimeListenEntityProps = ListenOneProps & { subscriptionId: string };
  * Implements the RealtimeProvider interface for database abstraction.
  */
 export class RealtimeService extends EventEmitter implements RealtimeProvider {
+    /**
+     * Declares to the multi-engine router that channel frames can be handled
+     * here. Read by `createRoutedRealtimeService`, which otherwise would have to
+     * guess — and guessed "the default provider", whichever engine that is.
+     */
+    public readonly supportsChannels = true;
+
     private clients = new Map<string, WebSocket>();
 
     // Broadcast channels: channel name → set of client IDs
@@ -107,6 +169,26 @@ export class RealtimeService extends EventEmitter implements RealtimeProvider {
      */
     private oversizedBroadcastWarned = new Set<string>();
 
+    /**
+     * Optional narrowing on top of the membership floor — see
+     * {@link ChannelAuthorizer}. Unset by default, which leaves membership as
+     * the whole of the rule.
+     */
+    private channelAuthorizer?: ChannelAuthorizer;
+
+    /**
+     * Whether a notification from another instance has ever arrived.
+     *
+     * The entity LISTEN handler sees a foreign `sid` on every cross-instance
+     * change, which is proof that this deployment runs more than one pod — the
+     * one fact needed to tell "the memory bus is fine here" from "broadcast and
+     * presence silently reach a fraction of your users".
+     */
+    private foreignInstanceSeen = false;
+
+    /** So the multi-pod memory-bus warning is emitted once, not once per join. */
+    private memoryBusWarned = false;
+
     private presenceInterval?: ReturnType<typeof setInterval>;
     private static readonly PRESENCE_TIMEOUT_MS = 30000; // 30s
     /** How often stale roster rows from other instances are reaped. */
@@ -119,16 +201,7 @@ export class RealtimeService extends EventEmitter implements RealtimeProvider {
         path: string;
         id?: string | number;
         // Store full collection request parameters for proper refetching
-        collectionRequest?: {
-            filter?: Record<string, unknown>;
-            orderBy?: string;
-            order?: "desc" | "asc";
-            limit?: number;
-            offset?: number;
-            startAfter?: Record<string, unknown>;
-            databaseId?: string;
-            searchString?: string;
-        };
+        collectionRequest?: StoredCollectionRequest;
         // Auth context for RLS — when set, refetches run in a transaction
         // with set_config('app.uid', ...) / set_config('app.user_roles', ...)
         authContext?: SubscriptionAuthContext;
@@ -212,16 +285,7 @@ export class RealtimeService extends EventEmitter implements RealtimeProvider {
         type: "collection" | "single";
         path: string;
         id?: string | number;
-        collectionRequest?: {
-            filter?: Record<string, unknown>;
-            orderBy?: string;
-            order?: "desc" | "asc";
-            limit?: number;
-            offset?: number;
-            startAfter?: Record<string, unknown>;
-            databaseId?: string;
-            searchString?: string;
-        };
+        collectionRequest?: StoredCollectionRequest;
         authContext?: SubscriptionAuthContext;
     }) {
         this.debugLog("📋 [RealtimeService] Registering DataDriver subscription:", subscriptionId, subscription.authContext ? "(with auth)" : "(no auth)");
@@ -262,7 +326,8 @@ export class RealtimeService extends EventEmitter implements RealtimeProvider {
                 limit: config.limit,
                 startAfter: config.startAfter as Record<string, unknown> | undefined,
                 databaseId: config.databaseId,
-                searchString: config.searchString
+                searchString: config.searchString,
+                searchExplain: config.searchExplain
             }
         });
 
@@ -371,45 +436,19 @@ export class RealtimeService extends EventEmitter implements RealtimeProvider {
                 await this.handleUnsubscribe(clientId, message.subscriptionId!);
                 break;
 
-            // ── Broadcast Channels ──
+            // ── Broadcast Channels & Presence ──
+            //
+            // One arm for all of them, because every one has to pass the same
+            // gate and a switch with seven arms is a place to forget it once.
+            // See `handleChannelMessage`.
             case "join_channel":
-                this.joinChannel(clientId, payload?.channel as string);
-                break;
             case "leave_channel":
-                this.leaveChannel(clientId, payload?.channel as string);
-                break;
             case "broadcast":
-                this.broadcastToChannel(
-                    clientId,
-                    payload?.channel as string,
-                    payload?.event as string,
-                    payload?.payload
-                );
-                break;
             case "channel_history":
-                await this.handleChannelHistoryRequest(
-                    clientId,
-                    payload?.channel as string,
-                    payload?.sinceSeq as number | undefined,
-                    payload?.limit as number | undefined
-                );
-                break;
-
-            // ── Presence ──
             case "presence_track":
-                // Auto-join the channel so presence works without a separate join
-                this.joinChannel(clientId, payload?.channel as string);
-                this.trackPresence(
-                    clientId,
-                    payload?.channel as string,
-                    payload?.state as Record<string, unknown> ?? {}
-                );
-                break;
             case "presence_untrack":
-                this.removePresence(clientId, payload?.channel as string);
-                break;
             case "presence_state":
-                this.sendPresenceState(clientId, payload?.channel as string);
+                await this.handleChannelMessage(clientId, message.type, payload, authContext);
                 break;
 
             default:
@@ -431,15 +470,42 @@ export class RealtimeService extends EventEmitter implements RealtimeProvider {
                 return;
             }
 
+            // A vector search cannot be served here, and the parameter used to
+            // be read for one thing only — the limit default below — and then
+            // dropped: the stored request carries no `vectorSearch` and the
+            // refetch has no branch for one. So `.vectorSearch(…).listen()`
+            // delivered an ordinary `id DESC` listing, with no `_distance` and
+            // no error, forever. Refusing says what the silence did not.
+            if (request.vectorSearch) {
+                const msg =
+                    "Realtime subscriptions do not support vector search: a subscription is re-run on every " +
+                    "matching write, and nothing here computes distances. Use `.vectorSearch(...).find()` for " +
+                    "the query, and subscribe without it if you need live updates.";
+                logger.warn(`[RealtimeService] ${msg}`);
+                this.sendError(clientId, msg, subscriptionId, "VECTOR_SEARCH_NOT_LIVE");
+                return;
+            }
+
             // Bound the client-supplied limit with the SAME guarantee the REST
-            // ingress applies (`resolveClientListLimit`): clamp to the hard max
-            // and default an absent limit by mode. A subscription is re-fetched
-            // on every matching write, so an unbounded one is a DoS amplified
-            // per write — resolve it once and reuse for the stored request and
-            // the initial fetch.
-            const boundedLimit = resolveClientListLimit(request.limit, {
-                vectorSearch: !!request.vectorSearch
-            });
+            // ingress applies (`resolveClientListLimit`): default an absent
+            // limit by mode, refuse one above the ceiling. A subscription is
+            // re-fetched on every matching write, so an unbounded one is a DoS
+            // amplified per write — resolve it once and reuse for the stored
+            // request and the initial fetch.
+            //
+            // Refusing matters more here than on the REST route: a
+            // `collection_update` frame carries rows and nothing else — no
+            // `total`, no `hasMore` — so a subscriber handed a quietly smaller
+            // page has no way at all to learn it is not seeing the collection.
+            let boundedLimit: number;
+            try {
+                boundedLimit = resolveClientListLimit(request.limit);
+            } catch (e) {
+                if (!(e instanceof ListLimitError)) throw e;
+                logger.warn(`[RealtimeService] Refused subscription to '${request.path}': ${e.message}`);
+                this.sendError(clientId, e.message, subscriptionId, "INVALID_LIMIT");
+                return;
+            }
 
             // Store subscription with full request parameters and auth context for RLS
             this._subscriptions.set(subscriptionId, {
@@ -448,27 +514,25 @@ export class RealtimeService extends EventEmitter implements RealtimeProvider {
                 path: request.path,
                 collectionRequest: {
                     filter: request.filter,
+                    logical: request.logical,
                     orderBy: request.orderBy,
                     order: request.order,
                     limit: boundedLimit,
+                    offset: request.offset,
                     startAfter: request.startAfter as Record<string, unknown> | undefined,
                     databaseId: request.collection?.databaseId,
-                    searchString: request.searchString
+                    searchString: request.searchString,
+                    searchExplain: request.searchExplain
                 },
                 authContext
             });
 
-            // Send initial data
+            // Send initial data. Built from the request the subscription just
+            // stored, so the first answer and every refetch after it cannot
+            // describe different queries.
             const rows = await this.fetchCollectionWithAuth(
                 request.path,
-                {
-                    filter: request.filter,
-                    orderBy: request.orderBy,
-                    order: request.order,
-                    limit: boundedLimit,
-                    startAfter: request.startAfter as Record<string, unknown> | undefined,
-                    searchString: request.searchString
-                },
+                this._subscriptions.get(subscriptionId)!.collectionRequest!,
                 authContext
             );
 
@@ -679,7 +743,7 @@ export class RealtimeService extends EventEmitter implements RealtimeProvider {
     private debouncedCollectionRefetch(
         subscriptionId: string,
         notifyPath: string,
-        subscription: { clientId: string; collectionRequest?: { filter?: Record<string, unknown>; orderBy?: string; order?: "desc" | "asc"; limit?: number; offset?: number; startAfter?: Record<string, unknown>; databaseId?: string; searchString?: string }; authContext?: SubscriptionAuthContext }
+        subscription: { clientId: string; collectionRequest?: StoredCollectionRequest; authContext?: SubscriptionAuthContext }
     ) {
         const timerKey = `ws_${subscriptionId}`;
         const existing = this.refetchTimers.get(timerKey);
@@ -705,7 +769,7 @@ export class RealtimeService extends EventEmitter implements RealtimeProvider {
     private debouncedDriverRefetch(
         subscriptionId: string,
         notifyPath: string,
-        subscription: { collectionRequest?: { filter?: Record<string, unknown>; orderBy?: string; order?: "desc" | "asc"; limit?: number; offset?: number; startAfter?: Record<string, unknown>; databaseId?: string; searchString?: string }; authContext?: SubscriptionAuthContext },
+        subscription: { collectionRequest?: StoredCollectionRequest; authContext?: SubscriptionAuthContext },
         callback: (data: Record<string, unknown>[] | Record<string, unknown> | null) => void
     ) {
         const timerKey = `drv_${subscriptionId}`;
@@ -731,7 +795,7 @@ export class RealtimeService extends EventEmitter implements RealtimeProvider {
      */
     private async fetchCollectionWithAuth(
         notifyPath: string,
-        collectionRequest: { filter?: Record<string, unknown>; orderBy?: string; order?: "desc" | "asc"; limit?: number; offset?: number; startAfter?: Record<string, unknown>; databaseId?: string; searchString?: string },
+        collectionRequest: StoredCollectionRequest,
         authContext?: SubscriptionAuthContext
     ): Promise<Record<string, unknown>[]> {
         if (this.driver) {
@@ -740,12 +804,14 @@ export class RealtimeService extends EventEmitter implements RealtimeProvider {
                 path: notifyPath,
                 collection: collection,
                 filter: collectionRequest.filter as FetchCollectionProps["filter"],
+                logical: collectionRequest.logical,
                 orderBy: collectionRequest.orderBy,
                 order: collectionRequest.order,
                 limit: collectionRequest.limit,
                 offset: collectionRequest.offset,
                 startAfter: collectionRequest.startAfter,
-                searchString: collectionRequest.searchString
+                searchString: collectionRequest.searchString,
+                searchExplain: collectionRequest.searchExplain
             });
 
             // Always wrap in a transaction with session vars, defaulting to anonymous context if missing.
@@ -763,15 +829,21 @@ roles: ["anon"] };
                         collectionRequest.searchString,
                         {
                             filter: collectionRequest.filter as FilterValues<string>,
+                            // The subscription stored a group; the search branch
+                            // did not pass it on, so a filtered live search
+                            // widened to every row matching the text.
+                            logical: collectionRequest.logical,
                             orderBy: collectionRequest.orderBy,
                             order: collectionRequest.order,
                             limit: collectionRequest.limit,
-                            databaseId: collectionRequest.databaseId
+                            databaseId: collectionRequest.databaseId,
+                            searchExplain: collectionRequest.searchExplain
                         }
                     );
                 } else {
                     fetchedEntities = await txEntityService.fetchCollection(notifyPath, {
                         filter: collectionRequest.filter as FilterValues<string>,
+                        logical: collectionRequest.logical,
                         orderBy: collectionRequest.orderBy,
                         order: collectionRequest.order,
                         limit: collectionRequest.limit,
@@ -836,22 +908,28 @@ roles: activeAuth.roles },
             });
         }
 
-        // No driver — use dataService directly (no auth wrapping possible)
+        // No driver — use dataService directly (no auth wrapping possible).
+        // The `logical` group is carried here as well: this branch answers the
+        // same subscription as the one above, and a fallback that drops a
+        // condition returns *more* rows than the path it stands in for.
         if (collectionRequest.searchString) {
             return await this.dataService.searchRows(
                 notifyPath,
                 collectionRequest.searchString,
                 {
                     filter: collectionRequest.filter as FilterValues<string>,
+                    logical: collectionRequest.logical,
                     orderBy: collectionRequest.orderBy,
                     order: collectionRequest.order,
                     limit: collectionRequest.limit,
-                    databaseId: collectionRequest.databaseId
+                    databaseId: collectionRequest.databaseId,
+                    searchExplain: collectionRequest.searchExplain
                 }
             );
         }
         return await this.dataService.fetchCollection(notifyPath, {
             filter: collectionRequest.filter as FilterValues<string>,
+            logical: collectionRequest.logical,
             orderBy: collectionRequest.orderBy,
             order: collectionRequest.order,
             limit: collectionRequest.limit,
@@ -1101,15 +1179,197 @@ roles: activeAuth.roles },
     // Broadcast Channels
     // =============================================================================
 
+    /**
+     * Install a channel authorizer — see {@link ChannelAuthorizer}.
+     *
+     * Nothing in the framework calls this yet: it is the seam a rules API will
+     * be built on, kept deliberately separate from the membership floor so the
+     * floor holds whether or not anyone uses it.
+     */
+    setChannelAuthorizer(authorizer: ChannelAuthorizer | undefined): void {
+        this.channelAuthorizer = authorizer;
+    }
+
+    /** Which action each channel frame is asking to perform. */
+    private static readonly CHANNEL_ACTIONS: Record<string, ChannelAction> = {
+        join_channel: "join",
+        broadcast: "broadcast",
+        channel_history: "history",
+        presence_track: "join",
+        presence_state: "presence"
+    };
+
+    /**
+     * The one door every channel frame comes through.
+     *
+     * Returns synchronously — and so dispatches synchronously — unless an
+     * authorizer is installed. That matters: a client sends `join_channel`,
+     * `presence_state` and `channel_history` back to back on connect, and the
+     * socket's message handler processes each frame up to its first `await`,
+     * so a gate that always yielded would let the reads overtake the join that
+     * is about to authorize them.
+     */
+    private handleChannelMessage(
+        clientId: string,
+        type: string,
+        payload: Record<string, unknown> | undefined,
+        authContext?: SubscriptionAuthContext
+    ): void | Promise<void> {
+        const channel = payload?.channel as string;
+
+        // Leaving and untracking only ever remove the caller's own state, so
+        // they need no permission — refusing them could only strand a client.
+        if (type === "leave_channel") {
+            this.leaveChannel(clientId, channel);
+            return;
+        }
+        if (type === "presence_untrack") {
+            this.removePresence(clientId, channel);
+            return;
+        }
+
+        const action = RealtimeService.CHANNEL_ACTIONS[type];
+        const allowed = this.authorizeChannelAction(clientId, channel, action, authContext);
+        if (allowed === false) return;
+        if (allowed === true) return this.dispatchChannelMessage(clientId, type, channel, payload);
+        return allowed.then((ok) => {
+            if (ok) return this.dispatchChannelMessage(clientId, type, channel, payload);
+        });
+    }
+
+    /** Perform an already-authorized channel frame. */
+    private dispatchChannelMessage(
+        clientId: string,
+        type: string,
+        channel: string,
+        payload: Record<string, unknown> | undefined
+    ): void | Promise<void> {
+        switch (type) {
+            case "join_channel":
+                this.joinChannel(clientId, channel);
+                return;
+            case "broadcast":
+                this.broadcastToChannel(clientId, channel, payload?.event as string, payload?.payload);
+                return;
+            case "channel_history":
+                return this.handleChannelHistoryRequest(
+                    clientId,
+                    channel,
+                    payload?.sinceSeq as number | undefined,
+                    payload?.limit as number | undefined
+                );
+            case "presence_track":
+                // Auto-join the channel so presence works without a separate join
+                this.joinChannel(clientId, channel);
+                this.trackPresence(clientId, channel, payload?.state as Record<string, unknown> ?? {});
+                return;
+            case "presence_state":
+                this.sendPresenceState(clientId, channel);
+                return;
+        }
+    }
+
+    /**
+     * Decide whether a client may perform an action on a channel.
+     *
+     * **Membership is the floor.** Reading a channel's presence roster, replaying
+     * its retained history and broadcasting into it all require that this client
+     * has joined it. That is a low bar — joining is open to anyone who can name
+     * the channel — but it is not the bar that was there before, which was none
+     * at all: `channel_history` and `presence_state` answered any socket about
+     * any channel, and a broadcast fanned out to members the sender had never
+     * joined. Two internal tables (`rebase.channel_presence`,
+     * `rebase.channel_messages`) are held outside RLS on the strength of this
+     * check, so it fails closed: an authorizer that throws refuses the frame.
+     *
+     * Anything richer than membership belongs in a {@link ChannelAuthorizer};
+     * this method is where it is consulted, and the only place.
+     */
+    private authorizeChannelAction(
+        clientId: string,
+        channel: string,
+        action: ChannelAction,
+        authContext?: SubscriptionAuthContext
+    ): boolean | Promise<boolean> {
+        // Joining is what establishes membership, so it cannot require it.
+        if (action !== "join" && !this.channels.get(channel)?.has(clientId)) {
+            this.denyChannelAction(clientId, channel, action, "not a member of the channel");
+            return false;
+        }
+
+        const authorizer = this.channelAuthorizer;
+        if (!authorizer) return true;
+
+        let verdict: boolean | Promise<boolean>;
+        try {
+            verdict = authorizer({ channel, action, clientId, user: authContext });
+        } catch (error) {
+            logger.error(`❌ [Channels] Authorizer threw for ${action} on "${channel}" — refusing`, { error });
+            this.denyChannelAction(clientId, channel, action, "channel authorization failed");
+            return false;
+        }
+
+        if (typeof verdict === "boolean") {
+            if (!verdict) this.denyChannelAction(clientId, channel, action, "refused by the channel authorizer");
+            return verdict;
+        }
+
+        return verdict.then(
+            (ok) => {
+                if (!ok) this.denyChannelAction(clientId, channel, action, "refused by the channel authorizer");
+                return ok;
+            },
+            (error) => {
+                logger.error(`❌ [Channels] Authorizer rejected for ${action} on "${channel}" — refusing`, { error });
+                this.denyChannelAction(clientId, channel, action, "channel authorization failed");
+                return false;
+            }
+        );
+    }
+
+    /** Tell the client why its channel frame went nowhere, and say so in the log. */
+    private denyChannelAction(clientId: string, channel: string, action: ChannelAction, reason: string): void {
+        this.debugLog(`🚫 [Channels] Refused ${action} on "${channel}" for ${clientId}: ${reason}`);
+        this.sendError(
+            clientId,
+            `Refused ${action} on channel "${channel}": ${reason}`,
+            undefined,
+            "CHANNEL_FORBIDDEN"
+        );
+    }
+
     /** Join a broadcast channel */
     joinChannel(clientId: string, channel: string): void {
         if (!this.channels.has(channel)) {
             this.channels.set(channel, new Set());
         }
         this.channels.get(channel)!.add(clientId);
+        this.warnIfMemoryBusOnMultiplePods();
         this.debugLog(`📡 [Broadcast] Client ${clientId} joined channel: ${channel}`);
     }
 
+    /**
+     * Say something the first time channels are used on a deployment that is
+     * demonstrably multi-pod while the bus is still the in-memory default.
+     *
+     * Every other warning in this subsystem covers a *configured* bus failing —
+     * the case where the operator already knew a bus mattered. The common
+     * misconfiguration is the opposite one: scaled to two replicas, never
+     * touched `realtime.bus`, and broadcast and presence quietly serve a
+     * fraction of the room. The evidence is already in the process, so use it.
+     */
+    private warnIfMemoryBusOnMultiplePods(): void {
+        if (this.memoryBusWarned) return;
+        if (this.bus.kind !== "memory" || !this.foreignInstanceSeen) return;
+        this.memoryBusWarned = true;
+        logger.warn(
+            "⚠️ [ChannelBus] Channels are in use with the in-memory bus, but notifications from another " +
+            "instance have been seen — this deployment runs more than one process. Broadcast and presence " +
+            "reach only the clients connected to this one. Set `realtime.bus` (or REBASE_REALTIME_BUS=postgres) " +
+            "to make channels cross-instance."
+        );
+    }
+
     /** Leave a broadcast channel */
     leaveChannel(clientId: string, channel: string): void {
         const members = this.channels.get(channel);
@@ -2065,6 +2325,11 @@ lastSeen: Date.now() });
                     // Skip our own notifications — already processed locally
                     if (sid === this.instanceId) return;
 
+                    // A foreign sid is proof of a second process. Nothing here
+                    // needs that fact, but the channel path does — see
+                    // `warnIfMemoryBusOnMultiplePods`.
+                    this.foreignInstanceSeen = true;
+
                     this.debugLog(`📡 [RealtimeService] Received cross-instance notification: path=${p}, id=${eid}, from=${sid}`);
 
                     // Refetch the row from the DB so row subscriptions