@rebasepro/common 0.12.0 → 0.12.1-canary.gdfba2a1

package/dist/util/index.d.ts

@@ -16,3 +16,4 @@ export * from "./auth-default-policies";
 export * from "./junction-policies";
 export * from "./conditions";
 export * from "./pg-column-to-property";
+export * from "./string-column-length";

package/dist/util/string-column-length.d.ts

@@ -0,0 +1,24 @@
+import type { StringProperty } from "@rebasepro/types";
+/**
+ * The length a bounded string column is declared with when the property does
+ * not say. Historical: it is what the DDL generator hardcoded, kept so that
+ * regenerating an existing schema does not silently redefine its columns.
+ */
+export declare const DEFAULT_STRING_COLUMN_LENGTH = 255;
+/**
+ * How wide a `varchar`/`char` column should be for a given property.
+ *
+ * One definition, three call sites, because they used to disagree. For the same
+ * `columnType: "varchar"` property the DDL generator emitted `VARCHAR(255)`
+ * while the Drizzle generator emitted a bare `varchar("col")` — which Postgres
+ * reads as *unbounded* — so which of the two you ran decided whether the column
+ * had a limit at all. Introspection then dropped the length entirely, so reading
+ * an existing `character varying(500)` column back and regenerating it produced
+ * a `VARCHAR(255)`: a silent narrowing of a column with data already in it.
+ *
+ * `validation.max` is the property's own statement about how long the value may
+ * be, so it is the only sensible source for the column's width — and it keeps
+ * the constraint the database enforces in step with the one the app enforces,
+ * rather than inventing a second, different limit underneath it.
+ */
+export declare function resolveStringColumnLength(prop: Pick<StringProperty, "validation">): number;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@rebasepro/common",
   "type": "module",
-  "version": "0.12.0",
+  "version": "0.12.1-canary.gdfba2a1",
   "description": "Awesome Firebase/Firestore-based headless open-source CMS",
   "funding": {
     "url": "https://github.com/sponsors/rebaseco"
@@ -38,26 +38,26 @@
     "./package.json": "./package.json"
   },
   "dependencies": {
-    "fast-equals": "6.0.0",
+    "fast-equals": "6.0.2",
     "json-logic-js": "^2.0.5",
-    "@rebasepro/types": "0.12.0",
-    "@rebasepro/utils": "0.12.0"
+    "@rebasepro/types": "0.12.1-canary.gdfba2a1",
+    "@rebasepro/utils": "0.12.1-canary.gdfba2a1"
   },
   "devDependencies": {
     "@jest/globals": "^30.4.1",
     "@testing-library/react": "^16.3.2",
     "@testing-library/user-event": "^14.6.1",
     "@types/jest": "^30.0.0",
-    "@types/node": "^25.9.3",
+    "@types/node": "^26.1.2",
     "@types/object-hash": "^3.0.6",
     "@types/react-measure": "^2.0.12",
     "babel-plugin-react-compiler": "beta",
     "cross-env": "^10.1.0",
     "jest": "^30.4.2",
-    "ts-jest": "^29.4.11",
+    "ts-jest": "^29.4.12",
     "tsd": "^0.33.0",
     "typescript": "^6.0.3",
-    "vite": "^8.0.16"
+    "vite": "^8.1.5"
   },
   "files": [
     "dist",

package/src/util/index.ts

@@ -16,3 +16,4 @@ export * from "./auth-default-policies";
 export * from "./junction-policies";
 export * from "./conditions";
 export * from "./pg-column-to-property";
+export * from "./string-column-length";

package/src/util/pg-column-to-property.ts

@@ -42,6 +42,7 @@ function pgTypeToRebaseProperty(column: TableColumnInfo): Property | null {
         udt_name,
         is_nullable,
         column_default,
+        character_maximum_length,
         enum_values
     } = column;
 
@@ -78,11 +79,23 @@ label: prettifyIdentifier(v) })),
             let colType: "varchar" | "text" | "char" = "varchar";
             if (dt === "text" || dt === "citext") colType = "text";
             if (dt === "char" || dt === "character") colType = "char";
+            // Carry the declared width across. Dropping it made introspection
+            // lossy in the one direction that costs data: a `character
+            // varying(500)` column read back as a bare `varchar` regenerates as
+            // `VARCHAR(255)`, narrowing a column that already holds longer
+            // values. TEXT has no width, and reporting one would invent a limit
+            // the database does not have.
+            const declaredLength = colType === "text" ? null : character_maximum_length;
             const prop: StringProperty = {
                 type: "string",
                 name: prettifiedName,
                 columnType: colType,
-                validation: required ? { required: true } : undefined
+                validation: required || declaredLength
+                    ? {
+                        ...(required ? { required: true } : {}),
+                        ...(declaredLength ? { max: declaredLength } : {})
+                    }
+                    : undefined
             };
             if (isAutoId) {
                 prop.isId = "manual";

package/src/util/string-column-length.ts

@@ -0,0 +1,31 @@
+import type { StringProperty } from "@rebasepro/types";
+
+/**
+ * The length a bounded string column is declared with when the property does
+ * not say. Historical: it is what the DDL generator hardcoded, kept so that
+ * regenerating an existing schema does not silently redefine its columns.
+ */
+export const DEFAULT_STRING_COLUMN_LENGTH = 255;
+
+/**
+ * How wide a `varchar`/`char` column should be for a given property.
+ *
+ * One definition, three call sites, because they used to disagree. For the same
+ * `columnType: "varchar"` property the DDL generator emitted `VARCHAR(255)`
+ * while the Drizzle generator emitted a bare `varchar("col")` — which Postgres
+ * reads as *unbounded* — so which of the two you ran decided whether the column
+ * had a limit at all. Introspection then dropped the length entirely, so reading
+ * an existing `character varying(500)` column back and regenerating it produced
+ * a `VARCHAR(255)`: a silent narrowing of a column with data already in it.
+ *
+ * `validation.max` is the property's own statement about how long the value may
+ * be, so it is the only sensible source for the column's width — and it keeps
+ * the constraint the database enforces in step with the one the app enforces,
+ * rather than inventing a second, different limit underneath it.
+ */
+export function resolveStringColumnLength(prop: Pick<StringProperty, "validation">): number {
+    const max = prop.validation?.max;
+    return typeof max === "number" && Number.isInteger(max) && max > 0
+        ? max
+        : DEFAULT_STRING_COLUMN_LENGTH;
+}