@rebasepro/app 0.16.0 → 0.16.1-canary.g0d7af95

package/src/i18n/RebaseI18nProvider.tsx

@@ -9,6 +9,7 @@ import { it } from "../locales/it";
 import { hi } from "../locales/hi";
 import { pt } from "../locales/pt";
 import { RebaseTranslations } from "@rebasepro/admin-types";
+import { readStoredString, writeStoredString } from "../util/local_storage";
 
 const REBASE_NS = "rebase_core";
 
@@ -59,10 +60,8 @@ export function RebaseI18nProvider({
         const resources = buildResources(translations);
 
         let initialLocale = locale;
-        if (typeof window !== "undefined") {
-            const stored = localStorage.getItem(REBASE_LOCALE_STORAGE_KEY);
-            if (stored) initialLocale = stored;
-        }
+        const stored = readStoredString(REBASE_LOCALE_STORAGE_KEY);
+        if (stored) initialLocale = stored;
 
         instance
             .use(initReactI18next)
@@ -82,7 +81,7 @@ export function RebaseI18nProvider({
 
         instance.on("languageChanged", (lng) => {
             if (typeof window !== "undefined") {
-                localStorage.setItem(REBASE_LOCALE_STORAGE_KEY, lng);
+                writeStoredString(REBASE_LOCALE_STORAGE_KEY, lng);
             }
         });
 
@@ -93,7 +92,7 @@ export function RebaseI18nProvider({
     // ONLY if the user hasn't explicitly set a preference
     useEffect(() => {
         if (i18nRef.current && i18nRef.current.language !== locale) {
-            const hasUserPreference = typeof window !== "undefined" && Boolean(localStorage.getItem(REBASE_LOCALE_STORAGE_KEY));
+            const hasUserPreference = Boolean(readStoredString(REBASE_LOCALE_STORAGE_KEY));
             if (!hasUserPreference) {
                 i18nRef.current.changeLanguage(locale);
             }

package/src/locales/de.ts

@@ -523,7 +523,6 @@ export const de: RebaseTranslations = {
     add_your: "Fügen Sie Ihre",
     database_collections: "Datenbanksammlungen",
     no_unmapped_collections: "Keine nicht zugeordneten Sammlungen",
-    query_and_update_with_datatalk: "Fragen Sie Ihre Daten in natürlicher Sprache ab und aktualisieren Sie sie mit DATATALK",
     welcome_to_rebase: "Willkommen bei Rebase",
     admin_panel_ready_bring_data: "Ihr Admin-Panel ist bereit. Bringen Sie Ihre Daten ein.",
     admin_panel_ready_get_started: "Ihr Admin-Panel ist bereit. So können Sie loslegen.",

package/src/locales/en.ts

@@ -637,7 +637,6 @@ export const en: RebaseTranslations = {
     add_your: "Add your",
     database_collections: "database collections",
     no_unmapped_collections: "No unmapped collections in the database",
-    query_and_update_with_datatalk: "Query and update your data in natural language with",
 
     welcome_to_rebase: "Welcome to Rebase Cloud",
     admin_panel_ready_bring_data: "Your admin panel is ready. Let's bring in your data.",

package/src/locales/es.ts

@@ -533,7 +533,6 @@ export const es: RebaseTranslations = {
     add_your: "Añade tus",
     database_collections: "colecciones de base de datos",
     no_unmapped_collections: "No hay colecciones sin mapear en la base de datos",
-    query_and_update_with_datatalk: "Consulta y actualiza tus datos en lenguaje natural con",
 
     welcome_to_rebase: "Bienvenido a Rebase Cloud",
     admin_panel_ready_bring_data: "Tu panel de administración está listo. Traigamos tus datos.",

package/src/locales/fr.ts

@@ -523,7 +523,6 @@ export const fr: RebaseTranslations = {
     add_your: "Ajoutez vos",
     database_collections: "collections de base de données",
     no_unmapped_collections: "Aucune collection non mappée",
-    query_and_update_with_datatalk: "Interrogez et mettez à jour vos données en langage naturel avec",
     welcome_to_rebase: "Bienvenue sur Rebase Cloud",
     admin_panel_ready_bring_data: "Votre panneau d'administration est prêt. Ajoutons vos données.",
     admin_panel_ready_get_started: "Votre panneau d'administration est prêt. Voici comment démarrer.",

package/src/locales/hi.ts

@@ -523,7 +523,6 @@ export const hi: RebaseTranslations = {
     add_your: "अपने",
     database_collections: "डेटाबेस संग्रह",
     no_unmapped_collections: "कोई असंबद्ध संग्रह नहीं",
-    query_and_update_with_datatalk: "DATATALK के साथ प्राकृतिक भाषा में अपना डेटा क्वेरी और अपडेट करें",
     welcome_to_rebase: "Rebase में आपका स्वागत है",
     admin_panel_ready_bring_data: "आपका पैनल तैयार है। अपना डेटा जोड़कर शुरू करें।",
     admin_panel_ready_get_started: "शुरू करें",

package/src/locales/it.ts

@@ -523,7 +523,6 @@ export const it: RebaseTranslations = {
     add_your: "Aggiungi le tue",
     database_collections: "collezioni del database",
     no_unmapped_collections: "Nessuna collezione non mappata",
-    query_and_update_with_datatalk: "Interroga e aggiorna i tuoi dati in linguaggio naturale con DATATALK",
     welcome_to_rebase: "Benvenuto in Rebase Cloud",
     admin_panel_ready_bring_data: "Il tuo pannello è pronto. Inizia aggiungendo i tuoi dati.",
     admin_panel_ready_get_started: "Il tuo pannello è pronto. Ecco come iniziare.",

package/src/locales/pt.ts

@@ -530,7 +530,6 @@ export const pt: RebaseTranslations = {
     add_your: "Adicione as suas",
     database_collections: "coleções da base de dados",
     no_unmapped_collections: "Sem coleções não mapeadas na base de dados",
-    query_and_update_with_datatalk: "Consulte e atualize os seus dados em linguagem natural com",
 
     welcome_to_rebase: "Bem-vindo ao Rebase Cloud",
     admin_panel_ready_bring_data: "O seu painel de administração está pronto. Vamos importar os seus dados.",

package/src/util/index.ts

@@ -10,3 +10,4 @@ export * from "./useStorageUploadController";
 export * from "./previews";
 export * from "./enums";
 export * from "./constants";
+export * from "./local_storage";

package/src/util/local_storage.ts

@@ -0,0 +1,66 @@
+/**
+ * localStorage that tolerates not being there.
+ *
+ * `typeof window !== "undefined"` was the guard these call sites used, and it
+ * answers the wrong question: it says "am I in a browser", not "can I read
+ * storage". Three things make that distinction real rather than theoretical:
+ *
+ * - A browser can have storage **disabled**. Safari in private mode, a blocked
+ *   third-party cookie policy, and a sandboxed iframe all give you a `window`
+ *   whose `localStorage` property *throws on access* — a SecurityError raised
+ *   before any method is called, which no amount of null-checking the result
+ *   catches.
+ * - A test environment can be **half torn down**. jsdom is disposed at the end
+ *   of a file while React is still finishing a concurrent render, so `window`
+ *   survives as a husk and `localStorage.getItem` is no longer a function.
+ *   That is how this was found: `TypeError: localStorage.getItem is not a
+ *   function`, thrown out of a render, failing a suite in which every one of
+ *   709 tests passed.
+ * - Server rendering has no `window` at all, which is the only case the old
+ *   guard actually covered.
+ *
+ * Reading a UI preference is never worth a crash. Every function here fails to
+ * `null` / no-op, so a user with storage switched off gets the default
+ * appearance instead of a blank page.
+ */
+
+/** The Storage object, or null when it is absent, blocked, or not usable. */
+function usableStorage(): Storage | null {
+    try {
+        if (typeof window === "undefined") return null;
+        const candidate = window.localStorage;
+        // Not `!= null`: a torn-down jsdom leaves an object behind whose
+        // methods are gone, which is exactly the shape that threw.
+        return typeof candidate?.getItem === "function" ? candidate : null;
+    } catch {
+        // Access itself throws when storage is blocked by policy.
+        return null;
+    }
+}
+
+/** The stored string for `key`, or null if it is unset or unreadable. */
+export function readStoredString(key: string): string | null {
+    try {
+        return usableStorage()?.getItem(key) ?? null;
+    } catch {
+        return null;
+    }
+}
+
+/** Persist `value` under `key`. A no-op when storage is unavailable. */
+export function writeStoredString(key: string, value: string): void {
+    try {
+        usableStorage()?.setItem(key, value);
+    } catch {
+        // Also the quota path: a full store throws on write but reads fine.
+    }
+}
+
+/** Remove `key`. A no-op when storage is unavailable. */
+export function removeStoredString(key: string): void {
+    try {
+        usableStorage()?.removeItem(key);
+    } catch {
+        /* nothing to undo */
+    }
+}