@rebasepro/admin 0.13.0 → 0.13.1-canary.g394d868

package/src/components/CollectionViewBinding/SlotValue.tsx

@@ -0,0 +1,156 @@
+import React from "react";
+import type { PreviewSize } from "../../types/components/PropertyPreviewProps";
+import { PropertyPreview } from "../../preview";
+import { StorageThumbnail } from "../../preview/components/StorageThumbnail";
+import { UrlComponentPreview } from "../../preview/components/UrlComponentPreview";
+import { Chip } from "@rebasepro/ui";
+import type { PreviewSlot } from "./usePreviewSlots";
+
+export interface SlotValueProps {
+    slot: PreviewSlot | undefined;
+    size: PreviewSize;
+    /**
+     * Relations and references render as one line of linked text rather than as
+     * a card. Defaults to true: a slot is a line in a row or a card, and a
+     * relation that renders its own bordered card there — with its own id line
+     * and its own side-panel button — is a card inside a card.
+     *
+     * Pass `false` only for a slot with room for one, which in practice is
+     * none of them.
+     */
+    textOnly?: boolean;
+    /** Images only: fill the container rather than fitting inside it. */
+    fill?: boolean;
+}
+
+/**
+ * One display slot, rendered.
+ *
+ * A slot's value arrives one of two ways and they cannot be rendered the same:
+ *
+ * - **From a property** — render it with that property's own preview, so an
+ *   enum status keeps its colour, a date keeps its format and a storage path
+ *   becomes a thumbnail. This is why a declared path beats a resolver whenever
+ *   the value is actually on the record.
+ * - **From a resolver** — there is no property, because the value was computed
+ *   or fetched. All that can be said about it is that it is text.
+ *
+ * The branch lives here, once, rather than at each of the fourteen places the
+ * list row, the card and the board card render a slot. That count is the reason:
+ * the last time a rule like this was inlined per call site, it drifted into
+ * seven versions.
+ */
+export function SlotValue({ slot, size, textOnly = true, fill }: SlotValueProps) {
+
+    if (!slot || slot.value === undefined || slot.value === null) return null;
+
+    if (!slot.property || !slot.propertyKey) {
+        // A computed image is still an image. "There is no property, so all that
+        // can be said about it is that it is text" holds for a title and fails
+        // here: `display.image` accepts "a storage path or a URL … so a resolver
+        // may return either", and both used to be printed as their own string
+        // inside the image frame.
+        if (slot.role === "image" && typeof slot.value === "string" && slot.value.trim()) {
+            return <ComputedImage value={slot.value.trim()} size={size} fill={fill}/>;
+        }
+
+        // Computed. Arrays (a `tags` resolver) join rather than rendering as
+        // "[object Object]" via String().
+        const text = Array.isArray(slot.value)
+            ? slot.value.map(item => String(item)).join(", ")
+            : String(slot.value);
+        return <>{text}</>;
+    }
+
+    return <PropertyPreview
+        propertyKey={slot.propertyKey}
+        value={slot.value as never}
+        property={slot.property}
+        size={size}
+        textOnly={textOnly}
+        fill={fill}/>;
+}
+
+/**
+ * The `tags` slot, as chips beside the status.
+ *
+ * Honours both arms the same way the rest of the file does. A declared **path**
+ * goes through {@link SlotValue}, so an array of enum values keeps its own
+ * colours — that is the stated advantage of naming a property. A **resolver**
+ * returns bare strings with no property to render them as, so they become plain
+ * chips; a single string is accepted as one tag, which the role's type documents.
+ *
+ * Lives here rather than in the list, the card and the board card because that is
+ * three copies of the same decision, and this file exists to hold exactly one.
+ */
+export function TagChips({ slot, max = 4 }: { slot: PreviewSlot, max?: number }) {
+
+    if (slot.property && slot.propertyKey) {
+        return <SlotValue slot={slot} size="small"/>;
+    }
+
+    const values = (Array.isArray(slot.value) ? slot.value : [slot.value])
+        .filter(item => item !== undefined && item !== null && String(item).trim() !== "")
+        .map(item => String(item));
+
+    if (values.length === 0) return null;
+
+    const shown = values.slice(0, max);
+    const hidden = values.length - shown.length;
+
+    return <>
+        {shown.map(value => (
+            <Chip key={value}
+                size="smallest"
+                className="!text-[10px] !leading-tight !py-0 shrink-0 max-w-[100px] truncate">
+                {value}
+            </Chip>
+        ))}
+        {hidden > 0 && (
+            <span className="text-[10px] text-surface-400 dark:text-surface-500 shrink-0">+{hidden}</span>
+        )}
+    </>;
+}
+
+/**
+ * Whether a computed image string can be fetched as-is, or has to be resolved
+ * through storage first.
+ *
+ * Exported because it is the whole decision: rendering either branch needs a
+ * provider (a storage source, a DOM), and the thing worth pinning is which
+ * branch a given string takes. `//host/x` is protocol-relative and equally
+ * fetchable; `data:` and `blob:` are already the bytes.
+ */
+export function isFetchableImageUrl(value: string): boolean {
+    return /^(https?:)?\/\//i.test(value) || /^(data|blob):/i.test(value);
+}
+
+/**
+ * A string a resolver returned for the `image` role, rendered as a picture.
+ *
+ * Two things can arrive here and they need different handling, which is the whole
+ * reason a property-path image is preferable: a storage property knows which
+ * backend holds it, and a bare string does not.
+ *
+ * - An **absolute URL** is already fetchable. Rendering it through the storage
+ *   layer would ask a bucket to sign a path that was never in it.
+ * - Anything else is read as a **storage path** on the default source, which is
+ *   the only source a value with no property can be attributed to. A resolver
+ *   pointing at a named source should name the property instead.
+ */
+function ComputedImage({ value, size, fill }: { value: string, size: PreviewSize, fill?: boolean }) {
+    const isAbsolute = isFetchableImageUrl(value);
+
+    if (isAbsolute) {
+        return <UrlComponentPreview previewType="image"
+            url={value}
+            size={size}
+            fill={fill}
+            hint={value}/>;
+    }
+
+    return <StorageThumbnail storagePathOrDownloadUrl={value}
+        storeUrl={false}
+        size={size}
+        fill={fill}/>;
+}

package/src/components/CollectionViewBinding/SplitListCloseButton.tsx

@@ -1,6 +1,6 @@
 import React from "react";
 
-import { IconButton, iconSize, Tooltip, XIcon } from "@rebasepro/ui";
+import { IconButton, iconSize, PanelLeftCloseIcon, Tooltip } from "@rebasepro/ui";
 import { useTranslation } from "@rebasepro/app";
 
 import { useSplitView } from "./SplitViewContext";
@@ -9,11 +9,24 @@ import { useSplitView } from "./SplitViewContext";
  * Closes the list of a split view, leaving the open record on its own.
  *
  * It leads the record's own app bar, where the breadcrumb starts — this is the
- * entity pane's old "Open full screen" button, moved to that edge and wearing an
- * X: closing the list and opening the record full screen are the same thing, so
- * there is one control and one route (`#full`) rather than two.
+ * entity pane's old "Open full screen" button, moved to that edge: closing the
+ * list and opening the record full screen are the same thing, so there is one
+ * control and one route (`#full`) rather than two. Full screen carries the
+ * mirrored icon to bring the list back.
+ *
+ * A pane glyph rather than the double chevron it wore first. Now that the bar
+ * ends in a ✕ that dismisses the record, an arrow pointing off the left edge of
+ * the record's own bar was the other thing on it that read as "close me" — and
+ * it is the one control here that does not act on the record at all.
  */
-export function SplitListCloseButton() {
+export function SplitListCloseButton({ onBeforeHide }: {
+    /**
+     * Run before the layout changes, while this form is still mounted: the edit
+     * view uses it to hand its edit in progress to the full-screen form that is
+     * about to show the same record.
+     */
+    onBeforeHide?: () => void;
+} = {}) {
 
     const { t } = useTranslation();
     const splitView = useSplitView();
@@ -24,9 +37,12 @@ export function SplitListCloseButton() {
         <Tooltip title={t("hide_list")}>
             <IconButton
                 size="small"
-                onClick={splitView.openFullScreen}
+                onClick={() => {
+                    onBeforeHide?.();
+                    splitView.openFullScreen();
+                }}
                 aria-label={t("hide_list")}>
-                <XIcon size={iconSize.smallest}/>
+                <PanelLeftCloseIcon size={iconSize.smallest}/>
             </IconButton>
         </Tooltip>
     );

package/src/components/CollectionViewBinding/SplitListShowButton.tsx

@@ -0,0 +1,28 @@
+import React from "react";
+
+import { IconButton, iconSize, PanelLeftOpenIcon, Tooltip } from "@rebasepro/ui";
+import { useTranslation } from "@rebasepro/app";
+
+/**
+ * Brings the list back beside a record that was opened full screen.
+ *
+ * The mirror of {@link SplitListCloseButton}: the same edge of the same bar,
+ * the same pane glyph opening rather than closing, and the same single route —
+ * showing the list is dropping the `#full` hash. It replaces the back arrow
+ * where it applies, because the list it unfolds already holds the record.
+ */
+export function SplitListShowButton({ onClick }: { onClick: () => void }) {
+
+    const { t } = useTranslation();
+
+    return (
+        <Tooltip title={t("show_list")}>
+            <IconButton
+                size="small"
+                onClick={onClick}
+                aria-label={t("show_list")}>
+                <PanelLeftOpenIcon size={iconSize.smallest}/>
+            </IconButton>
+        </Tooltip>
+    );
+}

package/src/components/CollectionViewBinding/SplitListView.tsx

@@ -79,6 +79,19 @@ function isListShortcutTarget(target: HTMLElement | null, detailPanel: HTMLEleme
     return !detailPanel?.contains(target);
 }
 
+/**
+ * The list's share of the split, as a percentage, before anyone drags it.
+ *
+ * The list only has to identify a record — a title, a subtitle and a status
+ * chip — while the detail beside it carries the whole record and its rail. At
+ * 30% the list was taking width from the side that had four columns of fields
+ * to lay out.
+ *
+ * A default, not a constraint: {@link savePanelSize} remembers the drag per
+ * collection, so anyone who has already sized this list keeps their size.
+ */
+const DEFAULT_PANEL_SIZE = 26;
+
 function getSavedPanelSize(path: string): number {
     try {
         const saved = localStorage.getItem(`${PANEL_SIZE_KEY}_${path}`);
@@ -87,7 +100,7 @@ function getSavedPanelSize(path: string): number {
             if (!isNaN(val) && val > 0 && val < 100) return val;
         }
     } catch { /* ignore */ }
-    return 30;
+    return DEFAULT_PANEL_SIZE;
 }
 
 function savePanelSize(path: string, size: number) {
@@ -150,8 +163,20 @@ export function SplitListView<M extends Record<string, unknown> = Record<string,
         dirty.current = modified;
     }, []);
 
-    // The form remounts per entity, so its dirty state must not leak into the next one.
+    // The form remounts per entity, so its dirty state must not leak into the
+    // next one — and it has to be cleared here rather than left to the next
+    // form's own first report, because that form spends the load in a skeleton
+    // and a navigation during it would prompt about the record before it.
+    //
+    // On a *change* of record only, never on this view's own mount: a record
+    // arriving from full screen carries its edit back in and opens dirty, and
+    // the form says so from its first effect — which runs before this one, being
+    // a child's. Clearing unconditionally overwrote that report with `false`,
+    // and the way out of the split stopped asking about a live edit.
+    const previousEntityId = useRef(selectedEntityId);
     useEffect(() => {
+        if (previousEntityId.current === selectedEntityId) return;
+        previousEntityId.current = selectedEntityId;
         dirty.current = false;
     }, [selectedEntityId]);
 
@@ -366,6 +391,7 @@ export function SplitListView<M extends Record<string, unknown> = Record<string,
                         parentEntityIds={usedParentEntityIds}
                         selectedTab={selectedTab}
                         layout="split"
+                        onCloseRequest={handleCloseDetail}
                         onEditClick={() => {
                             navigate(buildUrl(`${path}/${renderedEntityId}/edit`));
                         }}
@@ -387,6 +413,11 @@ export function SplitListView<M extends Record<string, unknown> = Record<string,
                         parentEntityIds={usedParentEntityIds}
                         selectedTab={selectedTab}
                         layout="split"
+                        // The ✕, and where "save and close" lands. A plain
+                        // navigation: `useNavigationBlocker` above already
+                        // stands between it and an unsaved edit, so the ✕ asks
+                        // exactly what Escape and the browser's Back ask.
+                        onCloseRequest={handleCloseDetail}
                         onValuesModified={setDirty}
                         onSaved={() => {
                             setDirty(false);

package/src/components/CollectionViewBinding/useBoardDataController.tsx

@@ -408,7 +408,8 @@ values: { ...e.values,
             where: whereFilter,
             limit: itemCount,
             orderBy: orderByParam,
-            include: includeParams
+            include: includeParams,
+            searchString: currentSearchString
         });
 
         const onError = (error: Error) => {
@@ -446,7 +447,12 @@ values: { ...e.values,
                 where: whereFilter,
                 limit: itemCount,
                 orderBy: orderByParam,
-                include: includeParams
+                include: includeParams,
+                // Read into a local at the top of this function and then used
+                // nowhere, in both places it was read. The board took a search
+                // term, re-subscribed every column when it changed, and
+                // returned the same rows.
+                searchString: currentSearchString
             }, res => {
                 liveDataReceived = true;
                 onUpdate(res.data as Entity<M>[]);
@@ -539,7 +545,10 @@ values: { ...e.values,
                     };
 
                     accessor.count({
-                        where: whereFilter
+                        where: whereFilter,
+                        // Or the column header counts the unsearched collection
+                        // while the column beneath it shows searched rows.
+                        searchString: currentSearchString
                     }).then(count => {
                         if (isCleaningUpRef.current) return;
                         setColumnData(prev => ({