@realvare/based 2.7.2 → 2.7.4

package/lib/Socket/groups.js

@@ -320,8 +320,8 @@ const extractGroupMetadata = (result) => {
         participants: (0, WABinary_1.getBinaryNodeChildren)(group, 'participant').map(({ attrs }) => {
             return {
                 id: attrs.jid,
-                jid: attrs.phone_number || attrs.jid,
-                lid: attrs.lid || attrs.jid,
+                jid: attrs.phone_number || (0, WABinary_1.lidToJid)(attrs.jid),
+                lid: attrs.lid || ((0, WABinary_1.isLid)(attrs.jid) ? attrs.jid : undefined),
                 admin: (attrs.type || null),
             };
         }),

package/lib/Socket/messages-recv.js

@@ -35,6 +35,12 @@ const makeMessagesRecvSocket = (config) => {
         useClones: false
     });
     let sendActiveReceipts = false;
+    const resolveJid = (jid) => {
+        if (typeof jid === 'string' && jid.endsWith('@lid')) {
+            return (0, WABinary_1.lidToJid)(jid);
+        }
+        return jid;
+    };
     const sendMessageAck = async ({ tag, attrs, content }, errorCode) => {
         const stanza = {
             tag: 'ack',
@@ -62,6 +68,16 @@ const makeMessagesRecvSocket = (config) => {
         logger.debug({ recv: { tag, attrs }, sent: stanza.attrs }, 'sent ack');
         await sendNode(stanza);
     };
+
+    // Add withAck wrapper for guaranteed acknowledgments
+    const withAck = (processFn) => async (node) => {
+        try {
+            await processFn(node);
+        } finally {
+            // Always send ack even on failure to allow potential retry
+            await sendMessageAck(node);
+        }
+    };
     const offerCall = async (toJid, isVideo = false) => {
         const callId = (0, crypto_1.randomBytes)(16).toString('hex').toUpperCase().substring(0, 64);
         const offerContent = [];
@@ -344,22 +360,28 @@ const makeMessagesRecvSocket = (config) => {
             default:
             // console.log("BAILEYS-DEBUG:", JSON.stringify({ ...child, content: Buffer.isBuffer(child.content) ? child.content.toString() : child.content, participant }, null, 2))
         }
-        // Resolve LIDs to real JIDs for all messageStubParameters
-        if (msg.messageStubParameters) {
+        const needsResolving = (msg.messageStubParameters && msg.messageStubParameters.some(p => typeof p === 'string' && (0, WABinary_1.isLid)(p))) ||
+                               (participant && (0, WABinary_1.isLid)(participant)) ||
+                               (msg.key?.participant && (0, WABinary_1.isLid)(msg.key.participant));
+        if(needsResolving) {
             const metadata = await groupMetadata(groupJid);
-            msg.messageStubParameters = await Promise.all(msg.messageStubParameters.map(async (param) => {
-                if (typeof param === 'string' && param.endsWith('@lid')) {
-                    const found = metadata.participants.find(p => p.id === param);
-                    return found?.jid || (0, WABinary_1.lidToJid)(param);
-                }
-                return param;
-            }));
-        }
-        // Also resolve key.participant if needed
-        if (msg.key?.participant && msg.key.participant.endsWith('@lid')) {
-            const metadata = await groupMetadata(groupJid);
-            const found = metadata.participants.find(p => p.id === msg.key.participant);
-            msg.key.participant = found?.jid || (0, WABinary_1.lidToJid)(msg.key.participant);
+            if (msg.messageStubParameters) {
+                msg.messageStubParameters = await Promise.all(msg.messageStubParameters.map(async (param) => {
+                    if (typeof param === 'string' && (0, WABinary_1.isLid)(param)) {
+                        const found = metadata.participants.find(p => p.id === param);
+                        return found?.jid || (0, WABinary_1.lidToJid)(param);
+                    }
+                    return param;
+                }));
+            }
+            if(participant && (0, WABinary_1.isLid)(participant)) {
+                const found = metadata.participants.find(p => p.id === participant);
+                msg.participant = found?.jid || (0, WABinary_1.lidToJid)(participant);
+            }
+            if (msg.key?.participant && (0, WABinary_1.isLid)(msg.key.participant)) {
+                const found = metadata.participants.find(p => p.id === msg.key.participant);
+                msg.key.participant = found?.jid || (0, WABinary_1.lidToJid)(msg.key.participant);
+            }
         }
     };
     const handleNewsletterNotification = (id, node) => {
@@ -411,12 +433,12 @@ const makeMessagesRecvSocket = (config) => {
         const result = {};
         const [child] = (0, WABinary_1.getAllBinaryNodeChildren)(node);
         const nodeType = node.attrs.type;
-        const from = (0, WABinary_1.jidNormalizedUser)(node.attrs.from);
+        const from = resolveJid((0, WABinary_1.jidNormalizedUser)(node.attrs.from));
         switch (nodeType) {
             case 'privacy_token':
                 const tokenList = (0, WABinary_1.getBinaryNodeChildren)(child, 'token');
                 for (const { attrs, content } of tokenList) {
-                    const jid = attrs.jid;
+                    const jid = resolveJid(attrs.jid);
                     ev.emit('chats.update', [
                         {
                             id: jid,
@@ -445,7 +467,7 @@ const makeMessagesRecvSocket = (config) => {
             case 'devices':
                 const devices = (0, WABinary_1.getBinaryNodeChildren)(child, 'device');
                 if ((0, WABinary_1.areJidsSameUser)(child.attrs.jid, authState.creds.me.id)) {
-                    const deviceJids = devices.map(d => d.attrs.jid);
+                    const deviceJids = devices.map(d => resolveJid(d.attrs.jid));
                     logger.info({ deviceJids }, 'got my own devices');
                 }
                 break;
@@ -460,7 +482,7 @@ const makeMessagesRecvSocket = (config) => {
                 const setPicture = (0, WABinary_1.getBinaryNodeChild)(node, 'set');
                 const delPicture = (0, WABinary_1.getBinaryNodeChild)(node, 'delete');
                 ev.emit('contacts.update', [{
-                        id: from || ((_b = (_a = (setPicture || delPicture)) === null || _a === void 0 ? void 0 : _a.attrs) === null || _b === void 0 ? void 0 : _b.hash) || '',
+                        id: resolveJid(from) || ((_b = (_a = (setPicture || delPicture)) === null || _a === void 0 ? void 0 : _a.attrs) === null || _b === void 0 ? void 0 : _b.hash) || '',
                         imgUrl: setPicture ? 'changed' : 'removed'
                     }]);
                 if ((0, WABinary_1.isJidGroup)(from)) {
@@ -474,6 +496,15 @@ const makeMessagesRecvSocket = (config) => {
                         ...result.key || {},
                         participant: setPicture === null || setPicture === void 0 ? void 0 : setPicture.attrs.author
                     };
+                    const metadata = await groupMetadata(from);
+                    if (result.participant && result.participant.endsWith('@lid')) {
+                        const found = metadata.participants.find(p => p.id === result.participant);
+                        result.participant = found?.jid || (0, WABinary_1.lidToJid)(result.participant);
+                    }
+                    if (result.key?.participant && result.key.participant.endsWith('@lid')) {
+                        const found = metadata.participants.find(p => p.id === result.key.participant);
+                        result.key.participant = found?.jid || (0, WABinary_1.lidToJid)(result.key.participant);
+                    }
                 }
                 break;
             case 'account_sync':
@@ -494,7 +525,7 @@ const makeMessagesRecvSocket = (config) => {
                 else if (child.tag === 'blocklist') {
                     const blocklists = (0, WABinary_1.getBinaryNodeChildren)(child, 'item');
                     for (const { attrs } of blocklists) {
-                        const blocklist = [attrs.jid];
+                        const blocklist = [resolveJid(attrs.jid)];
                         const type = (attrs.action === 'block') ? 'add' : 'remove';
                         ev.emit('blocklist.update', { blocklist, type });
                     }
@@ -625,14 +656,14 @@ const makeMessagesRecvSocket = (config) => {
         var _a, _b;
         const { attrs, content } = node;
         const isLid = attrs.from.includes('lid');
-        const isNodeFromMe = (0, WABinary_1.areJidsSameUser)(attrs.participant || attrs.from, isLid ? (_a = authState.creds.me) === null || _a === void 0 ? void 0 : _a.lid : (_b = authState.creds.me) === null || _b === void 0 ? void 0 : _b.id);
-        const remoteJid = !isNodeFromMe || (0, WABinary_1.isJidGroup)(attrs.from) ? attrs.from : attrs.recipient;
+        const isNodeFromMe = (0, WABinary_1.areJidsSameUser)(resolveJid(attrs.participant) || resolveJid(attrs.from), isLid ? (_a = authState.creds.me) === null || _a === void 0 ? void 0 : _a.lid : (_b = authState.creds.me) === null || _b === void 0 ? void 0 : _b.id);
+        const remoteJid = !isNodeFromMe || (0, WABinary_1.isJidGroup)(attrs.from) ? resolveJid(attrs.from) : attrs.recipient;
         const fromMe = !attrs.recipient || ((attrs.type === 'retry' || attrs.type === 'sender') && isNodeFromMe);
         const key = {
             remoteJid,
             id: '',
             fromMe,
-            participant: attrs.participant
+            participant: resolveJid(attrs.participant)
         };
         if (shouldIgnoreJid(remoteJid) && remoteJid !== '@s.whatsapp.net') {
             logger.debug({ remoteJid }, 'ignoring receipt from jid');
@@ -660,7 +691,7 @@ const makeMessagesRecvSocket = (config) => {
                                 ev.emit('message-receipt.update', ids.map(id => ({
                                     key: { ...key, id },
                                     receipt: {
-                                        userJid: (0, WABinary_1.jidNormalizedUser)(attrs.participant),
+                                        userJid: (0, WABinary_1.jidNormalizedUser)(resolveJid(attrs.participant)),
                                         [updateKey]: +attrs.t
                                     }
                                 })));
@@ -715,7 +746,7 @@ const makeMessagesRecvSocket = (config) => {
         }
     };
     const handleNotification = async (node) => {
-        const remoteJid = node.attrs.from;
+        const remoteJid = resolveJid(node.attrs.from);
         if (shouldIgnoreJid(remoteJid) && remoteJid !== '@s.whatsapp.net') {
             logger.debug({ remoteJid, id: node.attrs.id }, 'ignored notification');
             await sendMessageAck(node);
@@ -727,15 +758,15 @@ const makeMessagesRecvSocket = (config) => {
                     var _a;
                     const msg = await processNotification(node);
                     if (msg) {
-                        const fromMe = (0, WABinary_1.areJidsSameUser)(node.attrs.participant || remoteJid, authState.creds.me.id);
-                        msg.key = {
-                            remoteJid,
-                            fromMe,
-                            participant: node.attrs.participant,
-                            id: node.attrs.id,
-                            ...(msg.key || {})
-                        };
-                        (_a = msg.participant) !== null && _a !== void 0 ? _a : (msg.participant = node.attrs.participant);
+                        const participant = msg.participant || resolveJid(node.attrs.participant);
+                        const fromMe = (0, WABinary_1.areJidsSameUser)(participant || remoteJid, authState.creds.me.id);
+                        const key = msg.key || {};
+                        key.remoteJid = remoteJid;
+                        key.fromMe = fromMe;
+                        key.id = node.attrs.id;
+                        key.participant = key.participant || participant;
+                        msg.key = key;
+                        msg.participant = participant;
                         msg.messageTimestamp = +node.attrs.t;
                         const fullMsg = WAProto_1.proto.WebMessageInfo.fromObject(msg);
                         await upsertMessage(fullMsg, 'append');
@@ -747,23 +778,20 @@ const makeMessagesRecvSocket = (config) => {
             await sendMessageAck(node);
         }
     };
-    const handleMessage = async (node) => {
+    const handleMessage = withAck(async (node) => {
         var _a, _b, _c;
         if (shouldIgnoreJid(node.attrs.from) && node.attrs.from !== '@s.whatsapp.net') {
             logger.debug({ key: node.attrs.key }, 'ignored message');
-            await sendMessageAck(node);
             return;
         }
         const encNode = (0, WABinary_1.getBinaryNodeChild)(node, 'enc');
         // TODO: temporary fix for crashes and issues resulting of failed msmsg decryption
         if (encNode && encNode.attrs.type === 'msmsg') {
             logger.debug({ key: node.attrs.key }, 'ignored msmsg');
-            await sendMessageAck(node);
             return;
         }
         let response;
         if ((0, WABinary_1.getBinaryNodeChild)(node, 'unavailable') && !encNode) {
-            await sendMessageAck(node);
             const { key } = (0, Utils_1.decodeMessageNode)(node, authState.creds.me.id, authState.creds.me.lid || '').fullMessage;
             response = await requestPlaceholderResend(key);
             if (response === 'RESOLVED') {
@@ -849,7 +877,6 @@ const makeMessagesRecvSocket = (config) => {
                         }
                     }
                     (0, Utils_1.cleanMessage)(msg, authState.creds.me.id);
-                    await sendMessageAck(node);
                     await upsertMessage(msg, node.attrs.offline ? 'append' : 'notify');
                 })
             ]);
@@ -857,7 +884,7 @@ const makeMessagesRecvSocket = (config) => {
         catch (error) {
             logger.error({ error, node }, 'error in handling message');
         }
-    };
+    });
     const fetchMessageHistory = async (count, oldestMsgKey, oldestMsgTimestamp) => {
         var _a;
         if (!((_a = authState.creds.me) === null || _a === void 0 ? void 0 : _a.id)) {
@@ -910,10 +937,10 @@ const makeMessagesRecvSocket = (config) => {
         const { attrs } = node;
         const [infoChild] = (0, WABinary_1.getAllBinaryNodeChildren)(node);
         const callId = infoChild.attrs['call-id'];
-        const from = infoChild.attrs.from || infoChild.attrs['call-creator'];
+        const from = resolveJid(infoChild.attrs.from || infoChild.attrs['call-creator']);
         const status = (0, Utils_1.getCallStatusFromNode)(infoChild);
         const call = {
-            chatId: attrs.from,
+            chatId: resolveJid(attrs.from),
             from,
             id: callId,
             date: new Date(+attrs.t * 1000),
@@ -923,7 +950,7 @@ const makeMessagesRecvSocket = (config) => {
         if (status === 'offer') {
             call.isVideo = !!(0, WABinary_1.getBinaryNodeChild)(infoChild, 'video');
             call.isGroup = infoChild.attrs.type === 'group' || !!infoChild.attrs['group-jid'];
-            call.groupJid = infoChild.attrs['group-jid'];
+            call.groupJid = resolveJid(infoChild.attrs['group-jid']);
             callOfferCache.set(call.id, call);
         }
         const existingCall = callOfferCache.get(call.id);
@@ -1049,7 +1076,6 @@ const makeMessagesRecvSocket = (config) => {
             .catch(error => onUnexpectedError(error, 'handling bad ack'));
     });
     ev.on('call', ([call]) => {
-        // missed call + group call notification message generation
         if (call.status === 'timeout' || (call.status === 'offer' && call.isGroup)) {
             const msg = {
                 key: {
@@ -1087,20 +1113,17 @@ const makeMessagesRecvSocket = (config) => {
         } else if (connection === 'open') {
             sendActiveReceipts = true;
         }
-        // Update sendActiveReceipts based on connection status
         if (typeof update.isOnline !== 'undefined') {
             sendActiveReceipts = update.isOnline;
             logger.trace(`sendActiveReceipts set to "${sendActiveReceipts}"`);
         }
     });
-    // Enhanced retry logic for stuck pending messages with anti-ban delays
     ev.on('messages.update', (updates) => {
         const config = (0, performance_config_1.getPerformanceConfig)();
         updates.forEach(update => {
             if (update.update.status === WAProto_1.proto.WebMessageInfo.Status.PENDING &&
-                Date.now() - (update.update.timestamp || 0) > 30000) { // 30 seconds
+                Date.now() - (update.update.timestamp || 0) > 30000) {
                 logger.debug({ key: update.key }, 'retrying stuck pending message with anti-ban delay');
-                // Apply anti-ban delay before retry
                 setTimeout(async () => {
                     try {
                         const msg = await getMessage(update.key);

package/lib/Utils/decode-wa-message.js

@@ -29,11 +29,20 @@ exports.NACK_REASONS = {
  */
 function decodeMessageNode(stanza, meId, meLid) {
     var _a, _b, _c, _d, _e, _f, _g;
+    if (!stanza || !stanza.attrs) {
+        throw new boom_1.Boom('Invalid stanza or missing attributes', { statusCode: 400 });
+    }
     let msgType;
     let chatId;
     let author;
     const msgId = stanza.attrs.id;
+    if (!msgId) {
+        throw new boom_1.Boom('Missing message ID', { statusCode: 400 });
+    }
     const from = stanza.attrs.from;
+    if (!from) {
+        throw new boom_1.Boom('Missing sender JID', { statusCode: 400 });
+    }
     const senderPn = (_a = stanza === null || stanza === void 0 ? void 0 : stanza.attrs) === null || _a === void 0 ? void 0 : _a.sender_pn;
     const senderLid = (_b = stanza === null || stanza === void 0 ? void 0 : stanza.attrs) === null || _b === void 0 ? void 0 : _b.sender_lid;
     const participant = stanza.attrs.participant;

package/lib/Utils/messages.js

@@ -1194,49 +1194,4 @@ const assertMediaContent = (content) => {
     return mediaContent;
 };
 exports.assertMediaContent = assertMediaContent;
-const getNormalizedJid = (jid) => {
-    if (!jid) return jid;
-    return (0, WABinary_1.jidNormalizedUser)(jid);
-};
-exports.getNormalizedJid = getNormalizedJid;
-
-const isLidFormat = (jid) => {
-    return (0, WABinary_1.isLidUser)(jid);
-};
-exports.isLidFormat = isLidFormat;
 
-// Legacy compatibility functions - deprecated, use native APIs
-const toJid = (id) => {
-    console.warn('toJid is deprecated. Use getNormalizedJid instead.');
-    return getNormalizedJid(id);
-};
-exports.toJid = toJid;
-
-const getSenderLid = (message) => {
-    const sender = message?.key?.participant || message?.key?.remoteJid;
-    if (!sender) return null;
-
-    const normalized = getNormalizedJid(sender);
-    return {
-        jid: sender,
-        lid: normalized,
-        isValid: true,
-        user: (0, WABinary_1.jidDecode)(normalized)?.user || 'unknown'
-    };
-};
-exports.getSenderLid = getSenderLid;
-
-const validateJid = (jid) => {
-    console.warn('validateJid is deprecated. Use native Baileys validation.');
-    if (!jid || typeof jid !== 'string') {
-        return { isValid: false, error: 'Invalid JID: must be a non-empty string' };
-    }
-
-    try {
-        const decoded = (0, WABinary_1.jidDecode)(jid);
-        return { isValid: !!decoded };
-    } catch {
-        return { isValid: false, error: 'Invalid JID format' };
-    }
-};
-exports.validateJid = validateJid;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@realvare/based",
-  "version": "2.7.02",
+  "version": "2.7.4",
   "description": "whatsapp api by sam",
   "keywords": [
     "baileys",
@@ -9,7 +9,8 @@
     "whatsapp-web",
     "whatsapp-bot",
     "automation",
-    "multi-device"
+    "multi-device",
+    "based"
   ],
   "homepage": "https://github.com/realvare/based.git",
   "repository": {
@@ -44,20 +45,20 @@
     "@cacheable/node-cache": "^1.4.0",
     "@hapi/boom": "^10.0.1",
     "async-mutex": "^0.5.0",
-    "axios": "^1.7.0",
-    "cache-manager": "^5.7.6",
+    "axios": "^1.13.2",
+    "cache-manager": "^7.2.5",
     "chalk": "^4.1.2",
-    "cheerio": "^1.0.0-rc.12",
+    "cheerio": "^1.1.2",
     "gradient-string": "^2.0.2",
-    "jimp": "^0.22.10",
-    "libphonenumber-js": "^1.10.58",
-    "libsignal": "github:NaufalYupra/libsignal-node",
+    "jimp": "^1.6.0",
+    "libphonenumber-js": "^1.12.31",
+    "libsignal": "npm:@newfadel/libsignal-node",
     "lodash": "^4.17.21",
-    "music-metadata": "^7.12.3",
-    "pino": "^9.6",
-    "protobufjs": "^7.2.5",
-    "uuid": "^10.0.0",
-    "ws": "^8.18.0"
+    "music-metadata": "^11.7.0",
+    "pino": "^10.1.0",
+    "protobufjs": "^7.5.4",
+    "uuid": "^13.0.0",
+    "ws": "^8.18.3"
   },
   "devDependencies": {
     "@adiwajshing/eslint-config": "github:adiwajshing/eslint-config",
@@ -69,7 +70,7 @@
     "conventional-changelog-cli": "^2.2.2",
     "eslint": "^8.57.0",
     "jest": "^29.7.0",
-    "jimp": "^0.22.10",
+    "jimp": "^1.6.0",
     "json": "^11.0.0",
     "link-preview-js": "^3.0.0",
     "open": "^10.1.0",
@@ -79,7 +80,7 @@
     "ts-jest": "^29.1.2",
     "ts-node": "^10.9.2",
     "typedoc": "^0.25.12",
-    "typescript": "^5.6.0"
+    "typescript": "^5.9.3"
   },
   "peerDependencies": {
     "audio-decode": "^2.1.3",