@realfavicongenerator/check-favicon 0.4.6 → 0.4.7

package/dist/desktop/desktop.test.js

@@ -73,6 +73,21 @@ test('checkSvgFavicon - svgFaviconDeclared & svgFaviconCannotGet', () => __await
         }
     });
 }));
+// For https://github.com/RealFaviconGenerator/core/issues/2
+test('checkSvgFavicon - Protocol-relative URL', () => __awaiter(void 0, void 0, void 0, function* () {
+    yield runSvgTest(`<link rel="icon" type="image/svg+xml" href="//example.com/the-icon.svg" />`, [{
+            status: types_1.CheckerStatus.Ok,
+            id: types_1.MessageId.svgFaviconDeclared,
+        }, {
+            status: types_1.CheckerStatus.Error,
+            id: types_1.MessageId.svgFaviconCannotGet,
+        }], {
+        'https://example.com/the-icon.svg': {
+            status: 403,
+            contentType: 'image/svg+xml'
+        }
+    });
+}));
 test('checkSvgFavicon - svgFaviconDeclared & svgFaviconDownloadable & svgFaviconSquare', () => __awaiter(void 0, void 0, void 0, function* () {
     const testIconPath = './fixtures/happy-face.svg';
     const serpIcon = yield (0, helper_1.filePathToString)(testIconPath);

package/dist/helper.js

@@ -145,8 +145,12 @@ const mergeUrlAndPath = (baseUrl, absoluteOrRelativePath) => {
         return absoluteOrRelativePath;
     }
     const url = new URL(baseUrl);
-    // If the path starts with a slash, replace the pathname
-    if (absoluteOrRelativePath.startsWith('/')) {
+    // Protocol-relative URL
+    if (absoluteOrRelativePath.startsWith('//')) {
+        return `${url.protocol}${absoluteOrRelativePath}`;
+    }
+    else if (absoluteOrRelativePath.startsWith('/')) {
+        // If the path starts with a slash, replace the pathname
         return `${url.origin}${absoluteOrRelativePath}`;
     }
     else {

package/dist/helper.test.js

@@ -112,6 +112,10 @@ test('mergeUrlAndPath', () => {
     expect((0, helper_1.mergeUrlAndPath)('https://example.com/sub-page', '/some-path')).toBe('https://example.com/some-path');
     expect((0, helper_1.mergeUrlAndPath)('https://example.com/sub-page', 'some/path')).toBe('https://example.com/sub-page/some/path');
     expect((0, helper_1.mergeUrlAndPath)('https://example.com', 'https://elsewhere.com/some-path')).toBe('https://elsewhere.com/some-path');
+    // Protocol-relative URL
+    // For https://github.com/RealFaviconGenerator/core/issues/2
+    expect((0, helper_1.mergeUrlAndPath)('https://example.com', '//elsewhere.com/some-path')).toBe('https://elsewhere.com/some-path');
+    expect((0, helper_1.mergeUrlAndPath)('http://example.com', '//elsewhere.com/some-other/path')).toBe('http://elsewhere.com/some-other/path');
 });
 test('parseSizesAttribute', () => {
     expect((0, helper_1.parseSizesAttribute)(null)).toEqual(null);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@realfavicongenerator/check-favicon",
-  "version": "0.4.6",
+  "version": "0.4.7",
   "description": "Check the favicon of a website",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -38,6 +38,5 @@
     "decode-ico": "^0.4.1",
     "node-html-parser": "^6.1.13",
     "sharp": "^0.32.6"
-  },
-  "gitHead": "f62941a779e6ce1b49ad97bfea8a9eb71e7ceba5"
+  }
 }

package/src/desktop/desktop.test.ts

@@ -76,6 +76,22 @@ test('checkSvgFavicon - svgFaviconDeclared & svgFaviconCannotGet', async () => {
   });
 })
 
+// For https://github.com/RealFaviconGenerator/core/issues/2
+test('checkSvgFavicon - Protocol-relative URL', async () => {
+  await runSvgTest(`<link rel="icon" type="image/svg+xml" href="//example.com/the-icon.svg" />`, [{
+    status: CheckerStatus.Ok,
+    id: MessageId.svgFaviconDeclared,
+  }, {
+    status: CheckerStatus.Error,
+    id: MessageId.svgFaviconCannotGet,
+  }], {
+    'https://example.com/the-icon.svg': {
+      status: 403,
+      contentType: 'image/svg+xml'
+    }
+  });
+})
+
 test('checkSvgFavicon - svgFaviconDeclared & svgFaviconDownloadable & svgFaviconSquare', async () => {
   const testIconPath = './fixtures/happy-face.svg';
 

package/src/helper.test.ts

@@ -117,6 +117,11 @@ test('mergeUrlAndPath', () => {
   expect(mergeUrlAndPath('https://example.com/sub-page', 'some/path')).toBe('https://example.com/sub-page/some/path');
 
   expect(mergeUrlAndPath('https://example.com', 'https://elsewhere.com/some-path')).toBe('https://elsewhere.com/some-path');
+
+  // Protocol-relative URL
+  // For https://github.com/RealFaviconGenerator/core/issues/2
+  expect(mergeUrlAndPath('https://example.com', '//elsewhere.com/some-path')).toBe('https://elsewhere.com/some-path');
+  expect(mergeUrlAndPath('http://example.com', '//elsewhere.com/some-other/path')).toBe('http://elsewhere.com/some-other/path');
 })
 
 test('parseSizesAttribute', () => {

package/src/helper.ts

@@ -156,8 +156,11 @@ export const mergeUrlAndPath = (baseUrl: string, absoluteOrRelativePath: string)
 
   const url = new URL(baseUrl);
 
-  // If the path starts with a slash, replace the pathname
-  if (absoluteOrRelativePath.startsWith('/')) {
+  // Protocol-relative URL
+  if (absoluteOrRelativePath.startsWith('//')) {
+    return `${url.protocol}${absoluteOrRelativePath}`;
+  } else if (absoluteOrRelativePath.startsWith('/')) {
+    // If the path starts with a slash, replace the pathname
     return `${url.origin}${absoluteOrRelativePath}`;
   } else {
     // Otherwise, append the path to the existing pathname

package/LICENSE

@@ -1,21 +0,0 @@
-MIT License
-
-Copyright (c) 2024 RealFaviconGenerator
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.