@readme/httpsnippet 3.1.3 → 4.0.2

package/dist/src/targets/swift/nsurlsession/client.js

@@ -0,0 +1,156 @@
+"use strict";
+/**
+ * @description
+ * HTTP code snippet generator for Swift using NSURLSession.
+ *
+ * @author
+ * @thibaultCha
+ *
+ * for any questions or issues regarding the generated code snippet, please open an issue mentioning the author.
+ */
+var __assign = (this && this.__assign) || function () {
+    __assign = Object.assign || function(t) {
+        for (var s, i = 1, n = arguments.length; i < n; i++) {
+            s = arguments[i];
+            for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p))
+                t[p] = s[p];
+        }
+        return t;
+    };
+    return __assign.apply(this, arguments);
+};
+var __read = (this && this.__read) || function (o, n) {
+    var m = typeof Symbol === "function" && o[Symbol.iterator];
+    if (!m) return o;
+    var i = m.call(o), r, ar = [], e;
+    try {
+        while ((n === void 0 || n-- > 0) && !(r = i.next()).done) ar.push(r.value);
+    }
+    catch (error) { e = { error: error }; }
+    finally {
+        try {
+            if (r && !r.done && (m = i["return"])) m.call(i);
+        }
+        finally { if (e) throw e.error; }
+    }
+    return ar;
+};
+exports.__esModule = true;
+exports.nsurlsession = void 0;
+var code_builder_1 = require("../../../helpers/code-builder");
+var helpers_1 = require("../helpers");
+exports.nsurlsession = {
+    info: {
+        key: 'nsurlsession',
+        title: 'NSURLSession',
+        link: 'https://developer.apple.com/library/mac/documentation/Foundation/Reference/NSURLSession_class/index.html',
+        description: "Foundation's NSURLSession request"
+    },
+    convert: function (_a, options) {
+        var allHeaders = _a.allHeaders, postData = _a.postData, fullUrl = _a.fullUrl, method = _a.method;
+        var opts = __assign({ indent: '  ', pretty: true, timeout: '10' }, options);
+        var _b = new code_builder_1.CodeBuilder({ indent: opts.indent }), push = _b.push, blank = _b.blank, join = _b.join;
+        // Markers for headers to be created as litteral objects and later be set on the NSURLRequest if exist
+        var req = {
+            hasHeaders: false,
+            hasBody: false
+        };
+        // We just want to make sure people understand that is the only dependency
+        push('import Foundation');
+        if (Object.keys(allHeaders).length) {
+            req.hasHeaders = true;
+            blank();
+            push((0, helpers_1.literalDeclaration)('headers', allHeaders, opts));
+        }
+        if (postData.text || postData.jsonObj || postData.params) {
+            req.hasBody = true;
+            switch (postData.mimeType) {
+                case 'application/x-www-form-urlencoded':
+                    // By appending parameters one by one in the resulting snippet,
+                    // we make it easier for the user to edit it according to his or her needs after pasting.
+                    // The user can just add/remove lines adding/removing body parameters.
+                    blank();
+                    if (postData.params) {
+                        var _c = __read(postData.params), head = _c[0], tail = _c.slice(1);
+                        push("let postData = NSMutableData(data: \"".concat(head.name, "=").concat(head.value, "\".data(using: String.Encoding.utf8)!)"));
+                        tail.forEach(function (_a) {
+                            var name = _a.name, value = _a.value;
+                            push("postData.append(\"&".concat(name, "=").concat(value, "\".data(using: String.Encoding.utf8)!)"));
+                        });
+                    }
+                    else {
+                        req.hasBody = false;
+                    }
+                    break;
+                case 'application/json':
+                    if (postData.jsonObj) {
+                        push("".concat((0, helpers_1.literalDeclaration)('parameters', postData.jsonObj, opts), " as [String : Any]"));
+                        blank();
+                        push('let postData = JSONSerialization.data(withJSONObject: parameters, options: [])');
+                    }
+                    break;
+                case 'multipart/form-data':
+                    /**
+                     * By appending multipart parameters one by one in the resulting snippet,
+                     * we make it easier for the user to edit it according to his or her needs after pasting.
+                     * The user can just edit the parameters NSDictionary or put this part of a snippet in a multipart builder method.
+                     */
+                    push((0, helpers_1.literalDeclaration)('parameters', postData.params, opts));
+                    blank();
+                    push("let boundary = \"".concat(postData.boundary, "\""));
+                    blank();
+                    push('var body = ""');
+                    push('var error: NSError? = nil');
+                    push('for param in parameters {');
+                    push('let paramName = param["name"]!', 1);
+                    push('body += "--\\(boundary)\\r\\n"', 1);
+                    push('body += "Content-Disposition:form-data; name=\\"\\(paramName)\\""', 1);
+                    push('if let filename = param["fileName"] {', 1);
+                    push('let contentType = param["content-type"]!', 2);
+                    push('let fileContent = String(contentsOfFile: filename, encoding: String.Encoding.utf8)', 2);
+                    push('if (error != nil) {', 2);
+                    push('print(error as Any)', 3);
+                    push('}', 2);
+                    push('body += "; filename=\\"\\(filename)\\"\\r\\n"', 2);
+                    push('body += "Content-Type: \\(contentType)\\r\\n\\r\\n"', 2);
+                    push('body += fileContent', 2);
+                    push('} else if let paramValue = param["value"] {', 1);
+                    push('body += "\\r\\n\\r\\n\\(paramValue)"', 2);
+                    push('}', 1);
+                    push('}');
+                    break;
+                default:
+                    blank();
+                    push("let postData = NSData(data: \"".concat(postData.text, "\".data(using: String.Encoding.utf8)!)"));
+            }
+        }
+        blank();
+        // NSURLRequestUseProtocolCachePolicy is the default policy, let's just always set it to avoid confusion.
+        push("let request = NSMutableURLRequest(url: NSURL(string: \"".concat(fullUrl, "\")! as URL,"));
+        push('                                        cachePolicy: .useProtocolCachePolicy,');
+        push(
+        // @ts-expect-error needs better types
+        "                                    timeoutInterval: ".concat(parseInt(opts.timeout, 10).toFixed(1), ")"));
+        push("request.httpMethod = \"".concat(method, "\""));
+        if (req.hasHeaders) {
+            push('request.allHTTPHeaderFields = headers');
+        }
+        if (req.hasBody) {
+            push('request.httpBody = postData as Data');
+        }
+        blank();
+        // Retrieving the shared session will be less verbose than creating a new one.
+        push('let session = URLSession.shared');
+        push('let dataTask = session.dataTask(with: request as URLRequest, completionHandler: { (data, response, error) -> Void in');
+        push('if (error != nil) {', 1);
+        push('print(error as Any)', 2);
+        push('} else {', 1); // Casting the NSURLResponse to NSHTTPURLResponse so the user can see the status     .
+        push('let httpResponse = response as? HTTPURLResponse', 2);
+        push('print(httpResponse)', 2);
+        push('}', 1);
+        push('})');
+        blank();
+        push('dataTask.resume()');
+        return join();
+    }
+};

package/dist/src/targets/swift/target.js

@@ -0,0 +1,15 @@
+"use strict";
+exports.__esModule = true;
+exports.swift = void 0;
+var client_1 = require("./nsurlsession/client");
+exports.swift = {
+    info: {
+        key: 'swift',
+        title: 'Swift',
+        extname: '.swift',
+        "default": 'nsurlsession'
+    },
+    clientsById: {
+        nsurlsession: client_1.nsurlsession
+    }
+};

package/dist/src/targets/targets.js

@@ -0,0 +1,130 @@
+"use strict";
+exports.__esModule = true;
+exports.addTargetClient = exports.isClient = exports.addTarget = exports.isTarget = exports.targets = void 0;
+var target_1 = require("./c/target");
+var target_2 = require("./clojure/target");
+var target_3 = require("./csharp/target");
+var target_4 = require("./go/target");
+var target_5 = require("./http/target");
+var target_6 = require("./java/target");
+var target_7 = require("./javascript/target");
+var target_8 = require("./kotlin/target");
+var target_9 = require("./node/target");
+var target_10 = require("./objc/target");
+var target_11 = require("./ocaml/target");
+var target_12 = require("./php/target");
+var target_13 = require("./powershell/target");
+var target_14 = require("./python/target");
+var target_15 = require("./r/target");
+var target_16 = require("./ruby/target");
+var target_17 = require("./shell/target");
+var target_18 = require("./swift/target");
+exports.targets = {
+    c: target_1.c,
+    clojure: target_2.clojure,
+    csharp: target_3.csharp,
+    go: target_4.go,
+    http: target_5.http,
+    java: target_6.java,
+    javascript: target_7.javascript,
+    kotlin: target_8.kotlin,
+    node: target_9.node,
+    objc: target_10.objc,
+    ocaml: target_11.ocaml,
+    php: target_12.php,
+    powershell: target_13.powershell,
+    python: target_14.python,
+    r: target_15.r,
+    ruby: target_16.ruby,
+    shell: target_17.shell,
+    swift: target_18.swift
+};
+var isTarget = function (target) {
+    if (typeof target !== 'object' || target === null || Array.isArray(target)) {
+        var got = target === null ? 'null' : Array.isArray(target) ? 'array' : typeof target;
+        throw new Error("you tried to add a target which is not an object, got type: \"".concat(got, "\""));
+    }
+    if (!Object.prototype.hasOwnProperty.call(target, 'info')) {
+        throw new Error('targets must contain an `info` object');
+    }
+    if (!Object.prototype.hasOwnProperty.call(target.info, 'key')) {
+        throw new Error('targets must have an `info` object with the property `key`');
+    }
+    if (!target.info.key) {
+        throw new Error('target key must be a unique string');
+    }
+    if (Object.prototype.hasOwnProperty.call(exports.targets, target.info.key)) {
+        throw new Error("a target already exists with this key, `".concat(target.info.key, "`"));
+    }
+    if (!Object.prototype.hasOwnProperty.call(target.info, 'title')) {
+        throw new Error('targets must have an `info` object with the property `title`');
+    }
+    if (!target.info.title) {
+        throw new Error('target title must be a non-zero-length string');
+    }
+    if (!Object.prototype.hasOwnProperty.call(target.info, 'extname')) {
+        throw new Error('targets must have an `info` object with the property `extname`');
+    }
+    if (!Object.prototype.hasOwnProperty.call(target, 'clientsById') ||
+        !target.clientsById ||
+        Object.keys(target.clientsById).length === 0) {
+        throw new Error("No clients provided in target ".concat(target.info.key, ".  You must provide the property `clientsById` containg your clients."));
+    }
+    if (!Object.prototype.hasOwnProperty.call(target.info, 'default')) {
+        throw new Error('targets must have an `info` object with the property `default`');
+    }
+    if (!Object.prototype.hasOwnProperty.call(target.clientsById, target.info["default"])) {
+        throw new Error("target ".concat(target.info.key, " is configured with a default client ").concat(target.info["default"], ", but no such client was found in the property `clientsById` (found ").concat(JSON.stringify(Object.keys(target.clientsById)), ")"));
+    }
+    Object.values(target.clientsById).forEach(exports.isClient);
+    return true;
+};
+exports.isTarget = isTarget;
+var addTarget = function (target) {
+    if (!(0, exports.isTarget)(target)) {
+        return;
+    }
+    exports.targets[target.info.key] = target;
+};
+exports.addTarget = addTarget;
+var isClient = function (client) {
+    if (!client) {
+        throw new Error('clients must be objects');
+    }
+    if (!Object.prototype.hasOwnProperty.call(client, 'info')) {
+        throw new Error('targets client must contain an `info` object');
+    }
+    if (!Object.prototype.hasOwnProperty.call(client.info, 'key')) {
+        throw new Error('targets client must have an `info` object with property `key`');
+    }
+    if (!client.info.key) {
+        throw new Error('client.info.key must contain an identifier unique to this target');
+    }
+    if (!Object.prototype.hasOwnProperty.call(client.info, 'title')) {
+        throw new Error('targets client must have an `info` object with property `title`');
+    }
+    if (!Object.prototype.hasOwnProperty.call(client.info, 'description')) {
+        throw new Error('targets client must have an `info` object with property `description`');
+    }
+    if (!Object.prototype.hasOwnProperty.call(client.info, 'link')) {
+        throw new Error('targets client must have an `info` object with property `link`');
+    }
+    if (!Object.prototype.hasOwnProperty.call(client, 'convert') || typeof client.convert !== 'function') {
+        throw new Error('targets client must have a `convert` property containing a conversion function');
+    }
+    return true;
+};
+exports.isClient = isClient;
+var addTargetClient = function (targetId, client) {
+    if (!(0, exports.isClient)(client)) {
+        return;
+    }
+    if (!Object.prototype.hasOwnProperty.call(exports.targets, targetId)) {
+        throw new Error("Sorry, but no ".concat(targetId, " target exists to add clients to"));
+    }
+    if (Object.prototype.hasOwnProperty.call(exports.targets[targetId], client.info.key)) {
+        throw new Error("the target ".concat(targetId, " already has a client with the key ").concat(client.info.key, ", please use a different key"));
+    }
+    exports.targets[targetId].clientsById[client.info.key] = client;
+};
+exports.addTargetClient = addTargetClient;

package/package.json

@@ -1,10 +1,11 @@
 {
-  "version": "3.1.3",
+  "version": "4.0.2",
   "name": "@readme/httpsnippet",
   "description": "HTTP Request snippet generator for *most* languages",
   "homepage": "https://github.com/readmeio/httpsnippet",
   "license": "MIT",
-  "main": "src/index.js",
+  "main": "dist/index.js",
+  "types": "dist/index.d.ts",
   "keywords": [
     "api",
     "clojure",
@@ -36,46 +37,50 @@
     "xmlhttprequest"
   ],
   "engines": {
-    "node": ">=10"
+    "node": ">=14"
   },
   "files": [
-    "bin",
-    "src"
+    "dist"
   ],
   "repository": {
     "type": "git",
     "url": "https://github.com/readmeio/httpsnippet.git"
   },
   "scripts": {
+    "build": "tsc --build tsconfig.build.json",
+    "clean": "tsc --build tsconfig.build.json --clean",
     "lint": "eslint .",
+    "prebuild": "npm run clean",
+    "prepack": "npm run build",
     "pretest": "npm run lint",
     "prettier": "prettier --list-different --write \"./**/**.js\"",
     "test": "jest --coverage"
   },
   "devDependencies": {
-    "@readme/eslint-config": "^8.0.2",
-    "eslint": "^8.3.0",
+    "@readme/eslint-config": "^8.8.3",
+    "@types/eslint": "^8.4.1",
+    "@types/event-stream": "^4.0.0",
+    "@types/har-format": "^1.2.8",
+    "@types/jest": "^27.4.1",
+    "@types/node": "^16.11.26",
+    "@types/qs": "^6.9.7",
+    "@types/stringify-object": "^4.0.1",
+    "eslint": "^8.19.0",
     "glob": "^8.0.1",
     "jest": "^28.0.3",
-    "prettier": "^2.5.0",
-    "require-directory": "^2.1.1"
+    "prettier": "^2.7.1",
+    "require-directory": "^2.1.1",
+    "ts-jest": "^28.0.5",
+    "type-fest": "^2.12.2",
+    "typescript": "^4.6.3"
   },
   "dependencies": {
+    "ajv": "^6.12.6",
     "event-stream": "4.0.1",
     "form-data": "^4.0.0",
-    "har-validator": "^5.0.0",
+    "har-schema": "^2.0.0",
     "qs": "^6.10.1",
     "stringify-object": "^3.3.0"
   },
-  "prettier": "@readme/eslint-config/prettier",
-  "jest": {
-    "coveragePathIgnorePatterns": [
-      "<rootDir>/__tests__/(.*)/__fixtures__/",
-      "<rootDir>/node_modules"
-    ],
-    "testPathIgnorePatterns": [
-      "<rootDir>/__tests__/__fixtures__/",
-      "<rootDir>/__tests__/targets/"
-    ]
-  }
+  "prettier": "@readme/eslint-config/prettier"
 }

package/src/helpers/code-builder.js

@@ -1,108 +0,0 @@
-/* eslint-disable no-param-reassign */
-const { format } = require('util');
-
-/**
- * Helper object to format and aggragate lines of code.
- * Lines are aggregated in a `code` array, and need to be joined to obtain a proper code snippet.
- *
- * @class
- *
- * @param {string} indentation Desired indentation character for aggregated lines of code
- * @param {string} join Desired character to join each line of code
- */
-class CodeBuilder {
-  constructor(indentation, join) {
-    this.code = [];
-    this.indentation = indentation;
-    this.lineJoin = join || '\n';
-  }
-
-  /**
-   * Add given indentation level to given string and format the string (variadic)
-   * @param {number} [indentationLevel=0] - Desired level of indentation for this line
-   * @param {string} line - Line of code. Can contain formatting placeholders
-   * @param {...anyobject} - Parameter to bind to `line`'s formatting placeholders
-   * @return {string}
-   *
-   * @example
-   *   var builder = CodeBuilder('\t')
-   *
-   *   builder.buildLine('console.log("hello world")')
-   *   // returns: 'console.log("hello world")'
-   *
-   *   builder.buildLine(2, 'console.log("hello world")')
-   *   // returns: 'console.log("\t\thello world")'
-   *
-   *   builder.buildLine(2, 'console.log("%s %s")', 'hello', 'world')
-   *   // returns: 'console.log("\t\thello world")'
-   */
-  buildLine(indentationLevel, line) {
-    let lineIndentation = '';
-    let slice = 2;
-    if (Object.prototype.toString.call(indentationLevel) === '[object String]') {
-      slice = 1;
-      line = indentationLevel;
-      indentationLevel = 0;
-    } else if (indentationLevel === null) {
-      return null;
-    }
-
-    while (indentationLevel) {
-      lineIndentation += this.indentation;
-      // eslint-disable-next-line no-plusplus
-      indentationLevel--;
-    }
-
-    // eslint-disable-next-line prefer-rest-params
-    const data = Array.prototype.slice.call(arguments, slice, arguments.length);
-    data.unshift(lineIndentation + line);
-
-    return format.apply(this, data);
-  }
-
-  /**
-   * Invoke buildLine() and add the line at the top of current lines
-   * @param {number} [indentationLevel=0] Desired level of indentation for this line
-   * @param {string} line Line of code
-   * @return {this}
-   */
-  unshift(...args) {
-    // eslint-disable-next-line prefer-spread
-    this.code.unshift(this.buildLine.apply(this, args));
-
-    return this;
-  }
-
-  /**
-   * Invoke buildLine() and add the line at the bottom of current lines
-   * @param {number} [indentationLevel=0] Desired level of indentation for this line
-   * @param {string} line Line of code
-   * @return {this}
-   */
-  push(...args) {
-    // eslint-disable-next-line prefer-spread
-    this.code.push(this.buildLine.apply(this, args));
-
-    return this;
-  }
-
-  /**
-   * Add an empty line at the end of current lines
-   * @return {this}
-   */
-  blank() {
-    this.code.push(null);
-
-    return this;
-  }
-
-  /**
-   * Concatenate all current lines using the given lineJoin
-   * @return {string}
-   */
-  join() {
-    return this.code.join(this.lineJoin);
-  }
-}
-
-module.exports = CodeBuilder;

package/src/helpers/form-data.js

@@ -1,107 +0,0 @@
-/**
- * @license https://raw.githubusercontent.com/node-fetch/node-fetch/master/LICENSE.md
- *
- * The MIT License (MIT)
- *
- * Copyright (c) 2016 - 2020 Node Fetch Team
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in all
- * copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- * SOFTWARE.
- *
- * Extracted from https://github.com/node-fetch/node-fetch/blob/64c5c296a0250b852010746c76144cb9e14698d9/src/utils/form-data.js
- */
-
-const carriage = '\r\n';
-const dashes = '-'.repeat(2);
-
-const NAME = Symbol.toStringTag;
-
-const isBlob = object => {
-  return (
-    typeof object === 'object' &&
-    typeof object.arrayBuffer === 'function' &&
-    typeof object.type === 'string' &&
-    typeof object.stream === 'function' &&
-    typeof object.constructor === 'function' &&
-    /^(Blob|File)$/.test(object[NAME])
-  );
-};
-
-/**
- * @param {string} boundary
- */
-const getFooter = boundary => `${dashes}${boundary}${dashes}${carriage.repeat(2)}`;
-
-/**
- * @param {string} boundary
- * @param {string} name
- * @param {*} field
- *
- * @return {string}
- */
-function getHeader(boundary, name, field) {
-  let header = '';
-
-  header += `${dashes}${boundary}${carriage}`;
-  header += `Content-Disposition: form-data; name="${name}"`;
-
-  if (isBlob(field)) {
-    header += `; filename="${field.name}"${carriage}`;
-    header += `Content-Type: ${field.type || 'application/octet-stream'}`;
-  }
-
-  return `${header}${carriage.repeat(2)}`;
-}
-
-/**
- * @return {string}
- */
-module.exports.getBoundary = () => {
-  // This generates a 50 character boundary similar to those used by Firefox.
-  // They are optimized for boyer-moore parsing.
-  let boundary = '--------------------------';
-  // eslint-disable-next-line no-plusplus
-  for (let i = 0; i < 24; i++) {
-    boundary += Math.floor(Math.random() * 10).toString(16);
-  }
-
-  return boundary;
-};
-
-/**
- * @param {FormData} form
- * @param {string} boundary
- */
-module.exports.formDataIterator = function* (form, boundary) {
-  // eslint-disable-next-line no-restricted-syntax
-  for (const [name, value] of form) {
-    yield getHeader(boundary, name, value);
-
-    if (isBlob(value)) {
-      yield* value.stream();
-    } else {
-      yield value;
-    }
-
-    yield carriage;
-  }
-
-  yield getFooter(boundary);
-};
-
-module.exports.isBlob = isBlob;

package/src/helpers/headers.js

@@ -1,48 +0,0 @@
-module.exports = {
-  /**
-   * Given a headers object retrieve the contents of a header out of it via a case-insensitive key.
-   *
-   * @param {object} headers
-   * @param {string} name
-   * @return {string}
-   */
-  getHeader: (headers, name) => {
-    return headers[Object.keys(headers).find(k => k.toLowerCase() === name.toLowerCase())];
-  },
-
-  /**
-   * Given a headers object retrieve a specific header out of it via a case-insensitive key.
-   *
-   * @param {object} headers
-   * @param {string} name
-   * @return {string}
-   */
-  getHeaderName: (headers, name) => {
-    return Object.keys(headers).find(k => {
-      return k.toLowerCase() === name.toLowerCase();
-    });
-  },
-
-  /**
-   * Determine if a given case-insensitive header exists within a header object.
-   *
-   * @param {object} headers
-   * @param {string} name
-   * @return {(integer|boolean)}
-   */
-  hasHeader: (headers, name) => {
-    return Boolean(Object.keys(headers).find(k => k.toLowerCase() === name.toLowerCase()));
-  },
-
-  /**
-   * Determines if a given mimetype is JSON, or a variant of such.
-   *
-   * @param {string}} mimeType
-   * @returns {boolean}
-   */
-  isMimeTypeJson: mimeType => {
-    return ['application/json', 'application/x-json', 'text/json', 'text/x-json', '+json'].some(function (type) {
-      return mimeType.indexOf(type) > -1;
-    });
-  },
-};

package/src/helpers/reducer.js

@@ -1,20 +0,0 @@
-/* eslint-disable no-param-reassign */
-module.exports = function (obj, pair) {
-  if (obj[pair.name] === undefined) {
-    obj[pair.name] = pair.value;
-    return obj;
-  }
-
-  // If we already have it as array just push the value
-  if (Array.isArray(obj[pair.name])) {
-    obj[pair.name].push(pair.value);
-    return obj;
-  }
-
-  // convert to array
-  const arr = [obj[pair.name], pair.value];
-
-  obj[pair.name] = arr;
-
-  return obj;
-};