@reactoo/watchtogether-sdk-js 2.5.56 → 2.5.59

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@reactoo/watchtogether-sdk-js",
-  "version": "2.5.56",
+  "version": "2.5.59",
   "description": "Javascript SDK for Reactoo",
   "main": "src/index.js",
   "unpkg": "dist/watchtogether-sdk.min.js",

package/src/modules/sync-modules/sync-module.js

@@ -7,6 +7,7 @@ const syncModule = function ({room, emitter} = {}) {
 	let _emitter = localEmitter();
 	
 	let _playerInterface = null;
+	let _propagateMaster = false;
 	let _playerInterfaceOptions = {
 		type: 'none',
 		ignoreBufferedTimeRanges: true,
@@ -14,7 +15,7 @@ const syncModule = function ({room, emitter} = {}) {
 	};
 	const syncDefaultWaitTime = 60000;
 	const syncShortWaitTime = 10000;
-	const maxSyncThreshold = 0.5;
+	const maxSyncThreshold = 0.4;
 	const maxSyncTries = 3;
 	const waitForPlayingEventAfterSeek = 5000;
 	const fastForwardThreshold = 4
@@ -28,7 +29,6 @@ const syncModule = function ({room, emitter} = {}) {
 	let isPlaying = false;
 	let isPreloading = true;
 	let isProgrammaticallySeeked = false;
-	let shouldPropagateMaster = false;
 	
 	const startSyncLoop = () => {
 		
@@ -117,7 +117,7 @@ const syncModule = function ({room, emitter} = {}) {
 					return Promise.resolve();
 				}
 				
-				else if(shouldPropagateMaster) {
+				else if(_propagateMaster) {
 					setNextWaitTime(false);
 					return propagateMasterFunc();
 				}
@@ -134,7 +134,7 @@ const syncModule = function ({room, emitter} = {}) {
 						return Promise.resolve();
 					}
 					
-					if(position !== null) {
+					if(position !== null && !isNaN(position)) {
 						return seekBy(position)
 							.then(() => {
 								const seekDuration = (Date.now() - syncStartTime) / 1000;
@@ -142,7 +142,7 @@ const syncModule = function ({room, emitter} = {}) {
 									? _playerInterface.getTimeDifference(syncData.masterFragmentSn, syncData.masterFragmentPos, syncData.ping)
 									:  getTimeDifference(syncData.masterFragmentSn, syncData.masterFragmentPos, syncData.ping);
 
-								const syncPrecision =  Math.abs(realPosition || position);
+								const syncPrecision =  Math.abs(realPosition);
 								room._log(`Insufficient buffer: `, !isBufferSufficient)
 								room._log(`Seek duration is ${seekDuration} seconds`);
 								room._log(`Sync precision should be ${syncPrecision}`);
@@ -152,22 +152,25 @@ const syncModule = function ({room, emitter} = {}) {
 								return Promise.resolve();
 							})
 							.catch((e) => {
+								room._log(`Seek failed: `, e);
 								setNextWaitTime(true);
 								return Promise.reject(e);
 							});
 					} else {
+						room._log(`Position in not a number: `, position);
 						setNextWaitTime(true);
 						return Promise.reject();
 					}
 				}
-			}).catch(() => {
+			}).catch((e) => {
+				room._log(`getSyncData() failed: `, e);
 				setNextWaitTime(true);
 				return Promise.reject();
 			})
 	}
 	
 	const handleAddLocalParticipant = () => {
-		if(shouldPropagateMaster) {
+		if(_propagateMaster) {
 			propagateMasterFunc();
 		}
 		if(_playerInterface.isPaused === false) {
@@ -176,7 +179,7 @@ const syncModule = function ({room, emitter} = {}) {
 	};
 	
 	const handleAddRemoteParticipant = () => {
-		if(shouldPropagateMaster) {
+		if(_propagateMaster) {
 			propagateMasterFunc();
 		}
 	};
@@ -516,15 +519,17 @@ const syncModule = function ({room, emitter} = {}) {
 		
 		__events: ['playerSyncing'],
 		
-		initialize: (playerInterface) => {
+		initialize: ({playerInterface, propagateMaster = false} = {}) => {
 
 			_playerInterface = playerInterface;
 			_playerInterfaceOptions = {..._playerInterfaceOptions, ...(_playerInterface.syncSettings || {})}
-		
+			_propagateMaster = propagateMaster;
+
 			room._log('Interface options passed: ', (_playerInterface.syncSettings || {}));
 			room._log('All interface options: ', _playerInterfaceOptions );
 
 			if(_playerInterfaceOptions.type === 'none') {
+				room._log('Sync module has been disabled via type:none');
 				return;
 			}
 
@@ -557,9 +562,6 @@ const syncModule = function ({room, emitter} = {}) {
 					_emitter.emit('timeupdate', event);
 				}
 			});
-
-
-			shouldPropagateMaster = false;
 			
 			isPlaying = _playerInterface.isPaused === false;
 			
@@ -569,7 +571,7 @@ const syncModule = function ({room, emitter} = {}) {
 			room.on('addRemoteParticipant', handleAddRemoteParticipant);
 			room.on('data', parseDataEvents);
 			
-			if(shouldPropagateMaster) {
+			if(_propagateMaster) {
 				propagateMasterFunc().catch(() => {});
 			}
 			
@@ -580,8 +582,7 @@ const syncModule = function ({room, emitter} = {}) {
 			_emitter.on('buffering', handleBuffering);
 			_emitter.on('playing', handlePlaying);
 			_emitter.on('pause', handlePause);
-			
-			
+
 		},
 		
 		destroy: () => {