@react-spectrum/menu 3.20.5 → 3.21.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (124) hide show
  1. package/dist/ActionMenu.main.js +2 -5
  2. package/dist/ActionMenu.main.js.map +1 -1
  3. package/dist/ActionMenu.mjs +2 -5
  4. package/dist/ActionMenu.module.js +2 -5
  5. package/dist/ActionMenu.module.js.map +1 -1
  6. package/dist/ContextualHelpTrigger.main.js +5 -4
  7. package/dist/ContextualHelpTrigger.main.js.map +1 -1
  8. package/dist/ContextualHelpTrigger.mjs +5 -4
  9. package/dist/ContextualHelpTrigger.module.js +5 -4
  10. package/dist/ContextualHelpTrigger.module.js.map +1 -1
  11. package/dist/Menu.main.js +10 -20
  12. package/dist/Menu.main.js.map +1 -1
  13. package/dist/Menu.mjs +10 -20
  14. package/dist/Menu.module.js +10 -20
  15. package/dist/Menu.module.js.map +1 -1
  16. package/dist/MenuItem.main.js +1 -1
  17. package/dist/MenuItem.main.js.map +1 -1
  18. package/dist/MenuItem.mjs +1 -1
  19. package/dist/MenuItem.module.js +1 -1
  20. package/dist/MenuItem.module.js.map +1 -1
  21. package/dist/MenuSection.main.js +3 -2
  22. package/dist/MenuSection.main.js.map +1 -1
  23. package/dist/MenuSection.mjs +3 -2
  24. package/dist/MenuSection.module.js +3 -2
  25. package/dist/MenuSection.module.js.map +1 -1
  26. package/dist/MenuTrigger.main.js +18 -10
  27. package/dist/MenuTrigger.main.js.map +1 -1
  28. package/dist/MenuTrigger.mjs +21 -13
  29. package/dist/MenuTrigger.module.js +21 -13
  30. package/dist/MenuTrigger.module.js.map +1 -1
  31. package/dist/SubmenuTrigger.main.js +6 -4
  32. package/dist/SubmenuTrigger.main.js.map +1 -1
  33. package/dist/SubmenuTrigger.mjs +6 -4
  34. package/dist/SubmenuTrigger.module.js +6 -4
  35. package/dist/SubmenuTrigger.module.js.map +1 -1
  36. package/dist/ar-AE.main.js.map +1 -1
  37. package/dist/ar-AE.module.js.map +1 -1
  38. package/dist/bg-BG.main.js.map +1 -1
  39. package/dist/bg-BG.module.js.map +1 -1
  40. package/dist/context.main.js.map +1 -1
  41. package/dist/context.module.js.map +1 -1
  42. package/dist/cs-CZ.main.js.map +1 -1
  43. package/dist/cs-CZ.module.js.map +1 -1
  44. package/dist/da-DK.main.js.map +1 -1
  45. package/dist/da-DK.module.js.map +1 -1
  46. package/dist/de-DE.main.js.map +1 -1
  47. package/dist/de-DE.module.js.map +1 -1
  48. package/dist/el-GR.main.js.map +1 -1
  49. package/dist/el-GR.module.js.map +1 -1
  50. package/dist/en-US.main.js.map +1 -1
  51. package/dist/en-US.module.js.map +1 -1
  52. package/dist/es-ES.main.js.map +1 -1
  53. package/dist/es-ES.module.js.map +1 -1
  54. package/dist/et-EE.main.js.map +1 -1
  55. package/dist/et-EE.module.js.map +1 -1
  56. package/dist/fi-FI.main.js.map +1 -1
  57. package/dist/fi-FI.module.js.map +1 -1
  58. package/dist/fr-FR.main.js.map +1 -1
  59. package/dist/fr-FR.module.js.map +1 -1
  60. package/dist/he-IL.main.js.map +1 -1
  61. package/dist/he-IL.module.js.map +1 -1
  62. package/dist/hr-HR.main.js.map +1 -1
  63. package/dist/hr-HR.module.js.map +1 -1
  64. package/dist/hu-HU.main.js.map +1 -1
  65. package/dist/hu-HU.module.js.map +1 -1
  66. package/dist/it-IT.main.js.map +1 -1
  67. package/dist/it-IT.module.js.map +1 -1
  68. package/dist/ja-JP.main.js.map +1 -1
  69. package/dist/ja-JP.module.js.map +1 -1
  70. package/dist/ko-KR.main.js.map +1 -1
  71. package/dist/ko-KR.module.js.map +1 -1
  72. package/dist/lt-LT.main.js.map +1 -1
  73. package/dist/lt-LT.module.js.map +1 -1
  74. package/dist/lv-LV.main.js.map +1 -1
  75. package/dist/lv-LV.module.js.map +1 -1
  76. package/dist/menu_vars_css.main.js +55 -55
  77. package/dist/menu_vars_css.main.js.map +1 -1
  78. package/dist/menu_vars_css.mjs +55 -55
  79. package/dist/menu_vars_css.module.js +55 -55
  80. package/dist/menu_vars_css.module.js.map +1 -1
  81. package/dist/nb-NO.main.js.map +1 -1
  82. package/dist/nb-NO.module.js.map +1 -1
  83. package/dist/nl-NL.main.js.map +1 -1
  84. package/dist/nl-NL.module.js.map +1 -1
  85. package/dist/pl-PL.main.js.map +1 -1
  86. package/dist/pl-PL.module.js.map +1 -1
  87. package/dist/pt-BR.main.js.map +1 -1
  88. package/dist/pt-BR.module.js.map +1 -1
  89. package/dist/pt-PT.main.js.map +1 -1
  90. package/dist/pt-PT.module.js.map +1 -1
  91. package/dist/ro-RO.main.js.map +1 -1
  92. package/dist/ro-RO.module.js.map +1 -1
  93. package/dist/ru-RU.main.js.map +1 -1
  94. package/dist/ru-RU.module.js.map +1 -1
  95. package/dist/sk-SK.main.js.map +1 -1
  96. package/dist/sk-SK.module.js.map +1 -1
  97. package/dist/sl-SI.main.js.map +1 -1
  98. package/dist/sl-SI.module.js.map +1 -1
  99. package/dist/sr-SP.main.js.map +1 -1
  100. package/dist/sr-SP.module.js.map +1 -1
  101. package/dist/sv-SE.main.js.map +1 -1
  102. package/dist/sv-SE.module.js.map +1 -1
  103. package/dist/tr-TR.main.js.map +1 -1
  104. package/dist/tr-TR.module.js.map +1 -1
  105. package/dist/types.d.ts +1 -1
  106. package/dist/types.d.ts.map +1 -1
  107. package/dist/uk-UA.main.js.map +1 -1
  108. package/dist/uk-UA.module.js.map +1 -1
  109. package/dist/{vars.a1f9fd59.css → vars.5486a4f0.css} +117 -116
  110. package/dist/vars.5486a4f0.css.map +1 -0
  111. package/dist/zh-CN.main.js.map +1 -1
  112. package/dist/zh-CN.module.js.map +1 -1
  113. package/dist/zh-TW.main.js.map +1 -1
  114. package/dist/zh-TW.module.js.map +1 -1
  115. package/package.json +25 -25
  116. package/src/ActionMenu.tsx +5 -8
  117. package/src/ContextualHelpTrigger.tsx +8 -8
  118. package/src/Menu.tsx +18 -26
  119. package/src/MenuItem.tsx +1 -1
  120. package/src/MenuSection.tsx +2 -1
  121. package/src/MenuTrigger.tsx +23 -14
  122. package/src/SubmenuTrigger.tsx +7 -7
  123. package/src/context.ts +11 -11
  124. package/dist/vars.a1f9fd59.css.map +0 -1
@@ -1 +1 @@
1
- {"mappings":"AAAA,iBAAiB;IAAG,cAAc,CAAC,OAAS,CAAC,iBAAG,EAAE,KAAK,cAAc,CAAC,CAAC;IACrE,eAAe,CAAC,gCAAI,CAAC;IACrB,eAAe,CAAC,gHAAc,CAAC;AACjC","sources":["packages/@react-spectrum/menu/intl/zh-TW.json"],"sourcesContent":["{\n \"backButton\": \"返回 {prevMenuButton}\",\n \"moreActions\": \"更多動作\",\n \"unavailable\": \"無法使用,展開以取得詳細資料\"\n}\n"],"names":[],"version":3,"file":"zh-TW.main.js.map"}
1
+ {"mappings":"AAAA,iBAAiB;IAAG,cAAc,CAAC,OAAS,CAAC,iBAAG,EAAE,KAAK,cAAc,EAAE;IACrE,eAAe,CAAC,gCAAI,CAAC;IACrB,eAAe,CAAC,gHAAc,CAAC;AACjC","sources":["packages/@react-spectrum/menu/intl/zh-TW.json"],"sourcesContent":["{\n \"backButton\": \"返回 {prevMenuButton}\",\n \"moreActions\": \"更多動作\",\n \"unavailable\": \"無法使用,展開以取得詳細資料\"\n}\n"],"names":[],"version":3,"file":"zh-TW.main.js.map"}
@@ -1 +1 @@
1
- {"mappings":";AAAA,4BAAiB;IAAG,cAAc,CAAC,OAAS,CAAC,iBAAG,EAAE,KAAK,cAAc,CAAC,CAAC;IACrE,eAAe,CAAC,gCAAI,CAAC;IACrB,eAAe,CAAC,gHAAc,CAAC;AACjC","sources":["packages/@react-spectrum/menu/intl/zh-TW.json"],"sourcesContent":["{\n \"backButton\": \"返回 {prevMenuButton}\",\n \"moreActions\": \"更多動作\",\n \"unavailable\": \"無法使用,展開以取得詳細資料\"\n}\n"],"names":[],"version":3,"file":"zh-TW.module.js.map"}
1
+ {"mappings":";AAAA,4BAAiB;IAAG,cAAc,CAAC,OAAS,CAAC,iBAAG,EAAE,KAAK,cAAc,EAAE;IACrE,eAAe,CAAC,gCAAI,CAAC;IACrB,eAAe,CAAC,gHAAc,CAAC;AACjC","sources":["packages/@react-spectrum/menu/intl/zh-TW.json"],"sourcesContent":["{\n \"backButton\": \"返回 {prevMenuButton}\",\n \"moreActions\": \"更多動作\",\n \"unavailable\": \"無法使用,展開以取得詳細資料\"\n}\n"],"names":[],"version":3,"file":"zh-TW.module.js.map"}
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@react-spectrum/menu",
3
- "version": "3.20.5",
3
+ "version": "3.21.1",
4
4
  "description": "Spectrum UI components in React",
5
5
  "license": "Apache-2.0",
6
6
  "main": "dist/main.js",
@@ -36,27 +36,27 @@
36
36
  "url": "https://github.com/adobe/react-spectrum"
37
37
  },
38
38
  "dependencies": {
39
- "@react-aria/focus": "^3.18.4",
40
- "@react-aria/i18n": "^3.12.3",
41
- "@react-aria/interactions": "^3.22.4",
42
- "@react-aria/menu": "^3.15.5",
43
- "@react-aria/overlays": "^3.23.4",
44
- "@react-aria/separator": "^3.4.3",
45
- "@react-aria/utils": "^3.25.3",
46
- "@react-spectrum/button": "^3.16.8",
47
- "@react-spectrum/layout": "^3.6.9",
48
- "@react-spectrum/overlays": "^5.6.5",
49
- "@react-spectrum/text": "^3.5.9",
50
- "@react-spectrum/utils": "^3.11.11",
51
- "@react-stately/collections": "^3.11.0",
52
- "@react-stately/menu": "^3.8.3",
53
- "@react-stately/overlays": "^3.6.11",
54
- "@react-stately/tree": "^3.8.5",
55
- "@react-types/menu": "^3.9.12",
56
- "@react-types/overlays": "^3.8.10",
57
- "@react-types/shared": "^3.25.0",
58
- "@spectrum-icons/ui": "^3.6.10",
59
- "@spectrum-icons/workflow": "^4.2.15",
39
+ "@react-aria/focus": "^3.19.1",
40
+ "@react-aria/i18n": "^3.12.5",
41
+ "@react-aria/interactions": "^3.23.0",
42
+ "@react-aria/menu": "^3.17.0",
43
+ "@react-aria/overlays": "^3.25.0",
44
+ "@react-aria/separator": "^3.4.5",
45
+ "@react-aria/utils": "^3.27.0",
46
+ "@react-spectrum/button": "^3.16.10",
47
+ "@react-spectrum/layout": "^3.6.11",
48
+ "@react-spectrum/overlays": "^5.7.1",
49
+ "@react-spectrum/text": "^3.5.11",
50
+ "@react-spectrum/utils": "^3.12.1",
51
+ "@react-stately/collections": "^3.12.1",
52
+ "@react-stately/menu": "^3.9.1",
53
+ "@react-stately/overlays": "^3.6.13",
54
+ "@react-stately/tree": "^3.8.7",
55
+ "@react-types/menu": "^3.9.14",
56
+ "@react-types/overlays": "^3.8.12",
57
+ "@react-types/shared": "^3.27.0",
58
+ "@spectrum-icons/ui": "^3.6.12",
59
+ "@spectrum-icons/workflow": "^4.2.17",
60
60
  "@swc/helpers": "^0.5.0"
61
61
  },
62
62
  "devDependencies": {
@@ -64,11 +64,11 @@
64
64
  },
65
65
  "peerDependencies": {
66
66
  "@react-spectrum/provider": "^3.0.0",
67
- "react": "^16.8.0 || ^17.0.0-rc.1 || ^18.0.0 || ^19.0.0",
68
- "react-dom": "^16.8.0 || ^17.0.0-rc.1 || ^18.0.0 || ^19.0.0"
67
+ "react": "^16.8.0 || ^17.0.0-rc.1 || ^18.0.0 || ^19.0.0-rc.1",
68
+ "react-dom": "^16.8.0 || ^17.0.0-rc.1 || ^18.0.0 || ^19.0.0-rc.1"
69
69
  },
70
70
  "publishConfig": {
71
71
  "access": "public"
72
72
  },
73
- "gitHead": "8e0a28d188cdbdbd2b32296fa034b1b02ddde229"
73
+ "gitHead": "09e7f44bebdc9d89122926b2b439a0a38a2814ea"
74
74
  }
@@ -23,7 +23,10 @@ import {SpectrumActionMenuProps} from '@react-types/menu';
23
23
  import {useLocalizedStringFormatter} from '@react-aria/i18n';
24
24
  import {useSlotProps} from '@react-spectrum/utils';
25
25
 
26
- function ActionMenu<T extends object>(props: SpectrumActionMenuProps<T>, ref: FocusableRef<HTMLButtonElement>) {
26
+ /**
27
+ * ActionMenu combines an ActionButton with a Menu for simple "more actions" use cases.
28
+ */
29
+ export const ActionMenu = forwardRef(function ActionMenu<T extends object>(props: SpectrumActionMenuProps<T>, ref: FocusableRef<HTMLButtonElement>) {
27
30
  props = useSlotProps(props, 'actionMenu');
28
31
  let stringFormatter = useLocalizedStringFormatter(intlMessages, '@react-spectrum/menu');
29
32
  let buttonProps = filterDOMProps(props, {labelable: true});
@@ -52,10 +55,4 @@ function ActionMenu<T extends object>(props: SpectrumActionMenuProps<T>, ref: Fo
52
55
  onAction={props.onAction} />
53
56
  </MenuTrigger>
54
57
  );
55
- }
56
-
57
- /**
58
- * ActionMenu combines an ActionButton with a Menu for simple "more actions" use cases.
59
- */
60
- const _ActionMenu = forwardRef(ActionMenu) as <T>(props: SpectrumActionMenuProps<T> & {ref?: FocusableRef<HTMLButtonElement>}) => ReactElement;
61
- export {_ActionMenu as ActionMenu};
58
+ }) as <T>(props: SpectrumActionMenuProps<T> & {ref?: FocusableRef<HTMLButtonElement>}) => ReactElement;
@@ -11,10 +11,10 @@
11
11
  */
12
12
 
13
13
  import {classNames, SlotProvider, unwrapDOMRef, useIsMobileDevice} from '@react-spectrum/utils';
14
+ import {DOMRefValue, ItemProps, Key} from '@react-types/shared';
14
15
  import {FocusScope} from '@react-aria/focus';
15
16
  import {getInteractionModality} from '@react-aria/interactions';
16
17
  import helpStyles from '@adobe/spectrum-css-temp/components/contextualhelp/vars.css';
17
- import {ItemProps, Key} from '@react-types/shared';
18
18
  import {Popover} from '@react-spectrum/overlays';
19
19
  import React, {JSX, ReactElement, useEffect, useRef, useState} from 'react';
20
20
  import ReactDOM from 'react-dom';
@@ -41,9 +41,9 @@ function ContextualHelpTrigger(props: InternalMenuDialogTriggerProps): ReactElem
41
41
  let {isUnavailable = false, targetKey} = props;
42
42
 
43
43
  let triggerRef = useRef<HTMLLIElement>(null);
44
- let popoverRef = useRef(null);
45
- let {popoverContainer, trayContainerRef, rootMenuTriggerState, menu: parentMenuRef, state} = useMenuStateContext();
46
- let submenuTriggerState = useSubmenuTriggerState({triggerKey: targetKey}, {...rootMenuTriggerState, ...state});
44
+ let popoverRef = useRef<DOMRefValue<HTMLDivElement> | null>(null);
45
+ let {popoverContainer, trayContainerRef, rootMenuTriggerState, menu: parentMenuRef, state} = useMenuStateContext()!;
46
+ let submenuTriggerState = useSubmenuTriggerState({triggerKey: targetKey}, {...rootMenuTriggerState!, ...state});
47
47
  let submenuRef = unwrapDOMRef(popoverRef);
48
48
  let {submenuTriggerProps, popoverProps} = useSubmenuTrigger({
49
49
  parentMenuRef,
@@ -85,7 +85,7 @@ function ContextualHelpTrigger(props: InternalMenuDialogTriggerProps): ReactElem
85
85
  let [, content] = props.children as [ReactElement, ReactElement];
86
86
 
87
87
  let onBlurWithin = (e) => {
88
- if (e.relatedTarget && popoverRef.current && (!popoverRef?.current?.UNSAFE_getDOMNode()?.contains(e.relatedTarget) && !(e.relatedTarget === triggerRef.current && getInteractionModality() === 'pointer'))) {
88
+ if (e.relatedTarget && popoverRef.current && (!popoverRef.current.UNSAFE_getDOMNode()?.contains(e.relatedTarget) && !(e.relatedTarget === triggerRef.current && getInteractionModality() === 'pointer'))) {
89
89
  if (submenuTriggerState.isOpen) {
90
90
  submenuTriggerState.close();
91
91
  }
@@ -143,7 +143,7 @@ function ContextualHelpTrigger(props: InternalMenuDialogTriggerProps): ReactElem
143
143
  UNSAFE_className={classNames(styles, 'spectrum-Submenu-popover')}
144
144
  onDismissButtonPress={onDismissButtonPress}
145
145
  onBlurWithin={onBlurWithin}
146
- container={popoverContainer}
146
+ container={popoverContainer!}
147
147
  state={submenuTriggerState}
148
148
  ref={popoverRef}
149
149
  triggerRef={triggerRef}
@@ -151,7 +151,7 @@ function ContextualHelpTrigger(props: InternalMenuDialogTriggerProps): ReactElem
151
151
  containerPadding={0}
152
152
  hideArrow
153
153
  enableBothDismissButtons>
154
- <FocusScope restoreFocus>
154
+ <FocusScope restoreFocus contain>
155
155
  {content}
156
156
  </FocusScope>
157
157
  </Popover>
@@ -189,5 +189,5 @@ ContextualHelpTrigger.getCollectionNode = function* getCollectionNode<T>(props:
189
189
  };
190
190
  };
191
191
 
192
- let _Item = ContextualHelpTrigger as (props: SpectrumMenuDialogTriggerProps) => JSX.Element;
192
+ let _Item = ContextualHelpTrigger as unknown as (props: SpectrumMenuDialogTriggerProps) => JSX.Element;
193
193
  export {_Item as ContextualHelpTrigger};
package/src/Menu.tsx CHANGED
@@ -24,12 +24,16 @@ import {mergeProps, useLayoutEffect, useSlotId, useSyncRef} from '@react-aria/ut
24
24
  import React, {ReactElement, useContext, useEffect, useRef, useState} from 'react';
25
25
  import {SpectrumMenuProps} from '@react-types/menu';
26
26
  import styles from '@adobe/spectrum-css-temp/components/menu/vars.css';
27
- import {useInteractOutside} from '@react-aria/interactions';
28
27
  import {useLocale, useLocalizedStringFormatter} from '@react-aria/i18n';
29
28
  import {useMenu} from '@react-aria/menu';
30
29
  import {useTreeState} from '@react-stately/tree';
31
30
 
32
- function Menu<T extends object>(props: SpectrumMenuProps<T>, ref: DOMRef<HTMLDivElement>) {
31
+ /**
32
+ * Menus display a list of actions or options that a user can choose.
33
+ */
34
+ // forwardRef doesn't support generic parameters, so cast the result to the correct type
35
+ // https://stackoverflow.com/questions/58469229/react-with-typescript-generics-while-using-react-forwardref
36
+ export const Menu = React.forwardRef(function Menu<T extends object>(props: SpectrumMenuProps<T>, ref: DOMRef<HTMLDivElement>) {
33
37
  let isSubmenu = true;
34
38
  let contextProps = useContext(MenuContext);
35
39
  let parentMenuContext = useMenuStateContext();
@@ -41,15 +45,15 @@ function Menu<T extends object>(props: SpectrumMenuProps<T>, ref: DOMRef<HTMLDiv
41
45
  ...mergeProps(contextProps, props)
42
46
  };
43
47
  let domRef = useDOMRef(ref);
44
- let [popoverContainer, setPopoverContainer] = useState(null);
45
- let trayContainerRef = useRef(null);
48
+ let [popoverContainer, setPopoverContainer] = useState<HTMLElement | null>(null);
49
+ let trayContainerRef = useRef<HTMLDivElement | null>(null);
46
50
  let state = useTreeState(completeProps);
47
51
  let submenuRef = useRef<HTMLDivElement>(null);
48
52
  let {menuProps} = useMenu(completeProps, state, domRef);
49
53
  let {styleProps} = useStyleProps(completeProps);
50
54
  useSyncRef(contextProps, domRef);
51
55
  let [leftOffset, setLeftOffset] = useState({left: 0});
52
- let prevPopoverContainer = useRef(null);
56
+ let prevPopoverContainer = useRef<HTMLElement | null>(null);
53
57
  useEffect(() => {
54
58
  if (popoverContainer && prevPopoverContainer.current !== popoverContainer && leftOffset.left === 0) {
55
59
  prevPopoverContainer.current = popoverContainer;
@@ -59,16 +63,12 @@ function Menu<T extends object>(props: SpectrumMenuProps<T>, ref: DOMRef<HTMLDiv
59
63
  }, [leftOffset, popoverContainer]);
60
64
 
61
65
  let menuLevel = contextProps.submenuLevel ?? -1;
62
- let hasOpenSubmenu = state.collection.getItem(rootMenuTriggerState?.expandedKeysStack[menuLevel + 1]) != null;
63
- useInteractOutside({
64
- ref: domRef,
65
- onInteractOutside: (e) => {
66
- if (!popoverContainer?.contains(e.target) && !trayContainerRef.current?.contains(e.target)) {
67
- rootMenuTriggerState.close();
68
- }
69
- },
70
- isDisabled: isSubmenu || !hasOpenSubmenu
71
- });
66
+ let nextMenuLevelKey = rootMenuTriggerState?.expandedKeysStack[menuLevel + 1];
67
+ let hasOpenSubmenu = false;
68
+ if (nextMenuLevelKey != null) {
69
+ let nextMenuLevel = state.collection.getItem(nextMenuLevelKey);
70
+ hasOpenSubmenu = nextMenuLevel != null;
71
+ }
72
72
 
73
73
  return (
74
74
  <MenuStateContext.Provider value={{popoverContainer, trayContainerRef, menu: domRef, submenu: submenuRef, rootMenuTriggerState, state}}>
@@ -121,7 +121,7 @@ function Menu<T extends object>(props: SpectrumMenuProps<T>, ref: DOMRef<HTMLDiv
121
121
  </FocusScope>
122
122
  </MenuStateContext.Provider>
123
123
  );
124
- }
124
+ }) as <T>(props: SpectrumMenuProps<T> & {ref?: DOMRef<HTMLDivElement>}) => ReactElement;
125
125
 
126
126
  export function TrayHeaderWrapper(props) {
127
127
  let {children, isSubmenu, hasOpenSubmenu, parentMenuTreeState, rootMenuTriggerState, onBackButtonPress, wrapperKeyDown, menuRef} = props;
@@ -141,7 +141,7 @@ export function TrayHeaderWrapper(props) {
141
141
  }
142
142
  }, [hasOpenSubmenu, isMobile]);
143
143
 
144
- let timeoutRef = useRef(null);
144
+ let timeoutRef = useRef<ReturnType<typeof setTimeout> | null>(null);
145
145
  let handleBackButtonPress = () => {
146
146
  setTraySubmenuAnimation('spectrum-TraySubmenu-exit');
147
147
  timeoutRef.current = setTimeout(() => {
@@ -159,7 +159,7 @@ export function TrayHeaderWrapper(props) {
159
159
 
160
160
  // When opening submenu in tray, focus the first item in the submenu after animation completes
161
161
  // This fixes an issue with iOS VO where the closed submenu was getting focus
162
- let focusTimeoutRef = useRef(null);
162
+ let focusTimeoutRef = useRef<ReturnType<typeof setTimeout> | null>(null);
163
163
  useEffect(() => {
164
164
  if (isMobile && isSubmenu && !hasOpenSubmenu && traySubmenuAnimation === 'spectrum-TraySubmenu-enter') {
165
165
  focusTimeoutRef.current = setTimeout(() => {
@@ -211,11 +211,3 @@ export function TrayHeaderWrapper(props) {
211
211
  </>
212
212
  );
213
213
  }
214
-
215
- /**
216
- * Menus display a list of actions or options that a user can choose.
217
- */
218
- // forwardRef doesn't support generic parameters, so cast the result to the correct type
219
- // https://stackoverflow.com/questions/58469229/react-with-typescript-generics-while-using-react-forwardref
220
- const _Menu = React.forwardRef(Menu) as <T>(props: SpectrumMenuProps<T> & {ref?: DOMRef<HTMLDivElement>}) => ReactElement;
221
- export {_Menu as Menu};
package/src/MenuItem.tsx CHANGED
@@ -60,7 +60,7 @@ export function MenuItem<T>(props: MenuItemProps<T>) {
60
60
  let ElementType: React.ElementType = item.props.href ? 'a' : 'div';
61
61
 
62
62
  if (isSubmenuTrigger) {
63
- isUnavailable = submenuTriggerContext.isUnavailable;
63
+ isUnavailable = submenuTriggerContext!.isUnavailable;
64
64
  }
65
65
 
66
66
  let isDisabled = state.disabledKeys.has(key);
@@ -40,7 +40,8 @@ export function MenuSection<T>(props: MenuSectionProps<T>) {
40
40
  let firstSectionKey = state.collection.getFirstKey();
41
41
  let lastSectionKey = [...state.collection].filter(node => node.type === 'section').at(-1)?.key;
42
42
  let sectionIsFirst = firstSectionKey === item.key && state.collection.getFirstKey() === firstSectionKey;
43
- let sectionIsLast = lastSectionKey === item.key && state.collection.getItem(state.collection.getLastKey()).parentKey === lastSectionKey;
43
+ let lastKey = state.collection.getLastKey();
44
+ let sectionIsLast = lastSectionKey === item.key && lastKey != null && state.collection.getItem(lastKey)!.parentKey === lastSectionKey;
44
45
 
45
46
  return (
46
47
  <Fragment>
@@ -10,23 +10,27 @@
10
10
  * governing permissions and limitations under the License.
11
11
  */
12
12
 
13
- import {classNames, SlotProvider, useDOMRef, useIsMobileDevice} from '@react-spectrum/utils';
13
+ import {classNames, SlotProvider, unwrapDOMRef, useDOMRef, useIsMobileDevice} from '@react-spectrum/utils';
14
14
  import {DOMRef} from '@react-types/shared';
15
15
  import {MenuContext} from './context';
16
16
  import {Placement} from '@react-types/overlays';
17
17
  import {Popover, Tray} from '@react-spectrum/overlays';
18
- import {PressResponder} from '@react-aria/interactions';
18
+ import {PressResponder, useInteractOutside} from '@react-aria/interactions';
19
19
  import React, {forwardRef, Fragment, useRef} from 'react';
20
20
  import {SpectrumMenuTriggerProps} from '@react-types/menu';
21
21
  import styles from '@adobe/spectrum-css-temp/components/menu/vars.css';
22
22
  import {useMenuTrigger} from '@react-aria/menu';
23
23
  import {useMenuTriggerState} from '@react-stately/menu';
24
24
 
25
- function MenuTrigger(props: SpectrumMenuTriggerProps, ref: DOMRef<HTMLElement>) {
26
- let triggerRef = useRef<HTMLElement>(undefined);
25
+ /**
26
+ * The MenuTrigger serves as a wrapper around a Menu and its associated trigger,
27
+ * linking the Menu's open state with the trigger's press state.
28
+ */
29
+ export const MenuTrigger = forwardRef(function MenuTrigger(props: SpectrumMenuTriggerProps, ref: DOMRef<HTMLElement>) {
30
+ let triggerRef = useRef<HTMLElement>(null);
27
31
  let domRef = useDOMRef(ref);
28
32
  let menuTriggerRef = domRef || triggerRef;
29
- let menuRef = useRef<HTMLDivElement>(undefined);
33
+ let menuRef = useRef<HTMLDivElement>(null);
30
34
  let {
31
35
  children,
32
36
  align = 'start',
@@ -70,17 +74,29 @@ function MenuTrigger(props: SpectrumMenuTriggerProps, ref: DOMRef<HTMLElement>)
70
74
  state
71
75
  };
72
76
 
77
+ // Close when clicking outside the root menu when a submenu is open.
78
+ let rootOverlayRef = useRef(null);
79
+ let rootOverlayDomRef = unwrapDOMRef(rootOverlayRef);
80
+ useInteractOutside({
81
+ ref: rootOverlayDomRef,
82
+ onInteractOutside: () => {
83
+ state?.close();
84
+ },
85
+ isDisabled: !state.isOpen || state.expandedKeysStack.length === 0
86
+ });
87
+
73
88
  // On small screen devices, the menu is rendered in a tray, otherwise a popover.
74
89
  let overlay;
75
90
  if (isMobile) {
76
91
  overlay = (
77
- <Tray state={state} isFixedHeight>
92
+ <Tray state={state} isFixedHeight ref={rootOverlayRef}>
78
93
  {menu}
79
94
  </Tray>
80
95
  );
81
96
  } else {
82
97
  overlay = (
83
98
  <Popover
99
+ ref={rootOverlayRef}
84
100
  UNSAFE_style={{clipPath: 'unset', overflow: 'visible', filter: 'unset', borderWidth: '0px'}}
85
101
  state={state}
86
102
  triggerRef={menuTriggerRef}
@@ -105,11 +121,4 @@ function MenuTrigger(props: SpectrumMenuTriggerProps, ref: DOMRef<HTMLElement>)
105
121
  </MenuContext.Provider>
106
122
  </Fragment>
107
123
  );
108
- }
109
-
110
- /**
111
- * The MenuTrigger serves as a wrapper around a Menu and its associated trigger,
112
- * linking the Menu's open state with the trigger's press state.
113
- */
114
- let _MenuTrigger = forwardRef(MenuTrigger);
115
- export {_MenuTrigger as MenuTrigger};
124
+ });
@@ -33,15 +33,15 @@ interface SubmenuTriggerProps {
33
33
  export interface SpectrumSubmenuTriggerProps extends Omit<SubmenuTriggerProps, 'targetKey'> {}
34
34
 
35
35
  function SubmenuTrigger(props: SubmenuTriggerProps) {
36
- let triggerRef = useRef<HTMLDivElement>(undefined);
36
+ let triggerRef = useRef<HTMLDivElement>(null);
37
37
  let {
38
38
  children,
39
39
  targetKey
40
40
  } = props;
41
41
 
42
42
  let [menuTrigger, menu] = React.Children.toArray(children);
43
- let {popoverContainer, trayContainerRef, menu: parentMenuRef, submenu: menuRef, rootMenuTriggerState} = useMenuStateContext();
44
- let submenuTriggerState = useSubmenuTriggerState({triggerKey: targetKey}, rootMenuTriggerState);
43
+ let {popoverContainer, trayContainerRef, menu: parentMenuRef, submenu: menuRef, rootMenuTriggerState} = useMenuStateContext()!;
44
+ let submenuTriggerState = useSubmenuTriggerState({triggerKey: targetKey}, rootMenuTriggerState!);
45
45
  let {submenuTriggerProps, submenuProps, popoverProps} = useSubmenuTrigger({
46
46
  parentMenuRef,
47
47
  submenuRef: menuRef
@@ -59,12 +59,12 @@ function SubmenuTrigger(props: SubmenuTriggerProps) {
59
59
  switch (e.key) {
60
60
  case 'ArrowLeft':
61
61
  if (direction === 'ltr') {
62
- triggerRef.current.focus();
62
+ triggerRef.current?.focus();
63
63
  }
64
64
  break;
65
65
  case 'ArrowRight':
66
66
  if (direction === 'rtl') {
67
- triggerRef.current.focus();
67
+ triggerRef.current?.focus();
68
68
  }
69
69
  break;
70
70
  }
@@ -90,7 +90,7 @@ function SubmenuTrigger(props: SubmenuTriggerProps) {
90
90
  {...popoverProps}
91
91
  onDismissButtonPress={onDismissButtonPress}
92
92
  UNSAFE_className={classNames(styles, 'spectrum-Submenu-popover')}
93
- container={popoverContainer}
93
+ container={popoverContainer!}
94
94
  containerPadding={0}
95
95
  enableBothDismissButtons
96
96
  UNSAFE_style={{clipPath: 'unset', overflow: 'visible', borderWidth: '0px'}}
@@ -150,5 +150,5 @@ SubmenuTrigger.getCollectionNode = function* (props: SpectrumSubmenuTriggerProps
150
150
  };
151
151
  };
152
152
 
153
- let _SubmenuTrigger = SubmenuTrigger as (props: SpectrumSubmenuTriggerProps) => JSX.Element;
153
+ let _SubmenuTrigger = SubmenuTrigger as unknown as (props: SpectrumSubmenuTriggerProps) => JSX.Element;
154
154
  export {_SubmenuTrigger as SubmenuTrigger};
package/src/context.ts CHANGED
@@ -11,7 +11,7 @@
11
11
  */
12
12
 
13
13
  import {DOMProps, FocusStrategy, HoverEvents, KeyboardEvents, PressEvents, RefObject} from '@react-types/shared';
14
- import React, {HTMLAttributes, MutableRefObject, useContext} from 'react';
14
+ import React, {HTMLAttributes, useContext} from 'react';
15
15
  import {RootMenuTriggerState} from '@react-stately/menu';
16
16
  import {TreeState} from '@react-stately/tree';
17
17
 
@@ -20,7 +20,7 @@ export interface MenuContextValue extends Omit<HTMLAttributes<HTMLElement>, 'aut
20
20
  closeOnSelect?: boolean,
21
21
  shouldFocusWrap?: boolean,
22
22
  autoFocus?: boolean | FocusStrategy,
23
- ref?: MutableRefObject<HTMLDivElement>,
23
+ ref?: RefObject<HTMLDivElement | null>,
24
24
  state?: RootMenuTriggerState,
25
25
  onBackButtonPress?: () => void,
26
26
  submenuLevel?: number
@@ -34,7 +34,7 @@ export function useMenuContext(): MenuContextValue {
34
34
 
35
35
  export interface SubmenuTriggerContextValue extends DOMProps, Pick<PressEvents, 'onPressStart' | 'onPress'>, Pick<HoverEvents, 'onHoverChange'>, Pick<KeyboardEvents, 'onKeyDown'> {
36
36
  isUnavailable?: boolean,
37
- triggerRef?: MutableRefObject<HTMLElement>,
37
+ triggerRef?: RefObject<HTMLElement | null>,
38
38
  'aria-expanded'?: boolean | 'true' | 'false',
39
39
  'aria-controls'?: string,
40
40
  'aria-haspopup'?: 'dialog' | 'menu',
@@ -43,21 +43,21 @@ export interface SubmenuTriggerContextValue extends DOMProps, Pick<PressEvents,
43
43
 
44
44
  export const SubmenuTriggerContext = React.createContext<SubmenuTriggerContextValue | undefined>(undefined);
45
45
 
46
- export function useSubmenuTriggerContext(): SubmenuTriggerContextValue {
46
+ export function useSubmenuTriggerContext() {
47
47
  return useContext(SubmenuTriggerContext);
48
48
  }
49
49
 
50
50
  export interface MenuStateContextValue<T> {
51
- state?: TreeState<T>,
52
- popoverContainer?: HTMLElement,
53
- trayContainerRef?: RefObject<HTMLElement | null>,
54
- menu?: RefObject<HTMLDivElement | null>,
55
- submenu?: RefObject<HTMLDivElement | null>,
51
+ state: TreeState<T>,
52
+ popoverContainer: HTMLElement | null,
53
+ trayContainerRef: RefObject<HTMLElement | null>,
54
+ menu: RefObject<HTMLDivElement | null>,
55
+ submenu: RefObject<HTMLDivElement | null>,
56
56
  rootMenuTriggerState?: RootMenuTriggerState
57
57
  }
58
58
 
59
- export const MenuStateContext = React.createContext<MenuStateContextValue<any>>(undefined);
59
+ export const MenuStateContext = React.createContext<MenuStateContextValue<any> | undefined>(undefined);
60
60
 
61
- export function useMenuStateContext<T>(): MenuStateContextValue<T> {
61
+ export function useMenuStateContext() {
62
62
  return useContext(MenuStateContext);
63
63
  }
@@ -1 +0,0 @@
1
- {"mappings":"AA4DA;;;;;AAIE;;;;AAIA;;;;AAIA;;;;AAIA;;;;AAIA;;;;AAIA;;;;AAQA;;;;AAIA;;;;AAKF;;;;;;;;AAOE;;;;;;;;;;;AAqBE;;;;;AAQF;;;;AAKE;;;;;AAOJ;EACE;;;;EAIE;;;;;AAMJ;;;;;;;;;;AAWA;;;;AAIA;;;;AAIA;;;;;;;;;;;;;AAmBE;;;;;AAMA;;;;AAKF;;;;;;;AAWA;;;;;;;;;;;;;AAgBE;;;;AAIA;;;;AAIA;;;;AAKE;;;;AAKF;;;;AAMF;;;;;;AAMA;;;;;;AAMA;;;;;;AAOA;;;;;;;;;AAaA;;;;;;;;;;;;AAcE;;;;AAGA;;;;AAKF;;;;;AAMA;;;;;;;;;;AAgBE;;;;AAOF;;;;;;AAOA;;;;;;AAOA;;;;;;AAOA;;;;;;AAMA;;;;;;;;AAUA;;;;;;;;AASA;;;;AAGE;;;;;;AAKE;;;;AAKF;;;;;;;;AAOE;;;;;;;;AAQA;;;;;AAIE;;;;;;;;;;AAyBN;;;;;;;AAWA;;;;;AAKA;;;;AAIA;;;;;AAIE;;;;;;AAOA;;;;;AASE;;;;AAKF;;;;AAKA;;;;;;;AACE;;;;AAUJ;;;;AAIA;;;;AAIA;;;;AAIA;;;;;;AAQA;;;;AAIA;;;;;;;;;;AASA;;;;;;;;;;AASA;;;;;;;;;;AASA;;;;;;;;;;AASA;;;;;;;AAKE;;;;AAAA;;;;AAKF;;;;;;;AAKE;;;;AAAA;;;;AAKF;EACE;;;;;EAIA;;;;;;;;;;;;;;;;;;;EAkBE;;;;EAGA;;;;;EAOI;;;;EAIF;;;;;EAXF;;;;;EAOI;;;;EAIF;;;;;EAXF;;;;;EAOI;;;;EAIF;;;;;EAXF;;;;;EAOI;;;;EAIF;;;;;EAXF;;;;;EAOI;;;;EAIF;;;;;EAXF;;;;;EAOI;;;;EAIF","sources":["packages/@adobe/spectrum-css-temp/components/menu/vars.css"],"sourcesContent":["/*\n * Copyright 2020 Adobe. All rights reserved.\n * This file is licensed to you under the Apache License, Version 2.0 (the \"License\");\n * you may not use this file except in compliance with the License. You may obtain a copy\n * of the License at http://www.apache.org/licenses/LICENSE-2.0\n *\n * Unless required by applicable law or agreed to in writing, software distributed under\n * the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS\n * OF ANY KIND, either express or implied. See the License for the specific language\n * governing permissions and limitations under the License.\n */\n\n@import './index.css';\n@import './skin.css';\n"],"names":[],"version":3,"file":"vars.a1f9fd59.css.map"}