@react-spectrum/codemods 0.2.1 → 0.4.0

package/dist/s1-to-s2/src/codemods/changes.js

@@ -22,6 +22,39 @@ exports.changes = {
             }
         ]
     },
+    ActionGroup: {
+        changes: [
+            {
+                description: 'Comment out overflowMode',
+                reason: 'It has not been implemented yet',
+                function: {
+                    name: 'commentOutProp',
+                    args: { propToComment: 'overflowMode' }
+                }
+            },
+            {
+                description: 'Comment out buttonLabelBehavior',
+                reason: 'It has not been implemented yet',
+                function: {
+                    name: 'commentOutProp',
+                    args: { propToComment: 'buttonLabelBehavior' }
+                }
+            },
+            {
+                description: 'Comment out summaryIcon',
+                reason: 'It has not been implemented yet',
+                function: {
+                    name: 'commentOutProp',
+                    args: { propToComment: 'summaryIcon' }
+                }
+            },
+            {
+                description: 'Replace with ActionButtonGroup or ToggleButtonGroup',
+                reason: 'The API has changed',
+                function: { name: 'updateActionGroup', args: {} }
+            }
+        ]
+    },
     ActionMenu: {
         changes: [
             {
@@ -334,6 +367,30 @@ exports.changes = {
                     name: 'moveRenderPropsToChild',
                     args: { newChildComponent: 'Dialog' }
                 }
+            },
+            {
+                description: 'Rename isDismissable to isDismissible',
+                reason: 'Fixed spelling',
+                function: { name: 'updatePropName', args: { oldProp: 'isDismissable', newProp: 'isDismissible' } }
+            },
+            {
+                description: 'Update Dialog child to Popover or FullscreenDialog depending on type prop',
+                reason: 'Updated API',
+                function: { name: 'updateDialogChild', args: {} }
+            }
+        ]
+    },
+    DialogContainer: {
+        changes: [
+            {
+                description: 'Rename isDismissable to isDismissible',
+                reason: 'Fixed spelling',
+                function: { name: 'updatePropName', args: { oldProp: 'isDismissable', newProp: 'isDismissible' } }
+            },
+            {
+                description: 'Update Dialog child to Popover or FullscreenDialog depending on type prop',
+                reason: 'Updated API',
+                function: { name: 'updateDialogChild', args: {} }
             }
         ]
     },
@@ -1091,5 +1148,113 @@ exports.changes = {
                 }
             }
         ]
+    },
+    TableView: {
+        changes: [
+            {
+                description: 'Add columns prop to Row',
+                reason: 'Rows now require a columns prop from TableHeader',
+                function: {
+                    name: 'addColumnsPropToRow',
+                    args: {}
+                }
+            },
+            {
+                description: 'Leave comment if nested columns are used',
+                reason: 'Nested columns are not supported yet',
+                function: {
+                    name: 'commentIfNestedColumns',
+                    args: {}
+                }
+            },
+            {
+                description: 'Comment out dragAndDropHooks',
+                reason: 'It has not been implemented yet',
+                function: {
+                    name: 'commentOutProp',
+                    args: { propToComment: 'dragAndDropHooks' }
+                }
+            },
+            {
+                description: 'Comment out selectionStyle="highlight"',
+                reason: 'It has not been implemented yet',
+                function: {
+                    name: 'commentOutProp',
+                    args: { propToComment: 'selectionStyle' }
+                }
+            },
+            {
+                description: 'Comment out UNSTABLE_allowsExpandableRows',
+                reason: 'It has not been implemented yet',
+                function: {
+                    name: 'commentOutProp',
+                    args: { propToComment: 'UNSTABLE_allowsExpandableRows' }
+                }
+            },
+            {
+                description: 'Comment out UNSTABLE_defaultExpandedKeys',
+                reason: 'It has not been implemented yet',
+                function: {
+                    name: 'commentOutProp',
+                    args: { propToComment: 'UNSTABLE_defaultExpandedKeys' }
+                }
+            },
+            {
+                description: 'Comment out UNSTABLE_expandedKeys',
+                reason: 'It has not been implemented yet',
+                function: {
+                    name: 'commentOutProp',
+                    args: { propToComment: 'UNSTABLE_expandedKeys' }
+                }
+            },
+            {
+                description: 'Comment out UNSTABLE_onExpandedChange',
+                reason: 'It has not been implemented yet',
+                function: {
+                    name: 'commentOutProp',
+                    args: { propToComment: 'UNSTABLE_onExpandedChange' }
+                }
+            },
+            {
+                description: 'Add isRowHeader prop to fist Column if one doesn\'t eixst already',
+                reason: 'Updated API',
+                function: {
+                    name: 'addRowHeader',
+                    args: {}
+                }
+            }
+        ]
+    },
+    Column: {
+        changes: [
+            {
+                description: 'Update key prop to id',
+                reason: 'Updated API',
+                function: {
+                    name: 'updateKeyToId',
+                    args: {}
+                }
+            }
+        ]
+    },
+    Row: {
+        changes: [
+            {
+                description: 'Update key prop to id',
+                reason: 'Updated API',
+                function: {
+                    name: 'updateKeyToId',
+                    args: {}
+                }
+            },
+            {
+                description: 'Update child function to receive column object instead of column key',
+                reason: 'Updated API',
+                function: {
+                    name: 'updateRowFunctionArg',
+                    args: {}
+                }
+            }
+        ]
     }
 };

package/dist/s1-to-s2/src/codemods/codemod.js

@@ -49,6 +49,8 @@ availableComponents.add('Item');
 availableComponents.add('Section');
 // Don't update v3 Provider
 availableComponents.delete('Provider');
+// Replaced by ActionButtonGroup and ToggleButtonGroup
+availableComponents.add('ActionGroup');
 function transformer(file, api, options) {
     let j = api.jscodeshift.withParser({
         parse(source) {
@@ -227,7 +229,7 @@ function transformer(file, api, options) {
     if (importedComponents.size) {
         // Add imports to existing @react-spectrum/s2 import if it exists, otherwise add a new one.
         let importSpecifiers = new Set([...importedComponents]
-            .filter(([c]) => c !== 'Flex' && c !== 'Grid' && c !== 'View' && c !== 'Item' && c !== 'Section')
+            .filter(([c]) => c !== 'Flex' && c !== 'Grid' && c !== 'View' && c !== 'Item' && c !== 'Section' && c !== 'ActionGroup')
             .map(([, specifier]) => specifier));
         let existingImport = root.find(j.ImportDeclaration, {
             source: { value: '@react-spectrum/s2' }

package/dist/s1-to-s2/src/codemods/dimensions.js

@@ -140,7 +140,7 @@ const UNIT_RE = /(%|px|em|rem|vw|vh|auto|cm|mm|in|pt|pc|ex|ch|rem|vmin|vmax|fr)$
 const FUNC_RE = /^\s*\w+\(/;
 // const SPECTRUM_VARIABLE_RE = /(static-)?size-\d+|single-line-(height|width)/g;
 const SIZING_RE = /auto|100vh|min-content|max-content|fit-content/;
-function convertDimension(value, toPixels = false) {
+function convertDimension(value, type) {
     let pixelValue;
     if (typeof value === 'number') {
         pixelValue = value;
@@ -170,10 +170,10 @@ function convertDimension(value, toPixels = false) {
     if (pixelValue == null) {
         throw new Error('invalid dimension: ' + value);
     }
-    if (toPixels) {
+    if (type === 'px') {
         return `${pixelValue}px`;
     }
-    if (spacingValues.includes(pixelValue)) {
+    if (type === 'size' || spacingValues.includes(pixelValue)) {
         return pixelValue;
     }
     // TODO: Convert to rems? Find nearest value?
@@ -184,16 +184,16 @@ function convertGridTrack(value, toPixels = false) {
         return value;
     }
     else {
-        return convertDimension(value, toPixels);
+        return convertDimension(value, toPixels ? 'px' : 'space');
     }
 }
-function convertUnsafeDimension(value) {
+function convertUnsafeDimension(value, type) {
     if (typeof value === 'number') {
-        return convertDimension(value);
+        return convertDimension(value, type);
     }
     let m = value.match(/^var\(--spectrum-global-dimension-(static-)?size-(.*)\)$/);
     if (m) {
-        return convertDimension(`${m[1] || ''}size-${m[2]}`);
+        return convertDimension(`${m[1] || ''}size-${m[2]}`, type);
     }
     return null;
 }

package/dist/s1-to-s2/src/codemods/styleProps.js

@@ -63,7 +63,21 @@ function getStylePropValue(prop, value, element, colorVersion, condition = '') {
         case 'maxWidth':
         case 'height':
         case 'minHeight':
-        case 'maxHeight':
+        case 'maxHeight': {
+            if (value.type === 'StringLiteral' || value.type === 'NumericLiteral') {
+                let val = (0, dimensions_1.convertDimension)(value.value, 'size');
+                if (val != null) {
+                    return {
+                        macroValues: [{ key: mappedProp, value: val }]
+                    };
+                }
+            }
+            else if (value.type === 'ObjectExpression') {
+                return getResponsiveValue(prop, value, element, colorVersion);
+            }
+            // return [mappedProp, customProp, [[customProp, value]]];
+            return null;
+        }
         case 'margin':
         case 'marginStart':
         case 'marginEnd':
@@ -79,7 +93,7 @@ function getStylePropValue(prop, value, element, colorVersion, condition = '') {
         case 'end':
         case 'flexBasis': {
             if (value.type === 'StringLiteral' || value.type === 'NumericLiteral') {
-                let val = (0, dimensions_1.convertDimension)(value.value);
+                let val = (0, dimensions_1.convertDimension)(value.value, 'space');
                 if (val != null) {
                     return {
                         macroValues: [{ key: mappedProp, value: val }]
@@ -182,7 +196,7 @@ function getStylePropValue(prop, value, element, colorVersion, condition = '') {
         case 'rowGap':
             if (element === 'Flex' || element === 'Grid') {
                 if (value.type === 'StringLiteral' || value.type === 'NumericLiteral') {
-                    let val = (0, dimensions_1.convertDimension)(value.value);
+                    let val = (0, dimensions_1.convertDimension)(value.value, 'space');
                     if (val != null) {
                         return {
                             macroValues: [{ key: mappedProp, value: val }]
@@ -308,7 +322,7 @@ function getStylePropValue(prop, value, element, colorVersion, condition = '') {
         case 'paddingBottom':
             if (element === 'View') {
                 if (value.type === 'StringLiteral' || value.type === 'NumericLiteral') {
-                    let val = (0, dimensions_1.convertDimension)(value.value);
+                    let val = (0, dimensions_1.convertDimension)(value.value, 'space');
                     if (val != null) {
                         return {
                             macroValues: [{ key: mappedProp, value: val }]
@@ -410,7 +424,7 @@ function getStylePropValue(prop, value, element, colorVersion, condition = '') {
             // Try to automatically convert size prop to a macro value for components that supported size.
             if (element === 'ColorArea' || element === 'ColorWheel') {
                 if (value.type === 'StringLiteral' || value.type === 'NumericLiteral') {
-                    let val = (0, dimensions_1.convertDimension)(value.value);
+                    let val = (0, dimensions_1.convertDimension)(value.value, 'size');
                     if (val != null) {
                         return {
                             macroValues: [{ key: 'size', value: val }]

package/dist/s1-to-s2/src/codemods/transforms.js

@@ -24,6 +24,7 @@ var __importStar = (this && this.__importStar) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.functionMap = void 0;
+exports.commentIfNestedColumns = commentIfNestedColumns;
 const utils_1 = require("./utils");
 const dimensions_1 = require("./dimensions");
 const getComponents_1 = require("../getComponents");
@@ -285,7 +286,16 @@ function moveRenderPropsToChild(path, options) {
         t.isArrowFunctionExpression(renderFunction.expression) &&
         t.isJSXElement(renderFunction.expression.body)) {
         const dialogElement = renderFunction.expression.body;
-        const newRenderFunction = t.jsxExpressionContainer(t.arrowFunctionExpression(renderFunction.expression.params, t.jsxFragment(t.jsxOpeningFragment(), t.jsxClosingFragment(), dialogElement.children)));
+        const originalParam = renderFunction.expression.params[0];
+        if (!t.isIdentifier(originalParam)) {
+            (0, utils_1.addComment)(path.node.children[renderFunctionIndex], ' TODO(S2-upgrade): Could not automatically move the render props. You\'ll need to update this manually.');
+            return;
+        }
+        const paramName = originalParam.name;
+        const objectPattern = t.objectPattern([
+            t.objectProperty(t.identifier(paramName), t.identifier(paramName), false, true)
+        ]);
+        const newRenderFunction = t.jsxExpressionContainer(t.arrowFunctionExpression([objectPattern], t.jsxFragment(t.jsxOpeningFragment(), t.jsxClosingFragment(), dialogElement.children)));
         let removedOnDismiss = false;
         const attributes = dialogElement.openingElement.attributes.filter((attr) => {
             if (t.isJSXAttribute(attr) && attr.name.name === 'onDismiss') {
@@ -322,32 +332,13 @@ function updateComponentWithinCollection(path, options) {
             t.isJSXIdentifier(closestParentCollection.node.openingElement.name) &&
             (0, utils_1.getName)(path, closestParentCollection.node.openingElement.name) === parentComponent) {
             // If closest parent collection component matches parentComponent, replace with newComponent
-            let attributes = path.node.openingElement.attributes;
-            let keyProp = attributes.find((attr) => t.isJSXAttribute(attr) && attr.name.name === 'key');
-            if (keyProp &&
-                t.isJSXAttribute(keyProp)) {
-                // Update key prop to be id
-                keyProp.name = t.jsxIdentifier('id');
-            }
-            if (t.isArrowFunctionExpression(path.parentPath.node) &&
-                path.parentPath.parentPath &&
-                t.isCallExpression(path.parentPath.parentPath.node) &&
-                path.parentPath.parentPath.node.callee.type === 'MemberExpression' &&
-                path.parentPath.parentPath.node.callee.property.type === 'Identifier' &&
-                path.parentPath.parentPath.node.callee.property.name === 'map') {
-                // If Array.map is used, keep the key prop
-                if (keyProp &&
-                    t.isJSXAttribute(keyProp)) {
-                    let newKeyProp = t.jsxAttribute(t.jsxIdentifier('key'), keyProp.value);
-                    attributes.push(newKeyProp);
-                }
-            }
+            updateKeyToId(path);
             let localName = newComponent;
             if (availableComponents.has(newComponent)) {
                 let program = path.findParent((p) => t.isProgram(p.node));
                 localName = (0, utils_1.addComponentImport)(program, newComponent);
             }
-            let newNode = t.jsxElement(t.jsxOpeningElement(t.jsxIdentifier(localName), attributes), t.jsxClosingElement(t.jsxIdentifier(localName)), path.node.children);
+            let newNode = t.jsxElement(t.jsxOpeningElement(t.jsxIdentifier(localName), path.node.openingElement.attributes), t.jsxClosingElement(t.jsxIdentifier(localName)), path.node.children);
             path.replaceWith(newNode);
         }
     }
@@ -358,7 +349,7 @@ function updateComponentWithinCollection(path, options) {
  * Example: If they're declaring declaring Items somewhere above the collection.
  */
 function commentIfParentCollectionNotDetected(path) {
-    const collectionItemParents = new Set(['Menu', 'ActionMenu', 'TagGroup', 'Breadcrumbs', 'Picker', 'ComboBox', 'ListBox', 'TabList', 'TabPanels', 'ActionGroup', 'ListBox', 'ListView', 'Collection', 'SearchAutocomplete', 'Accordion', 'ActionBar', 'StepList']);
+    const collectionItemParents = new Set(['Menu', 'ActionMenu', 'TagGroup', 'Breadcrumbs', 'Picker', 'ComboBox', 'ListBox', 'TabList', 'TabPanels', 'ActionGroup', 'ActionButtonGroup', 'ToggleButtonGroup', 'ListBox', 'ListView', 'Collection', 'SearchAutocomplete', 'Accordion', 'ActionBar', 'StepList']);
     if (t.isJSXElement(path.node)) {
         // Find closest parent collection component
         let closestParentCollection = path.findParent((p) => t.isJSXElement(p.node) &&
@@ -532,7 +523,7 @@ function convertDimensionValueToPx(path, options) {
     if (attrPath && t.isJSXAttribute(attrPath.node) && attrPath.node.name.name === propToConvertValue) {
         if (t.isStringLiteral(attrPath.node.value)) {
             try {
-                let value = (0, dimensions_1.convertDimension)(attrPath.node.value.value);
+                let value = (0, dimensions_1.convertDimension)(attrPath.node.value.value, 'size');
                 if (value && typeof value === 'number') {
                     attrPath.node.value = t.jsxExpressionContainer(t.numericLiteral(value));
                 }
@@ -685,6 +676,343 @@ function updateLegacyLink(path) {
         }
     }
 }
+/**
+ * Copies the columns prop from the TableHeader to the Row component.
+ */
+function addColumnsPropToRow(path) {
+    const tableHeaderPath = path.get('children').find((child) => t.isJSXElement(child.node) &&
+        t.isJSXIdentifier(child.node.openingElement.name) &&
+        (0, utils_1.getName)(child, child.node.openingElement.name) === 'TableHeader');
+    if (!tableHeaderPath) {
+        (0, utils_1.addComment)(path.node, ' TODO(S2-upgrade): Could not find TableHeader within Table to retrieve columns prop.');
+        return;
+    }
+    const columnsProp = tableHeaderPath
+        .get('openingElement')
+        .get('attributes')
+        .find((attr) => t.isJSXAttribute(attr.node) && attr.node.name.name === 'columns');
+    if (columnsProp) {
+        path.traverse({
+            JSXElement(innerPath) {
+                if (t.isJSXElement(innerPath.node) &&
+                    t.isJSXIdentifier(innerPath.node.openingElement.name) &&
+                    (0, utils_1.getName)(innerPath, innerPath.node.openingElement.name) === 'Row') {
+                    let rowPath = innerPath;
+                    rowPath.node.openingElement.attributes.push(columnsProp.node);
+                    // If Row doesn't contain id prop, leave a comment for the user to check manually
+                    let idProp = rowPath.get('openingElement').get('attributes').find((attr) => t.isJSXAttribute(attr.node) && attr.node.name.name === 'id');
+                    if (!idProp) {
+                        (0, utils_1.addComment)(rowPath.node, ' TODO(S2-upgrade): If the items do not have id properties, you\'ll need to add an id prop to the Row.');
+                    }
+                }
+            }
+        });
+    }
+}
+/**
+ * Updates the function signature of the Row component.
+ */
+function updateRowFunctionArg(path) {
+    // Find the function passed as a child
+    let functionChild = path.get('children').find(childPath => childPath.isJSXExpressionContainer() &&
+        childPath.get('expression').isArrowFunctionExpression());
+    let tablePath = path.findParent((p) => t.isJSXElement(p.node) &&
+        t.isJSXIdentifier(p.node.openingElement.name) &&
+        (0, utils_1.getName)(path, p.node.openingElement.name) === 'TableView');
+    let tableHeaderPath = tablePath?.get('children').find((child) => t.isJSXElement(child.node) &&
+        t.isJSXIdentifier(child.node.openingElement.name) &&
+        (0, utils_1.getName)(child, child.node.openingElement.name) === 'TableHeader');
+    function findColumnKeyProp(path) {
+        let columnKeyProp = 'id';
+        path.traverse({
+            JSXElement(columnPath) {
+                if (t.isArrowFunctionExpression(columnPath.parentPath.node) &&
+                    t.isJSXElement(columnPath.node) &&
+                    t.isJSXIdentifier(columnPath.node.openingElement.name) &&
+                    (0, utils_1.getName)(columnPath, columnPath.node.openingElement.name) === 'Column') {
+                    let openingElement = columnPath.get('openingElement');
+                    let keyPropPath = openingElement.get('attributes').find(attr => t.isJSXAttribute(attr.node) &&
+                        (attr.node.name.name === 'key' || attr.node.name.name === 'id'));
+                    keyPropPath?.traverse({
+                        Identifier(innerPath) {
+                            if (innerPath.node.name === 'column' &&
+                                innerPath.parentPath.node.type === 'MemberExpression' &&
+                                t.isIdentifier(innerPath.parentPath.node.property)) {
+                                columnKeyProp = innerPath.parentPath.node.property.name;
+                            }
+                        }
+                    });
+                }
+            }
+        });
+        return columnKeyProp || 'id';
+    }
+    let columnKey = findColumnKeyProp(tableHeaderPath);
+    if (functionChild && functionChild.isJSXExpressionContainer()) {
+        let arrowFuncPath = functionChild.get('expression');
+        if (arrowFuncPath.isArrowFunctionExpression()) {
+            let params = arrowFuncPath.node.params;
+            if (params.length === 1 && t.isIdentifier(params[0])) {
+                let paramName = params[0].name;
+                // Rename parameter to 'column'
+                params[0].name = 'column';
+                // Replace references to the old parameter name inside the function body
+                arrowFuncPath.get('body').traverse({
+                    Identifier(innerPath) {
+                        if (innerPath.node.name === paramName &&
+                            // Ensure we're not replacing the parameter declaration
+                            innerPath.node !== params[0]) {
+                            // Replace with column key
+                            innerPath.replaceWith(t.memberExpression(t.identifier('column'), t.identifier(columnKey ?? 'id')));
+                        }
+                    }
+                });
+            }
+        }
+    }
+}
+/**
+ * Updates the key prop to id. Keeps the key prop if it's used in an array.map function.
+ */
+function updateKeyToId(path) {
+    let attributes = path.node.openingElement.attributes;
+    let keyProp = attributes.find((attr) => t.isJSXAttribute(attr) && attr.name.name === 'key');
+    if (keyProp &&
+        t.isJSXAttribute(keyProp)) {
+        // Update key prop to be id
+        keyProp.name = t.jsxIdentifier('id');
+    }
+    if (t.isArrowFunctionExpression(path.parentPath.node) &&
+        path.parentPath.parentPath &&
+        t.isCallExpression(path.parentPath.parentPath.node) &&
+        path.parentPath.parentPath.node.callee.type === 'MemberExpression' &&
+        path.parentPath.parentPath.node.callee.property.type === 'Identifier' &&
+        path.parentPath.parentPath.node.callee.property.name === 'map') {
+        // If Array.map is used, keep the key prop
+        if (keyProp &&
+            t.isJSXAttribute(keyProp)) {
+            let newKeyProp = t.jsxAttribute(t.jsxIdentifier('key'), keyProp.value);
+            attributes.push(newKeyProp);
+        }
+    }
+}
+function commentIfNestedColumns(path) {
+    const headerPath = path.get('children').find((child) => t.isJSXElement(child.node) &&
+        t.isJSXIdentifier(child.node.openingElement.name) &&
+        (0, utils_1.getName)(child, child.node.openingElement.name) === 'TableHeader');
+    const columns = headerPath?.get('children') || [];
+    let hasNestedColumns = false;
+    columns.forEach(column => {
+        let columnChildren = column.get('children');
+        if (columnChildren.find(child => t.isJSXElement(child.node) &&
+            t.isJSXIdentifier(child.node.openingElement.name) &&
+            (0, utils_1.getName)(child, child.node.openingElement.name) === 'Column')) {
+            hasNestedColumns = true;
+        }
+    });
+    if (hasNestedColumns) {
+        (0, utils_1.addComment)(path.node, ' TODO(S2-upgrade): Nested Column components are not supported yet.');
+    }
+}
+/**
+ * Updates DialogTrigger and DialogContainer to the new API.
+ *
+ * Example:
+ * - When `type="popover"`, replaces Dialog with `<Popover>`.
+ * - When `type="fullscreen"`, replaces Dialog with `<FullscreenDialog>`.
+ * - When `type="fullscreenTakeover"`, replaces Dialog with `<FullscreenDialog variant="fullscreenTakeover">`.
+ */
+function updateDialogChild(path) {
+    let typePath = path.get('openingElement').get('attributes').find((attr) => t.isJSXAttribute(attr.node) && attr.node.name.name === 'type');
+    let type = typePath?.node.value?.type === 'StringLiteral' ? typePath.node.value?.value : 'modal';
+    let newComponent = 'Dialog';
+    let props = [];
+    if (type === 'popover') {
+        newComponent = 'Popover';
+    }
+    else if (type === 'fullscreen' || type === 'fullscreenTakeover') {
+        newComponent = 'FullscreenDialog';
+        if (type === 'fullscreenTakeover') {
+            props.push(t.jsxAttribute(t.jsxIdentifier('variant'), t.stringLiteral(type)));
+        }
+    }
+    for (let prop of ['isDismissible', 'mobileType', 'hideArrow', 'placement', 'shouldFlip', 'isKeyboardDismissDisabled', 'containerPadding', 'offset', 'crossOffset']) {
+        let attr = path.get('openingElement').get('attributes').find(attr => attr.isJSXAttribute() && attr.node.name.name === prop);
+        if (attr) {
+            props.push(attr.node);
+            attr.remove();
+        }
+    }
+    typePath?.remove();
+    let localName = newComponent;
+    if (newComponent !== 'Dialog' && availableComponents.has(newComponent)) {
+        let program = path.findParent((p) => t.isProgram(p.node));
+        localName = (0, utils_1.addComponentImport)(program, newComponent);
+    }
+    path.traverse({
+        JSXElement(dialog) {
+            if (!t.isJSXIdentifier(dialog.node.openingElement.name) || (0, utils_1.getName)(dialog, dialog.node.openingElement.name) !== 'Dialog') {
+                return;
+            }
+            dialog.node.openingElement.name = t.jsxIdentifier(localName);
+            if (dialog.node.closingElement) {
+                dialog.node.closingElement.name = t.jsxIdentifier(localName);
+            }
+            dialog.node.openingElement.attributes.push(...props);
+        }
+    });
+}
+function updateActionGroup(path) {
+    let selectionModePath = path.get('openingElement').get('attributes').find((attr) => t.isJSXAttribute(attr.node) && attr.node.name.name === 'selectionMode');
+    let selectionMode = t.isStringLiteral(selectionModePath?.node.value) ? selectionModePath.node.value.value : 'none';
+    let newComponent, childComponent;
+    if (selectionMode === 'none') {
+        newComponent = 'ActionButtonGroup';
+        childComponent = 'ActionButton';
+        selectionModePath?.remove();
+    }
+    else {
+        newComponent = 'ToggleButtonGroup';
+        childComponent = 'ToggleButton';
+    }
+    let localName = newComponent;
+    if (availableComponents.has(newComponent)) {
+        let program = path.findParent((p) => t.isProgram(p.node));
+        localName = (0, utils_1.addComponentImport)(program, newComponent);
+    }
+    let localChildName = childComponent;
+    if (availableComponents.has(childComponent)) {
+        let program = path.findParent((p) => t.isProgram(p.node));
+        localChildName = (0, utils_1.addComponentImport)(program, childComponent);
+    }
+    // Convert dynamic collection to an array.map.
+    let items = path.get('openingElement').get('attributes').find((attr) => t.isJSXAttribute(attr.node) && attr.node.name.name === 'items');
+    let itemArg;
+    if (items && t.isJSXExpressionContainer(items.node.value) && t.isExpression(items.node.value.expression)) {
+        let child = path.get('children').find(c => c.isJSXExpressionContainer());
+        if (child && child.isJSXExpressionContainer() && t.isFunction(child.node.expression)) {
+            let arg = child.node.expression.params[0];
+            if (t.isIdentifier(arg)) {
+                itemArg = arg;
+            }
+            child.replaceWith(t.jsxExpressionContainer(t.callExpression(t.memberExpression(items.node.value.expression, t.identifier('map')), [child.node.expression])));
+        }
+    }
+    items?.remove();
+    let onAction = path.get('openingElement').get('attributes').find((attr) => t.isJSXAttribute(attr.node) && attr.node.name.name === 'onAction');
+    // Pull disabledKeys prop out into a variable, converted to a Set.
+    // Then we can check it in the isDisabled prop of each item.
+    let disabledKeysPath = path.get('openingElement').get('attributes').find((attr) => t.isJSXAttribute(attr.node) && attr.node.name.name === 'disabledKeys');
+    let disabledKeys;
+    if (disabledKeysPath && t.isJSXExpressionContainer(disabledKeysPath.node.value) && t.isExpression(disabledKeysPath.node.value.expression)) {
+        disabledKeys = path.scope.generateUidIdentifier('disabledKeys');
+        path.scope.push({
+            id: disabledKeys,
+            init: t.newExpression(t.identifier('Set'), [disabledKeysPath.node.value.expression]),
+            kind: 'let'
+        });
+        disabledKeysPath.remove();
+    }
+    path.traverse({
+        JSXElement(child) {
+            if (t.isJSXIdentifier(child.node.openingElement.name) && child.node.openingElement.name.name === 'Item') {
+                // Replace Item with ActionButton or ToggleButton.
+                let childNode = t.cloneNode(child.node);
+                childNode.openingElement.name = t.jsxIdentifier(localChildName);
+                if (childNode.closingElement) {
+                    childNode.closingElement.name = t.jsxIdentifier(localChildName);
+                }
+                // If there is no key prop and we are using dynamic collections, add a default computed from item.key ?? item.id.
+                let key = childNode.openingElement.attributes.find(attr => t.isJSXAttribute(attr) && attr.name.name === 'key');
+                if (!key && itemArg) {
+                    let id = t.jsxExpressionContainer(t.logicalExpression('??', t.memberExpression(itemArg, t.identifier('key')), t.memberExpression(itemArg, t.identifier('id'))));
+                    key = t.jsxAttribute(t.jsxIdentifier('key'), id);
+                    childNode.openingElement.attributes.push(key);
+                }
+                // If this is a ToggleButtonGroup, add an id prop in addition to key when needed.
+                if (key && newComponent === 'ToggleButtonGroup') {
+                    // If we are in an array.map we need both key and id. Otherwise, we only need id.
+                    if (itemArg) {
+                        childNode.openingElement.attributes.push(t.jsxAttribute(t.jsxIdentifier('id'), key.value));
+                    }
+                    else {
+                        key.name.name = 'id';
+                    }
+                }
+                let keyValue = undefined;
+                if (key && t.isJSXExpressionContainer(key.value) && t.isExpression(key.value.expression)) {
+                    keyValue = key.value.expression;
+                }
+                else if (key && t.isStringLiteral(key.value)) {
+                    keyValue = key.value;
+                }
+                // Add an onPress to each item that calls the previous onAction, passing in the key.
+                if (onAction && t.isJSXExpressionContainer(onAction.node.value) && t.isExpression(onAction.node.value.expression)) {
+                    childNode.openingElement.attributes.push(t.jsxAttribute(t.jsxIdentifier('onPress'), t.jsxExpressionContainer(keyValue
+                        ? t.arrowFunctionExpression([], t.callExpression(onAction.node.value.expression, [keyValue]))
+                        : onAction.node.value.expression)));
+                }
+                // Add an isDisabled prop to each item, testing whether it is in disabledKeys.
+                if (disabledKeys && keyValue) {
+                    childNode.openingElement.attributes.push(t.jsxAttribute(t.jsxIdentifier('isDisabled'), t.jsxExpressionContainer(t.callExpression(t.memberExpression(disabledKeys, t.identifier('has')), [keyValue]))));
+                }
+                child.replaceWith(childNode);
+            }
+        }
+    });
+    onAction?.remove();
+    path.node.openingElement.name = t.jsxIdentifier(localName);
+    if (path.node.closingElement) {
+        path.node.closingElement.name = t.jsxIdentifier(localName);
+    }
+}
+/**
+ * Adds isRowHeader to the first Column in a table if there isn't already a row header.
+ * @param path
+ */
+function addRowHeader(path) {
+    let tableHeaderPath = path.get('children').find((child) => t.isJSXElement(child.node) &&
+        t.isJSXIdentifier(child.node.openingElement.name) &&
+        (0, utils_1.getName)(child, child.node.openingElement.name) === 'TableHeader');
+    // Check if isRowHeader is already set on a Column
+    let hasRowHeader = false;
+    tableHeaderPath?.get('children').forEach((child) => {
+        if (t.isJSXElement(child.node) &&
+            t.isJSXIdentifier(child.node.openingElement.name) &&
+            (0, utils_1.getName)(child, child.node.openingElement.name) === 'Column') {
+            let isRowHeaderProp = child.get('openingElement').get('attributes').find((attr) => t.isJSXAttribute(attr.node) && attr.node.name.name === 'isRowHeader');
+            if (isRowHeaderProp) {
+                hasRowHeader = true;
+            }
+        }
+    });
+    // If there isn't already a row header, add one to the first Column if possible
+    if (!hasRowHeader) {
+        tableHeaderPath?.get('children').forEach((child) => {
+            // Add to first Column if static
+            if (!hasRowHeader &&
+                t.isJSXElement(child.node) &&
+                t.isJSXIdentifier(child.node.openingElement.name) &&
+                (0, utils_1.getName)(child, child.node.openingElement.name) === 'Column') {
+                child.node.openingElement.attributes.push(t.jsxAttribute(t.jsxIdentifier('isRowHeader'), t.jsxExpressionContainer(t.booleanLiteral(true))));
+                hasRowHeader = true;
+            }
+            // If render function is used, leave a comment to update manually
+            if (t.isJSXExpressionContainer(child.node) &&
+                t.isArrowFunctionExpression(child.node.expression)) {
+                (0, utils_1.addComment)(child.node, ' TODO(S2-upgrade): You\'ll need to add isRowHeader to one of the columns manually.');
+            }
+            // If array.map is used, leave a comment to update manually
+            if (t.isJSXExpressionContainer(child.node) &&
+                t.isCallExpression(child.node.expression) &&
+                t.isMemberExpression(child.node.expression.callee) &&
+                t.isIdentifier(child.node.expression.callee.property) &&
+                child.node.expression.callee.property.name === 'map') {
+                (0, utils_1.addComment)(child.node, ' TODO(S2-upgrade): You\'ll need to add isRowHeader to one of the columns manually.');
+            }
+        });
+    }
+}
 exports.functionMap = {
     updatePropNameAndValue,
     updatePropValueAndAddNewProp,
@@ -704,5 +1032,12 @@ exports.functionMap = {
     updatePlacementToSingleValue,
     removeComponentIfWithinParent,
     updateAvatarSize,
-    updateLegacyLink
+    updateLegacyLink,
+    addColumnsPropToRow,
+    updateRowFunctionArg,
+    updateDialogChild,
+    updateActionGroup,
+    updateKeyToId,
+    commentIfNestedColumns,
+    addRowHeader
 };

package/dist/s1-to-s2/src/codemods/unsafeStyle.js

@@ -160,7 +160,12 @@ function handleProperty(element, property, value) {
         case 'maxWidth':
         case 'height':
         case 'minHeight':
-        case 'maxHeight':
+        case 'maxHeight': {
+            if (value.type === 'NumericLiteral' || value.type === 'StringLiteral') {
+                return (0, dimensions_1.convertUnsafeDimension)(value.value, 'size');
+            }
+            break;
+        }
         case 'margin':
         case 'marginInlineStart':
         case 'marginInlineEnd':
@@ -178,7 +183,7 @@ function handleProperty(element, property, value) {
         case 'insetInlineEnd':
         case 'flexBasis': {
             if (value.type === 'NumericLiteral' || value.type === 'StringLiteral') {
-                return (0, dimensions_1.convertUnsafeDimension)(value.value);
+                return (0, dimensions_1.convertUnsafeDimension)(value.value, 'space');
             }
             break;
         }
@@ -196,7 +201,7 @@ function handleProperty(element, property, value) {
         case 'columnGap': {
             if (element === 'View' || element === 'Flex' || element === 'Grid') {
                 if (value.type === 'NumericLiteral' || value.type === 'StringLiteral') {
-                    return (0, dimensions_1.convertUnsafeDimension)(value.value);
+                    return (0, dimensions_1.convertUnsafeDimension)(value.value, 'space');
                 }
             }
             break;

package/dist/s1-to-s2/src/getComponents.js

@@ -14,12 +14,7 @@ const skipped = new Set([
     'Accordion',
     'Card',
     'CardView',
-    'TableView',
-    'TableHeader',
-    'Column',
-    'TableBody',
-    'Row',
-    'Cell'
+    'ActionBar'
 ]);
 function getComponents() {
     // Determine list of available components in S2 from index.ts

package/dist/s1-to-s2/src/iconMap.js

@@ -155,10 +155,6 @@ exports.iconMap = new Map([
         'Channel',
         'Channel'
     ],
-    [
-        'ChatAdd',
-        'Channel'
-    ],
     [
         'Checkmark',
         'CheckmarkSize300'
@@ -711,10 +707,22 @@ exports.iconMap = new Map([
         'Pause',
         'Pause'
     ],
+    [
+        'PauseCircle',
+        'PauseCircle'
+    ],
     [
         'Pending',
         'ClockPending'
     ],
+    [
+        'PinOff',
+        'PinOff'
+    ],
+    [
+        'PinOn',
+        'PinOn'
+    ],
     [
         'Play',
         'Play'
@@ -991,6 +999,10 @@ exports.iconMap = new Map([
         'TextBulleted',
         'ListBulleted'
     ],
+    [
+        'TextIncrease',
+        'TextIncrease'
+    ],
     [
         'TextItalic',
         'TextItalic'

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@react-spectrum/codemods",
-  "version": "0.2.1",
+  "version": "0.4.0",
   "main": "dist/index.js",
   "source": "src/index.ts",
   "bin": "dist/index.js",
@@ -24,29 +24,31 @@
     "@babel/parser": "^7.24.5",
     "@babel/traverse": "^7.24.5",
     "@babel/types": "^7.24.5",
-    "@react-spectrum/s2": "^0.4.1",
-    "@react-types/shared": "^3.25.0",
+    "@react-spectrum/s2": "^0.6.0",
+    "@react-types/shared": "^3.27.0",
     "@types/node": "^20",
     "boxen": "^5.1.2",
     "build": "^0.1.4",
     "chalk": "^4.0.0",
     "execa": "^5.1.1",
     "jscodeshift": "^0.15.2",
-    "react": "^16.8.0 || ^17.0.0-rc.1 || ^18.0.0 || ^19.0.0",
     "recast": "^0.23.9",
     "ts-node": "^10.9.2",
     "uuid": "^9.0.1"
   },
   "devDependencies": {
     "@types/jscodeshift": "^0.11.11",
-    "react-dom": "^16.8.0 || ^17.0.0-rc.1 || ^18.0.0 || ^19.0.0",
     "typescript": "^5.5.0"
   },
+  "peerDependencies": {
+    "react": "^18.0.0 || ^19.0.0-rc.1",
+    "react-dom": "^18.0.0 || ^19.0.0-rc.1"
+  },
   "rsp": {
     "type": "cli"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "8e0a28d188cdbdbd2b32296fa034b1b02ddde229"
+  "gitHead": "09e7f44bebdc9d89122926b2b439a0a38a2814ea"
 }