@react-native-ohos/slider 4.4.4-rc.1 → 5.0.1

package/example/package.json

@@ -0,0 +1,58 @@
+{
+  "name": "react-native-harmony-tester",
+  "version": "1.0.0",
+  "private": true,
+  "scripts": {
+    "i": "cd ../ && npm i && npm run pack && cd ./example && npm i",
+    "reStart": "npm run install:pkg && npm run codegen && hdc rport tcp:8081 tcp:8081 && react-native start",
+    "start": "hdc rport tcp:8081 tcp:8081 && react-native start",
+    "codegen": "react-native codegen-harmony --rnoh-module-path ./harmony/entry/oh_modules/@rnoh/react-native-openharmony",
+    "pack:pkg": "cd ../ && npm pack && cd ./example",
+    "install:pkg": "npm uninstall @react-native-ohos/slider && npm run pack:pkg && npm i @react-native-ohos/slider@file:../react-native-ohos-slider-5.0.1-rc.1.tgz",
+    "dev": "npm run codegen && react-native bundle-harmony --dev --minify=false",
+    "prod": "npm run codegen && react-native bundle-harmony --dev=false --minify=true",
+    "postinstall": "node ./scripts/create-build-profile",
+    "fast:pkg": "cd ../ && npm i --legacy-peer-deps && npm pack && cd ./example && npm i && npm run dev"
+  },
+  "dependencies": {
+    "@react-native-ohos/slider": "file:../react-native-ohos-slider-5.0.1-rc.1.tgz",
+    "react": "18.3.1",
+    "react-native": "0.77.1",
+    "react-native-harmony": "file:../packages/rnoh-react-native-harmony-0.77.10.tgz"
+  },
+  "devDependencies": {
+    "@babel/core": "^7.25.2",
+    "@babel/preset-env": "^7.25.3",
+    "@babel/runtime": "^7.25.0",
+    "@react-native-community/cli": "15.0.1",
+    "@react-native-community/cli-platform-android": "15.0.1",
+    "@react-native-community/cli-platform-ios": "15.0.1",
+    "@react-native-community/eslint-config": "^3.2.0",
+    "@react-native/babel-preset": "0.77.1",
+    "@react-native/eslint-config": "0.77.1",
+    "@react-native/metro-config": "^0.77.1",
+    "@react-native/typescript-config": "0.77.1",
+    "@rnoh/react-native-harmony-cli": "file:../packages/rnoh-react-native-harmony-cli-0.77.10.tgz",
+    "@tsconfig/react-native": "^3.0.0",
+    "@types/d3-scale-chromatic": "^3.0.0",
+    "@types/jest": "^29.5.13",
+    "@types/react": "^18.2.6",
+    "@types/react-test-renderer": "^18.0.0",
+    "babel-jest": "^29.6.3",
+    "eslint": "^8.19.0",
+    "jest": "^29.7.0",
+    "metro-react-native-babel-preset": "0.76.8",
+    "prettier": "2.8.8",
+    "react-test-renderer": "18.3.1",
+    "typescript": "5.5.4"
+  },
+  "overrides": {
+    "@react-native-community/cli": "15.0.1"
+  },
+ "resolutions": {
+    "@react-native-community/cli": "15.0.1"
+ },
+ "engines": {
+    "node": ">=18"
+ }
+}

package/example/react-native.config.js

@@ -0,0 +1,11 @@
+/*
+ * Copyright (c) 2025 Huawei Device Co., Ltd. All rights reserved
+ * Use of this source code is governed by a MIT license that can be
+ * found in the LICENSE file.
+ */
+
+module.exports = {
+  project: {
+  },
+  assets: ['./assets/fonts/'],
+};

package/example/scripts/create-build-profile.js

@@ -0,0 +1,46 @@
+/*
+ * Copyright (c) 2025 Huawei Device Co., Ltd. All rights reserved
+ * Use of this source code is governed by a MIT license that can be
+ * found in the LICENSE file.
+ */
+
+
+const fs = require('fs');
+const JSON5 = require('json5');
+const path = require('path');
+
+const templatePath = path.join(
+  __dirname,
+  '..',
+  'harmony',
+  'build-profile.template.json5',
+);
+const existingProfilePath = path.join(
+  __dirname,
+  '..',
+  'harmony',
+  'build-profile.json5',
+);
+
+if (fs.existsSync(existingProfilePath)) {
+  let existingProfile = JSON5.parse(
+    fs.readFileSync(existingProfilePath, 'utf-8'),
+  );
+  let template = JSON5.parse(fs.readFileSync(templatePath, 'utf-8'));
+  let signingConfigs =
+    existingProfile.app && existingProfile.app.signingConfigs;
+
+  existingProfile = {...template};
+
+  if (signingConfigs) {
+    existingProfile.app.signingConfigs = signingConfigs;
+  }
+
+  fs.writeFileSync(
+    existingProfilePath,
+    JSON5.stringify(existingProfile, null, 2),
+  );
+} else {
+  // File doesn't exist, create a copy from the template
+  fs.copyFileSync(templatePath, existingProfilePath);
+}

package/example/src/index.tsx

@@ -0,0 +1,22 @@
+/*
+ * Copyright (c) 2025 Huawei Device Co., Ltd. All rights reserved
+ * Use of this source code is governed by a MIT license that can be
+ * found in the LICENSE file.
+ */
+
+import Slider from "@react-native-community/slider"
+import { View } from 'react-native'
+
+export default function SliderExample() {
+    return (
+        <View style={{ backgroundColor: 'red', width: 200, height: 100 ,margin:100 }}>
+            <Slider
+                style={{ width: 200, height: 40 }}
+                minimumValue={0}
+                maximumValue={1}
+                minimumTrackTintColor="#FFFFFF"
+                maximumTrackTintColor="#000000"
+            />
+        </View>
+    );
+};

package/example/tsconfig.json

@@ -0,0 +1,20 @@
+/*
+ * Copyright (c) 2025 Huawei Device Co., Ltd. All rights reserved
+ * Use of this source code is governed by a MIT license that can be
+ * found in the LICENSE file.
+ */
+
+{
+  "extends": "@react-native/typescript-config/tsconfig.json",
+  "compilerOptions": {
+    "jsx": "react-native",
+    "paths": {
+      "react-native": [
+        "./node_modules/react-native-harmony"
+      ],
+    },
+  },
+  "exclude": [
+    "harmony"
+  ]
+}

package/harmony/slider/OAT.xml

@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<configuration>
+	<oatconfig>
+	<licensefile>LICENSE</licensefile>
+		<filefilterlist>
+			<filefilter name="copyrightPolicyFilter" desc="Filters for compatibility，license header policies">
+				<filteritem type="filename" name="hvigorfile.ts" desc="hvigor构建脚本，DevEco Studio自动生成，不需要添加版权头"/>
+				<filteritem type="filename" name="*.json5" desc="hvigor工程配置文件，DevEco Studio自动生成，不需要添加版权头"/>
+				<filteritem type="filename" name="*.proto" desc="资源文件，不需要添加版权头"/>
+				<filteritem type="filename" name="*.json" desc="资源文件，不需要添加版权头"/>
+				<filteritem type="filename" name="*.test.ts" desc="测试文件，不需要添加版权头"/>
+				<filteritem type="filename" name="index.ets" desc="入口文件，不需要添加版权头"/>
+				<filteritem type="filepath" name="hvigorw" desc="工程模板，不修改版权头，以防有修改版权风险"/>
+				<filteritem type="filepath" name="hvigorw.bat" desc="工程模板，不修改版权头，以防有修改版权风险"/>
+				<filteritem type="filepath" name="hvigor/hvigor-wrapper.js" desc="工程模板，不修改版权头，以防有修改版权风险"/>
+                <filteritem type="filename" name="LICENSE" desc="工程文件，不修改版权头"/>
+			</filefilter>
+			<filefilter name="defaultPolicyFilter" desc="Filters for compatibility，license header policies">
+				<filteritem type="filename" name="hvigorfile.ts" desc="hvigor构建脚本，DevEco Studio自动生成，不需要添加许可证头"/>
+				<filteritem type="filename" name="*.json5" desc="hvigor工程配置文件，DevEco Studio自动生成，不需要添加许可证头"/>
+				<filteritem type="filename" name="LICENSE" desc="原三方库证书文件无需更改，因此添加过滤"/>
+				<filteritem type="filename" name="*.proto" desc="资源文件，不需要添加许可证头"/>
+				<filteritem type="filename" name="*.json" desc="资源文件，不需要添加许可证头"/>
+				<filteritem type="filename" name="*.test.ts" desc="测试文件，不需要添加版权头"/>
+				<filteritem type="filename" name="index.ets" desc="入口文件，不需要添加版权头"/>
+				<filteritem type="filepath" name="hvigorw" desc="工程模板，不修改版权头，以防有修改版权风险"/>
+				<filteritem type="filepath" name="hvigorw.bat" desc="工程模板，不修改版权头，以防有修改版权风险"/>
+				<filteritem type="filepath" name="hvigor/hvigor-wrapper.js" desc="工程模板，不修改版权头，以防有修改版权风险"/>
+			</filefilter>
+			<filefilter name="binaryFileTypePolicyFilter" desc="Filters for resources files policies">
+				<filteritem type="filename" name="icon.png" desc="应用图标"/>
+				<filteritem type="filename" name="app_icon.png" desc="应用图标"/>
+				<filteritem type="filename" name="warn.png" desc="页面展示图标"/>
+			</filefilter>
+		</filefilterlist>
+        <policylist>
+            <policy name="projectPolicy" desc="">
+                <policyitem type="license" name="MIT" path=".*" desc="license under the MIT"/>
+            </policy>
+        </policylist>
+	</oatconfig>
+</configuration>

package/harmony/slider/index.ets

@@ -21,6 +21,5 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
  * SOFTWARE.
  */
-import { SliderPackage } from './src/main/ets/SliderPackage'
-export default SliderPackage
+ 
 export * from './src/main/ets/Slider'

package/harmony/slider/oh-package.json5

@@ -1,11 +1,11 @@
 {
   "name": "@react-native-ohos/slider",
-  "version": "4.4.4-rc.1",
+  "version": "5.0.1",
   "description": "@react-native-community/slider for HarmonyOS",
   "main": "index.ets",
   "author": "Huawei",
   "license": "MIT",
   "dependencies": {
-    "@rnoh/react-native-openharmony": "file:../react_native_openharmony"
+    "@rnoh/react-native-openharmony": "file:../react_native_openharmony.har"
   }
 }

package/harmony/slider/src/main/cpp/ComponentDescriptor.h

@@ -21,8 +21,7 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
  * SOFTWARE.
  */
-#ifndef COMPONENTDESCRIPTOR_SLIDER_H
-#define COMPONENTDESCRIPTOR_SLIDER_H
+
 #pragma once
 
 #include "ShadowNodes.h"
@@ -34,5 +33,4 @@ namespace react {
 using RNCSliderComponentDescriptor = ConcreteComponentDescriptor<RNCSliderShadowNode>;
 
 } // namespace react
-} // namespace facebook
-#endif
+} // namespace facebook

package/harmony/slider/src/main/cpp/EventEmitters.cpp

@@ -28,38 +28,38 @@
 namespace facebook {
 namespace react {
 
-void RNCSliderEventEmitter::onChange(OnChange event) const
-{
-    dispatchEvent("change", [event = std::move(event)](jsi::Runtime &runtime) {
-        auto payload = jsi::Object(runtime);
-        payload.setProperty(runtime, "value", event.value);
-        return payload;
-    });
+void RNCSliderEventEmitter::onChange(OnChange event) const {
+   dispatchEvent("change", [event = std::move(event)](jsi::Runtime &runtime) {
+       auto payload = jsi::Object(runtime);
+       payload.setProperty(runtime, "value", event.value);
+    //    payload.setProperty(runtime, "fromUser", event.fromUser);
+       return payload;
+   });
 }
 
-void RNCSliderEventEmitter::onRNCSliderSlidingStart(OnRNCSliderSlidingStart event) const
-{
+void RNCSliderEventEmitter::onRNCSliderSlidingStart(OnRNCSliderSlidingStart event) const {
     dispatchEvent("rNCSliderSlidingStart", [event = std::move(event)](jsi::Runtime &runtime) {
         auto payload = jsi::Object(runtime);
         payload.setProperty(runtime, "value", event.value);
+//        payload.setProperty(runtime, "fromUser", event.fromUser);
         return payload;
     });
 }
 
-void RNCSliderEventEmitter::onRNCSliderSlidingComplete(OnRNCSliderSlidingComplete event) const
-{
+void RNCSliderEventEmitter::onRNCSliderSlidingComplete(OnRNCSliderSlidingComplete event) const {
     dispatchEvent("rNCSliderSlidingComplete", [event = std::move(event)](jsi::Runtime &runtime) {
         auto payload = jsi::Object(runtime);
         payload.setProperty(runtime, "value", event.value);
+//        payload.setProperty(runtime, "fromUser", event.fromUser);
         return payload;
     });
 }
 
-void RNCSliderEventEmitter::onRNCSliderValueChange(OnRNCSliderValueChange event) const
-{
+void RNCSliderEventEmitter::onRNCSliderValueChange(OnRNCSliderValueChange event) const {
     dispatchEvent("rNCSliderValueChange", [event = std::move(event)](jsi::Runtime &runtime) {
         auto payload = jsi::Object(runtime);
         payload.setProperty(runtime, "value", event.value);
+//        payload.setProperty(runtime, "fromUser", event.fromUser);
         return payload;
     });
 }

package/harmony/slider/src/main/cpp/EventEmitters.h

@@ -21,8 +21,7 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
  * SOFTWARE.
  */
-#ifndef EVENTEMITTERS_SLIDER_H
-#define EVENTEMITTERS_SLIDER_H
+
 #pragma once
 
 #include <react/renderer/components/view/ViewEventEmitter.h>
@@ -34,20 +33,28 @@ namespace react {
 class JSI_EXPORT RNCSliderEventEmitter : public ViewEventEmitter {
     public:
       using ViewEventEmitter::ViewEventEmitter;
-    struct OnChange {
-            Float value;
-        };
+    
+   struct OnChange {
+       Float value;
+    //    bool fromUser;
+   };
+
     struct OnRNCSliderSlidingStart {
             Float value;
+    //        bool fromUser;
         };
+    
     struct OnRNCSliderSlidingComplete {
             Float value;
+    //        bool fromUser;
         };
+    
     struct OnRNCSliderValueChange {
             Float value;
+    //        bool fromUser;
         };
-    
-    void onChange(OnChange value) const;
+
+   void onChange(OnChange value) const;
 
     void onRNCSliderSlidingStart(OnRNCSliderSlidingStart value) const;
 
@@ -57,5 +64,4 @@ class JSI_EXPORT RNCSliderEventEmitter : public ViewEventEmitter {
 };
 
 } // namespace react
-} // namespace facebook
-#endif
+} // namespace facebook

package/harmony/slider/src/main/cpp/Props.cpp

@@ -33,13 +33,17 @@ RNCSliderProps::RNCSliderProps(
     const PropsParserContext &context,
     const RNCSliderProps &sourceProps,
     const RawProps &rawProps): ViewProps(context, sourceProps, rawProps),
-    maximumTrackTintColor(
-        convertRawProp(context, rawProps, "maximumTrackTintColor", sourceProps.maximumTrackTintColor, {})),
-    minimumTrackTintColor(
-        convertRawProp(context, rawProps, "minimumTrackTintColor", sourceProps.minimumTrackTintColor, {})),
+
+//    accessibilityUnits(convertRawProp(context, rawProps, "accessibilityUnits", sourceProps.accessibilityUnits, {})),
+//    accessibilityIncrements(convertRawProp(context, rawProps, "accessibilityIncrements", sourceProps.accessibilityIncrements, {})),
+//    maximumTrackImage(convertRawProp(context, rawProps, "maximumTrackImage", sourceProps.maximumTrackImage, {})),
+    maximumTrackTintColor(convertRawProp(context, rawProps, "maximumTrackTintColor", sourceProps.maximumTrackTintColor, {})),
+//    minimumTrackImage(convertRawProp(context, rawProps, "minimumTrackImage", sourceProps.minimumTrackImage, {})),
+    minimumTrackTintColor(convertRawProp(context, rawProps, "minimumTrackTintColor", sourceProps.minimumTrackTintColor, {})),
     thumbImage(convertRawProp(context, rawProps, "thumbImage", sourceProps.thumbImage, {})),
     thumbTintColor(convertRawProp(context, rawProps, "thumbTintColor", sourceProps.thumbTintColor, {}))
-    {}
+//    trackImage(convertRawProp(context, rawProps, "trackImage", sourceProps.trackImage, {})),
+      {}
 
 } // namespace react
 } // namespace facebook

package/harmony/slider/src/main/cpp/Props.h

@@ -21,8 +21,7 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
  * SOFTWARE.
  */
-#ifndef PROPS_SLIDER_H
-#define PROPS_SLIDER_H
+
 #pragma once
 
 #include <jsi/jsi.h>
@@ -37,15 +36,21 @@ namespace react {
 
 class JSI_EXPORT RNCSliderProps final : public ViewProps {
 public:
-    RNCSliderProps() = default;
-    RNCSliderProps(const PropsParserContext& context, const RNCSliderProps &sourceProps, const RawProps &rawProps);
+  RNCSliderProps() = default;
+  RNCSliderProps(const PropsParserContext& context, const RNCSliderProps &sourceProps, const RawProps &rawProps);
 
 #pragma mark - Props
-    SharedColor maximumTrackTintColor{};
-    SharedColor minimumTrackTintColor{};
-    ImageSource thumbImage{};
-    SharedColor thumbTintColor{};
+
+  // std::string accessibilityUnits{};
+  // std::vector<std::string> accessibilityIncrements{};
+  // ImageSource maximumTrackImage{};
+  SharedColor maximumTrackTintColor{};
+  // ImageSource minimumTrackImage{};
+  SharedColor minimumTrackTintColor{};
+  ImageSource thumbImage{};
+  SharedColor thumbTintColor{};
+  // ImageSource trackImage{};
 };
+
 } // namespace react
-} // namespace facebook
-#endif
+} // namespace facebook

package/harmony/slider/src/main/cpp/ShadowNodes.cpp

@@ -27,7 +27,7 @@
 namespace facebook {
 namespace react {
 
-const char RNC_SLIDER_COMPONENT_NAME[] = "RNCSlider";
+extern const char RNCSliderComponentName[] = "RNCSlider";
 
 } // namespace react
 } // namespace facebook

package/harmony/slider/src/main/cpp/ShadowNodes.h

@@ -21,8 +21,6 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
  * SOFTWARE.
  */
-#ifndef SHADOWNODES_SLIDER_H
-#define SHADOWNODES_SLIDER_H
 #pragma once
 
 #include <react/renderer/components/view/ConcreteViewShadowNode.h>
@@ -34,13 +32,15 @@
 namespace facebook {
 namespace react {
 
-JSI_EXPORT extern const char RNC_SLIDER_COMPONENT_NAME[32];
+JSI_EXPORT extern const char RNCSliderComponentName[];
 
+/*
+ * `ShadowNode` for <RNCSlider> component.
+ */
 using RNCSliderShadowNode = ConcreteViewShadowNode<
-    RNC_SLIDER_COMPONENT_NAME,
+    RNCSliderComponentName,
     RNCSliderProps,
     RNCSliderEventEmitter>;
 
 } // namespace react
-} // namespace facebook
-#endif
+} // namespace facebook

package/harmony/slider/src/main/cpp/SliderEventEmiRequestHandler.h

@@ -21,8 +21,7 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
  * SOFTWARE.
  */
-#ifndef SLIDEREVENTEMIREQUESTHANDLER_H
-#define SLIDEREVENTEMIREQUESTHANDLER_H
+
 #pragma once
 
 #include "RNOH/ArkJS.h"
@@ -39,8 +38,7 @@ enum SliderEventType {
     SLIDING_COMPLETE = 2
 };
 
-SliderEventType getSliderEventType(ArkJS &arkJs, napi_value eventObject)
-{
+SliderEventType getSliderEventType(ArkJS &arkJs, napi_value eventObject) {
     auto eventType = arkJs.getString(arkJs.getObjectProperty(eventObject, "type"));
     if (eventType == "SliderValueChange") {
         return SliderEventType::VALUE_CHANGE;
@@ -55,8 +53,7 @@ SliderEventType getSliderEventType(ArkJS &arkJs, napi_value eventObject)
 
 class SliderEventEmitRequestHandler : public EventEmitRequestHandler {
     public:
-        void handleEvent(EventEmitRequestHandler::Context const &ctx) override
-        {
+        void handleEvent(EventEmitRequestHandler::Context const &ctx) override {
             if (ctx.eventName != "RNCSlider") {
                 return;
             }
@@ -66,31 +63,31 @@ class SliderEventEmitRequestHandler : public EventEmitRequestHandler {
                 return;
             }
             auto eventType = getSliderEventType(arkJs, ctx.payload);
-            switch (eventType) {
-                case SliderEventType::VALUE_CHANGE: {
-                    facebook::react::Float value = arkJs.getDouble(arkJs.getObjectProperty(ctx.payload, "value"));
-                    react::RNCSliderEventEmitter::OnChange event1 = {value};
-                    eventEmitter->onChange(event1);
-                    react::RNCSliderEventEmitter::OnRNCSliderValueChange event2 = {value};
-                    eventEmitter->onRNCSliderValueChange(event2);
-                    break;
-                }
-                case SliderEventType::SLIDING_START: {
-                    facebook::react::Float value = arkJs.getDouble(arkJs.getObjectProperty(ctx.payload, "value"));
-                    react::RNCSliderEventEmitter::OnRNCSliderSlidingStart event = {value};
-                    eventEmitter->onRNCSliderSlidingStart(event);
-                    break;
-                }
-                case SliderEventType::SLIDING_COMPLETE: {
-                    facebook::react::Float value = arkJs.getDouble(arkJs.getObjectProperty(ctx.payload, "value"));
-                    react::RNCSliderEventEmitter::OnRNCSliderSlidingComplete event = {value};
-                    eventEmitter->onRNCSliderSlidingComplete(event);
-                    break;
-                }
-                default:
-                    break;
+            switch (eventType)
+            {
+            case SliderEventType::VALUE_CHANGE: {
+                facebook::react::Float value = arkJs.getDouble(arkJs.getObjectProperty(ctx.payload, "value"));
+                react::RNCSliderEventEmitter::OnChange event1 = {value};
+                eventEmitter->onChange(event1);
+                react::RNCSliderEventEmitter::OnRNCSliderValueChange event2 = {value};
+                eventEmitter->onRNCSliderValueChange(event2);
+                break;
+            }
+            case SliderEventType::SLIDING_START: {
+                facebook::react::Float value = arkJs.getDouble(arkJs.getObjectProperty(ctx.payload, "value"));
+                react::RNCSliderEventEmitter::OnRNCSliderSlidingStart event = {value};
+                eventEmitter->onRNCSliderSlidingStart(event);
+                break;
+            }
+            case SliderEventType::SLIDING_COMPLETE: {
+                facebook::react::Float value = arkJs.getDouble(arkJs.getObjectProperty(ctx.payload, "value"));
+                react::RNCSliderEventEmitter::OnRNCSliderSlidingComplete event = {value};
+                eventEmitter->onRNCSliderSlidingComplete(event);
+                break;
+            }
+            default:
+                break;
             }
         };
 };
-} // namespace rnoh
-#endif
+} // namespace rnoh

package/harmony/slider/src/main/cpp/SliderJSIBinder.h

@@ -21,8 +21,7 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
  * SOFTWARE.
  */
-#ifndef SLIDERJSIBINDER_H
-#define SLIDERJSIBINDER_H
+
 #pragma once
 
 #include "RNOHCorePackage/ComponentBinders/ViewComponentJSIBinder.h"
@@ -30,8 +29,7 @@
 namespace rnoh {
 
 class SliderJSIBinder : public ViewComponentJSIBinder {
-    facebook::jsi::Object createNativeProps(facebook::jsi::Runtime &rt) override
-    {
+    facebook::jsi::Object createNativeProps(facebook::jsi::Runtime &rt) override {
         auto object = ViewComponentJSIBinder::createNativeProps(rt);
         object.setProperty(rt, "disabled", "boolean");
         object.setProperty(rt, "inverted", "boolean");
@@ -51,21 +49,19 @@ class SliderJSIBinder : public ViewComponentJSIBinder {
         return object;
     }
 
-    facebook::jsi::Object createBubblingEventTypes(facebook::jsi::Runtime &rt) override
-    {
+    facebook::jsi::Object createBubblingEventTypes(facebook::jsi::Runtime &rt) override {
         facebook::jsi::Object events(rt);
-        events.setProperty(rt, "topChange", createBubblingCapturedEvent(rt, "onChange"));
-        events.setProperty(rt, "topRNCSliderValueChange", createBubblingCapturedEvent(rt, "onRNCSliderValueChange"));
+        events.setProperty(rt, "topChange", createDirectEvent(rt, "onChange"));
+        events.setProperty(rt, "topRNCSliderValueChange", createDirectEvent(rt, "onRNCSliderValueChange"));
         return events;
     }
 
-    facebook::jsi::Object createDirectEventTypes(facebook::jsi::Runtime &rt) override
-    {
+    facebook::jsi::Object createDirectEventTypes(facebook::jsi::Runtime &rt) override {
         facebook::jsi::Object events(rt);
         events.setProperty(rt, "topRNCSliderSlidingStart", createDirectEvent(rt, "onRNCSliderSlidingStart"));
         events.setProperty(rt, "topRNCSliderSlidingComplete", createDirectEvent(rt, "onRNCSliderSlidingComplete"));
         return events;
     }
+
 };
-} // namespace rnoh
-#endif
+} // namespace rnoh

package/harmony/slider/src/main/cpp/SliderNapiBinder.h

@@ -21,8 +21,6 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
  * SOFTWARE.
  */
-#ifndef SLIDERNAPIBINDER_H
-#define SLIDERNAPIBINDER_H
 #pragma once
 
 #include "RNOHCorePackage/ComponentBinders/ViewComponentNapiBinder.h"
@@ -32,8 +30,7 @@ namespace rnoh {
 
 class SliderNapiBinder : public ViewComponentNapiBinder {
 public:
-    napi_value createProps(napi_env env, facebook::react::ShadowView const shadowView) override
-    {
+    napi_value createProps(napi_env env, facebook::react::ShadowView const shadowView) override {
         napi_value napiViewProps = ViewComponentNapiBinder::createProps(env, shadowView);
         if (auto props = std::dynamic_pointer_cast<const facebook::react::RNCSliderProps>(shadowView.props)) {
             return ArkJS(env)
@@ -47,5 +44,4 @@ public:
         return napiViewProps;
     };
 };
-} //namespace rnoh
-#endif
+} //namespace rnoh