@react-native-oh-tpl/react-native-gesture-handler 2.14.14 → 2.14.16

package/harmony/gesture_handler/BuildProfile.ets

@@ -1,7 +1,7 @@
 /**
  * Use these variables when you tailor your ArkTS code. They must be of the const type.
  */
-export const HAR_VERSION = '2.14.14';
+export const HAR_VERSION = '2.14.16';
 export const BUILD_MODE_NAME = 'release';
 export const DEBUG = false;
 export const TARGET_NAME = 'default';

package/harmony/gesture_handler/build-profile.json5

@@ -1,12 +1,5 @@
 {
   "apiType": 'stageMode',
-//  "buildOption": {
-//    "externalNativeOptions": {
-//      "path": "./src/main/cpp/CMakeLists.txt",
-//      "arguments": "",
-//      "cppFlags": "",
-//    },
-//  },
   "targets": [
     {
       "name": "default",

package/harmony/gesture_handler/oh-package-lock.json5

@@ -5,14 +5,15 @@
   "lockfileVersion": 3,
   "ATTENTION": "THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.",
   "specifiers": {
-    "@rnoh/react-native-openharmony@../react_native_openharmony.har": "@rnoh/react-native-openharmony@../react_native_openharmony.har"
+    "@rnoh/react-native-openharmony@0.72.38": "@rnoh/react-native-openharmony@0.72.38"
   },
   "packages": {
-    "@rnoh/react-native-openharmony@../react_native_openharmony.har": {
+    "@rnoh/react-native-openharmony@0.72.38": {
       "name": "@rnoh/react-native-openharmony",
-      "version": "0.72.35",
-      "resolved": "../react_native_openharmony.har",
-      "registryType": "local"
+      "version": "0.72.38",
+      "integrity": "sha512-br5SIrbB0OarSLirenleE7eTOX1lNccMJ7nb/G7qWTyJ7kW4DalmTXVKYpoT2qaOLls1uEE7McD1OjbZZM9jug==",
+      "resolved": "https://ohpm.openharmony.cn/ohpm/@rnoh/react-native-openharmony/-/react-native-openharmony-0.72.38.har",
+      "registryType": "ohpm"
     }
   }
 }

package/harmony/gesture_handler/oh-package.json5

@@ -5,8 +5,8 @@
   name: '@react-native-oh-tpl/react-native-gesture-handler',
   description: '',
   type: 'module',
-  version: '2.14.14',
+  version: '2.14.16',
   dependencies: {
-    "@rnoh/react-native-openharmony": "file:./react_native_openharmony"
+    "@rnoh/react-native-openharmony": "^0.72.32"
   },
 }

package/harmony/gesture_handler/src/main/ets/gesture-handlers/PanGestureHandler.ts

@@ -284,7 +284,13 @@ export class PanGestureHandler extends GestureHandler<PanGestureHandlerConfig> {
     if (this.currentState === State.ACTIVE) {
       this.lastPos = this.tracker.getLastAvgPos();
     }
+
     this.tracker.removeFromTracker(event.pointerId);
+    
+    if (this.tracker.getTrackedPointersCount() === 0) {
+      this.clearActivationTimeout();
+    }
+
     if (this.currentState === State.ACTIVE) {
       this.end();
     } else {
@@ -358,4 +364,12 @@ export class PanGestureHandler extends GestureHandler<PanGestureHandlerConfig> {
       this.unlockRNGestureResponder?.()
     }
   }
+
+  protected onCancel(): void {
+    this.clearActivationTimeout();
+  }
+
+  protected onReset(): void {
+    this.clearActivationTimeout();
+  }
 }

package/harmony/gesture_handler/src/main/ets/rnoh/GestureHandlerPackage.ts

@@ -19,7 +19,7 @@ class GestureHandlerTurboModuleFactory extends TurboModulesFactory {
  * @deprecated: Use the package class exported from ../RNOHPackage.ets (2024-10-10)
  */
 export class GestureHandlerPackage extends RNPackage {
-  createUITurboModuleFactory(ctx: TurboModuleContext): TurboModulesFactory {
+  createTurboModulesFactory(ctx: TurboModuleContext): TurboModulesFactory {
     return new GestureHandlerTurboModuleFactory(ctx);
   }
 }

package/harmony/gesture_handler/src/main/ets/rnoh/RNGHRootViewController.ts

@@ -1,6 +1,6 @@
 import { TouchEvent as TouchEventArkTS, TouchType, TouchObject } from './types';
 import { RNGHLogger, View, Multiset, GestureHandlerRegistry } from '../core';
-import { RawTouchableView } from "./RNGHView"
+import { RawTouchableView, RNGHView } from "./RNGHView"
 import { RNGHViewController } from './RNGHViewController';
 
 type RawTouchPoint = {
@@ -59,8 +59,9 @@ export class RNGHRootViewController {
     if (e.type === TouchType.Down) {
       this.activeViewTags.clear();
     }
-    const views = touchableViews
-    for (const view of views) {
+    const views = touchableViews as RNGHView[]
+    for (let i = 0; i < views.length; i++) {
+      const view = views[i];
       for (const handler of this.gestureHandlerRegistry.getGestureHandlersByViewTag(
         view.getTag(),
       )) {
@@ -87,6 +88,18 @@ export class RNGHRootViewController {
           this.activeViewTags.add(view.getTag());
         }
       }
+
+      // If the pointer is inside the view but it overflows its parent, handlers attached to the parent
+      // might not have been called correctly (wrong bounding box). Extending the parent bounding box 
+      // with the child bounding box ensures that the parent handlers are called correctly.
+      // This approach is slightly different from Android RNGH implementation (extracting parent gesture handlers), 
+      // however, the outcome is the same.
+      for (let j = i - 1; j > 0; j--) {
+        const parentView = views[j];
+        if (parentView.intersectsWith(view)) {
+          parentView.attachChildrenBoundingRects(view);
+        }
+      }
     }
 
     // send touch to gesture handlers, prioritize handling touch events for child components
@@ -104,6 +117,7 @@ export class RNGHRootViewController {
 
     if (touchEvent.type === TouchType.Up || touchEvent.type === TouchType.Cancel) {
       touchableViews.forEach(view => this.touchableViewsMultiset.remove(view));
+      views.forEach(view => view.resetChildrenBoundingRects());
     }
   }
 

package/harmony/gesture_handler/src/main/ets/rnoh/RNGHView.ts

@@ -20,6 +20,7 @@ export class RNGHView implements View {
   private tag: number
   private buttonRole: boolean
   private boundingBox: BoundingBox
+  private childrenBoundingBoxes: Set<BoundingBox> = new Set()
 
   constructor({ tag, buttonRole, ...boundingBox }: RawTouchableView) {
     this.tag = tag
@@ -35,23 +36,49 @@ export class RNGHView implements View {
     return { ...this.boundingBox }
   }
 
+  getChildrenBoundingRects(): BoundingBox[] {
+    return Array.from(this.childrenBoundingBoxes)
+  }
+
   isPositionInBounds({ x, y }: {
     x: number;
     y: number
   }): boolean {
-    const rect = this.getBoundingRect();
-    return (
+    const rects = [this.boundingBox, ...this.childrenBoundingBoxes]
+    return rects.some(rect => (
       x >= rect.x &&
         x <= rect.x + rect.width &&
         y >= rect.y &&
         y <= rect.y + rect.height
-    );
+    ))
   }
 
   updateBoundingBox(boundingBox: BoundingBox) {
     this.boundingBox = boundingBox
   }
 
+  resetChildrenBoundingRects() {
+    this.childrenBoundingBoxes.clear()
+  }
+
+  attachChildrenBoundingRects(view: RNGHView) {
+    this.childrenBoundingBoxes.add(view.getBoundingRect())
+    for (const childBoundingBox of view.getChildrenBoundingRects()) {
+      this.childrenBoundingBoxes.add(childBoundingBox)
+    }
+  }
+
+  intersectsWith(view: RNGHView): boolean {
+    const rect1 = this.getBoundingRect()
+    const rect2 = view.getBoundingRect()
+    return (
+      rect1.x < rect2.x + rect2.width &&
+      rect1.x + rect1.width > rect2.x &&
+      rect1.y < rect2.y + rect2.height &&
+      rect1.y + rect1.height > rect2.y
+    )
+  }
+
   setButtonRole(buttonRole: boolean) {
     this.buttonRole = buttonRole
   }

package/harmony/gesture_handler/src/main/ets/rnoh/RNGHViewController.ts

@@ -165,16 +165,9 @@ export class RNGHViewController {
   }
 
   private isInBounds(point: Point): boolean {
-    const x = point.x;
-    const y = point.y;
     const rect = this.view.getBoundingRect();
     this.logger.cloneAndJoinPrefix("isInBounds").debug({ rect })
-    const result =
-      x >= rect.x &&
-        x <= rect.x + rect.width &&
-        y >= rect.y &&
-        y <= rect.y + rect.height;
-    return result;
+    return this.view.isPositionInBounds(point);
   }
 
   private updateActivePointers(touchType: TouchType, pointerId: number): void {

package/harmony/gesture_handler/src/main/ets/rnoh/RNGestureHandlerModule.ts

@@ -1,4 +1,4 @@
-import { UITurboModule, UITurboModuleContext, Tag } from "@rnoh/react-native-openharmony/ts";
+import { TurboModule, TurboModuleContext, Tag } from "@rnoh/react-native-openharmony/ts";
 import { TM } from "@rnoh/react-native-openharmony/generated/ts"
 import {
   GestureHandlerRegistry,
@@ -25,7 +25,7 @@ export enum ActionType {
 }
 
 
-export class RNGestureHandlerModule extends UITurboModule implements TM.RNGestureHandlerModule.Spec {
+export class RNGestureHandlerModule extends TurboModule implements TM.RNGestureHandlerModule.Spec {
   static readonly NAME = "RNGestureHandlerModule"
 
   private gestureHandlerRegistry: GestureHandlerRegistry
@@ -36,7 +36,7 @@ export class RNGestureHandlerModule extends UITurboModule implements TM.RNGestur
   private rootViewControllerByRootTag = new Map<Tag, RNGHRootViewController>()
   private interactionManager: InteractionManager
 
-  constructor(ctx: UITurboModuleContext, isDevModeEnabled: boolean = false) {
+  constructor(ctx: TurboModuleContext, isDevModeEnabled: boolean = false) {
     super(ctx)
     this.cleanLogger =
       isDevModeEnabled && ctx.isDebugModeEnabled ? new DevelopmentRNGHLogger(ctx.logger, "RNGH") :

package/package.json

@@ -17,7 +17,7 @@
     "type": "git",
     "url": "https://github.com/react-native-oh-library/react-native-harmony-gesture-handler.git"
   },
-  "version": "2.14.14",
+  "version": "2.14.16",
   "description": "",
   "react-native": "src/index.ts",
   "main": "lib/commonjs/index.js",