@react-native-harness/jest 1.1.0-rc.1 → 1.1.0-rc.2

package/src/__tests__/index.test.ts

@@ -0,0 +1,61 @@
+import { describe, expect, it, vi } from 'vitest';
+import type { Harness } from '../harness.js';
+import type { Config as HarnessConfig } from '@react-native-harness/config';
+import type { Config, Test, TestWatcher } from 'jest-runner';
+import JestHarness from '../index.js';
+import { StartupStallError } from '../errors.js';
+
+describe('JestHarness', () => {
+  it('reports StartupStallError without a stack trace', async () => {
+    const runner = new JestHarness({} as Config.GlobalConfig);
+    const onFailure = vi.fn();
+
+    const harness = {
+      ensureAppReady: vi
+        .fn()
+        .mockRejectedValue(new StartupStallError(1500, 3)),
+      callHook: vi.fn(async () => undefined),
+      setRunState: vi.fn(),
+      getRunState: vi.fn(() => null),
+      crashSupervisor: {
+        beginTestRun: vi.fn(),
+        waitForCrash: vi.fn(),
+        cancelCrashWaiters: vi.fn(),
+        reset: vi.fn(),
+      },
+    } as unknown as Harness;
+
+    await runner._createInBandTestRun(
+      [
+        {
+          path: '/tmp/example.harness.ts',
+          context: {
+            config: {},
+          },
+        } as Test,
+      ],
+      {
+        isInterrupted: () => false,
+      } as TestWatcher,
+      harness,
+      {
+        detectNativeCrashes: true,
+        resetEnvironmentBetweenTestFiles: false,
+      } as HarnessConfig,
+      () => Promise.resolve(),
+      () => Promise.resolve(),
+      onFailure
+    );
+
+    expect(onFailure).toHaveBeenCalledWith(
+      expect.objectContaining({
+        path: '/tmp/example.harness.ts',
+      }),
+      {
+        message:
+          'The app did not request its Metro bundle after 3 launch attempts within 1500ms. Last Metro status: unknown.',
+        stack: '',
+      }
+    );
+  });
+});

package/src/cli-args.ts

@@ -3,6 +3,7 @@ import { hideBin } from 'yargs/helpers';
 
 export type HarnessCliArgs = {
   harnessRunner?: string;
+  metroPort?: number;
 };
 
 export const getAdditionalCliArgs = (): HarnessCliArgs => {
@@ -11,6 +12,10 @@ export const getAdditionalCliArgs = (): HarnessCliArgs => {
       type: 'string',
       description: 'Specify which Harness runner to use',
     })
+    .option('metroPort', {
+      type: 'number',
+      description: 'Override the Metro bundler port',
+    })
     .strict(false)
     .help(false)
     .version(false)
@@ -19,5 +24,6 @@ export const getAdditionalCliArgs = (): HarnessCliArgs => {
 
   return {
     harnessRunner: argv.harnessRunner,
+    metroPort: argv.metroPort,
   };
 };

package/src/crash-supervisor.ts

@@ -12,6 +12,8 @@ import {
 } from './errors.js';
 import { logger } from '@react-native-harness/tools';
 
+const crashLogger = logger.child('crash');
+
 export type CrashSupervisorState =
   | 'idle'
   | 'launching'
@@ -113,15 +115,20 @@ export const createCrashSupervisor = ({
     }
 
     if (!activeTestFilePath) {
-      logger.debug(`Ignoring crash signal without active test: ${reason}`);
+      crashLogger.debug('ignoring crash signal without active test: %s', reason);
       return;
     }
 
     isResolvingCrash = true;
-    logger.debug(`Native crash detected during ${activeTestFilePath} (state: ${state}, reason: ${reason || '(none)'})`);
+    crashLogger.debug(
+      'native crash detected during %s (state=%s reason=%s)',
+      activeTestFilePath,
+      state,
+      reason || '(none)'
+    );
 
     for (const line of details?.rawLines ?? []) {
-      logger.debug(line);
+      crashLogger.debug('%s', line);
     }
 
     const phase = getCrashPhase(state);
@@ -136,7 +143,7 @@ export const createCrashSupervisor = ({
       });
 
       const mergedDetails = mergeCrashDetails(phase, details, enrichedDetails, reason);
-      logger.debug('Crash details:', {
+      crashLogger.debug('crash details: %o', {
         phase: mergedDetails.phase,
         source: mergedDetails.source,
         summary: mergedDetails.summary,
@@ -160,10 +167,10 @@ export const createCrashSupervisor = ({
       const isRunning = await platformRunner.isAppRunning();
 
       if (!isRunning) {
-        handleCrash(reason, details);
+        void handleCrash(reason, details);
       }
     } catch (error) {
-      logger.debug('Crash confirmation failed', error);
+      crashLogger.debug('crash confirmation failed', error);
     }
   };
 

package/src/env.d.ts

@@ -1,4 +1,4 @@
-import type { Harness } from '@react-native-harness/cli/external';
+import type { Harness } from './harness.js';
 import type { Config as HarnessConfig } from '@react-native-harness/config';
 
 declare global {

package/src/errors.ts

@@ -1,5 +1,10 @@
 import { HarnessError } from '@react-native-harness/tools';
 import type { AppCrashDetails } from '@react-native-harness/platforms';
+export {
+  StartupStallError,
+  type StartupStallCode,
+  type StartupStallDetails,
+} from '@react-native-harness/bundler-metro';
 
 export class NoRunnerSpecifiedError extends HarnessError {
   constructor() {