@react-native-firebase/database 18.7.1 → 18.7.3

package/CHANGELOG.md

@@ -3,6 +3,16 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [18.7.3](https://github.com/invertase/react-native-firebase/compare/v18.7.2...v18.7.3) (2023-12-13)
+
+**Note:** Version bump only for package @react-native-firebase/database
+
+## [18.7.2](https://github.com/invertase/react-native-firebase/compare/v18.7.1...v18.7.2) (2023-12-08)
+
+### Bug Fixes
+
+- **database:** react-native 0.73 compatibility ([788cc22](https://github.com/invertase/react-native-firebase/commit/788cc228b7ab34af371bf0c537bbc2033a789b1a))
+
 ## [18.7.1](https://github.com/invertase/react-native-firebase/compare/v18.7.0...v18.7.1) (2023-11-29)
 
 **Note:** Version bump only for package @react-native-firebase/database

package/lib/DatabaseSyncTree.js

@@ -26,6 +26,15 @@ class DatabaseSyncTree {
     this._tree = {};
     this._reverseLookup = {};
 
+    // we need to be able to register multiple listeners for a single event,
+    // *then delete a specific single listener for that event*, so we have to
+    // be able to identify specific listeners for removal which means we need
+    // to mirror the private registration accounting from upstream EventEmitter
+    // so we have access here and can do our single emitter removal
+    // This is a map of emitter-key <-> set of listener registrations
+    // The listener registrations have { context, listener, remove() }
+    this._registry = {};
+
     SharedEventEmitter.addListener('database_sync_event', this._handleSyncEvent.bind(this));
   }
 
@@ -33,6 +42,16 @@ class DatabaseSyncTree {
     return NativeModules.RNFBDatabaseQueryModule;
   }
 
+  // from upstream EventEmitter: initialize registrations for an emitter key
+  _allocate(registry, eventType) {
+    let registrations = registry[eventType];
+    if (registrations == null) {
+      registrations = new Set();
+      registry[eventType] = registrations;
+    }
+    return registrations;
+  }
+
   /**
    * Handles an incoming event from native
    * @param event
@@ -132,6 +151,13 @@ class DatabaseSyncTree {
     if (isString(registrations)) {
       this.removeRegistration(registrations);
       SharedEventEmitter.removeAllListeners(registrations);
+
+      // mirror upstream accounting - clear out all registrations for this key
+      if (registrations == null) {
+        this._registry = {};
+      } else {
+        delete this._registry[registrations];
+      }
       return 1;
     }
 
@@ -141,6 +167,12 @@ class DatabaseSyncTree {
     for (let i = 0, len = registrations.length; i < len; i++) {
       this.removeRegistration(registrations[i]);
       SharedEventEmitter.removeAllListeners(registrations[i]);
+      // mirror upstream accounting - clear out all registrations for this key
+      if (registrations[i] == null) {
+        this._registry = {};
+      } else {
+        delete this._registry[registrations[i]];
+      }
     }
 
     return registrations.length;
@@ -163,15 +195,10 @@ class DatabaseSyncTree {
       const registration = registrations[i];
       let subscriptions;
 
-      // EventEmitter in react-native < 0.70 had a `_subscriber` property with a method for subscriptions by type...
-      if (SharedEventEmitter._subscriber) {
-        subscriptions = SharedEventEmitter._subscriber.getSubscriptionsForType(registration);
-      } else {
-        // ...react-native 0.70 now stores subscribers as a map of Sets by type in `_registry`
-        const registrySubscriptionsSet = SharedEventEmitter._registry[registration];
-        if (registrySubscriptionsSet) {
-          subscriptions = Array.from(registrySubscriptionsSet);
-        }
+      // get all registrations for this key so we can find our specific listener
+      const registrySubscriptionsSet = this._registry[registration];
+      if (registrySubscriptionsSet) {
+        subscriptions = Array.from(registrySubscriptionsSet);
       }
 
       if (subscriptions) {
@@ -180,6 +207,7 @@ class DatabaseSyncTree {
           // The subscription may have been removed during this event loop.
           // its listener matches the listener in method parameters
           if (subscription && subscription.listener === listener) {
+            this._registry[registration].delete(subscription);
             subscription.remove();
             removed.push(registration);
             this.removeRegistration(registration);
@@ -278,7 +306,12 @@ class DatabaseSyncTree {
         subscription.remove();
       });
     } else {
-      SharedEventEmitter.addListener(eventRegistrationKey, listener);
+      const registration = SharedEventEmitter.addListener(eventRegistrationKey, listener);
+
+      // add this listener registration info to our emitter-key map
+      // in case we need to identify and remove a specific listener later
+      const registrations = this._allocate(this._registry, eventRegistrationKey);
+      registrations.add(registration);
     }
 
     return eventRegistrationKey;

package/lib/version.js

@@ -1,2 +1,2 @@
 // Generated by genversion.
-module.exports = '18.7.1';
+module.exports = '18.7.3';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@react-native-firebase/database",
-  "version": "18.7.1",
+  "version": "18.7.3",
   "author": "Invertase <oss@invertase.io> (http://invertase.io)",
   "description": "React Native Firebase - The Firebase Realtime Database is a cloud-hosted database. Data is stored as JSON and synchronized in realtime to every connected client. React Native Firebase provides native integration with the Android & iOS Firebase SDKs, supporting both realtime data sync and offline capabilities.",
   "main": "lib/index.js",
@@ -25,10 +25,10 @@
     "realtome database"
   ],
   "peerDependencies": {
-    "@react-native-firebase/app": "18.7.1"
+    "@react-native-firebase/app": "18.7.3"
   },
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "f8b7794db23185c8a934a3e3623e996ce282c1f7"
+  "gitHead": "605a0df8171c451513125629355027bda2ea5e5d"
 }