@react-native-firebase/crashlytics 21.7.0 → 21.7.2

package/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.7.2](https://github.com/invertase/react-native-firebase/compare/v21.7.1...v21.7.2) (2025-02-05)
+
+**Note:** Version bump only for package @react-native-firebase/crashlytics
+
+## [21.7.1](https://github.com/invertase/react-native-firebase/compare/v21.7.0...v21.7.1) (2025-01-20)
+
+**Note:** Version bump only for package @react-native-firebase/crashlytics
+
 ## [21.7.0](https://github.com/invertase/react-native-firebase/compare/v21.6.2...v21.7.0) (2025-01-16)
 
 **Note:** Version bump only for package @react-native-firebase/crashlytics

package/README.md

@@ -49,7 +49,7 @@ yarn add @react-native-firebase/crashlytics
 ---
 
 <p>
-  <img align="left" width="75px" src="https://static.invertase.io/assets/invertase-logo-small.png">
+  <img align="left" width="75px" src="https://static.invertase.io/assets/invertase/invertase-rounded.png">
   <p align="left">
     Built and maintained with 💛 by <a href="https://invertase.io">Invertase</a>.
   </p>

package/__tests__/crashlytics.test.ts

@@ -1,5 +1,10 @@
-import { describe, expect, it } from '@jest/globals';
-
+import { describe, expect, it, jest, beforeEach } from '@jest/globals';
+// @ts-ignore test
+import FirebaseModule from '../../app/lib/internal/FirebaseModule';
+import {
+  createCheckV9Deprecation,
+  CheckV9DeprecationFunction,
+} from '../../app/lib/common/unitTestUtils';
 import {
   firebase,
   getCrashlytics,
@@ -79,4 +84,132 @@ describe('Crashlytics', function () {
       expect(setCrashlyticsCollectionEnabled).toBeDefined();
     });
   });
+
+  describe('test `console.warn` is called for RNFB v8 API & not called for v9 API', function () {
+    let checkV9Deprecation: CheckV9DeprecationFunction;
+
+    beforeEach(function () {
+      checkV9Deprecation = createCheckV9Deprecation(['crashlytics']);
+
+      // @ts-ignore test
+      jest.spyOn(FirebaseModule.prototype, 'native', 'get').mockImplementation(() => {
+        return new Proxy(
+          {},
+          {
+            get: () => jest.fn(),
+          },
+        );
+      });
+    });
+
+    it('checkForUnsentReports', function () {
+      const crashlytics = getCrashlytics();
+      checkV9Deprecation(
+        () => checkForUnsentReports(crashlytics),
+        () => crashlytics.checkForUnsentReports(),
+        'checkForUnsentReports',
+      );
+    });
+
+    it('crash', function () {
+      const crashlytics = getCrashlytics();
+      checkV9Deprecation(
+        () => crash(crashlytics),
+        () => crashlytics.crash(),
+        'crash',
+      );
+    });
+
+    it('deleteUnsentReports', function () {
+      const crashlytics = getCrashlytics();
+      checkV9Deprecation(
+        () => deleteUnsentReports(crashlytics),
+        () => crashlytics.deleteUnsentReports(),
+        'deleteUnsentReports',
+      );
+    });
+
+    it('didCrashOnPreviousExecution', function () {
+      const crashlytics = getCrashlytics();
+      checkV9Deprecation(
+        () => didCrashOnPreviousExecution(crashlytics),
+        () => crashlytics.didCrashOnPreviousExecution(),
+        'didCrashOnPreviousExecution',
+      );
+    });
+
+    it('log', function () {
+      const crashlytics = getCrashlytics();
+      checkV9Deprecation(
+        () => log(crashlytics, 'message'),
+        () => crashlytics.log('message'),
+        'log',
+      );
+    });
+
+    it('setAttribute', function () {
+      const crashlytics = getCrashlytics();
+      checkV9Deprecation(
+        () => setAttribute(crashlytics, 'name', 'value'),
+        () => crashlytics.setAttribute('name', 'value'),
+        'setAttribute',
+      );
+    });
+
+    it('setAttributes', function () {
+      const crashlytics = getCrashlytics();
+      checkV9Deprecation(
+        () => setAttributes(crashlytics, {}),
+        () => crashlytics.setAttributes({}),
+        'setAttributes',
+      );
+    });
+
+    it('setUserId', function () {
+      const crashlytics = getCrashlytics();
+      checkV9Deprecation(
+        () => setUserId(crashlytics, 'id'),
+        () => crashlytics.setUserId('id'),
+        'setUserId',
+      );
+    });
+
+    it('recordError', function () {
+      const crashlytics = getCrashlytics();
+      checkV9Deprecation(
+        () => recordError(crashlytics, new Error(), 'name'),
+        () => crashlytics.recordError(new Error(), 'name'),
+        'recordError',
+      );
+    });
+
+    it('sendUnsentReports', function () {
+      const crashlytics = getCrashlytics();
+      checkV9Deprecation(
+        () => sendUnsentReports(crashlytics),
+        () => crashlytics.sendUnsentReports(),
+        'sendUnsentReports',
+      );
+    });
+
+    it('setCrashlyticsCollectionEnabled', function () {
+      const crashlytics = getCrashlytics();
+      checkV9Deprecation(
+        () => setCrashlyticsCollectionEnabled(crashlytics, true),
+        () => crashlytics.setCrashlyticsCollectionEnabled(true),
+        'setCrashlyticsCollectionEnabled',
+      );
+    });
+
+    it('isCrashlyticsCollectionEnabled', function () {
+      const crashlytics = getCrashlytics();
+      checkV9Deprecation(
+        // swapped order here because we're deprecating the modular method and keeping the property on Crashlytics instance
+        () => crashlytics.isCrashlyticsCollectionEnabled,
+        () => isCrashlyticsCollectionEnabled(crashlytics),
+        '',
+        '`isCrashlyticsCollectionEnabled()` is deprecated, please use `Crashlytics.isCrashlyticsCollectionEnabled` property instead',
+      );
+    });
+  });
 });

package/lib/handlers.js

@@ -103,7 +103,7 @@ export const setGlobalErrorHandler = once(nativeModule => {
               timestamp: fatalTime,
             },
           );
-        } catch (e) {
+        } catch (_) {
           // This just means analytics was not present, so we could not log the analytics event
           // console.log('error logging analytics app_exception: ' + e);
         }
@@ -114,7 +114,7 @@ export const setGlobalErrorHandler = once(nativeModule => {
         } else {
           await nativeModule.crashWithStackPromise(createNativeErrorObj(error, stackFrames, false));
         }
-      } catch (e) {
+      } catch (_) {
         // do nothing
         // console.log('error logging handling the exception: ' + e);
       }
@@ -131,7 +131,7 @@ export const setGlobalErrorHandler = once(nativeModule => {
 });
 
 export const setOnUnhandledPromiseRejectionHandler = once(nativeModule => {
-  async function onUnhandled(id, error) {
+  async function onUnhandled(_id, error) {
     if (!__DEV__) {
       // TODO(salakar): Option to disable
       try {

package/lib/index.d.ts

@@ -50,7 +50,7 @@ import { ReactNativeFirebase } from '@react-native-firebase/app';
 export namespace FirebaseCrashlyticsTypes {
   import FirebaseModule = ReactNativeFirebase.FirebaseModule;
 
-  // eslint-disable-next-line @typescript-eslint/no-empty-interface
+  // eslint-disable-next-line @typescript-eslint/no-empty-object-type
   export interface Statics {}
 
   /**
@@ -272,7 +272,6 @@ export * from './modular';
  * Attach namespace to `firebase.` and `FirebaseApp.`.
  */
 declare module '@react-native-firebase/app' {
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   namespace ReactNativeFirebase {
     import FirebaseModuleWithStatics = ReactNativeFirebase.FirebaseModuleWithStatics;
     interface Module {

package/lib/index.js

@@ -51,6 +51,7 @@ class FirebaseCrashlyticsModule extends FirebaseModule {
   }
 
   get isCrashlyticsCollectionEnabled() {
+    // Purposefully did not deprecate this as I think it should remain a property rather than a method.
     return this._isCrashlyticsCollectionEnabled;
   }
 

package/lib/modular/index.js

@@ -1,3 +1,4 @@
+import { MODULAR_DEPRECATION_ARG } from '@react-native-firebase/app/lib/common';
 import { firebase } from '..';
 
 /**
@@ -31,6 +32,11 @@ export function getCrashlytics() {
  * @returns {boolean}
  */
 export function isCrashlyticsCollectionEnabled(crashlytics) {
+  // Unique. Deprecating modular method and allow it as a property on Crashlytics instance.
+  // eslint-disable-next-line no-console
+  console.warn(
+    '`isCrashlyticsCollectionEnabled()` is deprecated, please use `Crashlytics.isCrashlyticsCollectionEnabled` property instead',
+  );
   return crashlytics.isCrashlyticsCollectionEnabled;
 }
 
@@ -53,7 +59,7 @@ export function isCrashlyticsCollectionEnabled(crashlytics) {
  * @returns {Promise<boolean>}
  */
 export function checkForUnsentReports(crashlytics) {
-  return crashlytics.checkForUnsentReports();
+  return crashlytics.checkForUnsentReports.call(crashlytics, MODULAR_DEPRECATION_ARG);
 }
 
 /**
@@ -70,7 +76,7 @@ export function checkForUnsentReports(crashlytics) {
  * @returns {Promise<void>}
  */
 export function deleteUnsentReports(crashlytics) {
-  return crashlytics.deleteUnsentReports();
+  return crashlytics.deleteUnsentReports.call(crashlytics, MODULAR_DEPRECATION_ARG);
 }
 
 /**
@@ -91,7 +97,7 @@ export function deleteUnsentReports(crashlytics) {
  * @returns {Promise<boolean>}
  */
 export function didCrashOnPreviousExecution(crashlytics) {
-  return crashlytics.didCrashOnPreviousExecution();
+  return crashlytics.didCrashOnPreviousExecution.call(crashlytics, MODULAR_DEPRECATION_ARG);
 }
 
 /**
@@ -109,7 +115,7 @@ export function didCrashOnPreviousExecution(crashlytics) {
  * @returns {void}
  */
 export function crash(crashlytics) {
-  return crashlytics.crash();
+  return crashlytics.crash.call(crashlytics, MODULAR_DEPRECATION_ARG);
 }
 
 /**
@@ -127,7 +133,7 @@ export function crash(crashlytics) {
  * @returns {void}
  */
 export function log(crashlytics, message) {
-  return crashlytics.log(message);
+  return crashlytics.log.call(crashlytics, message, MODULAR_DEPRECATION_ARG);
 }
 
 /**
@@ -152,7 +158,7 @@ export function log(crashlytics, message) {
  * @returns {void}
  */
 export function recordError(crashlytics, error, jsErrorName) {
-  return crashlytics.recordError(error, jsErrorName);
+  return crashlytics.recordError.call(crashlytics, error, jsErrorName, MODULAR_DEPRECATION_ARG);
 }
 
 /**
@@ -169,7 +175,7 @@ export function recordError(crashlytics, error, jsErrorName) {
  * @returns {void}
  */
 export function sendUnsentReports(crashlytics) {
-  return crashlytics.sendUnsentReports();
+  return crashlytics.sendUnsentReports.call(crashlytics, MODULAR_DEPRECATION_ARG);
 }
 
 /**
@@ -196,7 +202,7 @@ export function sendUnsentReports(crashlytics) {
  * @returns {Promise<null>}
  */
 export function setUserId(crashlytics, userId) {
-  return crashlytics.setUserId(userId);
+  return crashlytics.setUserId.call(crashlytics, userId, MODULAR_DEPRECATION_ARG);
 }
 
 /**
@@ -214,7 +220,7 @@ export function setUserId(crashlytics, userId) {
  * @returns {Promise<null>}
  */
 export function setAttribute(crashlytics, name, value) {
-  return crashlytics.setAttribute(name, value);
+  return crashlytics.setAttribute.call(crashlytics, name, value, MODULAR_DEPRECATION_ARG);
 }
 
 /**
@@ -234,7 +240,7 @@ export function setAttribute(crashlytics, name, value) {
  * @returns {Promise<null>}
  */
 export function setAttributes(crashlytics, attributes) {
-  return crashlytics.setAttributes(attributes);
+  return crashlytics.setAttributes.call(crashlytics, attributes, MODULAR_DEPRECATION_ARG);
 }
 
 /**
@@ -254,5 +260,9 @@ export function setAttributes(crashlytics, attributes) {
  * @returns {Promise<null>}
  */
 export function setCrashlyticsCollectionEnabled(crashlytics, enabled) {
-  return crashlytics.setCrashlyticsCollectionEnabled(enabled);
+  return crashlytics.setCrashlyticsCollectionEnabled.call(
+    crashlytics,
+    enabled,
+    MODULAR_DEPRECATION_ARG,
+  );
 }

package/lib/version.js

@@ -1,2 +1,2 @@
 // Generated by genversion.
-module.exports = '21.7.0';
+module.exports = '21.7.2';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@react-native-firebase/crashlytics",
-  "version": "21.7.0",
+  "version": "21.7.2",
   "author": "Invertase <oss@invertase.io> (http://invertase.io)",
   "description": "React Native Firebase - Firebase Crashlytics is a lightweight, realtime crash reporter that helps you track, prioritize, and fix stability issues that erode your app quality. React Native Firebase provides automatic crash reporting for both native and JavaScript errors, including unhandled promise rejections.",
   "main": "lib/index.js",
@@ -29,14 +29,14 @@
     "crashlytics"
   ],
   "peerDependencies": {
-    "@react-native-firebase/app": "21.7.0",
+    "@react-native-firebase/app": "21.7.2",
     "expo": ">=47.0.0"
   },
   "dependencies": {
     "stacktrace-js": "^2.0.2"
   },
   "devDependencies": {
-    "expo": "^50.0.21"
+    "expo": "^52.0.30"
   },
   "peerDependenciesMeta": {
     "expo": {
@@ -46,5 +46,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "c027ef2d772882c091383b7ff81b65573f549b5d"
+  "gitHead": "209b36e4b469355e4d024ecdeb6c875f8bd8a187"
 }

package/plugin/tsconfig.tsbuildinfo

@@ -1 +1 @@
-{"root":["./src/index.ts","./src/android/applyPlugin.ts","./src/android/buildscriptDependency.ts","./src/android/constants.ts","./src/android/index.ts"],"version":"5.6.2"}
+{"root":["./src/index.ts","./src/android/applyPlugin.ts","./src/android/buildscriptDependency.ts","./src/android/constants.ts","./src/android/index.ts"],"version":"5.7.3"}