@react-native-firebase/crashlytics 20.1.0 → 20.2.1

package/CHANGELOG.md

@@ -3,6 +3,17 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [20.2.1](https://github.com/invertase/react-native-firebase/compare/v20.2.0...v20.2.1) (2024-07-17)
+
+**Note:** Version bump only for package @react-native-firebase/crashlytics
+
+## [20.2.0](https://github.com/invertase/react-native-firebase/compare/v20.1.0...v20.2.0) (2024-07-15)
+
+### Bug Fixes
+
+- **app, android:** adopt firebase-android-sdk 31.1.1 ([dba1beb](https://github.com/invertase/react-native-firebase/commit/dba1beba97d88d1110e0838b6287fd4907cfa8a7))
+- **crashlytics, ios:** init w/componentsToRegister vs configureWithApp ([ca07cad](https://github.com/invertase/react-native-firebase/commit/ca07cadd592487102b035a24b55f593f065ef4a5))
+
 ## [20.1.0](https://github.com/invertase/react-native-firebase/compare/v20.0.0...v20.1.0) (2024-06-04)
 
 **Note:** Version bump only for package @react-native-firebase/crashlytics

package/ios/RNFBCrashlytics/RNFBCrashlyticsInitProvider.h

@@ -30,8 +30,4 @@
 /// FIRApp and participate in dependency resolution and injection.
 + (NSArray<FIRComponent *> *)componentsToRegister;
 
-/// Implement this method if the library needs notifications for lifecycle events. This method is
-/// called when the developer calls `FirebaseApp.configure()`.
-+ (void)configureWithApp:(FIRApp *)app;
-
 @end

package/ios/RNFBCrashlytics/RNFBCrashlyticsInitProvider.m

@@ -18,6 +18,11 @@
 #import "RNFBCrashlyticsInitProvider.h"
 #import <Firebase/Firebase.h>
 #import <FirebaseCoreExtension/FIRAppInternal.h>
+#import <FirebaseCoreExtension/FIRComponent.h>
+#import <FirebaseCoreExtension/FIRComponentContainer.h>
+#import <FirebaseCoreExtension/FIRComponentType.h>
+#import <FirebaseCoreExtension/FIRLibrary.h>
+#import <FirebaseCrashlytics/FIRCrashlytics.h>
 #import "RNFBJSON.h"
 #import "RNFBMeta.h"
 #import "RNFBPreferences.h"
@@ -32,6 +37,19 @@ NSString *const KEY_CRASHLYTICS_IS_ERROR_GENERATION_ON_JS_CRASH_ENABLED =
 NSString *const KEY_CRASHLYTICS_JAVASCRIPT_EXCEPTION_HANDLER_CHAINING_ENABLED =
     @"crashlytics_javascript_exception_handler_chaining_enabled";
 
+/// Empty protocol to register this provider as a component with Core.
+@protocol RNFBCrashlyticsInitProviderProtocol
+@end
+
+/// The name of the Crashlytics component in FirebaseCore's component system. Reference:
+// https://github.com/firebase/firebase-ios-sdk/blob/main/Crashlytics/Crashlytics/FIRCrashlytics.m#L87-L89
+@protocol FIRCrashlyticsInstanceProvider <NSObject>
+@end
+
+/// Privately conform to the protocol for component registration.
+@interface RNFBCrashlyticsInitProvider () <RNFBCrashlyticsInitProviderProtocol, FIRLibrary>
+@end
+
 @implementation RNFBCrashlyticsInitProvider
 
 + (void)load {
@@ -79,26 +97,47 @@ NSString *const KEY_CRASHLYTICS_JAVASCRIPT_EXCEPTION_HANDLER_CHAINING_ENABLED =
 }
 
 + (NSArray<FIRComponent *> *)componentsToRegister {
-  return @[];
-}
+  // Goal: enable or disable crashlytics logging based on firebase.json settings at app startup
+  //
+  // Problem: We need a correctly instantiated Crashlytics component in order to configure it
+  //
+  // Solution:
+  // 1) put the desired startup logic that requires Crashlytics dependency in deferrable block...
+  FIRComponentCreationBlock creationBlock =
+      ^id _Nullable(FIRComponentContainer *container, BOOL *isCacheable) {
+    if (!container.app.isDefaultApp) {
+      return nil;
+    }
 
-/*
- * configureWithApp is automatically invoked by Firebase as this app is a registered FIRLibrary with
- * the SDK.
- *
- * At this point "configure" has already been called on the FIRApp instance. This behavior is meant
- * to mirror what is done in ReactNativeFirebaseCrashlyticsInitProvider.java
- *
- * This pattern may not be supported long term
- * https://github.com/firebase/firebase-ios-sdk/issues/2933
- */
-+ (void)configureWithApp:(FIRApp *)app {
-  // This setting is sticky. setCrashlyticsCollectionEnabled persists the setting to disk until it
-  // is explicitly set otherwise or the app is deleted. Jump to the setCrashlyticsCollectionEnabled
-  // definition to see implementation details.
-  [[FIRCrashlytics crashlytics]
-      setCrashlyticsCollectionEnabled:self.isCrashlyticsCollectionEnabled];
-  DLog(@"RNFBCrashlyticsInit initialization successful");
+    // Ensure it's cached so it returns the same instance every time messaging is called.
+    *isCacheable = YES;
+
+    // 2) ... ask the SDK component system to get a correctly running dependency...
+    // Note: This is a FIRCrashlytics *, directly cast it later for practical use, reference:
+    // https://github.com/firebase/firebase-ios-sdk/blob/main/Crashlytics/Crashlytics/FIRCrashlytics.m#L282-L284
+    id<FIRCrashlyticsInstanceProvider> crashlytics =
+        FIR_COMPONENT(FIRCrashlyticsInstanceProvider, container);
+
+    // This setting is sticky. setCrashlyticsCollectionEnabled persists the setting to disk until it
+    // is explicitly set otherwise or the app is deleted. Jump to the
+    // setCrashlyticsCollectionEnabled definition to see implementation details.
+    [(FIRCrashlytics *)crashlytics
+        setCrashlyticsCollectionEnabled:self.isCrashlyticsCollectionEnabled];
+
+    // For testing: filter for this in logs to make sure this block executes via
+    // xcrun simctl spawn booted log stream --level debug --style compact |grep RNFBCrashlyticsInit
+    DLog(@"RNFBCrashlyticsInit initialization successful");
+    return nil;
+  };
+
+  // 3) ...finally: register startup block to run w/Crashlytics dependency when ready
+  FIRComponent *crashlyticsInitProvider =
+      [FIRComponent componentWithProtocol:@protocol(RNFBCrashlyticsInitProviderProtocol)
+                      instantiationTiming:FIRInstantiationTimingEagerInDefaultApp
+                             dependencies:@[]  // note this will go away in firebase-ios-sdk v11+
+                            creationBlock:creationBlock];
+
+  return @[ crashlyticsInitProvider ];
 }
 
 @end

package/lib/index.js

@@ -16,7 +16,13 @@
  *
  */
 
-import { isBoolean, isError, isObject, isString } from '@react-native-firebase/app/lib/common';
+import {
+  isBoolean,
+  isError,
+  isObject,
+  isString,
+  isOther,
+} from '@react-native-firebase/app/lib/common';
 import {
   createModuleNamespace,
   FirebaseModule,
@@ -161,4 +167,8 @@ export default createModuleNamespace({
 // crashlytics().X(...);
 // firebase.crashlytics().X(...);
 export const firebase = getFirebaseRoot();
-firebase.crashlytics();
+
+// This will throw with 'Default App Not initialized' if the default app is not configured.
+if (!isOther) {
+  firebase.crashlytics();
+}

package/lib/version.js

@@ -1,2 +1,2 @@
 // Generated by genversion.
-module.exports = '20.1.0';
+module.exports = '20.2.1';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@react-native-firebase/crashlytics",
-  "version": "20.1.0",
+  "version": "20.2.1",
   "author": "Invertase <oss@invertase.io> (http://invertase.io)",
   "description": "React Native Firebase - Firebase Crashlytics is a lightweight, realtime crash reporter that helps you track, prioritize, and fix stability issues that erode your app quality. React Native Firebase provides automatic crash reporting for both native and JavaScript errors, including unhandled promise rejections.",
   "main": "lib/index.js",
@@ -29,14 +29,14 @@
     "crashlytics"
   ],
   "peerDependencies": {
-    "@react-native-firebase/app": "20.1.0",
+    "@react-native-firebase/app": "20.2.1",
     "expo": ">=47.0.0"
   },
   "dependencies": {
     "stacktrace-js": "^2.0.2"
   },
   "devDependencies": {
-    "expo": "^50.0.18"
+    "expo": "^50.0.19"
   },
   "peerDependenciesMeta": {
     "expo": {
@@ -46,5 +46,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "99819b9cef23ac46080cbffe50cc85083305d04c"
+  "gitHead": "2c787c2dbefbefcc637018e1e5d74a73b39600ab"
 }