@react-native-firebase/app 21.6.0 → 21.6.1

package/CHANGELOG.md

@@ -3,6 +3,12 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [21.6.1](https://github.com/invertase/react-native-firebase/compare/v21.6.0...v21.6.1) (2024-11-25)
+
+### Bug Fixes
+
+- **android, app:** fix hot-reload on react-native <= 0.73 ([81e5fc2](https://github.com/invertase/react-native-firebase/commit/81e5fc2b6c89fdb4aa5f0f5aa95e1e90dae5f2e4))
+
 ## [21.6.0](https://github.com/invertase/react-native-firebase/compare/v21.5.0...v21.6.0) (2024-11-20)
 
 ### Features

package/android/src/reactnative/java/io/invertase/firebase/app/ReactNativeFirebaseVersion.java

@@ -18,5 +18,5 @@ package io.invertase.firebase.app;
  */
 // generated file - do not modify or commit
 public class ReactNativeFirebaseVersion {
-  public static String VERSION = "21.6.0";
+  public static String VERSION = "21.6.1";
 }

package/android/src/reactnative/java/io/invertase/firebase/common/ReactNativeFirebaseModule.java

@@ -92,12 +92,13 @@ public class ReactNativeFirebaseModule extends ReactContextBaseJavaModule
     return executorService.getTransactionalExecutor(identifier);
   }
 
-
-  // This is no longer called as of react-native 0.74 and is only here for
-  // compatibility with older versions. It delegates to thew new `invalidate`
+  // On react-native 0.73 this is called, but simply calls `invalidate()`
+  // https://github.com/facebook/react-native/blob/0.73-stable/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/BaseJavaModule.java#L65-L72
+  // This is no longer called ever for react-native >= 0.74 and is only here for
+  // compatibility with older versions. We delegate to the new `invalidate`
   // method, which all modules should implement now
   // Remove this method when minimum supported react-native is 0.74
-  /** @noinspection removal*/
+  // @noinspection removal
   @SuppressWarnings({"deprecation", "removal"})
   @Deprecated
   public void onCatalystInstanceDestroy() {
@@ -107,11 +108,14 @@ public class ReactNativeFirebaseModule extends ReactContextBaseJavaModule
   }
 
   // This should have an @Override annotation but we cannot do
-  // that until our minimum supported react-native version is 0.74, since the
-  // method did not exist before then
+  // that until our minimum supported react-native version is 0.74
+  //
+  // No need to call super.invalidate and in fact it is dangerous to do so:
+  // - did not exist before react-native 0.73
+  // - on 0.74 it calls onCatalystInstanceDestroy which would infinite loop here
+  // - on 0.75+ it is empty - meant as sub-class hook only
   @CallSuper
   public void invalidate() {
-    super.invalidate();
     executorService.shutdown();
   }
 

package/ios/RNFBApp/RNFBVersion.m

@@ -18,4 +18,4 @@
 #import <React/RCTVersion.h>
 
 // generated file - do not modify or commit
-NSString* const RNFBVersionString = @"21.6.0";
+NSString* const RNFBVersionString = @"21.6.1";

package/lib/version.js

@@ -1,2 +1,2 @@
 // Generated by genversion.
-module.exports = '21.6.0';
+module.exports = '21.6.1';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@react-native-firebase/app",
-  "version": "21.6.0",
+  "version": "21.6.1",
   "author": "Invertase <oss@invertase.io> (http://invertase.io)",
   "description": "A well tested, feature rich Firebase implementation for React Native, supporting iOS & Android. Individual module support for Admob, Analytics, Auth, Crash Reporting, Cloud Firestore, Database, Dynamic Links, Functions, Messaging (FCM), Remote Config, Storage and more.",
   "main": "lib/index.js",
@@ -89,5 +89,5 @@
       "playServicesAuth": "21.2.0"
     }
   },
-  "gitHead": "0103e12714de3c106128859eeadaf0fe07f9674c"
+  "gitHead": "3623a504a6d07fa148390bd3f97d6c06fea8955d"
 }