@react-aria/utils 3.30.1 → 3.32.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (84) hide show
  1. package/dist/filterDOMProps.main.js +1 -1
  2. package/dist/filterDOMProps.main.js.map +1 -1
  3. package/dist/filterDOMProps.mjs +1 -1
  4. package/dist/filterDOMProps.module.js +1 -1
  5. package/dist/filterDOMProps.module.js.map +1 -1
  6. package/dist/import.mjs +2 -2
  7. package/dist/isElementVisible.main.js +3 -1
  8. package/dist/isElementVisible.main.js.map +1 -1
  9. package/dist/isElementVisible.mjs +3 -1
  10. package/dist/isElementVisible.module.js +3 -1
  11. package/dist/isElementVisible.module.js.map +1 -1
  12. package/dist/keyboard.main.js +16 -0
  13. package/dist/keyboard.main.js.map +1 -1
  14. package/dist/keyboard.mjs +16 -1
  15. package/dist/keyboard.module.js +16 -1
  16. package/dist/keyboard.module.js.map +1 -1
  17. package/dist/main.js +1 -0
  18. package/dist/main.js.map +1 -1
  19. package/dist/mergeProps.main.js.map +1 -1
  20. package/dist/mergeProps.module.js.map +1 -1
  21. package/dist/module.js +2 -2
  22. package/dist/module.js.map +1 -1
  23. package/dist/openLink.main.js +1 -0
  24. package/dist/openLink.main.js.map +1 -1
  25. package/dist/openLink.mjs +1 -0
  26. package/dist/openLink.module.js +1 -0
  27. package/dist/openLink.module.js.map +1 -1
  28. package/dist/scrollIntoView.main.js +1 -0
  29. package/dist/scrollIntoView.main.js.map +1 -1
  30. package/dist/scrollIntoView.mjs +1 -0
  31. package/dist/scrollIntoView.module.js +1 -0
  32. package/dist/scrollIntoView.module.js.map +1 -1
  33. package/dist/types.d.ts +10 -10
  34. package/dist/types.d.ts.map +1 -1
  35. package/dist/useEvent.main.js +1 -2
  36. package/dist/useEvent.main.js.map +1 -1
  37. package/dist/useEvent.mjs +1 -2
  38. package/dist/useEvent.module.js +1 -2
  39. package/dist/useEvent.module.js.map +1 -1
  40. package/dist/useFormReset.main.js +1 -2
  41. package/dist/useFormReset.main.js.map +1 -1
  42. package/dist/useFormReset.mjs +1 -2
  43. package/dist/useFormReset.module.js +1 -2
  44. package/dist/useFormReset.module.js.map +1 -1
  45. package/dist/useLoadMoreSentinel.main.js +0 -1
  46. package/dist/useLoadMoreSentinel.main.js.map +1 -1
  47. package/dist/useLoadMoreSentinel.mjs +0 -1
  48. package/dist/useLoadMoreSentinel.module.js +0 -1
  49. package/dist/useLoadMoreSentinel.module.js.map +1 -1
  50. package/dist/useResizeObserver.main.js +8 -4
  51. package/dist/useResizeObserver.main.js.map +1 -1
  52. package/dist/useResizeObserver.mjs +8 -4
  53. package/dist/useResizeObserver.module.js +8 -4
  54. package/dist/useResizeObserver.module.js.map +1 -1
  55. package/dist/useUpdateEffect.main.js +5 -2
  56. package/dist/useUpdateEffect.main.js.map +1 -1
  57. package/dist/useUpdateEffect.mjs +5 -2
  58. package/dist/useUpdateEffect.module.js +5 -2
  59. package/dist/useUpdateEffect.module.js.map +1 -1
  60. package/dist/useValueEffect.main.js +13 -8
  61. package/dist/useValueEffect.main.js.map +1 -1
  62. package/dist/useValueEffect.mjs +14 -9
  63. package/dist/useValueEffect.module.js +14 -9
  64. package/dist/useValueEffect.module.js.map +1 -1
  65. package/dist/useViewportSize.main.js +27 -2
  66. package/dist/useViewportSize.main.js.map +1 -1
  67. package/dist/useViewportSize.mjs +27 -2
  68. package/dist/useViewportSize.module.js +27 -2
  69. package/dist/useViewportSize.module.js.map +1 -1
  70. package/package.json +4 -4
  71. package/src/filterDOMProps.ts +1 -1
  72. package/src/index.ts +1 -1
  73. package/src/isElementVisible.ts +1 -1
  74. package/src/keyboard.tsx +21 -0
  75. package/src/mergeProps.ts +1 -2
  76. package/src/openLink.tsx +1 -1
  77. package/src/scrollIntoView.ts +3 -0
  78. package/src/useEvent.ts +1 -1
  79. package/src/useFormReset.ts +1 -1
  80. package/src/useLoadMoreSentinel.ts +1 -1
  81. package/src/useResizeObserver.ts +8 -4
  82. package/src/useUpdateEffect.ts +5 -3
  83. package/src/useValueEffect.ts +15 -11
  84. package/src/useViewportSize.ts +37 -2
@@ -1 +1 @@
1
- {"mappings":";;;AAAA;;;;;;;;;;CAUC;;AAUD,IAAI,uCAAiB,OAAO,aAAa,eAAe,OAAO,cAAc;AAEtE,SAAS;IACd,IAAI,QAAQ,CAAA,GAAA,eAAO;IACnB,IAAI,CAAC,MAAM,QAAQ,GAAG,CAAA,GAAA,eAAO,EAAE,IAAM,QAAQ;YAAC,OAAO;YAAG,QAAQ;QAAC,IAAI;IAErE,CAAA,GAAA,gBAAQ,EAAE;QACR,wFAAwF;QACxF,IAAI,WAAW;YACb,QAAQ,CAAA;gBACN,IAAI,UAAU;gBACd,IAAI,QAAQ,KAAK,KAAK,KAAK,KAAK,IAAI,QAAQ,MAAM,KAAK,KAAK,MAAM,EAChE,OAAO;gBAET,OAAO;YACT;QACF;QAEA,IAAI,CAAC,sCACH,OAAO,gBAAgB,CAAC,UAAU;aAElC,qCAAe,gBAAgB,CAAC,UAAU;QAG5C,OAAO;YACL,IAAI,CAAC,sCACH,OAAO,mBAAmB,CAAC,UAAU;iBAErC,qCAAe,mBAAmB,CAAC,UAAU;QAEjD;IACF,GAAG,EAAE;IAEL,OAAO;AACT;AAEA,SAAS;IACP,OAAO;QACL,OAAO,AAAC,yCAAkB,iDAAA,2DAAA,qCAAgB,KAAK,KAAK,OAAO,UAAU;QACrE,QAAQ,AAAC,yCAAkB,iDAAA,2DAAA,qCAAgB,MAAM,KAAK,OAAO,WAAW;IAC1E;AACF","sources":["packages/@react-aria/utils/src/useViewportSize.ts"],"sourcesContent":["/*\n * Copyright 2020 Adobe. All rights reserved.\n * This file is licensed to you under the Apache License, Version 2.0 (the \"License\");\n * you may not use this file except in compliance with the License. You may obtain a copy\n * of the License at http://www.apache.org/licenses/LICENSE-2.0\n *\n * Unless required by applicable law or agreed to in writing, software distributed under\n * the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS\n * OF ANY KIND, either express or implied. See the License for the specific language\n * governing permissions and limitations under the License.\n */\n\nimport {useEffect, useState} from 'react';\nimport {useIsSSR} from '@react-aria/ssr';\n\ninterface ViewportSize {\n width: number,\n height: number\n}\n\nlet visualViewport = typeof document !== 'undefined' && window.visualViewport;\n\nexport function useViewportSize(): ViewportSize {\n let isSSR = useIsSSR();\n let [size, setSize] = useState(() => isSSR ? {width: 0, height: 0} : getViewportSize());\n\n useEffect(() => {\n // Use visualViewport api to track available height even on iOS virtual keyboard opening\n let onResize = () => {\n setSize(size => {\n let newSize = getViewportSize();\n if (newSize.width === size.width && newSize.height === size.height) {\n return size;\n }\n return newSize;\n });\n };\n\n if (!visualViewport) {\n window.addEventListener('resize', onResize);\n } else {\n visualViewport.addEventListener('resize', onResize);\n }\n\n return () => {\n if (!visualViewport) {\n window.removeEventListener('resize', onResize);\n } else {\n visualViewport.removeEventListener('resize', onResize);\n }\n };\n }, []);\n\n return size;\n}\n\nfunction getViewportSize(): ViewportSize {\n return {\n width: (visualViewport && visualViewport?.width) || window.innerWidth,\n height: (visualViewport && visualViewport?.height) || window.innerHeight\n };\n}\n"],"names":[],"version":3,"file":"useViewportSize.module.js.map"}
1
+ {"mappings":";;;;AAAA;;;;;;;;;;CAUC;;;AAWD,IAAI,uCAAiB,OAAO,aAAa,eAAe,OAAO,cAAc;AAEtE,SAAS;IACd,IAAI,QAAQ,CAAA,GAAA,eAAO;IACnB,IAAI,CAAC,MAAM,QAAQ,GAAG,CAAA,GAAA,eAAO,EAAE,IAAM,QAAQ;YAAC,OAAO;YAAG,QAAQ;QAAC,IAAI;IAErE,CAAA,GAAA,gBAAQ,EAAE;QACR,wFAAwF;QACxF,IAAI,WAAW;YACb,8BAA8B;YAC9B,IAAI,wCAAkB,qCAAe,KAAK,GAAG,GAC3C;YAGF,QAAQ,CAAA;gBACN,IAAI,UAAU;gBACd,IAAI,QAAQ,KAAK,KAAK,KAAK,KAAK,IAAI,QAAQ,MAAM,KAAK,KAAK,MAAM,EAChE,OAAO;gBAET,OAAO;YACT;QACF;QAEA,iHAAiH;QACjH,gGAAgG;QAChG,IAAI;QACJ,IAAI,SAAS,CAAC;YACZ,IAAI,wCAAkB,qCAAe,KAAK,GAAG,GAC3C;YAGF,IAAI,CAAA,GAAA,yCAAe,EAAE,EAAE,MAAM,GAC3B,uDAAuD;YACvD,QAAQ,sBAAsB;gBAC5B,IAAI,CAAC,SAAS,aAAa,IAAI,CAAC,CAAA,GAAA,yCAAe,EAAE,SAAS,aAAa,GACrE,QAAQ,CAAA;oBACN,IAAI,UAAU;wBAAC,OAAO,OAAO,UAAU;wBAAE,QAAQ,OAAO,WAAW;oBAAA;oBACnE,IAAI,QAAQ,KAAK,KAAK,KAAK,KAAK,IAAI,QAAQ,MAAM,KAAK,KAAK,MAAM,EAChE,OAAO;oBAET,OAAO;gBACT;YAEJ;QAEJ;QAEA,OAAO,gBAAgB,CAAC,QAAQ,QAAQ;QAExC,IAAI,CAAC,sCACH,OAAO,gBAAgB,CAAC,UAAU;aAElC,qCAAe,gBAAgB,CAAC,UAAU;QAG5C,OAAO;YACL,qBAAqB;YACrB,OAAO,mBAAmB,CAAC,QAAQ,QAAQ;YAC3C,IAAI,CAAC,sCACH,OAAO,mBAAmB,CAAC,UAAU;iBAErC,qCAAe,mBAAmB,CAAC,UAAU;QAEjD;IACF,GAAG,EAAE;IAEL,OAAO;AACT;AAEA,SAAS;IACP,OAAO;QACL,+FAA+F;QAC/F,OAAO,uCAAiB,qCAAe,KAAK,GAAG,qCAAe,KAAK,GAAG,OAAO,UAAU;QACvF,QAAQ,uCAAiB,qCAAe,MAAM,GAAG,qCAAe,KAAK,GAAG,OAAO,WAAW;IAC5F;AACF","sources":["packages/@react-aria/utils/src/useViewportSize.ts"],"sourcesContent":["/*\n * Copyright 2020 Adobe. All rights reserved.\n * This file is licensed to you under the Apache License, Version 2.0 (the \"License\");\n * you may not use this file except in compliance with the License. You may obtain a copy\n * of the License at http://www.apache.org/licenses/LICENSE-2.0\n *\n * Unless required by applicable law or agreed to in writing, software distributed under\n * the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS\n * OF ANY KIND, either express or implied. See the License for the specific language\n * governing permissions and limitations under the License.\n */\n\nimport {useEffect, useState} from 'react';\nimport {useIsSSR} from '@react-aria/ssr';\nimport {willOpenKeyboard} from './keyboard';\n\ninterface ViewportSize {\n width: number,\n height: number\n}\n\nlet visualViewport = typeof document !== 'undefined' && window.visualViewport;\n\nexport function useViewportSize(): ViewportSize {\n let isSSR = useIsSSR();\n let [size, setSize] = useState(() => isSSR ? {width: 0, height: 0} : getViewportSize());\n\n useEffect(() => {\n // Use visualViewport api to track available height even on iOS virtual keyboard opening\n let onResize = () => {\n // Ignore updates when zoomed.\n if (visualViewport && visualViewport.scale > 1) {\n return;\n }\n\n setSize(size => {\n let newSize = getViewportSize();\n if (newSize.width === size.width && newSize.height === size.height) {\n return size;\n }\n return newSize;\n });\n };\n\n // When closing the keyboard, iOS does not fire the visual viewport resize event until the animation is complete.\n // We can anticipate this and resize early by handling the blur event and using the layout size.\n let frame: number;\n let onBlur = (e: FocusEvent) => {\n if (visualViewport && visualViewport.scale > 1) {\n return;\n }\n\n if (willOpenKeyboard(e.target as Element)) {\n // Wait one frame to see if a new element gets focused.\n frame = requestAnimationFrame(() => {\n if (!document.activeElement || !willOpenKeyboard(document.activeElement)) {\n setSize(size => {\n let newSize = {width: window.innerWidth, height: window.innerHeight};\n if (newSize.width === size.width && newSize.height === size.height) {\n return size;\n }\n return newSize;\n });\n }\n });\n }\n };\n\n window.addEventListener('blur', onBlur, true);\n\n if (!visualViewport) {\n window.addEventListener('resize', onResize);\n } else {\n visualViewport.addEventListener('resize', onResize);\n }\n\n return () => {\n cancelAnimationFrame(frame);\n window.removeEventListener('blur', onBlur, true);\n if (!visualViewport) {\n window.removeEventListener('resize', onResize);\n } else {\n visualViewport.removeEventListener('resize', onResize);\n }\n };\n }, []);\n\n return size;\n}\n\nfunction getViewportSize(): ViewportSize {\n return {\n // Multiply by the visualViewport scale to get the \"natural\" size, unaffected by pinch zooming.\n width: visualViewport ? visualViewport.width * visualViewport.scale : window.innerWidth,\n height: visualViewport ? visualViewport.height * visualViewport.scale : window.innerHeight\n };\n}\n"],"names":[],"version":3,"file":"useViewportSize.module.js.map"}
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@react-aria/utils",
3
- "version": "3.30.1",
3
+ "version": "3.32.0",
4
4
  "description": "Spectrum UI components in React",
5
5
  "license": "Apache-2.0",
6
6
  "main": "dist/main.js",
@@ -28,8 +28,8 @@
28
28
  "dependencies": {
29
29
  "@react-aria/ssr": "^3.9.10",
30
30
  "@react-stately/flags": "^3.1.2",
31
- "@react-stately/utils": "^3.10.8",
32
- "@react-types/shared": "^3.32.0",
31
+ "@react-stately/utils": "^3.11.0",
32
+ "@react-types/shared": "^3.32.1",
33
33
  "@swc/helpers": "^0.5.0",
34
34
  "clsx": "^2.0.0"
35
35
  },
@@ -40,5 +40,5 @@
40
40
  "publishConfig": {
41
41
  "access": "public"
42
42
  },
43
- "gitHead": "2c58ed3ddd9be9100af9b1d0cfd137fcdc95ba2d"
43
+ "gitHead": "4d838da5bfe36abb35aed166995a9ef63825370f"
44
44
  }
@@ -114,7 +114,7 @@ export function filterDOMProps(props: DOMProps & AriaLabelingProps & LinkDOMProp
114
114
  (labelable && labelablePropNames.has(prop)) ||
115
115
  (isLink && linkPropNames.has(prop)) ||
116
116
  (global && globalAttrs.has(prop)) ||
117
- (events && globalEvents.has(prop) || (prop.endsWith('Capture') && globalEvents.has(prop.slice(0, -7)))) ||
117
+ (events && (globalEvents.has(prop) || (prop.endsWith('Capture') && globalEvents.has(prop.slice(0, -7))))) ||
118
118
  propNames?.has(prop) ||
119
119
  propRe.test(prop)
120
120
  )
package/src/index.ts CHANGED
@@ -48,7 +48,7 @@ export {useLoadMore} from './useLoadMore';
48
48
  export {useLoadMoreSentinel, useLoadMoreSentinel as UNSTABLE_useLoadMoreSentinel} from './useLoadMoreSentinel';
49
49
  export {inertValue} from './inertValue';
50
50
  export {CLEAR_FOCUS_EVENT, FOCUS_EVENT} from './constants';
51
- export {isCtrlKeyPressed} from './keyboard';
51
+ export {isCtrlKeyPressed, willOpenKeyboard} from './keyboard';
52
52
  export {useEnterAnimation, useExitAnimation} from './animation';
53
53
  export {isFocusable, isTabbable} from './isFocusable';
54
54
 
@@ -63,7 +63,7 @@ function isAttributeVisible(element: Element, childElement?: Element) {
63
63
  */
64
64
  export function isElementVisible(element: Element, childElement?: Element): boolean {
65
65
  if (supportsCheckVisibility) {
66
- return element.checkVisibility() && !element.closest('[data-react-aria-prevent-focus]');
66
+ return element.checkVisibility({visibilityProperty: true}) && !element.closest('[data-react-aria-prevent-focus]');
67
67
  }
68
68
 
69
69
  return (
package/src/keyboard.tsx CHANGED
@@ -25,3 +25,24 @@ export function isCtrlKeyPressed(e: Event): boolean {
25
25
 
26
26
  return e.ctrlKey;
27
27
  }
28
+
29
+ // HTML input types that do not cause the software keyboard to appear.
30
+ const nonTextInputTypes = new Set([
31
+ 'checkbox',
32
+ 'radio',
33
+ 'range',
34
+ 'color',
35
+ 'file',
36
+ 'image',
37
+ 'button',
38
+ 'submit',
39
+ 'reset'
40
+ ]);
41
+
42
+ export function willOpenKeyboard(target: Element) {
43
+ return (
44
+ (target instanceof HTMLInputElement && !nonTextInputTypes.has(target.type)) ||
45
+ target instanceof HTMLTextAreaElement ||
46
+ (target instanceof HTMLElement && target.isContentEditable)
47
+ );
48
+ }
package/src/mergeProps.ts CHANGED
@@ -28,8 +28,7 @@ type UnionToIntersection<U> = (U extends any ? (k: U) => void : never) extends (
28
28
 
29
29
  /**
30
30
  * Merges multiple props objects together. Event handlers are chained,
31
- * classNames are combined, and ids are deduplicated - different ids
32
- * will trigger a side-effect and re-render components hooked up with `useId`.
31
+ * classNames are combined, and ids are deduplicated.
33
32
  * For all other props, the last prop object overrides all previous ones.
34
33
  * @param args - Multiple sets of props to merge together.
35
34
  */
package/src/openLink.tsx CHANGED
@@ -106,7 +106,7 @@ export function openLink(target: HTMLAnchorElement, modifiers: Modifiers, setOpe
106
106
  let event = isWebKit() && isMac() && !isIPad() && process.env.NODE_ENV !== 'test'
107
107
  // @ts-ignore - keyIdentifier is a non-standard property, but it's what webkit expects
108
108
  ? new KeyboardEvent('keydown', {keyIdentifier: 'Enter', metaKey, ctrlKey, altKey, shiftKey})
109
- : new MouseEvent('click', {metaKey, ctrlKey, altKey, shiftKey, bubbles: true, cancelable: true});
109
+ : new MouseEvent('click', {metaKey, ctrlKey, altKey, shiftKey, detail: 1, bubbles: true, cancelable: true});
110
110
  (openLink as any).isOpening = setOpening;
111
111
  focusWithoutScrolling(target);
112
112
  target.dispatchEvent(event);
@@ -117,6 +117,9 @@ export function scrollIntoViewport(targetElement: Element | null, opts?: ScrollI
117
117
  } else {
118
118
  let scrollParents = getScrollParents(targetElement);
119
119
  // If scrolling is prevented, we don't want to scroll the body since it might move the overlay partially offscreen and the user can't scroll it back into view.
120
+ if (!isScrollPrevented) {
121
+ scrollParents.push(root);
122
+ }
120
123
  for (let scrollParent of scrollParents) {
121
124
  scrollIntoView(scrollParent as HTMLElement, targetElement as HTMLElement);
122
125
  }
package/src/useEvent.ts CHANGED
@@ -33,5 +33,5 @@ export function useEvent<K extends keyof GlobalEventHandlersEventMap>(
33
33
  return () => {
34
34
  element.removeEventListener(event, handleEvent as EventListener, options);
35
35
  };
36
- }, [ref, event, options, isDisabled, handleEvent]);
36
+ }, [ref, event, options, isDisabled]);
37
37
  }
@@ -32,5 +32,5 @@ export function useFormReset<T>(
32
32
  return () => {
33
33
  form?.removeEventListener('reset', handleReset);
34
34
  };
35
- }, [ref, handleReset]);
35
+ }, [ref]);
36
36
  }
@@ -59,5 +59,5 @@ export function useLoadMoreSentinel(props: LoadMoreSentinelProps, ref: RefObject
59
59
  sentinelObserver.current.disconnect();
60
60
  }
61
61
  };
62
- }, [collection, triggerLoadMore, ref, scrollOffset]);
62
+ }, [collection, ref, scrollOffset]);
63
63
  }
@@ -1,6 +1,7 @@
1
1
 
2
2
  import {RefObject} from '@react-types/shared';
3
3
  import {useEffect} from 'react';
4
+ import {useEffectEvent} from './useEffectEvent';
4
5
 
5
6
  function hasResizeObserver() {
6
7
  return typeof window.ResizeObserver !== 'undefined';
@@ -13,7 +14,10 @@ type useResizeObserverOptionsType<T> = {
13
14
  }
14
15
 
15
16
  export function useResizeObserver<T extends Element>(options: useResizeObserverOptionsType<T>): void {
17
+ // Only call onResize from inside the effect, otherwise we'll void our assumption that
18
+ // useEffectEvents are safe to pass in.
16
19
  const {ref, box, onResize} = options;
20
+ let onResizeEvent = useEffectEvent(onResize);
17
21
 
18
22
  useEffect(() => {
19
23
  let element = ref?.current;
@@ -22,9 +26,9 @@ export function useResizeObserver<T extends Element>(options: useResizeObserverO
22
26
  }
23
27
 
24
28
  if (!hasResizeObserver()) {
25
- window.addEventListener('resize', onResize, false);
29
+ window.addEventListener('resize', onResizeEvent, false);
26
30
  return () => {
27
- window.removeEventListener('resize', onResize, false);
31
+ window.removeEventListener('resize', onResizeEvent, false);
28
32
  };
29
33
  } else {
30
34
 
@@ -33,7 +37,7 @@ export function useResizeObserver<T extends Element>(options: useResizeObserverO
33
37
  return;
34
38
  }
35
39
 
36
- onResize();
40
+ onResizeEvent();
37
41
  });
38
42
  resizeObserverInstance.observe(element, {box});
39
43
 
@@ -44,5 +48,5 @@ export function useResizeObserver<T extends Element>(options: useResizeObserverO
44
48
  };
45
49
  }
46
50
 
47
- }, [onResize, ref, box]);
51
+ }, [ref, box]);
48
52
  }
@@ -11,11 +11,13 @@
11
11
  */
12
12
 
13
13
  import {EffectCallback, useEffect, useRef} from 'react';
14
+ import {useEffectEvent} from './useEffectEvent';
14
15
 
15
16
  // Like useEffect, but only called for updates after the initial render.
16
- export function useUpdateEffect(effect: EffectCallback, dependencies: any[]): void {
17
+ export function useUpdateEffect(cb: EffectCallback, dependencies: any[]): void {
17
18
  const isInitialMount = useRef(true);
18
19
  const lastDeps = useRef<any[] | null>(null);
20
+ let cbEvent = useEffectEvent(cb);
19
21
 
20
22
  useEffect(() => {
21
23
  isInitialMount.current = true;
@@ -29,9 +31,9 @@ export function useUpdateEffect(effect: EffectCallback, dependencies: any[]): vo
29
31
  if (isInitialMount.current) {
30
32
  isInitialMount.current = false;
31
33
  } else if (!prevDeps || dependencies.some((dep, i) => !Object.is(dep, prevDeps[i]))) {
32
- effect();
34
+ cbEvent();
33
35
  }
34
36
  lastDeps.current = dependencies;
35
- // eslint-disable-next-line react-hooks/exhaustive-deps
37
+ // eslint-disable-next-line react-hooks/exhaustive-deps
36
38
  }, dependencies);
37
39
  }
@@ -10,8 +10,8 @@
10
10
  * governing permissions and limitations under the License.
11
11
  */
12
12
 
13
- import {Dispatch, MutableRefObject, useRef, useState} from 'react';
14
- import {useEffectEvent, useLayoutEffect} from './';
13
+ import {Dispatch, RefObject, useCallback, useRef, useState} from 'react';
14
+ import {useLayoutEffect} from './';
15
15
 
16
16
  type SetValueAction<S> = (prev: S) => Generator<any, void, unknown>;
17
17
 
@@ -21,11 +21,14 @@ type SetValueAction<S> = (prev: S) => Generator<any, void, unknown>;
21
21
  // written linearly.
22
22
  export function useValueEffect<S>(defaultValue: S | (() => S)): [S, Dispatch<SetValueAction<S>>] {
23
23
  let [value, setValue] = useState(defaultValue);
24
- let effect: MutableRefObject<Generator<S> | null> = useRef<Generator<S> | null>(null);
24
+ // Keep an up to date copy of value in a ref so we can access the current value in the generator.
25
+ // This allows us to maintain a stable queue function.
26
+ let currValue = useRef(value);
27
+ let effect: RefObject<Generator<S> | null> = useRef<Generator<S> | null>(null);
25
28
 
26
29
  // Store the function in a ref so we can always access the current version
27
30
  // which has the proper `value` in scope.
28
- let nextRef = useEffectEvent(() => {
31
+ let nextRef = useRef(() => {
29
32
  if (!effect.current) {
30
33
  return;
31
34
  }
@@ -41,24 +44,25 @@ export function useValueEffect<S>(defaultValue: S | (() => S)): [S, Dispatch<Set
41
44
  // If the value is the same as the current value,
42
45
  // then continue to the next yield. Otherwise,
43
46
  // set the value in state and wait for the next layout effect.
44
- if (value === newValue.value) {
45
- nextRef();
47
+ if (currValue.current === newValue.value) {
48
+ nextRef.current();
46
49
  } else {
47
50
  setValue(newValue.value);
48
51
  }
49
52
  });
50
53
 
51
54
  useLayoutEffect(() => {
55
+ currValue.current = value;
52
56
  // If there is an effect currently running, continue to the next yield.
53
57
  if (effect.current) {
54
- nextRef();
58
+ nextRef.current();
55
59
  }
56
60
  });
57
61
 
58
- let queue = useEffectEvent(fn => {
59
- effect.current = fn(value);
60
- nextRef();
61
- });
62
+ let queue = useCallback(fn => {
63
+ effect.current = fn(currValue.current);
64
+ nextRef.current();
65
+ }, [nextRef]);
62
66
 
63
67
  return [value, queue];
64
68
  }
@@ -12,6 +12,7 @@
12
12
 
13
13
  import {useEffect, useState} from 'react';
14
14
  import {useIsSSR} from '@react-aria/ssr';
15
+ import {willOpenKeyboard} from './keyboard';
15
16
 
16
17
  interface ViewportSize {
17
18
  width: number,
@@ -27,6 +28,11 @@ export function useViewportSize(): ViewportSize {
27
28
  useEffect(() => {
28
29
  // Use visualViewport api to track available height even on iOS virtual keyboard opening
29
30
  let onResize = () => {
31
+ // Ignore updates when zoomed.
32
+ if (visualViewport && visualViewport.scale > 1) {
33
+ return;
34
+ }
35
+
30
36
  setSize(size => {
31
37
  let newSize = getViewportSize();
32
38
  if (newSize.width === size.width && newSize.height === size.height) {
@@ -36,6 +42,32 @@ export function useViewportSize(): ViewportSize {
36
42
  });
37
43
  };
38
44
 
45
+ // When closing the keyboard, iOS does not fire the visual viewport resize event until the animation is complete.
46
+ // We can anticipate this and resize early by handling the blur event and using the layout size.
47
+ let frame: number;
48
+ let onBlur = (e: FocusEvent) => {
49
+ if (visualViewport && visualViewport.scale > 1) {
50
+ return;
51
+ }
52
+
53
+ if (willOpenKeyboard(e.target as Element)) {
54
+ // Wait one frame to see if a new element gets focused.
55
+ frame = requestAnimationFrame(() => {
56
+ if (!document.activeElement || !willOpenKeyboard(document.activeElement)) {
57
+ setSize(size => {
58
+ let newSize = {width: window.innerWidth, height: window.innerHeight};
59
+ if (newSize.width === size.width && newSize.height === size.height) {
60
+ return size;
61
+ }
62
+ return newSize;
63
+ });
64
+ }
65
+ });
66
+ }
67
+ };
68
+
69
+ window.addEventListener('blur', onBlur, true);
70
+
39
71
  if (!visualViewport) {
40
72
  window.addEventListener('resize', onResize);
41
73
  } else {
@@ -43,6 +75,8 @@ export function useViewportSize(): ViewportSize {
43
75
  }
44
76
 
45
77
  return () => {
78
+ cancelAnimationFrame(frame);
79
+ window.removeEventListener('blur', onBlur, true);
46
80
  if (!visualViewport) {
47
81
  window.removeEventListener('resize', onResize);
48
82
  } else {
@@ -56,7 +90,8 @@ export function useViewportSize(): ViewportSize {
56
90
 
57
91
  function getViewportSize(): ViewportSize {
58
92
  return {
59
- width: (visualViewport && visualViewport?.width) || window.innerWidth,
60
- height: (visualViewport && visualViewport?.height) || window.innerHeight
93
+ // Multiply by the visualViewport scale to get the "natural" size, unaffected by pinch zooming.
94
+ width: visualViewport ? visualViewport.width * visualViewport.scale : window.innerWidth,
95
+ height: visualViewport ? visualViewport.height * visualViewport.scale : window.innerHeight
61
96
  };
62
97
  }