@rdjperron/lint 0.2.0 → 0.3.0

package/dist/index.mjs

@@ -1125,8 +1125,9 @@ const noRuntimeTypeofRule = defineRule({
 //#endregion
 //#region src/anti-slop/rules/no-shape-in-symbol-names.ts
 const FORBIDDEN_SYMBOL_NAME = "shape";
+const IDENTIFIER_WORD = /[A-Z]+(?![a-z])|[A-Z]?[a-z]+|\d+/gu;
 function containsForbiddenSymbolName(name) {
-	return name.toLowerCase().includes(FORBIDDEN_SYMBOL_NAME);
+	return (name.match(IDENTIFIER_WORD) ?? []).some((word) => word.toLowerCase().startsWith(FORBIDDEN_SYMBOL_NAME));
 }
 /** Return whether an identifier names a statically accessed member owned by another value. */
 function isBorrowedMemberName(node) {
@@ -1134,11 +1135,11 @@ function isBorrowedMemberName(node) {
 	if (parent === null || parent.type !== "MemberExpression") return false;
 	return parent.property === node && parent.computed === false;
 }
-/** Ban the case-insensitive substring "shape" in every JavaScript and TypeScript symbol name. */
+/** Ban the word "shape" in every JavaScript and TypeScript symbol name. */
 const noForbiddenTermInSymbolNamesRule = defineRule({
 	meta: {
 		type: "problem",
-		docs: { description: "Disallow the case-insensitive substring \"shape\" in JavaScript, TypeScript, private, and JSX symbol names." },
+		docs: { description: "Disallow the word \"shape\" in JavaScript, TypeScript, private, and JSX symbol names." },
 		messages: { forbiddenSymbolName: "Rename symbol \"{{name}}\" for its domain role; \"shape\" describes structure rather than ownership." }
 	},
 	createOnce(context) {
@@ -1720,12 +1721,18 @@ const noHardcodedJsxTextRule = defineRule({
 //#endregion
 //#region src/rules/no-use-effect.ts
 const effectHooks = /* @__PURE__ */ new Set(["useEffect", "useLayoutEffect"]);
-/** The effect hook a call reaches, whether called bare (`useEffect(...)`) or through a member (`React.useEffect(...)`). */
+/** The name a member expression reads, written `.useEffect` or `["useEffect"]`; null when the key is not a literal name. */
+function memberPropertyName(node) {
+	const { property } = node;
+	if (!node.computed) return property.type === "Identifier" ? property.name : null;
+	return property.type === "Literal" && typeof property.value === "string" ? property.value : null;
+}
+/** The effect hook a call reaches, called bare (`useEffect(...)`) or through a member (`React.useEffect(...)`, `React["useEffect"](...)`). */
 function calledEffectHook(callee) {
 	if (callee.type === "Identifier") return effectHooks.has(callee.name) ? callee.name : null;
-	if (callee.type !== "MemberExpression" || callee.computed) return null;
-	const { property } = callee;
-	return property.type === "Identifier" && effectHooks.has(property.name) ? property.name : null;
+	if (callee.type !== "MemberExpression") return null;
+	const name = memberPropertyName(callee);
+	return name !== null && effectHooks.has(name) ? name : null;
 }
 function importedName(specifier) {
 	return specifier.imported.type === "Identifier" ? specifier.imported.name : specifier.imported.value;
@@ -1781,17 +1788,43 @@ const noUseEffectRule = defineRule({
 });
 //#endregion
 //#region src/rules/static-public-env.ts
+/** The name a member expression reads, the way Babel's `toComputedKey` does: `.NAME` and `["NAME"]` only. */
+function literalKeyName(node) {
+	const { property } = node;
+	if (!node.computed) return property.type === "Identifier" ? property.name : null;
+	return property.type === "Literal" && typeof property.value === "string" ? property.value : null;
+}
+/** Whether a member expression is `process.env` or `process["env"]`, the object the inliner matches. */
 function isProcessEnv(node) {
-	return node.type === "MemberExpression" && !node.computed && node.object.type === "Identifier" && node.object.name === "process" && node.property.type === "Identifier" && node.property.name === "env";
+	return node.object.type === "Identifier" && node.object.name === "process" && literalKeyName(node) === "env";
+}
+/** Whether a pattern takes `process.env` apart, in a declaration or in an assignment. */
+function isDestructured(node) {
+	const { parent } = node;
+	let target = null;
+	if (parent.type === "VariableDeclarator" && parent.init === node) target = parent.id;
+	if (parent.type === "AssignmentExpression" && parent.right === node) target = parent.left;
+	return target !== null && (target.type === "ObjectPattern" || target.type === "ArrayPattern");
+}
+/** What is wrong with a `process.env.KEY` read, or null when Expo replaces that exact shape. */
+function readProblem(env, read) {
+	const { parent } = read;
+	if (parent.type === "AssignmentExpression" && parent.left === read) return "assigned";
+	if (env.optional || read.optional) return "optionalChain";
+	if (literalKeyName(read) !== null) return null;
+	return read.property.type === "Literal" || read.property.type === "TemplateLiteral" ? "literalKey" : "computed";
 }
 /** Reject every use of `process.env` that Expo's textual inlining cannot see. */
 const staticPublicEnvRule = defineRule({
 	meta: {
 		type: "problem",
-		docs: { description: "Allow only static `process.env.NAME` reads; Expo replaces each one textually at bundle time and everything else is undefined on the device." },
+		docs: { description: "Allow only the `process.env` reads Expo replaces at bundle time; everything else is undefined on the device." },
 		messages: {
 			destructured: "Expo replaces each `process.env.EXPO_PUBLIC_*` read textually at bundle time, so there is no `process.env` object to destructure on the device. Read each variable as `process.env.NAME`.",
-			computed: "Expo replaces each `process.env.EXPO_PUBLIC_*` read textually at bundle time, so a computed key is undefined on the device. Read the variable as `process.env.NAME` with the name spelled out.",
+			computed: "Expo replaces each `process.env.EXPO_PUBLIC_*` read textually at bundle time, so a key it has to evaluate is undefined on the device. Read the variable as `process.env.NAME` with the name spelled out.",
+			literalKey: "Expo reads a computed key only when it is a string literal, so a template or a number leaves the read in the bundle and it is undefined on the device. Read the variable as `process.env.NAME`.",
+			optionalChain: "Expo's inliner never sees an optional chain, so `process.env?.NAME` survives into the bundle and is undefined on the device. Read the variable as `process.env.NAME`.",
+			assigned: "Expo replaces reads, not writes: an assignment to `process.env` stays in the bundle and no inlined read will ever see it. Set the variable in the environment the bundler reads.",
 			bareValue: "Expo replaces each `process.env.EXPO_PUBLIC_*` read textually at bundle time, so `process.env` passed around as a value is empty on the device. Read each variable as `process.env.NAME`."
 		}
 	},
@@ -1800,13 +1833,14 @@ const staticPublicEnvRule = defineRule({
 			if (!isProcessEnv(node)) return;
 			const { parent } = node;
 			if (parent.type === "MemberExpression" && parent.object === node) {
-				if (parent.computed) context.report({
+				const problem = readProblem(node, parent);
+				if (problem !== null) context.report({
 					node: parent,
-					messageId: "computed"
+					messageId: problem
 				});
 				return;
 			}
-			if (parent.type === "VariableDeclarator" && parent.id.type === "ObjectPattern") {
+			if (isDestructured(node)) {
 				context.report({
 					node: parent,
 					messageId: "destructured"
@@ -1822,8 +1856,8 @@ const staticPublicEnvRule = defineRule({
 });
 //#endregion
 //#region src/index.ts
-const rdjPlugin = eslintCompatPlugin({
-	meta: { name: "rdj" },
+const rdjperronPlugin = eslintCompatPlugin({
+	meta: { name: "rdjperron" },
 	rules: {
 		"no-array-filter-map": noArrayFilterMapRule,
 		"no-chained-type-assertions": noChainedTypeAssertionsRule,
@@ -1848,6 +1882,6 @@ const rdjPlugin = eslintCompatPlugin({
 	}
 });
 //#endregion
-export { rdjPlugin as default };
+export { rdjperronPlugin as default };
 
 //# sourceMappingURL=index.mjs.map