@rcrsr/rill-cli 0.6.0

package/dist/check/rules/anti-patterns.js

@@ -0,0 +1,481 @@
+/**
+ * Anti-Pattern Rules
+ * Enforces best practices from docs/guide-conventions.md:411-462.
+ */
+import { extractContextLine } from './helpers.js';
+// ============================================================
+// AVOID_REASSIGNMENT RULE
+// ============================================================
+/**
+ * Warns on variable reassignment patterns.
+ * Variables lock to their first type, and reassignment suggests confusing
+ * flow control. Prefer functional style or new variables.
+ *
+ * Detection:
+ * - Capture node (=> $var) where $var already exists in validation context
+ * - Tracks variables seen during validation pass
+ *
+ * Valid alternatives:
+ * - Use new variable: $result1, $result2
+ * - Functional chains: value -> op1 -> op2
+ *
+ * References:
+ * - docs/guide-conventions.md:413-424
+ */
+export const AVOID_REASSIGNMENT = {
+    code: 'AVOID_REASSIGNMENT',
+    category: 'anti-patterns',
+    severity: 'warning',
+    nodeTypes: ['Capture'],
+    validate(node, context) {
+        const captureNode = node;
+        const varName = captureNode.name;
+        // Check if this variable was already captured before
+        if (context.variables.has(varName)) {
+            const firstLocation = context.variables.get(varName);
+            const variableScope = context.variableScopes.get(varName) ?? null;
+            // Get the current closure scope (if we're inside a closure)
+            const currentClosureScope = context.scopeStack.length > 0
+                ? context.scopeStack[context.scopeStack.length - 1]
+                : null;
+            // Only warn if the variable is truly in the same scope or a parent scope
+            // Variables in sibling closures are independent and should not trigger warnings
+            const isInSameOrParentScope = isVariableInParentScope(variableScope, currentClosureScope, context.scopeStack);
+            if (isInSameOrParentScope) {
+                return [
+                    {
+                        location: captureNode.span.start,
+                        severity: 'warning',
+                        code: 'AVOID_REASSIGNMENT',
+                        message: `Variable reassignment detected: '$${varName}' first defined at line ${firstLocation.line}. Prefer new variable or functional style.`,
+                        context: extractContextLine(captureNode.span.start.line, context.source),
+                        fix: null, // Cannot auto-fix without understanding intent
+                    },
+                ];
+            }
+        }
+        return [];
+    },
+};
+// ============================================================
+// COMPLEX_CONDITION RULE
+// ============================================================
+/**
+ * Warns on complex nested boolean conditions.
+ * Complex conditions with multiple nested operators are hard to read.
+ * Extract to named variables for clarity.
+ *
+ * Detection:
+ * - Conditional nodes with conditions containing 3+ boolean operators (&&, ||)
+ * - Nesting depth > 2 for boolean expressions
+ *
+ * Valid alternatives:
+ * - Extract sub-conditions to named variables
+ * - Split complex checks into multiple smaller checks
+ *
+ * References:
+ * - docs/guide-conventions.md:451-461
+ */
+export const COMPLEX_CONDITION = {
+    code: 'COMPLEX_CONDITION',
+    category: 'anti-patterns',
+    severity: 'info',
+    nodeTypes: ['Conditional'],
+    validate(node, context) {
+        const conditionalNode = node;
+        const condition = conditionalNode.condition;
+        if (!condition) {
+            return [];
+        }
+        // Unwrap GroupedExpr to get to the actual condition
+        let unwrappedCondition = condition;
+        if (unwrappedCondition.type === 'GroupedExpr') {
+            unwrappedCondition = unwrappedCondition.expression;
+        }
+        // Count boolean operators, boolean nesting depth, and parenthetical nesting
+        const operatorCount = countBooleanOperators(unwrappedCondition);
+        const booleanDepth = getBooleanNestingDepth(unwrappedCondition);
+        const parenDepth = getParenNestingDepth(unwrappedCondition);
+        // Flag if 3+ operators, boolean nesting > 2, or excessive parentheses (> 2)
+        if (operatorCount >= 3 || booleanDepth > 2 || parenDepth > 2) {
+            return [
+                {
+                    location: conditionalNode.span.start,
+                    severity: 'info',
+                    code: 'COMPLEX_CONDITION',
+                    message: 'Complex condition with multiple operators. Extract to named checks for clarity.',
+                    context: extractContextLine(conditionalNode.span.start.line, context.source),
+                    fix: null, // Auto-fix would require semantic understanding
+                },
+            ];
+        }
+        return [];
+    },
+};
+/**
+ * Count boolean operators (&&, ||) in an expression tree.
+ */
+function countBooleanOperators(node) {
+    let count = 0;
+    if (node.type === 'BinaryExpr') {
+        const binaryNode = node;
+        if (binaryNode.op === '&&' || binaryNode.op === '||') {
+            count = 1;
+        }
+        count += countBooleanOperators(binaryNode.left);
+        count += countBooleanOperators(binaryNode.right);
+    }
+    // Traverse other node types that might contain expressions
+    switch (node.type) {
+        case 'UnaryExpr': {
+            const unaryNode = node;
+            count += countBooleanOperators(unaryNode.operand);
+            break;
+        }
+        case 'GroupedExpr': {
+            const groupedNode = node;
+            count += countBooleanOperators(groupedNode.expression);
+            break;
+        }
+        case 'PipeChain': {
+            const pipeNode = node;
+            if (pipeNode.head)
+                count += countBooleanOperators(pipeNode.head);
+            if (pipeNode.pipes) {
+                for (const pipe of pipeNode.pipes) {
+                    count += countBooleanOperators(pipe);
+                }
+            }
+            break;
+        }
+        case 'PostfixExpr': {
+            const postfixNode = node;
+            if (postfixNode.primary)
+                count += countBooleanOperators(postfixNode.primary);
+            break;
+        }
+    }
+    return count;
+}
+/**
+ * Calculate maximum nesting depth of boolean operators.
+ */
+function getBooleanNestingDepth(node, currentDepth = 0) {
+    let maxDepth = currentDepth;
+    if (node.type === 'BinaryExpr') {
+        const binaryNode = node;
+        const depth = binaryNode.op === '&&' || binaryNode.op === '||'
+            ? currentDepth + 1
+            : currentDepth;
+        const leftDepth = getBooleanNestingDepth(binaryNode.left, depth);
+        const rightDepth = getBooleanNestingDepth(binaryNode.right, depth);
+        maxDepth = Math.max(maxDepth, leftDepth, rightDepth);
+    }
+    // Traverse other node types
+    switch (node.type) {
+        case 'UnaryExpr': {
+            const unaryNode = node;
+            maxDepth = Math.max(maxDepth, getBooleanNestingDepth(unaryNode.operand, currentDepth));
+            break;
+        }
+        case 'GroupedExpr': {
+            const groupedNode = node;
+            maxDepth = Math.max(maxDepth, getBooleanNestingDepth(groupedNode.expression, currentDepth));
+            break;
+        }
+        case 'PipeChain': {
+            const pipeNode = node;
+            if (pipeNode.head) {
+                maxDepth = Math.max(maxDepth, getBooleanNestingDepth(pipeNode.head, currentDepth));
+            }
+            if (pipeNode.pipes) {
+                for (const pipe of pipeNode.pipes) {
+                    maxDepth = Math.max(maxDepth, getBooleanNestingDepth(pipe, currentDepth));
+                }
+            }
+            break;
+        }
+        case 'PostfixExpr': {
+            const postfixNode = node;
+            if (postfixNode.primary) {
+                maxDepth = Math.max(maxDepth, getBooleanNestingDepth(postfixNode.primary, currentDepth));
+            }
+            break;
+        }
+    }
+    return maxDepth;
+}
+// ============================================================
+// LOOP_OUTER_CAPTURE RULE
+// ============================================================
+/**
+ * Detects attempts to modify outer-scope variables from inside loops.
+ * This is a common LLM-generated anti-pattern that never works in Rill.
+ *
+ * Rill's scoping rules mean that captures inside loop bodies create LOCAL
+ * variables that don't affect outer scope. This is a fundamental language
+ * constraint, not a style preference.
+ *
+ * WRONG - this pattern NEVER works:
+ *   0 => $count
+ *   [1, 2, 3] -> each { $count + 1 => $count }  # creates LOCAL $count
+ *   $count                                       # still 0!
+ *
+ * RIGHT - use accumulators:
+ *   [1, 2, 3] -> fold(0) { $@ + 1 }             # returns 3
+ *   [1, 2, 3] -> each(0) { $@ + 1 }             # returns [1, 2, 3]
+ *
+ * This rule catches captures inside loop/collection bodies where the
+ * variable name matches an outer-scope variable.
+ *
+ * References:
+ * - docs/ref-llm.txt (LOOP STATE PATTERNS)
+ * - docs/topic-variables.md (Scope Rules)
+ */
+export const LOOP_OUTER_CAPTURE = {
+    code: 'LOOP_OUTER_CAPTURE',
+    category: 'anti-patterns',
+    severity: 'warning',
+    nodeTypes: [
+        'EachExpr',
+        'MapExpr',
+        'FilterExpr',
+        'FoldExpr',
+        'WhileLoop',
+        'DoWhileLoop',
+    ],
+    validate(node, context) {
+        const diagnostics = [];
+        // Get the loop body based on node type
+        let body = null;
+        switch (node.type) {
+            case 'EachExpr':
+                body = node.body;
+                break;
+            case 'MapExpr':
+                body = node.body;
+                break;
+            case 'FilterExpr':
+                body = node.body;
+                break;
+            case 'FoldExpr':
+                body = node.body;
+                break;
+            case 'WhileLoop':
+                body = node.body;
+                break;
+            case 'DoWhileLoop':
+                body = node.body;
+                break;
+        }
+        if (!body)
+            return diagnostics;
+        // Find all captures in the body
+        const captures = findCapturesInBody(body);
+        // Get the current closure scope (if we're inside a closure)
+        const currentClosureScope = context.scopeStack.length > 0
+            ? context.scopeStack[context.scopeStack.length - 1]
+            : null;
+        // Check if any capture targets an outer-scope variable
+        for (const capture of captures) {
+            if (context.variables.has(capture.name)) {
+                const outerLocation = context.variables.get(capture.name);
+                const variableScope = context.variableScopes.get(capture.name) ?? null;
+                // Only flag if the variable is in a parent scope, not a sibling closure
+                // Variable is "outer" if:
+                // 1. It was defined in script scope (variableScope === null), OR
+                // 2. It was defined in a parent closure that contains the current closure
+                const isOuterScope = isVariableInParentScope(variableScope, currentClosureScope, context.scopeStack);
+                if (isOuterScope) {
+                    diagnostics.push({
+                        location: capture.span.start,
+                        severity: 'warning',
+                        code: 'LOOP_OUTER_CAPTURE',
+                        message: `Cannot modify outer variable '$${capture.name}' from inside loop. ` +
+                            `Captures inside loops create LOCAL variables. ` +
+                            `Use fold(init) with $@ accumulator, or pack state into $ as a dict. ` +
+                            `(Outer '$${capture.name}' defined at line ${outerLocation.line})`,
+                        context: extractContextLine(capture.span.start.line, context.source),
+                        fix: null,
+                    });
+                }
+            }
+        }
+        return diagnostics;
+    },
+};
+/**
+ * Check if a variable's scope is in the parent scope chain.
+ * Returns true if the variable is accessible from the current scope.
+ *
+ * A variable is "outer" (parent scope) if:
+ * - It was defined at script level (variableScope === null), OR
+ * - It was defined in the SAME closure as the loop (same scope), OR
+ * - It was defined in a closure that is an ancestor of the current closure
+ *
+ * A variable is NOT outer (sibling scope) if:
+ * - It was defined in a different closure that is not an ancestor
+ */
+function isVariableInParentScope(variableScope, currentClosureScope, scopeStack) {
+    // Variable defined at script level is always outer
+    if (variableScope === null) {
+        return true;
+    }
+    // If we're not in a closure, variable can't be outer to us
+    if (currentClosureScope === null) {
+        return variableScope === null;
+    }
+    // Variable is outer if its scope is the same as current closure
+    // (loop body creates new scope within the closure)
+    if (variableScope === currentClosureScope) {
+        return true;
+    }
+    // Variable is outer if its scope is in our parent chain
+    // Check if variableScope appears in scopeStack before currentClosureScope
+    const currentIndex = scopeStack.indexOf(currentClosureScope);
+    const variableIndex = scopeStack.indexOf(variableScope);
+    // If variable scope is not in stack, it's not accessible
+    if (variableIndex === -1) {
+        return false;
+    }
+    // Variable is outer if it appears before current scope in stack (ancestor)
+    return variableIndex < currentIndex;
+}
+/**
+ * Recursively find all Capture nodes in a loop body.
+ */
+function findCapturesInBody(node) {
+    const captures = [];
+    function traverse(n) {
+        if (n.type === 'Capture') {
+            captures.push(n);
+            return;
+        }
+        // Traverse children based on node type
+        switch (n.type) {
+            case 'Block':
+                for (const stmt of n.statements)
+                    traverse(stmt);
+                break;
+            case 'Statement':
+                traverse(n.expression);
+                break;
+            case 'AnnotatedStatement':
+                traverse(n.statement);
+                break;
+            case 'PipeChain':
+                traverse(n.head);
+                for (const pipe of n.pipes)
+                    traverse(pipe);
+                if (n.terminator)
+                    traverse(n.terminator);
+                break;
+            case 'PostfixExpr':
+                traverse(n.primary);
+                for (const method of n.methods)
+                    traverse(method);
+                break;
+            case 'BinaryExpr':
+                traverse(n.left);
+                traverse(n.right);
+                break;
+            case 'UnaryExpr':
+                traverse(n.operand);
+                break;
+            case 'GroupedExpr':
+                traverse(n.expression);
+                break;
+            case 'Conditional':
+                if (n.input)
+                    traverse(n.input);
+                if (n.condition)
+                    traverse(n.condition);
+                traverse(n.thenBranch);
+                if (n.elseBranch)
+                    traverse(n.elseBranch);
+                break;
+            case 'Closure':
+                // Don't traverse into closures - they have their own scope
+                break;
+            // Nested loops - traverse their bodies too
+            case 'WhileLoop':
+                traverse(n.body);
+                break;
+            case 'DoWhileLoop':
+                traverse(n.body);
+                break;
+            case 'EachExpr':
+            case 'MapExpr':
+            case 'FilterExpr':
+            case 'FoldExpr':
+                traverse(n.body);
+                break;
+        }
+    }
+    traverse(node);
+    return captures;
+}
+/**
+ * Calculate maximum consecutive GroupedExpr (parenthetical) nesting depth.
+ * Counts chains of nested parentheses like ((($x))).
+ * Treats PipeChain (single head) and PostfixExpr (primary only) as transparent wrappers.
+ */
+function getParenNestingDepth(node) {
+    let maxDepth = 0;
+    function traverse(n, consecutiveDepth) {
+        if (n.type === 'GroupedExpr') {
+            const groupedNode = n;
+            const newDepth = consecutiveDepth + 1;
+            maxDepth = Math.max(maxDepth, newDepth);
+            traverse(groupedNode.expression, newDepth);
+        }
+        else if (n.type === 'PipeChain') {
+            // Treat simple PipeChain (head only) as transparent for nesting
+            const pipeNode = n;
+            if (pipeNode.head && (!pipeNode.pipes || pipeNode.pipes.length === 0)) {
+                // Transparent: pass through consecutive depth
+                traverse(pipeNode.head, consecutiveDepth);
+            }
+            else {
+                // Complex pipe chain: reset depth but continue traversing
+                if (pipeNode.head)
+                    traverse(pipeNode.head, 0);
+                if (pipeNode.pipes) {
+                    for (const pipe of pipeNode.pipes) {
+                        traverse(pipe, 0);
+                    }
+                }
+            }
+        }
+        else if (n.type === 'PostfixExpr') {
+            // Treat simple PostfixExpr (primary only) as transparent for nesting
+            const postfixNode = n;
+            if (postfixNode.primary &&
+                (!postfixNode.methods || postfixNode.methods.length === 0)) {
+                // Transparent: pass through consecutive depth
+                traverse(postfixNode.primary, consecutiveDepth);
+            }
+            else {
+                // Complex postfix: reset depth
+                if (postfixNode.primary)
+                    traverse(postfixNode.primary, 0);
+            }
+        }
+        else {
+            // Reset consecutive depth when we hit a structural node
+            // but continue traversing children
+            if (n.type === 'BinaryExpr') {
+                const binaryNode = n;
+                traverse(binaryNode.left, 0);
+                traverse(binaryNode.right, 0);
+            }
+            else if (n.type === 'UnaryExpr') {
+                const unaryNode = n;
+                traverse(unaryNode.operand, 0);
+            }
+        }
+    }
+    traverse(node, 0);
+    return maxDepth;
+}
+//# sourceMappingURL=anti-patterns.js.map

package/dist/check/rules/anti-patterns.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"anti-patterns.js","sourceRoot":"","sources":["../../../src/check/rules/anti-patterns.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAuBH,OAAO,EAAE,kBAAkB,EAAE,MAAM,cAAc,CAAC;AAElD,+DAA+D;AAC/D,0BAA0B;AAC1B,+DAA+D;AAE/D;;;;;;;;;;;;;;;GAeG;AACH,MAAM,CAAC,MAAM,kBAAkB,GAAmB;IAChD,IAAI,EAAE,oBAAoB;IAC1B,QAAQ,EAAE,eAAe;IACzB,QAAQ,EAAE,SAAS;IACnB,SAAS,EAAE,CAAC,SAAS,CAAC;IAEtB,QAAQ,CAAC,IAAa,EAAE,OAA0B;QAChD,MAAM,WAAW,GAAG,IAAmB,CAAC;QACxC,MAAM,OAAO,GAAG,WAAW,CAAC,IAAI,CAAC;QAEjC,qDAAqD;QACrD,IAAI,OAAO,CAAC,SAAS,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC;YACnC,MAAM,aAAa,GAAG,OAAO,CAAC,SAAS,CAAC,GAAG,CAAC,OAAO,CAAE,CAAC;YACtD,MAAM,aAAa,GAAG,OAAO,CAAC,cAAc,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,IAAI,CAAC;YAElE,4DAA4D;YAC5D,MAAM,mBAAmB,GACvB,OAAO,CAAC,UAAU,CAAC,MAAM,GAAG,CAAC;gBAC3B,CAAC,CAAC,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,UAAU,CAAC,MAAM,GAAG,CAAC,CAAE;gBACpD,CAAC,CAAC,IAAI,CAAC;YAEX,yEAAyE;YACzE,gFAAgF;YAChF,MAAM,qBAAqB,GAAG,uBAAuB,CACnD,aAAa,EACb,mBAAmB,EACnB,OAAO,CAAC,UAAU,CACnB,CAAC;YAEF,IAAI,qBAAqB,EAAE,CAAC;gBAC1B,OAAO;oBACL;wBACE,QAAQ,EAAE,WAAW,CAAC,IAAI,CAAC,KAAK;wBAChC,QAAQ,EAAE,SAAS;wBACnB,IAAI,EAAE,oBAAoB;wBAC1B,OAAO,EAAE,qCAAqC,OAAO,2BAA2B,aAAa,CAAC,IAAI,4CAA4C;wBAC9I,OAAO,EAAE,kBAAkB,CACzB,WAAW,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,EAC3B,OAAO,CAAC,MAAM,CACf;wBACD,GAAG,EAAE,IAAI,EAAE,+CAA+C;qBAC3D;iBACF,CAAC;YACJ,CAAC;QACH,CAAC;QAED,OAAO,EAAE,CAAC;IACZ,CAAC;CACF,CAAC;AAEF,+DAA+D;AAC/D,yBAAyB;AACzB,+DAA+D;AAE/D;;;;;;;;;;;;;;;GAeG;AACH,MAAM,CAAC,MAAM,iBAAiB,GAAmB;IAC/C,IAAI,EAAE,mBAAmB;IACzB,QAAQ,EAAE,eAAe;IACzB,QAAQ,EAAE,MAAM;IAChB,SAAS,EAAE,CAAC,aAAa,CAAC;IAE1B,QAAQ,CAAC,IAAa,EAAE,OAA0B;QAChD,MAAM,eAAe,GAAG,IAAuB,CAAC;QAChD,MAAM,SAAS,GAAG,eAAe,CAAC,SAAS,CAAC;QAE5C,IAAI,CAAC,SAAS,EAAE,CAAC;YACf,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,oDAAoD;QACpD,IAAI,kBAAkB,GAAY,SAAS,CAAC;QAC5C,IAAI,kBAAkB,CAAC,IAAI,KAAK,aAAa,EAAE,CAAC;YAC9C,kBAAkB,GAAI,kBAAsC,CAAC,UAAU,CAAC;QAC1E,CAAC;QAED,4EAA4E;QAC5E,MAAM,aAAa,GAAG,qBAAqB,CAAC,kBAAkB,CAAC,CAAC;QAChE,MAAM,YAAY,GAAG,sBAAsB,CAAC,kBAAkB,CAAC,CAAC;QAChE,MAAM,UAAU,GAAG,oBAAoB,CAAC,kBAAkB,CAAC,CAAC;QAE5D,4EAA4E;QAC5E,IAAI,aAAa,IAAI,CAAC,IAAI,YAAY,GAAG,CAAC,IAAI,UAAU,GAAG,CAAC,EAAE,CAAC;YAC7D,OAAO;gBACL;oBACE,QAAQ,EAAE,eAAe,CAAC,IAAI,CAAC,KAAK;oBACpC,QAAQ,EAAE,MAAM;oBAChB,IAAI,EAAE,mBAAmB;oBACzB,OAAO,EACL,iFAAiF;oBACnF,OAAO,EAAE,kBAAkB,CACzB,eAAe,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,EAC/B,OAAO,CAAC,MAAM,CACf;oBACD,GAAG,EAAE,IAAI,EAAE,gDAAgD;iBAC5D;aACF,CAAC;QACJ,CAAC;QAED,OAAO,EAAE,CAAC;IACZ,CAAC;CACF,CAAC;AAEF;;GAEG;AACH,SAAS,qBAAqB,CAAC,IAAa;IAC1C,IAAI,KAAK,GAAG,CAAC,CAAC;IAEd,IAAI,IAAI,CAAC,IAAI,KAAK,YAAY,EAAE,CAAC;QAC/B,MAAM,UAAU,GAAG,IAAsB,CAAC;QAC1C,IAAI,UAAU,CAAC,EAAE,KAAK,IAAI,IAAI,UAAU,CAAC,EAAE,KAAK,IAAI,EAAE,CAAC;YACrD,KAAK,GAAG,CAAC,CAAC;QACZ,CAAC;QAED,KAAK,IAAI,qBAAqB,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC;QAChD,KAAK,IAAI,qBAAqB,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC;IACnD,CAAC;IAED,2DAA2D;IAC3D,QAAQ,IAAI,CAAC,IAAI,EAAE,CAAC;QAClB,KAAK,WAAW,CAAC,CAAC,CAAC;YACjB,MAAM,SAAS,GAAG,IAAqB,CAAC;YACxC,KAAK,IAAI,qBAAqB,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC;YAClD,MAAM;QACR,CAAC;QAED,KAAK,aAAa,CAAC,CAAC,CAAC;YACnB,MAAM,WAAW,GAAG,IAAuB,CAAC;YAC5C,KAAK,IAAI,qBAAqB,CAAC,WAAW,CAAC,UAAU,CAAC,CAAC;YACvD,MAAM;QACR,CAAC;QAED,KAAK,WAAW,CAAC,CAAC,CAAC;YACjB,MAAM,QAAQ,GAAG,IAAqB,CAAC;YACvC,IAAI,QAAQ,CAAC,IAAI;gBAAE,KAAK,IAAI,qBAAqB,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;YACjE,IAAI,QAAQ,CAAC,KAAK,EAAE,CAAC;gBACnB,KAAK,MAAM,IAAI,IAAI,QAAQ,CAAC,KAAK,EAAE,CAAC;oBAClC,KAAK,IAAI,qBAAqB,CAAC,IAAI,CAAC,CAAC;gBACvC,CAAC;YACH,CAAC;YACD,MAAM;QACR,CAAC;QAED,KAAK,aAAa,CAAC,CAAC,CAAC;YACnB,MAAM,WAAW,GAAG,IAAuB,CAAC;YAC5C,IAAI,WAAW,CAAC,OAAO;gBACrB,KAAK,IAAI,qBAAqB,CAAC,WAAW,CAAC,OAAO,CAAC,CAAC;YACtD,MAAM;QACR,CAAC;IACH,CAAC;IAED,OAAO,KAAK,CAAC;AACf,CAAC;AAED;;GAEG;AACH,SAAS,sBAAsB,CAAC,IAAa,EAAE,YAAY,GAAG,CAAC;IAC7D,IAAI,QAAQ,GAAG,YAAY,CAAC;IAE5B,IAAI,IAAI,CAAC,IAAI,KAAK,YAAY,EAAE,CAAC;QAC/B,MAAM,UAAU,GAAG,IAAsB,CAAC;QAC1C,MAAM,KAAK,GACT,UAAU,CAAC,EAAE,KAAK,IAAI,IAAI,UAAU,CAAC,EAAE,KAAK,IAAI;YAC9C,CAAC,CAAC,YAAY,GAAG,CAAC;YAClB,CAAC,CAAC,YAAY,CAAC;QAEnB,MAAM,SAAS,GAAG,sBAAsB,CAAC,UAAU,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;QACjE,MAAM,UAAU,GAAG,sBAAsB,CAAC,UAAU,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC;QAEnE,QAAQ,GAAG,IAAI,CAAC,GAAG,CAAC,QAAQ,EAAE,SAAS,EAAE,UAAU,CAAC,CAAC;IACvD,CAAC;IAED,4BAA4B;IAC5B,QAAQ,IAAI,CAAC,IAAI,EAAE,CAAC;QAClB,KAAK,WAAW,CAAC,CAAC,CAAC;YACjB,MAAM,SAAS,GAAG,IAAqB,CAAC;YACxC,QAAQ,GAAG,IAAI,CAAC,GAAG,CACjB,QAAQ,EACR,sBAAsB,CAAC,SAAS,CAAC,OAAO,EAAE,YAAY,CAAC,CACxD,CAAC;YACF,MAAM;QACR,CAAC;QAED,KAAK,aAAa,CAAC,CAAC,CAAC;YACnB,MAAM,WAAW,GAAG,IAAuB,CAAC;YAC5C,QAAQ,GAAG,IAAI,CAAC,GAAG,CACjB,QAAQ,EACR,sBAAsB,CAAC,WAAW,CAAC,UAAU,EAAE,YAAY,CAAC,CAC7D,CAAC;YACF,MAAM;QACR,CAAC;QAED,KAAK,WAAW,CAAC,CAAC,CAAC;YACjB,MAAM,QAAQ,GAAG,IAAqB,CAAC;YACvC,IAAI,QAAQ,CAAC,IAAI,EAAE,CAAC;gBAClB,QAAQ,GAAG,IAAI,CAAC,GAAG,CACjB,QAAQ,EACR,sBAAsB,CAAC,QAAQ,CAAC,IAAI,EAAE,YAAY,CAAC,CACpD,CAAC;YACJ,CAAC;YACD,IAAI,QAAQ,CAAC,KAAK,EAAE,CAAC;gBACnB,KAAK,MAAM,IAAI,IAAI,QAAQ,CAAC,KAAK,EAAE,CAAC;oBAClC,QAAQ,GAAG,IAAI,CAAC,GAAG,CACjB,QAAQ,EACR,sBAAsB,CAAC,IAAI,EAAE,YAAY,CAAC,CAC3C,CAAC;gBACJ,CAAC;YACH,CAAC;YACD,MAAM;QACR,CAAC;QAED,KAAK,aAAa,CAAC,CAAC,CAAC;YACnB,MAAM,WAAW,GAAG,IAAuB,CAAC;YAC5C,IAAI,WAAW,CAAC,OAAO,EAAE,CAAC;gBACxB,QAAQ,GAAG,IAAI,CAAC,GAAG,CACjB,QAAQ,EACR,sBAAsB,CAAC,WAAW,CAAC,OAAO,EAAE,YAAY,CAAC,CAC1D,CAAC;YACJ,CAAC;YACD,MAAM;QACR,CAAC;IACH,CAAC;IAED,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,+DAA+D;AAC/D,0BAA0B;AAC1B,+DAA+D;AAE/D;;;;;;;;;;;;;;;;;;;;;;;GAuBG;AACH,MAAM,CAAC,MAAM,kBAAkB,GAAmB;IAChD,IAAI,EAAE,oBAAoB;IAC1B,QAAQ,EAAE,eAAe;IACzB,QAAQ,EAAE,SAAS;IACnB,SAAS,EAAE;QACT,UAAU;QACV,SAAS;QACT,YAAY;QACZ,UAAU;QACV,WAAW;QACX,aAAa;KACd;IAED,QAAQ,CAAC,IAAa,EAAE,OAA0B;QAChD,MAAM,WAAW,GAAiB,EAAE,CAAC;QAErC,uCAAuC;QACvC,IAAI,IAAI,GAAmB,IAAI,CAAC;QAChC,QAAQ,IAAI,CAAC,IAAI,EAAE,CAAC;YAClB,KAAK,UAAU;gBACb,IAAI,GAAI,IAAqB,CAAC,IAAI,CAAC;gBACnC,MAAM;YACR,KAAK,SAAS;gBACZ,IAAI,GAAI,IAAoB,CAAC,IAAI,CAAC;gBAClC,MAAM;YACR,KAAK,YAAY;gBACf,IAAI,GAAI,IAAuB,CAAC,IAAI,CAAC;gBACrC,MAAM;YACR,KAAK,UAAU;gBACb,IAAI,GAAI,IAAqB,CAAC,IAAI,CAAC;gBACnC,MAAM;YACR,KAAK,WAAW;gBACd,IAAI,GAAI,IAAsB,CAAC,IAAI,CAAC;gBACpC,MAAM;YACR,KAAK,aAAa;gBAChB,IAAI,GAAI,IAAwB,CAAC,IAAI,CAAC;gBACtC,MAAM;QACV,CAAC;QAED,IAAI,CAAC,IAAI;YAAE,OAAO,WAAW,CAAC;QAE9B,gCAAgC;QAChC,MAAM,QAAQ,GAAG,kBAAkB,CAAC,IAAI,CAAC,CAAC;QAE1C,4DAA4D;QAC5D,MAAM,mBAAmB,GACvB,OAAO,CAAC,UAAU,CAAC,MAAM,GAAG,CAAC;YAC3B,CAAC,CAAC,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,UAAU,CAAC,MAAM,GAAG,CAAC,CAAE;YACpD,CAAC,CAAC,IAAI,CAAC;QAEX,uDAAuD;QACvD,KAAK,MAAM,OAAO,IAAI,QAAQ,EAAE,CAAC;YAC/B,IAAI,OAAO,CAAC,SAAS,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;gBACxC,MAAM,aAAa,GAAG,OAAO,CAAC,SAAS,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,CAAE,CAAC;gBAC3D,MAAM,aAAa,GAAG,OAAO,CAAC,cAAc,CAAC,GAAG,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC;gBAEvE,wEAAwE;gBACxE,0BAA0B;gBAC1B,iEAAiE;gBACjE,0EAA0E;gBAC1E,MAAM,YAAY,GAAG,uBAAuB,CAC1C,aAAa,EACb,mBAAmB,EACnB,OAAO,CAAC,UAAU,CACnB,CAAC;gBAEF,IAAI,YAAY,EAAE,CAAC;oBACjB,WAAW,CAAC,IAAI,CAAC;wBACf,QAAQ,EAAE,OAAO,CAAC,IAAI,CAAC,KAAK;wBAC5B,QAAQ,EAAE,SAAS;wBACnB,IAAI,EAAE,oBAAoB;wBAC1B,OAAO,EACL,kCAAkC,OAAO,CAAC,IAAI,sBAAsB;4BACpE,gDAAgD;4BAChD,sEAAsE;4BACtE,YAAY,OAAO,CAAC,IAAI,qBAAqB,aAAa,CAAC,IAAI,GAAG;wBACpE,OAAO,EAAE,kBAAkB,CACzB,OAAO,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,EACvB,OAAO,CAAC,MAAM,CACf;wBACD,GAAG,EAAE,IAAI;qBACV,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;QACH,CAAC;QAED,OAAO,WAAW,CAAC;IACrB,CAAC;CACF,CAAC;AAEF;;;;;;;;;;;GAWG;AACH,SAAS,uBAAuB,CAC9B,aAA6B,EAC7B,mBAAmC,EACnC,UAAqB;IAErB,mDAAmD;IACnD,IAAI,aAAa,KAAK,IAAI,EAAE,CAAC;QAC3B,OAAO,IAAI,CAAC;IACd,CAAC;IAED,2DAA2D;IAC3D,IAAI,mBAAmB,KAAK,IAAI,EAAE,CAAC;QACjC,OAAO,aAAa,KAAK,IAAI,CAAC;IAChC,CAAC;IAED,gEAAgE;IAChE,mDAAmD;IACnD,IAAI,aAAa,KAAK,mBAAmB,EAAE,CAAC;QAC1C,OAAO,IAAI,CAAC;IACd,CAAC;IAED,wDAAwD;IACxD,0EAA0E;IAC1E,MAAM,YAAY,GAAG,UAAU,CAAC,OAAO,CAAC,mBAAmB,CAAC,CAAC;IAC7D,MAAM,aAAa,GAAG,UAAU,CAAC,OAAO,CAAC,aAAa,CAAC,CAAC;IAExD,yDAAyD;IACzD,IAAI,aAAa,KAAK,CAAC,CAAC,EAAE,CAAC;QACzB,OAAO,KAAK,CAAC;IACf,CAAC;IAED,2EAA2E;IAC3E,OAAO,aAAa,GAAG,YAAY,CAAC;AACtC,CAAC;AAED;;GAEG;AACH,SAAS,kBAAkB,CAAC,IAAa;IACvC,MAAM,QAAQ,GAAkB,EAAE,CAAC;IAEnC,SAAS,QAAQ,CAAC,CAAU;QAC1B,IAAI,CAAC,CAAC,IAAI,KAAK,SAAS,EAAE,CAAC;YACzB,QAAQ,CAAC,IAAI,CAAC,CAAgB,CAAC,CAAC;YAChC,OAAO;QACT,CAAC;QAED,uCAAuC;QACvC,QAAQ,CAAC,CAAC,IAAI,EAAE,CAAC;YACf,KAAK,OAAO;gBACV,KAAK,MAAM,IAAI,IAAI,CAAC,CAAC,UAAU;oBAAE,QAAQ,CAAC,IAAI,CAAC,CAAC;gBAChD,MAAM;YACR,KAAK,WAAW;gBACd,QAAQ,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC;gBACvB,MAAM;YACR,KAAK,oBAAoB;gBACvB,QAAQ,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC;gBACtB,MAAM;YACR,KAAK,WAAW;gBACd,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;gBACjB,KAAK,MAAM,IAAI,IAAI,CAAC,CAAC,KAAK;oBAAE,QAAQ,CAAC,IAAe,CAAC,CAAC;gBACtD,IAAI,CAAC,CAAC,UAAU;oBAAE,QAAQ,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC;gBACzC,MAAM;YACR,KAAK,aAAa;gBAChB,QAAQ,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC;gBACpB,KAAK,MAAM,MAAM,IAAI,CAAC,CAAC,OAAO;oBAAE,QAAQ,CAAC,MAAM,CAAC,CAAC;gBACjD,MAAM;YACR,KAAK,YAAY;gBACf,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;gBACjB,QAAQ,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC;gBAClB,MAAM;YACR,KAAK,WAAW;gBACd,QAAQ,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC;gBACpB,MAAM;YACR,KAAK,aAAa;gBAChB,QAAQ,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC;gBACvB,MAAM;YACR,KAAK,aAAa;gBAChB,IAAI,CAAC,CAAC,KAAK;oBAAE,QAAQ,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC;gBAC/B,IAAI,CAAC,CAAC,SAAS;oBAAE,QAAQ,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC;gBACvC,QAAQ,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC;gBACvB,IAAI,CAAC,CAAC,UAAU;oBAAE,QAAQ,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC;gBACzC,MAAM;YACR,KAAK,SAAS;gBACZ,2DAA2D;gBAC3D,MAAM;YACR,2CAA2C;YAC3C,KAAK,WAAW;gBACd,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;gBACjB,MAAM;YACR,KAAK,aAAa;gBAChB,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;gBACjB,MAAM;YACR,KAAK,UAAU,CAAC;YAChB,KAAK,SAAS,CAAC;YACf,KAAK,YAAY,CAAC;YAClB,KAAK,UAAU;gBACb,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;gBACjB,MAAM;QACV,CAAC;IACH,CAAC;IAED,QAAQ,CAAC,IAAI,CAAC,CAAC;IACf,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED;;;;GAIG;AACH,SAAS,oBAAoB,CAAC,IAAa;IACzC,IAAI,QAAQ,GAAG,CAAC,CAAC;IAEjB,SAAS,QAAQ,CAAC,CAAU,EAAE,gBAAwB;QACpD,IAAI,CAAC,CAAC,IAAI,KAAK,aAAa,EAAE,CAAC;YAC7B,MAAM,WAAW,GAAG,CAAoB,CAAC;YACzC,MAAM,QAAQ,GAAG,gBAAgB,GAAG,CAAC,CAAC;YACtC,QAAQ,GAAG,IAAI,CAAC,GAAG,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC;YACxC,QAAQ,CAAC,WAAW,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;QAC7C,CAAC;aAAM,IAAI,CAAC,CAAC,IAAI,KAAK,WAAW,EAAE,CAAC;YAClC,gEAAgE;YAChE,MAAM,QAAQ,GAAG,CAAkB,CAAC;YACpC,IAAI,QAAQ,CAAC,IAAI,IAAI,CAAC,CAAC,QAAQ,CAAC,KAAK,IAAI,QAAQ,CAAC,KAAK,CAAC,MAAM,KAAK,CAAC,CAAC,EAAE,CAAC;gBACtE,8CAA8C;gBAC9C,QAAQ,CAAC,QAAQ,CAAC,IAAI,EAAE,gBAAgB,CAAC,CAAC;YAC5C,CAAC;iBAAM,CAAC;gBACN,0DAA0D;gBAC1D,IAAI,QAAQ,CAAC,IAAI;oBAAE,QAAQ,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;gBAC9C,IAAI,QAAQ,CAAC,KAAK,EAAE,CAAC;oBACnB,KAAK,MAAM,IAAI,IAAI,QAAQ,CAAC,KAAK,EAAE,CAAC;wBAClC,QAAQ,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;oBACpB,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;aAAM,IAAI,CAAC,CAAC,IAAI,KAAK,aAAa,EAAE,CAAC;YACpC,qEAAqE;YACrE,MAAM,WAAW,GAAG,CAAoB,CAAC;YACzC,IACE,WAAW,CAAC,OAAO;gBACnB,CAAC,CAAC,WAAW,CAAC,OAAO,IAAI,WAAW,CAAC,OAAO,CAAC,MAAM,KAAK,CAAC,CAAC,EAC1D,CAAC;gBACD,8CAA8C;gBAC9C,QAAQ,CAAC,WAAW,CAAC,OAAO,EAAE,gBAAgB,CAAC,CAAC;YAClD,CAAC;iBAAM,CAAC;gBACN,+BAA+B;gBAC/B,IAAI,WAAW,CAAC,OAAO;oBAAE,QAAQ,CAAC,WAAW,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC;YAC5D,CAAC;QACH,CAAC;aAAM,CAAC;YACN,wDAAwD;YACxD,mCAAmC;YACnC,IAAI,CAAC,CAAC,IAAI,KAAK,YAAY,EAAE,CAAC;gBAC5B,MAAM,UAAU,GAAG,CAAmB,CAAC;gBACvC,QAAQ,CAAC,UAAU,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;gBAC7B,QAAQ,CAAC,UAAU,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC;YAChC,CAAC;iBAAM,IAAI,CAAC,CAAC,IAAI,KAAK,WAAW,EAAE,CAAC;gBAClC,MAAM,SAAS,GAAG,CAAkB,CAAC;gBACrC,QAAQ,CAAC,SAAS,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC;YACjC,CAAC;QACH,CAAC;IACH,CAAC;IAED,QAAQ,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;IAClB,OAAO,QAAQ,CAAC;AAClB,CAAC"}

package/dist/check/rules/closures.d.ts

@@ -0,0 +1,66 @@
+/**
+ * Closure Convention Rules
+ * Enforces closure best practices from docs/guide-conventions.md:237-286.
+ */
+import type { ValidationRule } from '../types.js';
+/**
+ * Warns on bare $ in stored closures without parameters.
+ * Bare $ in stored closures has ambiguous binding - it refers to the
+ * pipe value at closure invocation time, not definition time.
+ *
+ * Detection:
+ * - Zero-parameter closures (|| { }) used outside dict context
+ * - Body contains bare $ references (VariableNode with name '$')
+ *
+ * Valid patterns:
+ * - Dict closures: [count: ||{ $.items -> .len }]  ($ binds to dict)
+ * - Parameterized closures: |x|{ $x }  (explicit params)
+ * - Inline blocks: -> { $ * 2 }  (immediate evaluation)
+ *
+ * References:
+ * - docs/guide-conventions.md:251-261
+ * - docs/topic-closures.md: Late binding section
+ */
+export declare const CLOSURE_BARE_DOLLAR: ValidationRule;
+/**
+ * Enforces braces for complex closure bodies.
+ * Simple expressions can use parentheses, but complex bodies need braces.
+ *
+ * Complex body criteria:
+ * - Contains Block (multiple statements)
+ * - Contains Conditional
+ * - Contains loop constructs
+ *
+ * Simple bodies (parentheses OK):
+ * - Single expression: |x|($x * 2)
+ * - Single method chain: |s|($s.trim.lower)
+ *
+ * Complex bodies (braces required):
+ * - Conditionals: |n| { ($n < 1) ? 1 ! ($n * $fact($n - 1)) }
+ * - Multiple statements: |x| { $x => $y; $y * 2 }
+ *
+ * References:
+ * - docs/guide-conventions.md:239-249
+ */
+export declare const CLOSURE_BRACES: ValidationRule;
+/**
+ * Detects closures created in loops that may suffer from late binding issues.
+ * When creating closures inside loops, variables are captured by reference,
+ * not by value. This causes all closures to share the final loop value.
+ *
+ * Detection:
+ * - Each loop body creates a Closure node
+ * - Closure references loop variable ($) without explicit capture
+ *
+ * Solution: Explicit capture per iteration:
+ *   [1, 2, 3] -> each {
+ *     $ => $item
+ *     || { $item }
+ *   }
+ *
+ * References:
+ * - docs/guide-conventions.md:251-261
+ * - docs/topic-closures.md: Late binding section
+ */
+export declare const CLOSURE_LATE_BINDING: ValidationRule;
+//# sourceMappingURL=closures.d.ts.map

package/dist/check/rules/closures.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"closures.d.ts","sourceRoot":"","sources":["../../../src/check/rules/closures.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,KAAK,EACV,cAAc,EAGf,MAAM,aAAa,CAAC;AAuBrB;;;;;;;;;;;;;;;;;GAiBG;AACH,eAAO,MAAM,mBAAmB,EAAE,cAoCjC,CAAC;AAmIF;;;;;;;;;;;;;;;;;;;GAmBG;AACH,eAAO,MAAM,cAAc,EAAE,cAsD5B,CAAC;AAMF;;;;;;;;;;;;;;;;;;GAkBG;AACH,eAAO,MAAM,oBAAoB,EAAE,cAqClC,CAAC"}