@rbxts/replecs 0.4.0-rc.4 → 0.4.0-rc.5

package/out/replecs/client/init.luau

@@ -777,13 +777,18 @@ local function process_full_entity(
 	end
 end
 
+-- removals resolve their target with find_entity: a target this client never
+-- saw (filtered out, or deleted earlier in the same packet) has nothing to
+-- remove, and creating a placeholder for it would leak a ghost entity
+
 -- pair tag removal: [target id, relation]
 local function process_entity_pair_removal(self: Client, entity: Entity, c: Cursor, custom_ids: CustomIdMap)
 	local relation = read_component_id(self, c)
 	local relation_hooks = self.network_hooks.removed[PAIR(self.components.relation, relation)]
-	process_entity(self, c, custom_ids, function(target)
+	local target = find_entity(self, c)
+	if target then
 		entity_remove_pair(self, entity, relation, target, relation_hooks)
-	end)
+	end
 end
 
 -- relation target removals: [target ids..., vlq count, relation]
@@ -793,9 +798,10 @@ local function process_entity_relation_removals(self: Client, entity: Entity, c:
 	local relation_hooks = self.network_hooks.removed[PAIR(self.components.relation, relation)]
 
 	for _ = 1, total_targets do
-		process_entity(self, c, custom_ids, function(target)
+		local target = find_entity(self, c)
+		if target then
 			entity_remove_pair(self, entity, relation, target, relation_hooks)
-		end)
+		end
 	end
 end
 
@@ -1595,8 +1601,7 @@ function client.resolve_dirty(self: Client)
 		end
 	end
 
-	self.shared =
-		shared.resolve_shared(self.world, self.components, self.registered_custom_ids, serdes, preprocessors)
+	self.shared = shared.resolve_shared(self.world, self.components, self.registered_custom_ids, serdes, preprocessors)
 	self.is_shared_dirty = false
 end
 
@@ -1759,6 +1764,8 @@ return {
 
 	process_entity_pair = process_entity_pair,
 	process_entity_pair_value = process_entity_pair_value,
+	process_entity_pair_removal = process_entity_pair_removal,
+	process_entity_relation_removals = process_entity_relation_removals,
 	process_entity_relations = process_entity_relations,
 	process_entity_relation_values = process_entity_relation_values,
 	process_full_entity = process_full_entity,

package/out/replecs/server/filter_group.luau

@@ -30,7 +30,6 @@ export type FilterNodeClass = {
 	input_versions: Array<number>,
 	dependents: Set<FilterNode>,
 
-
 	value: Bitmask?,
 	scratch: Bitmask?,
 	version: number,
@@ -173,7 +172,6 @@ local function resolve_computed(node: FilterNode, scratch: Bitmask): boolean
 	return true
 end
 
-
 function filter_node.resolve(node: FilterNode): Bitmask
 	local reg = node.registry
 	if not reg then
@@ -263,7 +261,6 @@ function filter_node.clear(self: FilterNode)
 	mark_dirty(self)
 end
 
-
 function filter_node.create_source(reg: Registry?, initial: FilterSimple?): FilterNode
 	local node = create_node(KINDS.source, reg)
 	node.member_set = {}
@@ -331,7 +328,6 @@ function filter_node.exclude(self: FilterNode, ...: FilterOperand): FilterNode
 	return create_computed(KINDS.exclude, self, { ... })
 end
 
-
 function filter_node.members(self: FilterNode): Set<Player>
 	local value = filter_node.resolve(self)
 	local index_clients = (self.registry :: Registry).index_clients

package/out/replecs/server/init.luau

@@ -1876,7 +1876,11 @@ function push_relation_updates(
 	local is_component = storage.is_component
 
 	for target in storage.dirty_targets do
-		if WORLD_HAS(world, entity, PAIR(rel, target)) then
+		-- the pair id only keeps the target's index: a target deleted and
+		-- recycled in the same frame aliases the live pair, so the pair must
+		-- resolve back to this exact generation to count as present
+		local id = PAIR(rel, target)
+		if WORLD_HAS(world, entity, id) and PAIR_SECOND(world, id) == target then
 			if is_component then
 				local changed = bucket.changed[rel]
 				if not changed then
@@ -1884,7 +1888,7 @@ function push_relation_updates(
 					bucket.changed[rel] = changed
 				end
 
-				local value = WORLD_GET(world, entity, PAIR(rel, target))
+				local value = WORLD_GET(world, entity, id)
 				table.insert(changed.targets, target)
 				table.insert(changed.values, SET_VALUE(value))
 			else
@@ -2959,8 +2963,7 @@ function server.resolve_dirty(self: Server)
 		end
 	end
 
-	self.shared =
-		shared.resolve_shared(self.world, self.components, self.registered_custom_ids, serdes, preprocessors)
+	self.shared = shared.resolve_shared(self.world, self.components, self.registered_custom_ids, serdes, preprocessors)
 	self.is_shared_dirty = false
 end
 

package/out/replecs/ver.luau

@@ -1 +1 @@
-return "v0.4.0-rc.4"
+return "v0.4.0-rc.5"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rbxts/replecs",
-  "version": "0.4.0-rc.4",
+  "version": "0.4.0-rc.5",
   "description": "Replication library for Jecs",
   "main": "out/init.luau",
   "types": "out/index.d.ts",