@raydiant/playlist-window-manager 0.14.20 → 0.14.21

package/README.md

@@ -1,4 +1,10 @@
-Usage:
+## Deployment
+
+```
+yarn deploy
+```
+
+## Usage
 
 ```js
 

package/build/embeddedApps.js

@@ -21,9 +21,8 @@ function createEmbeddedApp(presentation, embeddedUrlFormat) {
         if (!isNaN(Number(variableName)))
             return;
         var value = presentation.applicationVariables[m[2]];
-        if (value === undefined)
-            value = '';
-        url = url.replace(variable, value);
+        var encodedValue = value === undefined ? '' : encodeURIComponent(value);
+        url = url.replace(variable, encodedValue);
     });
     return url;
 }

package/build/embeddedApps.test.js

@@ -37,3 +37,8 @@ test('Replaces variable with underscore', function () {
 test('Does not replace variable that is a number', function () {
     expect(embeddedApps_1.default(createPresentation({ applicationVariables: { foo: 'bar' } }), 'http://localhost:8080?foo=:foo')).toBe('http://localhost:8080?foo=bar');
 });
+test('Encodes a variables containing special characters', function () {
+    var fooValue = 'Lorem Ipsum. !@#$%^&*()-. More Text';
+    var fooValueEncoded = 'Lorem%20Ipsum.%20!%40%23%24%25%5E%26*()-.%20More%20Text';
+    expect(embeddedApps_1.default(createPresentation({ applicationVariables: { foo: fooValue } }), "http://localhost:8080?foo=:foo")).toBe("http://localhost:8080?foo=" + fooValueEncoded);
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@raydiant/playlist-window-manager",
-  "version": "0.14.20",
+  "version": "0.14.21",
   "description": "Window manager for playlist playback.",
   "main": "build/index.js",
   "scripts": {

package/src/embeddedApps.test.ts

@@ -64,3 +64,16 @@ test('Does not replace variable that is a number', () => {
     )
   ).toBe('http://localhost:8080?foo=bar');
 });
+
+test('Encodes a variables containing special characters', () => {
+  const fooValue = 'Lorem Ipsum. !@#$%^&*()-. More Text';
+  const fooValueEncoded =
+    'Lorem%20Ipsum.%20!%40%23%24%25%5E%26*()-.%20More%20Text';
+
+  expect(
+    createEmbeddedApp(
+      createPresentation({ applicationVariables: { foo: fooValue } }),
+      `http://localhost:8080?foo=:foo`
+    )
+  ).toBe(`http://localhost:8080?foo=${fooValueEncoded}`);
+});

package/src/embeddedApps.ts

@@ -25,9 +25,9 @@ export default function createEmbeddedApp(
     // port numbers in the embedded app url.
     if (!isNaN(Number(variableName))) return;
 
-    let value = presentation.applicationVariables[m[2]];
-    if (value === undefined) value = '';
-    url = url.replace(variable, value);
+    const value = presentation.applicationVariables[m[2]];
+    const encodedValue = value === undefined ? '' : encodeURIComponent(value);
+    url = url.replace(variable, encodedValue);
   });
 
   return url;