@ravshansbox/pi-next-issue 1.0.1 → 1.0.3

package/README.md

@@ -22,7 +22,7 @@ The run does not belong to a session: it goes on after `/new`, `/resume`, a fork
 
 ## What it does
 
-Each loop fetches the open issues and takes the oldest one with saved state, else the oldest one with the `status:todo` label and none of `status:in-progress`, `status:done`, `status:needs-human` or `status:blocked`. The run ends when no such issue is left, or at the first error. For each issue:
+Each loop fetches the 200 oldest open issues with the `status:todo` label and none of `status:in-progress`, `status:done`, `status:needs-human` or `status:blocked`, and the open issues with saved state that it can read. It takes the oldest one with saved state, else the oldest one with the `status:todo` label and none of `status:in-progress`, `status:done`, `status:needs-human` or `status:blocked`. The run ends when no such issue is left, or at the first error. For each issue:
 
 1. Swap `status:todo` for `status:in-progress`.
 2. Add a git worktree at `.worktrees/<n>` on the `<n>` branch, from the remote default branch.
@@ -35,6 +35,8 @@ Each loop fetches the open issues and takes the oldest one with saved state, els
 
 An issue that cannot go on gets `status:needs-human` and a comment with the reason. Its worktree stays for you to look at.
 
+The implementer and the reviewer read the issue title, the body and the comments. They get only comments by the owner, members and collaborators of the repository. The body is passed as it is, and its author can edit it after you add the label, so check the body before you add the label.
+
 Each agent is a pi session in the worktree. It uses the model and thinking level from your pi settings, and loads all of your extensions except this one.
 
 The state of each issue is saved in `.worktrees/<n>.json`. The extension adds `/.worktrees/` to `.git/info/exclude`.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ravshansbox/pi-next-issue",
-  "version": "1.0.1",
+  "version": "1.0.3",
   "description": "Pi extension that works through GitHub issues in the background",
   "license": "MIT",
   "type": "module",

package/src/github.ts

@@ -1,6 +1,6 @@
 import { setTimeout as sleep } from 'node:timers/promises';
 import { must, run } from './exec.ts';
-import type { ChecksResult, Issue } from './runner.ts';
+import { LABELS, STOP_LABELS, type ChecksResult, type Issue } from './runner.ts';
 
 export type Repo = { root: string; slug: string };
 
@@ -9,6 +9,7 @@ type Check = { name: string; bucket: string; link: string };
 const POLL_MS = 15_000;
 const GRACE_MS = 60_000;
 const READ_TRIES = 3;
+const TRUSTED = ['OWNER', 'MEMBER', 'COLLABORATOR'];
 
 function gh(repo: Repo, args: string[], input?: string): Promise<string> {
   return must('gh', [...args, '--repo', repo.slug], {
@@ -27,25 +28,48 @@ export async function defaultBranch(repo: Repo): Promise<string> {
   );
 }
 
-export async function openIssues(repo: Repo): Promise<Issue[]> {
+type RawIssue = {
+  number: number;
+  title: string;
+  body: string | null;
+  createdAt: string;
+  labels: Array<{ name: string }>;
+};
+
+const ISSUE_FIELDS = 'number,title,body,labels,createdAt';
+
+export async function openIssues(repo: Repo, saved: number[]): Promise<Issue[]> {
   const raw = await gh(repo, [
     'issue',
     'list',
     '--state',
     'open',
+    '--label',
+    LABELS.ready,
+    '--search',
+    ['sort:created-asc', ...STOP_LABELS.map((label) => `-label:${label}`)].join(' '),
     '--limit',
     '200',
     '--json',
-    'number,title,body,labels,createdAt',
+    ISSUE_FIELDS,
   ]);
-  const parsed = JSON.parse(raw) as Array<{
-    number: number;
-    title: string;
-    body: string | null;
-    createdAt: string;
-    labels: Array<{ name: string }>;
-  }>;
-  return parsed
+  const listed = JSON.parse(raw) as RawIssue[];
+  const known = new Set(listed.map((item) => item.number));
+  for (const number of saved.filter((item) => !known.has(item))) {
+    const view = await run(
+      'gh',
+      ['issue', 'view', String(number), '--json', `${ISSUE_FIELDS},state`, '--repo', repo.slug],
+      { cwd: repo.root },
+    );
+    if (view.code !== 0) {
+      continue;
+    }
+    const item = JSON.parse(view.stdout) as RawIssue & { state: string };
+    if (item.state === 'OPEN') {
+      listed.push(item);
+    }
+  }
+  return listed
     .sort((a, b) => a.createdAt.localeCompare(b.createdAt))
     .map((item) => ({
       number: item.number,
@@ -58,9 +82,11 @@ export async function openIssues(repo: Repo): Promise<Issue[]> {
 export async function comments(repo: Repo, issue: number): Promise<string[]> {
   const raw = await gh(repo, ['issue', 'view', String(issue), '--json', 'comments']);
   const parsed = JSON.parse(raw) as {
-    comments: Array<{ author: { login: string }; body: string }>;
+    comments: Array<{ author: { login: string }; authorAssociation: string; body: string }>;
   };
-  return parsed.comments.map((comment) => `@${comment.author.login}: ${comment.body}`);
+  return parsed.comments
+    .filter((comment) => TRUSTED.includes(comment.authorAssociation))
+    .map((comment) => `@${comment.author.login}: ${comment.body}`);
 }
 
 export async function setLabel(

package/src/ports.ts

@@ -10,7 +10,7 @@ export async function createPorts(root: string, config: Config): Promise<Ports>
   const base = await github.defaultBranch(repo);
   const timeoutMs = config.checkTimeoutMinutes * 60_000;
   return {
-    openIssues: () => github.openIssues(repo),
+    openIssues: async () => github.openIssues(repo, await state.savedIssues(root)),
     comments: (issue) => github.comments(repo, issue),
     setLabel: (issue, add, remove) => github.setLabel(repo, issue, add, remove),
     commentOnIssue: (issue, body) => github.commentOnIssue(repo, issue, body),

package/src/runner.ts

@@ -86,7 +86,7 @@ export const LABELS = {
   blocked: 'status:blocked',
 };
 
-const STOP_LABELS = [LABELS.inProgress, LABELS.done, LABELS.needsHuman, LABELS.blocked];
+export const STOP_LABELS = [LABELS.inProgress, LABELS.done, LABELS.needsHuman, LABELS.blocked];
 
 function ready(issue: Issue): boolean {
   return (