@rasensio/aidlc-content 1.15.0 → 1.15.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +1 -1
- package/skills/50-testing.md +16 -0
- package/skills/60-deployment.md +3 -1
- package/skills/80-review.md +7 -1
package/package.json
CHANGED
package/skills/50-testing.md
CHANGED
|
@@ -57,6 +57,22 @@ Verify that the implementation satisfies all acceptance criteria. Produce eviden
|
|
|
57
57
|
{{context:style-guide}}
|
|
58
58
|
{{guidance:secure-defaults}}
|
|
59
59
|
|
|
60
|
+
## Security Testing
|
|
61
|
+
|
|
62
|
+
When the work under test touches a trust boundary (user input, auth, file paths,
|
|
63
|
+
subprocess or query construction, deserialization), the suite MUST include
|
|
64
|
+
negative security tests, not only happy paths:
|
|
65
|
+
|
|
66
|
+
- Inputs crafted to escape the intended context: injection payloads for shell,
|
|
67
|
+
SQL, path (`../`), and template sinks the code actually has
|
|
68
|
+
- Requests without credentials, and with valid credentials for the WRONG user or
|
|
69
|
+
role, asserting they are rejected
|
|
70
|
+
- Malformed and boundary inputs (empty, oversized, wrong type) asserting safe
|
|
71
|
+
failure — no stack traces or internals in the response
|
|
72
|
+
|
|
73
|
+
Run the project's dependency audit (e.g. `npm audit`, `pnpm audit`) once per
|
|
74
|
+
testing phase and record newly introduced advisories as findings.
|
|
75
|
+
|
|
60
76
|
## Security Confirmation
|
|
61
77
|
|
|
62
78
|
If testing requires:
|
package/skills/60-deployment.md
CHANGED
|
@@ -14,7 +14,9 @@ Prepare and execute the release. Ensure all preceding phases are complete, all g
|
|
|
14
14
|
|
|
15
15
|
- All preceding required phases have status `complete` in `.aidlc/state/<instance>/`
|
|
16
16
|
- Testing phase complete with all tests passing
|
|
17
|
-
-
|
|
17
|
+
- The review findings file has no open `critical` security finding (the adversarial
|
|
18
|
+
review's security dimension is the sign-off; no template configures a separate
|
|
19
|
+
security review phase)
|
|
18
20
|
- The instance is claimed by this session
|
|
19
21
|
|
|
20
22
|
## Required Artifacts
|
package/skills/80-review.md
CHANGED
|
@@ -36,7 +36,11 @@ You MUST perform this review with fresh eyes. If you authored the artifact being
|
|
|
36
36
|
- **Missing edge cases** — Inputs, states, or scenarios not addressed
|
|
37
37
|
- **Untestable criteria** — Requirements with no observable pass/fail
|
|
38
38
|
- **Hidden assumptions** — Unstated preconditions the artifact relies on
|
|
39
|
-
- **Security gaps** — Missing auth, unvalidated input, exposed data
|
|
39
|
+
- **Security gaps** — Missing auth, unvalidated input, exposed data. When the
|
|
40
|
+
instance has implementation code (a branch or diff), review the CODE for this
|
|
41
|
+
dimension, not only the markdown artifacts: injection sinks (shell, SQL, path,
|
|
42
|
+
template), secrets in source, missing authorization checks, and unsafe
|
|
43
|
+
deserialization. Apply the secure-defaults guidance below as the checklist.
|
|
40
44
|
- **Scalability concerns** — Performance bottlenecks or resource limits
|
|
41
45
|
- **Scope creep** — Functionality beyond the stated scope
|
|
42
46
|
3. **Write findings.** For each issue found, record:
|
|
@@ -47,6 +51,8 @@ You MUST perform this review with fresh eyes. If you authored the artifact being
|
|
|
47
51
|
- **Status**: `open` (always for new findings)
|
|
48
52
|
4. **Save the findings file** as `<artifact>.review.md` in the instance namespace.
|
|
49
53
|
|
|
54
|
+
{{guidance:secure-defaults}}
|
|
55
|
+
|
|
50
56
|
## Findings Format
|
|
51
57
|
|
|
52
58
|
```markdown
|