@rapidmx/web-client 0.4.0 → 0.5.0

package/apps/shared/components/contacts/ContactDetailPane.tsx

@@ -2,11 +2,14 @@
 // Copyright (C) 2026 Jean-Philippe Steinmetz
 // SPDX-License-Identifier: MPL-2.0
 ///////////////////////////////////////////////////////////////////////////////
-import React from "react";
+import React, { useState } from "react";
 import { Contact } from "@rapidmx/react-shared/contacts/contactsApi.js";
 import Button from "@rapidmx/react-shared/components/buttons/Button.js";
 import Alert from "@rapidmx/react-shared/components/feedback/Alert.js";
 import ContactAvatar from "@rapidmx/react-shared/components/avatar/ContactAvatar.js";
+import KeyChangeReview from "./KeyChangeReview.js";
+import { KEY_CHANGE_STALE_MESSAGE, formatDate, keyPinnedSince, revocationLabel } from "./contactKeys.js";
+import { clearPinnedSignerCache } from "../mail/pinnedSigners.js";
 
 /** Groups a hex fingerprint into 4-character blocks (`ab12 cd34 ...`) for out-of-band verification -
  * the spec's own use case ("compare this over the phone") is materially easier with a grouped string
@@ -15,6 +18,14 @@ function formatFingerprint(fingerprint: string): string {
     return fingerprint.match(/.{1,4}/g)?.join(" ") ?? fingerprint;
 }
 
+/** A revoked key's reason: a superseded key was routinely replaced, a revoked one must not be trusted. */
+function RevocationBadge({ label }: { label: "superseded" | "revoked" | undefined }) {
+    if (!label) {
+        return null;
+    }
+    return <span className={label === "superseded" ? "text-text-muted" : "text-danger"}> ({label})</span>;
+}
+
 export interface ContactDetailPaneProps {
     contact: Contact;
     onEdit: () => void;
@@ -23,6 +34,12 @@ export interface ContactDetailPaneProps {
      * on the desktop inline pane, which never navigates away (selecting a different contact just swaps
      * `contact` in place). */
     backHref?: string;
+    /** Called after one of the contact's key changes was accepted or kept, or turned out to be stale - the caller
+     * re-reads the contact. */
+    onKeysChanged?: () => void;
+    /** `false` when the reader is known not to be able to change this contact's keys (the actions are hidden); `undefined`
+     * when unknown (they're hidden after a 403). */
+    canResolveKeys?: boolean;
 }
 
 /**
@@ -30,7 +47,20 @@ export interface ContactDetailPaneProps {
  * always visible alongside the contact list) and the mobile detail route
  * (`apps/www/contacts/[uid].tsx`, a full page on its own reached by tapping a contact row).
  */
-export default function ContactDetailPane({ contact, onEdit, onDelete, backHref }: ContactDetailPaneProps) {
+export default function ContactDetailPane({ contact, onEdit, onDelete, backHref, onKeysChanged, canResolveKeys }: ContactDetailPaneProps) {
+    // The outcome of the last key decision, kept per contact so selecting another contact doesn't carry it over.
+    const [keyNotice, setKeyNotice] = useState<{ contactUid: string; text: string } | null>(null);
+    const notice = keyNotice?.contactUid === contact.uid ? keyNotice.text : null;
+    const keyConflicts = contact.keyConflicts ?? [];
+    const previousKeys = contact.previousKeys ?? [];
+
+    // Pinned signing keys vouch for signatures, so the pinned-signer cache is dropped along with re-reading the contact.
+    function refresh(text: string) {
+        setKeyNotice({ contactUid: contact.uid, text });
+        clearPinnedSignerCache();
+        onKeysChanged?.();
+    }
+
     return (
         <div role="region" aria-label="Contact details" className="max-w-xl flex flex-col gap-5">
             {backHref && (
@@ -101,27 +131,55 @@ export default function ContactDetailPane({ contact, onEdit, onDelete, backHref
                         <div>{contact.notes}</div>
                     </div>
                 )}
-                {(contact.keys && contact.keys.length > 0) || contact.encryptPreference || contact.keyConflict ? (
+                {(contact.keys && contact.keys.length > 0) ||
+                contact.encryptPreference ||
+                keyConflicts.length > 0 ||
+                previousKeys.length > 0 ? (
                     <div>
                         <div className="text-text-muted text-xs font-bold uppercase tracking-wide mb-1">Encryption</div>
-                        {contact.keyConflict && (
-                            <div className="mb-2">
-                                <Alert>
-                                    <p className="mb-2">
-                                        A different encryption key was observed for this contact on{" "}
-                                        {new Date(contact.keyConflict.observedAt).toLocaleDateString()}. The
-                                        previously verified key below is still the one in use — this is routine
-                                        after a device change or reinstall, but it&rsquo;s also what a real attack
-                                        looks like, so verify the new fingerprint with {contact.displayName}{" "}
-                                        directly (e.g. by phone) before trusting it. There is no automatic way to
-                                        accept or reject this yet.
-                                    </p>
-                                    <p className="font-mono text-xs">
-                                        Newly observed: {formatFingerprint(contact.keyConflict.observedFingerprint)}
-                                    </p>
-                                </Alert>
-                            </div>
+                        {notice && (
+                            <p role="status" className="mb-2 py-2 px-3 rounded-sm bg-surface-alt text-text">
+                                {notice}
+                            </p>
                         )}
+                        {keyConflicts.map((conflict) => {
+                            const pinned = contact.keys?.find((key) => key.useType === conflict.useType);
+                            const kind = conflict.useType === "sign" ? "signing" : "encryption";
+                            return (
+                                <section
+                                    key={conflict.useType}
+                                    aria-label={`${conflict.useType === "sign" ? "Signing" : "Encryption"} key change`}
+                                    className="mb-3 py-3 px-3 rounded-sm bg-warning/15 text-text flex flex-col gap-2"
+                                >
+                                    <h2 className="font-semibold">
+                                        A different {kind} key was seen for {contact.displayName}
+                                    </h2>
+                                    <p>The current key stays in use until you decide what to do with the new one.</p>
+                                    <KeyChangeReview
+                                        mailboxUid={contact.mailboxUid}
+                                        address={contact.emails[0]?.address}
+                                        useType={conflict.useType}
+                                        ownerName={contact.displayName}
+                                        current={pinned && { fingerprint: pinned.fingerprint, since: keyPinnedSince(contact, pinned) }}
+                                        proposed={{
+                                            fingerprint: conflict.observedKey.fingerprint,
+                                            observedAt: conflict.observedAt,
+                                            source: conflict.source,
+                                        }}
+                                        canReject
+                                        canResolve={canResolveKeys}
+                                        onResolved={(action) =>
+                                            refresh(
+                                                action === "accept"
+                                                    ? `The new ${kind} key is now trusted for ${contact.displayName}.`
+                                                    : `You kept the current ${kind} key for ${contact.displayName}.`,
+                                            )
+                                        }
+                                        onPinnedKeyChanged={() => refresh(KEY_CHANGE_STALE_MESSAGE)}
+                                    />
+                                </section>
+                            );
+                        })}
                         {contact.encryptPreference && (
                             <div className="mb-1">
                                 {contact.encryptPreference.preferEncrypt === "mutual"
@@ -132,9 +190,30 @@ export default function ContactDetailPane({ contact, onEdit, onDelete, backHref
                         {contact.keys?.map((key) => (
                             <div key={key.fingerprint} className="font-mono text-xs py-0.5">
                                 {key.useType === "sign" ? "Signing" : "Encryption"} key: {formatFingerprint(key.fingerprint)}
-                                {key.revokedAt && <span className="text-danger"> (revoked)</span>}
+                                <RevocationBadge label={revocationLabel(key)} />
                             </div>
                         ))}
+                        {previousKeys.length > 0 && (
+                            <div className="mt-3">
+                                <div className="text-text-muted text-xs font-bold mb-1">Key history</div>
+                                <ul aria-label="Key history">
+                                    {previousKeys.map((key) => (
+                                        <li key={`${key.useType}:${key.fingerprint}:${key.replacedAt}`} className="text-xs py-0.5">
+                                            <span className="font-mono">
+                                                {key.useType === "sign" ? "Signing" : "Encryption"} key: {formatFingerprint(key.fingerprint)}
+                                            </span>
+                                            <RevocationBadge label={revocationLabel(key)} />
+                                            <span className="text-text-muted">
+                                                {" "}
+                                                &middot;{" "}
+                                                {key.replacement === "automatic" ? "Renewed automatically" : "Replaced by you"} on{" "}
+                                                {formatDate(key.replacedAt)}
+                                            </span>
+                                        </li>
+                                    ))}
+                                </ul>
+                            </div>
+                        )}
                     </div>
                 ) : null}
             </div>